)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29a3839ac9b1fd4596701d671e4e9dae5ecc6798","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"525be8b0_6136b380","updated":"2022-04-20 10:32:11.000000000","message":"\\o/ Thanks you Stephen to pushing this whole change series through.","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c4d572f60443c9b241557fbef20264e0b494b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db3a03a9_4e40171a","updated":"2022-04-14 17:55:15.000000000","message":"recheck gate issues","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fb99be75f46513d2224c49b87f15f6b8c25b1ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0c3f053_ec2c3dcf","updated":"2022-04-13 09:11:47.000000000","message":"recheck unrelated failure","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"}],"nova/db/main/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29a3839ac9b1fd4596701d671e4e9dae5ecc6798","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    select \u003d _compute_node_select(context, filters, limit\u003dlimit, marker\u003dmarker)"},{"line_number":614,"context_line":"    engine \u003d get_engine(context\u003dcontext)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    with engine.connect() as conn, conn.begin():"},{"line_number":617,"context_line":"        results \u003d conn.execute(select).fetchall()"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    # Callers expect dict-like objects, not SQLAlchemy RowProxy objects..."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa75c845_78ccff3e","line":616,"updated":"2022-04-20 10:32:11.000000000","message":"nicely avoided \"with\" nesting","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29a3839ac9b1fd4596701d671e4e9dae5ecc6798","unresolved":false,"context_lines":[{"line_number":4365,"context_line":"            shadow_tablename, metadata, autoload_with\u003dconn)"},{"line_number":4366,"context_line":"    except sqla_exc.NoSuchTableError:"},{"line_number":4367,"context_line":"        # No corresponding shadow table; skip it."},{"line_number":4368,"context_line":"        return rows_archived, deleted_instance_uuids, {}"},{"line_number":4369,"context_line":""},{"line_number":4370,"context_line":"    # TODO(stephenfin): Drop this when we drop the table"},{"line_number":4371,"context_line":"    if tablename \u003d\u003d \"dns_domains\":"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb5187f_39590b00","line":4368,"updated":"2022-04-20 10:32:11.000000000","message":"Probably we leak the an open connection here. But this is not worst than before the change so we can live with it.","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2911c69a5e876047f8ad3df08af71537ff94c012","unresolved":false,"context_lines":[{"line_number":4365,"context_line":"            shadow_tablename, metadata, autoload_with\u003dconn)"},{"line_number":4366,"context_line":"    except sqla_exc.NoSuchTableError:"},{"line_number":4367,"context_line":"        # No corresponding shadow table; skip it."},{"line_number":4368,"context_line":"        return rows_archived, deleted_instance_uuids, {}"},{"line_number":4369,"context_line":""},{"line_number":4370,"context_line":"    # TODO(stephenfin): Drop this when we drop the table"},{"line_number":4371,"context_line":"    if tablename \u003d\u003d \"dns_domains\":"}],"source_content_type":"text/x-python","patch_set":1,"id":"43a7b773_74fe2c76","line":4368,"in_reply_to":"9fb5187f_39590b00","updated":"2022-04-22 09:26:45.000000000","message":"Good catch. Done in https://review.opendev.org/c/openstack/nova/+/839030","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"006209a1c74a734d4bab635bad41019c6ba12dca","unresolved":true,"context_lines":[{"line_number":4456,"context_line":"                        \"%(tablename)s: %(error)s\","},{"line_number":4457,"context_line":"                        {\u0027tablename\u0027: tablename, \u0027error\u0027: str(ex)})"},{"line_number":4458,"context_line":""},{"line_number":4459,"context_line":"    conn.close()"},{"line_number":4460,"context_line":""},{"line_number":4461,"context_line":"    return rows_archived, deleted_instance_uuids, extras"},{"line_number":4462,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"eca37318_1f58892b","line":4459,"updated":"2022-04-22 10:16:47.000000000","message":"ok","commit_id":"612b83ee5dfe426a9bb9771d0e55cc13209565d5"}]}