)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01e4acb5b048a60994691ba1dc5784e6bebf7885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d2e67bc_22ee9541","updated":"2022-04-20 10:36:45.000000000","message":"Thanks for the excellent commit message.","commit_id":"8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ece9dc3fe9bbe53b95a86f5d53e67d0e74c0a6e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4265fa31_a3a8cc5a","updated":"2022-04-20 16:41:42.000000000","message":"This fix makes sense, thanks for catching it. LGTM","commit_id":"8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"330d33cb4e83540bff23802a84de1e4ddbbb99ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"003accea_406601d2","updated":"2022-04-29 01:46:10.000000000","message":"recheck bug 1970642","commit_id":"8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"9458737b81822530fee21943d265eac0ae67b07b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c31cfb6_f9902773","updated":"2022-04-12 01:58:02.000000000","message":"vmware-recheck-patch","commit_id":"8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc"}],"nova/db/main/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ece9dc3fe9bbe53b95a86f5d53e67d0e74c0a6e5","unresolved":true,"context_lines":[{"line_number":4278,"context_line":"                # if the foreign key doesn\u0027t actually point to the table we\u0027re"},{"line_number":4279,"context_line":"                # archiving entries from then it\u0027s not relevant; trying to"},{"line_number":4280,"context_line":"                # resolve this would result in a cartesian product"},{"line_number":4281,"context_line":"                continue"},{"line_number":4282,"context_line":""},{"line_number":4283,"context_line":"            # We need to find the records in the referring (child) table that"},{"line_number":4284,"context_line":"            # correspond to the records in our (parent) table so we can archive"}],"source_content_type":"text/x-python","patch_set":1,"id":"cdb9cc36_01eea2e6","line":4281,"updated":"2022-04-20 16:41:42.000000000","message":"Hm, so the call to _get_tables_with_fk_to_table(table) on L4257 intention was to only consider \"child\" tables that have foreign keys to the table to be archived and thus only do queries involving the \"parent\" table ... but the SAWarning has revealed a bug where this was not handling the fact that a fk_table could possibly have additional foreign keys that don\u0027t point to the \"parent\" table we want.\n\nSo this fix is correct to skip such foreign keys.","commit_id":"8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc"}]}