)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"82edfca10c5c3a5887f4f54e654d1f09387e05d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ecb3f5f_4b941698","updated":"2023-10-05 12:51:43.000000000","message":"LGTM: merged in victoria (when it was master), conflicts are noted \u0026 resolved correctly (there are many differences but mostly due to mypy related). Zuul is also happy.","commit_id":"82182cb343e3ae6c95392a54f5e21d38ac7ab6af"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a5a9e0f8af943b76a39742e981c3e63d26c99574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98a64381_3edea298","updated":"2023-10-03 14:12:05.000000000","message":"recheck - lots of POST_FAILURE, probably related to infra issues at that time?","commit_id":"82182cb343e3ae6c95392a54f5e21d38ac7ab6af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ad3056ef93d7b577b8846ffc4b21d19d60ae78d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"846cbd3d_dc72fb7e","updated":"2023-10-05 13:18:04.000000000","message":"unfortunetly this intorduces bug #1915255 to ussuri\n\ni have commented inline with more details but overall this backport looks good to me.\n\n-1 until we decied on the path forward for not intoduceing bug #1915255","commit_id":"82182cb343e3ae6c95392a54f5e21d38ac7ab6af"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"4a8e489347d90d69493cb9bd1e03384fda5f550e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d484bdae_ee6c8423","in_reply_to":"846cbd3d_dc72fb7e","updated":"2023-10-05 14:25:20.000000000","message":"thanks for the info Sean, then I\u0027m also removing my +2 until the other bug\u0027s patch is not merged back to ussuri.","commit_id":"82182cb343e3ae6c95392a54f5e21d38ac7ab6af"}],"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ad3056ef93d7b577b8846ffc4b21d19d60ae78d","unresolved":true,"context_lines":[{"line_number":841,"context_line":"    def name(self):"},{"line_number":842,"context_line":"        return self._name"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"    def listCaps(self):"},{"line_number":845,"context_line":"        return [self.name().split(\u0027_\u0027)[0]]"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b7ab734b_bb8f837e","line":844,"updated":"2023-10-05 13:18:04.000000000","message":"this is the only realy delta in this file form \nhttps://review.opendev.org/c/openstack/nova/+/739131/12/nova/tests/unit/virt/libvirt/fakelibvirt.py#831\nand its simply the lack of type hints so looks good to me","commit_id":"82182cb343e3ae6c95392a54f5e21d38ac7ab6af"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ad3056ef93d7b577b8846ffc4b21d19d60ae78d","unresolved":true,"context_lines":[{"line_number":7034,"context_line":"                    try:"},{"line_number":7035,"context_line":"                        parent_ifname \u003d pci_utils.get_ifname_by_pci_address("},{"line_number":7036,"context_line":"                            pci_address, pf_interface\u003dTrue)"},{"line_number":7037,"context_line":"                    except exception.PciDeviceNotFoundById:"},{"line_number":7038,"context_line":"                        # NOTE(sean-k-mooney): we ignore this error as it"},{"line_number":7039,"context_line":"                        # is expected when the virtual function is not a NIC."},{"line_number":7040,"context_line":"                        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf07afe1_5d0a8dac","side":"PARENT","line":7037,"updated":"2023-10-05 13:18:04.000000000","message":"i belive this removal was reverted however.\ni need to check that but i belive this actully intoduced a bug and it was corrected in a second patch which should also be backported.\n\nlater so ya\n\nIa10ccdd9fbed3870d0592e3cbbff17f292651dd2\nis the fix but that is only present on xena+\n\ncurrently its unpatched on Victoria and wallaby but the bug is not in Ussuri\n\nso we proably shoudl beackport that first to W/V and hten backport both to U\nor inline it here.\n\n\nthe fix basically just adds back this try except and updates the comemns to say why this is needed.\nso its a pretty trivial thing to inline which might be the simpler aprcoh since this fucntion was moved to a diffent file in a later release.","commit_id":"184a3c976faed38907af148a533bc6e9faa410f5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a87fe6afe590cbbdd9364611e5359e3b75589707","unresolved":true,"context_lines":[{"line_number":7034,"context_line":"                    try:"},{"line_number":7035,"context_line":"                        parent_ifname \u003d pci_utils.get_ifname_by_pci_address("},{"line_number":7036,"context_line":"                            pci_address, pf_interface\u003dTrue)"},{"line_number":7037,"context_line":"                    except exception.PciDeviceNotFoundById:"},{"line_number":7038,"context_line":"                        # NOTE(sean-k-mooney): we ignore this error as it"},{"line_number":7039,"context_line":"                        # is expected when the virtual function is not a NIC."},{"line_number":7040,"context_line":"                        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"e573aaa3_2111cb5d","side":"PARENT","line":7037,"in_reply_to":"bf07afe1_5d0a8dac","updated":"2023-10-05 13:31:32.000000000","message":"it applied cleanly to wallaby so i just cherry picked that via the gerrit ui\nhttps://review.opendev.org/c/openstack/nova/+/897300\n\nthe victoria cherrypic woudl need to be done by hand since the function moved in wallaby and then either inline or put on top of this patch.","commit_id":"184a3c976faed38907af148a533bc6e9faa410f5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ad3056ef93d7b577b8846ffc4b21d19d60ae78d","unresolved":true,"context_lines":[{"line_number":6985,"context_line":"        cpu_info[\u0027features\u0027] \u003d features"},{"line_number":6986,"context_line":"        return cpu_info"},{"line_number":6987,"context_line":""},{"line_number":6988,"context_line":"    def _get_pcinet_info(self, dev, net_devs):"},{"line_number":6989,"context_line":"        \"\"\"Returns a dict of NET device.\"\"\""},{"line_number":6990,"context_line":"        net_dev \u003d {dev.parent(): dev for dev in net_devs}.get(dev.name(), None)"},{"line_number":6991,"context_line":"        if net_dev is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f2e3af0c_e1756418","line":6988,"updated":"2023-10-05 13:18:04.000000000","message":"other then the type hints this and formating \n\nhttps://review.opendev.org/c/openstack/nova/+/739131/12/nova/virt/libvirt/driver.py#6911\n\nthis also looks like a clean backport to me.","commit_id":"82182cb343e3ae6c95392a54f5e21d38ac7ab6af"}]}