)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9cf001551f6df5f6a37fec493eb642ad3437d9c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ef700c4f_f2f4249c","updated":"2022-05-03 13:47:31.000000000","message":"-1 for the config option help text. The rest are typos, nits and a suggestion","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"08c7b990252141e893da97e4dd6d264d135d6949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d2127641_9d9989f8","updated":"2022-05-04 08:08:23.000000000","message":"Looks good","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"73a94d8a7e3bf66203f752505247ccde68fa4dd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f8ef96bf_8d82d0be","updated":"2022-05-23 21:46:31.000000000","message":"Soft -1 for unused code.","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a0b7a690e2ecdd7913e6e5aaf649dd52842bce3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"abee36ce_c5e41954","updated":"2022-05-04 15:46:31.000000000","message":"recheck","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"63400503fad022f1529044b1e0c75ba230f13438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"02f59164_124ffd64","updated":"2022-05-17 13:56:55.000000000","message":"recheck centos-9-stream -- random unrelated timeout","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4dc3ce20b62e75ebed7e622c69509b137968a4ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eca2e2af_bb1eb807","updated":"2022-05-11 13:19:27.000000000","message":"recheck nova-next failure seems to be an intermittent network failure. I don\u0027t see any similar hits in the last week https://paste.opendev.org/show/b33iPr2fy3h5tU0NYYgo/","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11759c7f65a9541d5da65085a0f88f1e192e2908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8ee75862_f125e541","in_reply_to":"02f59164_124ffd64","updated":"2022-05-17 14:23:10.000000000","message":"Actually this is our beloved disk detach issue:\n\nMay 11 14:23:03.111283 centos-9-stream-rax-dfw-0029615342 nova-compute[63376]: ERROR oslo_messaging.rpc.server [None req-886f8973-7bf5-4c0d-8170-c3427f6c5f34 tempest-AttachVolumeMultiAttachTest-1675935760 tempest-AttachVolumeMultiAttachTest-1675935760-project] Exception during message handling: nova.exception.DeviceDetachFailed: Device detach failed for vdb: Run out of retry while detaching device vdb with device alias virtio-disk1 from instance e4de042c-bdb9-4d1b-b52e-4b532285f6ef from the live domain config. Device is still attached to the guest.\n\nhttps://zuul.opendev.org/t/openstack/build/bcaf2154eeb545cdb7907d0c807513e9/log/controller/logs/screen-n-cpu.txt?severity\u003d3#40471","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8dc4762740b75fb7af16950f46f34d4826d4fc7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"686bdc7e_9f7a2a19","in_reply_to":"8ee75862_f125e541","updated":"2022-05-23 15:18:33.000000000","message":"Ah, I see.  Still this intermittent (?) failure is unrelated to this patch\n\nThe CI is passing now, though.","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4a14e050a593a9ea7c7e64391306ee9f6a3fead2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d86fc092_554df5e1","updated":"2022-05-24 16:03:16.000000000","message":"Looks good","commit_id":"267a40663cd8d0b94bbc5ebda4ece55a45753b64"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c255be27adc06a3d5fefb0624ad72c34bbb8188f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"01de53bb_5ad43c92","updated":"2022-05-25 02:53:22.000000000","message":"Updates look good, thanks 😊","commit_id":"267a40663cd8d0b94bbc5ebda4ece55a45753b64"}],"nova/conf/workarounds.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9cf001551f6df5f6a37fec493eb642ad3437d9c0","unresolved":true,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"* :oslo.config:option:`quota.driver`"},{"line_number":404,"context_line":"\"\"\"),"},{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"}],"source_content_type":"text/x-python","patch_set":7,"id":"4b46b434_40f870d7","line":405,"updated":"2022-05-03 13:47:31.000000000","message":"I\u0027m not a fan of double negatives. I know this is a workaround option, so I guess precedent dictates that we default to False, so the option has to be a negative in the form of \"skip\" as well, but I\u0027d like to at least get others\u0027s opinion on calling it \u0027live_migration_compare_cpus\u0027 or something, and defaulting it to True to keep legacy behaviour intact.","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e6c6870e8be5a17494e5091264554899cac33dc6","unresolved":true,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"* :oslo.config:option:`quota.driver`"},{"line_number":404,"context_line":"\"\"\"),"},{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"}],"source_content_type":"text/x-python","patch_set":7,"id":"c0465b78_d376f090","line":405,"in_reply_to":"4b46b434_40f870d7","updated":"2022-05-03 13:50:33.000000000","message":"I have no hard opinions as I think we will drop this config option (at least from master) pretty soon when https://review.opendev.org/q/topic:bp/cpu-selection-with-hypervisor-consideration lands.","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"be5297e604eca13b8ddd1ba200719de5d2586adb","unresolved":true,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"* :oslo.config:option:`quota.driver`"},{"line_number":404,"context_line":"\"\"\"),"},{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"}],"source_content_type":"text/x-python","patch_set":7,"id":"e9c10506_95e1f187","line":405,"in_reply_to":"c0465b78_d376f090","updated":"2022-05-03 14:29:39.000000000","message":"On double-negation, it\u0027s a fair point, and I agree in general.  But in this case, IMO the \"skip\" wording is more explicit.  And it isn\u0027t _that_ big of a cognitive burden :-) So I\u0027ll retain it.\n\n\n@Gibi: yes, we could drop it on git/main once that BP lands.  (I\u0027d like to backport this workaround to a stable branch or two.)","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"08c7b990252141e893da97e4dd6d264d135d6949","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"* :oslo.config:option:`quota.driver`"},{"line_number":404,"context_line":"\"\"\"),"},{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"}],"source_content_type":"text/x-python","patch_set":7,"id":"16108143_97f3638e","line":405,"in_reply_to":"e9c10506_95e1f187","updated":"2022-05-04 08:08:23.000000000","message":"Sure, we can make the deprecation in the implementation of the BP so that you can clearly backport this to stable without the deprecation flag","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9cf001551f6df5f6a37fec493eb642ad3437d9c0","unresolved":true,"context_lines":[{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"},{"line_number":409,"context_line":"host. When using QEMU \u003e\u003d 2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the"},{"line_number":410,"context_line":"correct thing with respect to checking CPU compatibility on the"},{"line_number":411,"context_line":"destination host during live migration."}],"source_content_type":"text/x-python","patch_set":7,"id":"f2ef660a_55e5aac5","line":408,"updated":"2022-05-03 13:47:31.000000000","message":"I\u0027d rephrase this a bit, and lead with the wider context first, so something like:\n\nWith the libvirt driver, during live migration, skip comparing CPUs of the source and destination hosts. When using etc etc","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e09039e6ce1dcb903222592531fe633b7c32e8e8","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"},{"line_number":409,"context_line":"host. When using QEMU \u003e\u003d 2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the"},{"line_number":410,"context_line":"correct thing with respect to checking CPU compatibility on the"},{"line_number":411,"context_line":"destination host during live migration."}],"source_content_type":"text/x-python","patch_set":7,"id":"1c08d30e_53bb41d6","line":408,"in_reply_to":"82bd814b_359107e2","updated":"2022-05-03 14:36:18.000000000","message":"Done","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"be5297e604eca13b8ddd1ba200719de5d2586adb","unresolved":true,"context_lines":[{"line_number":405,"context_line":"    cfg.BoolOpt(\u0027skip_cpu_compare_on_dest\u0027,"},{"line_number":406,"context_line":"               default\u003dFalse,"},{"line_number":407,"context_line":"               help\u003d\"\"\""},{"line_number":408,"context_line":"When this is enabled, it will skip CPU comparison on the destination"},{"line_number":409,"context_line":"host. When using QEMU \u003e\u003d 2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the"},{"line_number":410,"context_line":"correct thing with respect to checking CPU compatibility on the"},{"line_number":411,"context_line":"destination host during live migration."}],"source_content_type":"text/x-python","patch_set":7,"id":"82bd814b_359107e2","line":408,"in_reply_to":"f2ef660a_55e5aac5","updated":"2022-05-03 14:29:39.000000000","message":"Yep, will do.","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e6c6870e8be5a17494e5091264554899cac33dc6","unresolved":true,"context_lines":[{"line_number":409,"context_line":"host. When using QEMU \u003e\u003d 2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the"},{"line_number":410,"context_line":"correct thing with respect to checking CPU compatibility on the"},{"line_number":411,"context_line":"destination host during live migration."},{"line_number":412,"context_line":"\"\"\"),"},{"line_number":413,"context_line":"]"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"11eae178_67e9a650","line":412,"updated":"2022-05-03 13:50:33.000000000","message":"Do we want to deprecate this option right away as https://review.opendev.org/q/topic:bp/cpu-selection-with-hypervisor-consideration is actively worked on?","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"08c7b990252141e893da97e4dd6d264d135d6949","unresolved":false,"context_lines":[{"line_number":409,"context_line":"host. When using QEMU \u003e\u003d 2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the"},{"line_number":410,"context_line":"correct thing with respect to checking CPU compatibility on the"},{"line_number":411,"context_line":"destination host during live migration."},{"line_number":412,"context_line":"\"\"\"),"},{"line_number":413,"context_line":"]"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ddd23d97_886d417f","line":412,"in_reply_to":"11eae178_67e9a650","updated":"2022-05-04 08:08:23.000000000","message":"I\u0027m convinced to do the deprecation in the BP","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"73a94d8a7e3bf66203f752505247ccde68fa4dd9","unresolved":true,"context_lines":[{"line_number":10930,"context_line":"        instance_ref.vcpu_model.model \u003d None"},{"line_number":10931,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10932,"context_line":"        compute_info \u003d {\u0027cpu_info\u0027: \u0027asdf\u0027, \u0027disk_available_least\u0027: 1}"},{"line_number":10933,"context_line":"        result \u003d drvr.check_can_live_migrate_destination("},{"line_number":10934,"context_line":"            self.context, instance_ref, compute_info, compute_info)"},{"line_number":10935,"context_line":"        result.is_volume_backed \u003d False"},{"line_number":10936,"context_line":"        mock_cpu.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ae291abd_8734ceeb","line":10933,"range":{"start_line":10933,"start_character":8,"end_line":10933,"end_character":17},"updated":"2022-05-23 21:46:31.000000000","message":"This is not used (looks like copy paste error).","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"22f75dfd7021281be46eca98181546e6312b4bc7","unresolved":false,"context_lines":[{"line_number":10930,"context_line":"        instance_ref.vcpu_model.model \u003d None"},{"line_number":10931,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10932,"context_line":"        compute_info \u003d {\u0027cpu_info\u0027: \u0027asdf\u0027, \u0027disk_available_least\u0027: 1}"},{"line_number":10933,"context_line":"        result \u003d drvr.check_can_live_migrate_destination("},{"line_number":10934,"context_line":"            self.context, instance_ref, compute_info, compute_info)"},{"line_number":10935,"context_line":"        result.is_volume_backed \u003d False"},{"line_number":10936,"context_line":"        mock_cpu.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":8,"id":"8ef5e2d1_44472558","line":10933,"range":{"start_line":10933,"start_character":8,"end_line":10933,"end_character":17},"in_reply_to":"ae291abd_8734ceeb","updated":"2022-05-24 16:02:55.000000000","message":"Yep; fixed in next iteration.","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"73a94d8a7e3bf66203f752505247ccde68fa4dd9","unresolved":true,"context_lines":[{"line_number":10932,"context_line":"        compute_info \u003d {\u0027cpu_info\u0027: \u0027asdf\u0027, \u0027disk_available_least\u0027: 1}"},{"line_number":10933,"context_line":"        result \u003d drvr.check_can_live_migrate_destination("},{"line_number":10934,"context_line":"            self.context, instance_ref, compute_info, compute_info)"},{"line_number":10935,"context_line":"        result.is_volume_backed \u003d False"},{"line_number":10936,"context_line":"        mock_cpu.assert_not_called()"},{"line_number":10937,"context_line":""},{"line_number":10938,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":8,"id":"96f74c89_cac981c0","line":10935,"range":{"start_line":10935,"start_character":8,"end_line":10935,"end_character":39},"updated":"2022-05-23 21:46:31.000000000","message":"Ditto.","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"22f75dfd7021281be46eca98181546e6312b4bc7","unresolved":false,"context_lines":[{"line_number":10932,"context_line":"        compute_info \u003d {\u0027cpu_info\u0027: \u0027asdf\u0027, \u0027disk_available_least\u0027: 1}"},{"line_number":10933,"context_line":"        result \u003d drvr.check_can_live_migrate_destination("},{"line_number":10934,"context_line":"            self.context, instance_ref, compute_info, compute_info)"},{"line_number":10935,"context_line":"        result.is_volume_backed \u003d False"},{"line_number":10936,"context_line":"        mock_cpu.assert_not_called()"},{"line_number":10937,"context_line":""},{"line_number":10938,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":8,"id":"0127ed98_ca18f130","line":10935,"range":{"start_line":10935,"start_character":8,"end_line":10935,"end_character":39},"in_reply_to":"96f74c89_cac981c0","updated":"2022-05-24 16:02:55.000000000","message":"Here too; fixed in next iteration.","commit_id":"2cfcf874e46e3581b3a5aafc7288866898806b77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"94efc4218dfedf1b5e2d2b6e1e4c4e35f3be9c77","unresolved":true,"context_lines":[{"line_number":10928,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":10929,"context_line":"        instance_ref.vcpu_model \u003d test_vcpu_model.fake_vcpumodel"},{"line_number":10930,"context_line":"        instance_ref.vcpu_model.model \u003d None"},{"line_number":10931,"context_line":"        mock_cpu.assert_not_called()"},{"line_number":10932,"context_line":""},{"line_number":10933,"context_line":"    @mock.patch("},{"line_number":10934,"context_line":"        \u0027nova.network.neutron.API.has_port_binding_extension\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a03a5ec_354c7391","line":10931,"updated":"2022-05-24 15:46:58.000000000","message":"I think you delete too much. We still want to call check_can_live_migrate_destination()","commit_id":"349477928e6d281c819001cbad9152dadaf811f9"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"22f75dfd7021281be46eca98181546e6312b4bc7","unresolved":false,"context_lines":[{"line_number":10928,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"},{"line_number":10929,"context_line":"        instance_ref.vcpu_model \u003d test_vcpu_model.fake_vcpumodel"},{"line_number":10930,"context_line":"        instance_ref.vcpu_model.model \u003d None"},{"line_number":10931,"context_line":"        mock_cpu.assert_not_called()"},{"line_number":10932,"context_line":""},{"line_number":10933,"context_line":"    @mock.patch("},{"line_number":10934,"context_line":"        \u0027nova.network.neutron.API.has_port_binding_extension\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"6335005a_11a64b6b","line":10931,"in_reply_to":"9a03a5ec_354c7391","updated":"2022-05-24 16:02:55.000000000","message":"\u003cEmbarassed\u003e Fixed in next iteration. :)","commit_id":"349477928e6d281c819001cbad9152dadaf811f9"}],"releasenotes/notes/skip-compare-cpu-on-dest-6ae419ddd61fd0f8.yaml":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"f37691a72c142f86313a98eef3c5a66fab8bf997","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Nova\u0027s use of libvirt\u0027s compareCPU() API served its purpose"},{"line_number":5,"context_line":"    over the years, but its design limitations break live migration in"},{"line_number":6,"context_line":"    sutble ways.  For example, the compareCPU() API compares against the"},{"line_number":7,"context_line":"    host physical CPUID.  Some of the features from this CPUID aren not"},{"line_number":8,"context_line":"    exposed by KVM, and then there are some features that KVM emulates"},{"line_number":9,"context_line":"    that are not in the host CPUID.  The latter can cause bogus live"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7ca6cec0_8be5a1cb","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":10},"updated":"2022-04-25 13:04:44.000000000","message":"Typo?","commit_id":"7a07865ff75f14bda39388032bf338cd4caca169"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"f37691a72c142f86313a98eef3c5a66fab8bf997","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Nova\u0027s use of libvirt\u0027s compareCPU() API served its purpose"},{"line_number":5,"context_line":"    over the years, but its design limitations break live migration in"},{"line_number":6,"context_line":"    sutble ways.  For example, the compareCPU() API compares against the"},{"line_number":7,"context_line":"    host physical CPUID.  Some of the features from this CPUID aren not"},{"line_number":8,"context_line":"    exposed by KVM, and then there are some features that KVM emulates"},{"line_number":9,"context_line":"    that are not in the host CPUID.  The latter can cause bogus live"},{"line_number":10,"context_line":"    migration failures."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0b0a17e5_627f7e2a","line":7,"range":{"start_line":7,"start_character":63,"end_line":7,"end_character":71},"updated":"2022-04-25 13:04:44.000000000","message":"Typo?","commit_id":"7a07865ff75f14bda39388032bf338cd4caca169"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9cf001551f6df5f6a37fec493eb642ad3437d9c0","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the right"},{"line_number":13,"context_line":"    thing in terms of CPU compatibility checks on the destination host"},{"line_number":14,"context_line":"    during live migration.  Nova satisfies these minimum version"},{"line_number":15,"context_line":"    requirements by a good margin.  So, this workaround provides a way"},{"line_number":16,"context_line":"    to skip the CPU comparison check on the destination host before"},{"line_number":17,"context_line":"    migrating a guest, and let libvirt handle it correctly."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4026dc87_8d46a316","line":14,"range":{"start_line":14,"start_character":26,"end_line":14,"end_character":28},"updated":"2022-05-03 13:47:31.000000000","message":"femtonit: double space","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"be5297e604eca13b8ddd1ba200719de5d2586adb","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the right"},{"line_number":13,"context_line":"    thing in terms of CPU compatibility checks on the destination host"},{"line_number":14,"context_line":"    during live migration.  Nova satisfies these minimum version"},{"line_number":15,"context_line":"    requirements by a good margin.  So, this workaround provides a way"},{"line_number":16,"context_line":"    to skip the CPU comparison check on the destination host before"},{"line_number":17,"context_line":"    migrating a guest, and let libvirt handle it correctly."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d74e884a_c5faaf6f","line":14,"range":{"start_line":14,"start_character":26,"end_line":14,"end_character":28},"in_reply_to":"4026dc87_8d46a316","updated":"2022-05-03 14:29:39.000000000","message":"Heh, nod.  It\u0027s an old habit.  I started using double-spaces as I feel it does give some \"breathing room\" for the eyes by separating sentences a bit more clearly.\n\nBut I know that in Nova we usually prefer no double-spaces.","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e09039e6ce1dcb903222592531fe633b7c32e8e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the right"},{"line_number":13,"context_line":"    thing in terms of CPU compatibility checks on the destination host"},{"line_number":14,"context_line":"    during live migration.  Nova satisfies these minimum version"},{"line_number":15,"context_line":"    requirements by a good margin.  So, this workaround provides a way"},{"line_number":16,"context_line":"    to skip the CPU comparison check on the destination host before"},{"line_number":17,"context_line":"    migrating a guest, and let libvirt handle it correctly."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3d09baf7_b3a5dfb4","line":14,"range":{"start_line":14,"start_character":26,"end_line":14,"end_character":28},"in_reply_to":"d74e884a_c5faaf6f","updated":"2022-05-03 14:36:18.000000000","message":"Done","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9cf001551f6df5f6a37fec493eb642ad3437d9c0","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    With QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0, libvirt will do the right"},{"line_number":13,"context_line":"    thing in terms of CPU compatibility checks on the destination host"},{"line_number":14,"context_line":"    during live migration.  Nova satisfies these minimum version"},{"line_number":15,"context_line":"    requirements by a good margin.  So, this workaround provides a way"},{"line_number":16,"context_line":"    to skip the CPU comparison check on the destination host before"},{"line_number":17,"context_line":"    migrating a guest, and let libvirt handle it correctly."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ad157def_357c42b0","line":15,"range":{"start_line":15,"start_character":34,"end_line":15,"end_character":36},"updated":"2022-05-03 13:47:31.000000000","message":"Ditto","commit_id":"d8b4ccaf983be2ca265f465fa4f9dff6271d4879"}]}