)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fc21d3cd479498216e9a9c74d1dd6198059c1687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be4ecbfd_53dab81e","updated":"2022-04-26 10:51:13.000000000","message":"I think you unintentionally added an unrelated change","commit_id":"ef22c1eeb310672d62159f6f8c78112b589b616b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3c69e86f555fc1a472747efd306f93623666a52e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0ce33167_5a770f38","updated":"2022-04-28 09:29:11.000000000","message":"Looks good. The doc job failure is a known issue bug 1970725 (and being worked on)","commit_id":"5181bae923bdae2b536affc87d39ddf2c5f7835d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d140ac04ce47b91fc344324bb6e326c42ccbd613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"498cbb42_22ed3028","updated":"2022-04-29 10:00:16.000000000","message":"recheck https://review.opendev.org/c/openstack/releases/+/839775","commit_id":"5181bae923bdae2b536affc87d39ddf2c5f7835d"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fc21d3cd479498216e9a9c74d1dd6198059c1687","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"            self.stdlog.logger.output,"},{"line_number":1028,"context_line":"        )"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"    def test_delete_and_create(self):"},{"line_number":1031,"context_line":"        self.start_compute("},{"line_number":1032,"context_line":"            hostname\u003d\u0027test-compute\u0027,"},{"line_number":1033,"context_line":"            host_info\u003dfakelibvirt.HostInfo("}],"source_content_type":"text/x-python","patch_set":4,"id":"d0a8dd4f_574107f8","line":1030,"updated":"2022-04-26 10:51:13.000000000","message":"This feels unrelated.","commit_id":"ef22c1eeb310672d62159f6f8c78112b589b616b"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4881143ecde450ee0e1045caa851282cc5337d40","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"            self.stdlog.logger.output,"},{"line_number":1028,"context_line":"        )"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"    def test_delete_and_create(self):"},{"line_number":1031,"context_line":"        self.start_compute("},{"line_number":1032,"context_line":"            hostname\u003d\u0027test-compute\u0027,"},{"line_number":1033,"context_line":"            host_info\u003dfakelibvirt.HostInfo("}],"source_content_type":"text/x-python","patch_set":4,"id":"03fe6fcf_ab896255","line":1030,"in_reply_to":"d0a8dd4f_574107f8","updated":"2022-04-27 18:53:16.000000000","message":"Yeah, that was me being careless with git commit -a :(","commit_id":"ef22c1eeb310672d62159f6f8c78112b589b616b"}],"nova/tests/functional/regressions/test_bug_1888395.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b319d1020bae4a3b763dce10990333ec7669dce4","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            self.neutron_api.has_port_binding_extension(self.ctxt))"},{"line_number":145,"context_line":"        # FIXME(artom) Until bug 1969980 is fixed, this will fail with a"},{"line_number":146,"context_line":"        # NotImplementedError."},{"line_number":147,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027error\u0027,"},{"line_number":148,"context_line":"                           server_expected_state\u003d\u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c0934f5_065f3a49","line":147,"updated":"2022-04-23 07:04:01.000000000","message":"It does not fail for the expected reason:\n\"AttributeError: \u0027TestLiveMigrationRollbackWithoutMultiplePortBindin\u0027 object has no attribute \u0027server\u0027\"\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_61a/839091/2/check/nova-tox-functional-py38/61ade5d/testr_results.html","commit_id":"12640a4565c82bf0c375d328726ca6f359a90a6d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d140ac04ce47b91fc344324bb6e326c42ccbd613","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.neutron_api.has_port_binding_extension(self.ctxt))"},{"line_number":145,"context_line":"        # FIXME(artom) Until bug 1969980 is fixed, this will fail with a"},{"line_number":146,"context_line":"        # NotImplementedError."},{"line_number":147,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027error\u0027,"},{"line_number":148,"context_line":"                           server_expected_state\u003d\u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f4d97fc4_c36fbe87","line":147,"in_reply_to":"03c01be2_aff7fdff","updated":"2022-04-29 10:00:16.000000000","message":"Done","commit_id":"12640a4565c82bf0c375d328726ca6f359a90a6d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b24969db9da111c4174d7df777561eb519c2e9a2","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            self.neutron_api.has_port_binding_extension(self.ctxt))"},{"line_number":145,"context_line":"        # FIXME(artom) Until bug 1969980 is fixed, this will fail with a"},{"line_number":146,"context_line":"        # NotImplementedError."},{"line_number":147,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027error\u0027,"},{"line_number":148,"context_line":"                           server_expected_state\u003d\u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"af8ae9f3_87b56b8b","line":147,"in_reply_to":"3c0934f5_065f3a49","updated":"2022-04-23 13:22:43.000000000","message":"It\u0027s not actually here that it\u0027s failing, it\u0027s in test_live_migrate() inherited from the parent class, because I forgot that if you inherit from a test class, you get all its test methods as well. Fixed now.","commit_id":"12640a4565c82bf0c375d328726ca6f359a90a6d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9b524cfbd6cbbf6bb43f1968cded0855bba32514","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            self.neutron_api.has_port_binding_extension(self.ctxt))"},{"line_number":145,"context_line":"        # FIXME(artom) Until bug 1969980 is fixed, this will fail with a"},{"line_number":146,"context_line":"        # NotImplementedError."},{"line_number":147,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027error\u0027,"},{"line_number":148,"context_line":"                           server_expected_state\u003d\u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"03c01be2_aff7fdff","line":147,"in_reply_to":"4d4275e4_5cf2c485","updated":"2022-04-25 14:54:59.000000000","message":"Good idea, done!","commit_id":"12640a4565c82bf0c375d328726ca6f359a90a6d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d4a6503bd7c26f50d0e99f61289350456fc091be","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            self.neutron_api.has_port_binding_extension(self.ctxt))"},{"line_number":145,"context_line":"        # FIXME(artom) Until bug 1969980 is fixed, this will fail with a"},{"line_number":146,"context_line":"        # NotImplementedError."},{"line_number":147,"context_line":"        self._live_migrate(self.server, migration_expected_state\u003d\u0027error\u0027,"},{"line_number":148,"context_line":"                           server_expected_state\u003d\u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4d4275e4_5cf2c485","line":147,"in_reply_to":"af8ae9f3_87b56b8b","updated":"2022-04-25 12:34:18.000000000","message":"Thanks! Looks good now.\n\nIf you have to re-spin this for any other reasons. Or if you are not going to provide the fix for the bug at this time. Then please add an extra assert at the end to show that the live migration fails for the expected reason:\n\n        server \u003d self.api.get_server(self.server[\u0027id\u0027])\n        self.assertIn(\n            \"NotImplementedError: Cannot load \u0027vifs\u0027 in the base class\",\n            server[\u0027fault\u0027][\u0027details\u0027]\n        )","commit_id":"12640a4565c82bf0c375d328726ca6f359a90a6d"}]}