)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"970d9258f3116a49ab30b71467ed05e12ed63a40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"incoming migration and the update_available_resource periodic"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Conflicts: The \u0027_create_server\u0027 helper"},{"line_number":13,"context_line":"don\u0027t exist here, so we need to use direct api calls instead."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] Later change that bumps API version on parent classes"},{"line_number":16,"context_line":"https://review.opendev.org/c/openstack/nova/+/741282"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4d2ef3f4_2a143789","line":13,"updated":"2022-11-29 21:40:22.000000000","message":"Conflicts:\n  nova/tests/functional/libvirt/test_numa_servers.py\nThe \u0027_create_server\u0027 helper doesn\u0027t exist here, so we\nneed to use direct api calls instead.\nAlso: CPUPinning needs to be used instead of nova.exception.CPUPinning","commit_id":"9b58ea81aa6145140c55841eccc50588ced9aaa1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"970d9258f3116a49ab30b71467ed05e12ed63a40","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Conflicts: The \u0027_create_server\u0027 helper"},{"line_number":13,"context_line":"don\u0027t exist here, so we need to use direct api calls instead."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] Later change that bumps API version on parent classes"},{"line_number":16,"context_line":"https://review.opendev.org/c/openstack/nova/+/741282"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Gabriel Silva Trevisan \u003cgabriel.silvatrevisan@windriver.com\u003e"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"05f4c3a8_95d57541","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":52},"updated":"2022-11-29 21:40:22.000000000","message":"This was added to the \u0027conflict note\u0027 in ussuri patch, thus should be removed here as point 1 doesn\u0027t exist anymore.","commit_id":"9b58ea81aa6145140c55841eccc50588ced9aaa1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"970d9258f3116a49ab30b71467ed05e12ed63a40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad7eb2a0_dafa2a68","updated":"2022-11-29 21:40:22.000000000","message":"The backport looks good to me:\n* merged in ussuri ✔\n* a note explains why the changes needed ✔\nThe commit message could use some update (see my comments), but let\u0027s not block this patch series because of that. (I\u0027ve added some explanation to other reviewers in my code comments to help the reviewing). Anyway, this LGTM.","commit_id":"9b58ea81aa6145140c55841eccc50588ced9aaa1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"85c8869f7f77b94de8821638ac78ee8efe1a161e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e9ca304_96ca7468","updated":"2022-05-31 12:44:33.000000000","message":"recheck lower constraints job has been dropped","commit_id":"9b58ea81aa6145140c55841eccc50588ced9aaa1"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"970d9258f3116a49ab30b71467ed05e12ed63a40","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        # pcpu 0 on compute2"},{"line_number":768,"context_line":"        # NOTE(gibi): _run_build_test cannot be used here as it assumes only"},{"line_number":769,"context_line":"        # compute1 exists"},{"line_number":770,"context_line":"        flavor_a_id \u003d self._create_flavor("},{"line_number":771,"context_line":"            vcpu\u003d1, extra_spec\u003d{\u0027hw:cpu_policy\u0027: \u0027dedicated\u0027})"},{"line_number":772,"context_line":"        server_body \u003d self._build_server(flavor_a_id)"},{"line_number":773,"context_line":"        server_body[\u0027host\u0027] \u003d \u0027compute2\u0027"},{"line_number":774,"context_line":"        server_body[\u0027networks\u0027] \u003d \u0027none\u0027"},{"line_number":775,"context_line":"        microversion \u003d self.admin_api.microversion"},{"line_number":776,"context_line":"        self.admin_api.microversion \u003d \u00272.74\u0027"},{"line_number":777,"context_line":"        server2 \u003d self.admin_api.post_server({\u0027server\u0027: server_body})"},{"line_number":778,"context_line":"        server2 \u003d self._wait_for_state_change(server2, \u0027BUILD\u0027)"},{"line_number":779,"context_line":"        # Reset API microversion to original state"},{"line_number":780,"context_line":"        self.admin_api.microversion \u003d microversion"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        inst2 \u003d objects.Instance.get_by_uuid(self.ctxt, server2[\u0027id\u0027])"},{"line_number":783,"context_line":"        self.assertEqual(1, len(inst2.numa_topology.cells))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd219051_f3804944","line":780,"range":{"start_line":770,"start_character":0,"end_line":780,"end_character":50},"updated":"2022-11-29 21:40:22.000000000","message":"note to reviewers: this is the part that replaced the create_server call [1] compared to the patch in ussuri (described in the commit message). LGTM.\n\n[1]\n+        server2 \u003d self._create_server(\n+            flavor_id\u003dflavor_id,\n+            host\u003d\u0027compute2\u0027,\n+        )","commit_id":"9b58ea81aa6145140c55841eccc50588ced9aaa1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"970d9258f3116a49ab30b71467ed05e12ed63a40","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        log \u003d self.stdlog.logger.output"},{"line_number":822,"context_line":"        self.assertIn(\u0027Error updating resources for node compute2\u0027, log)"},{"line_number":823,"context_line":"        self.assertIn("},{"line_number":824,"context_line":"            \u0027CPUPinningInvalid: CPU set to pin [0] must be \u0027"},{"line_number":825,"context_line":"            \u0027a subset of free CPU set [1]\u0027,"},{"line_number":826,"context_line":"            log,"},{"line_number":827,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"c745f416_a2f5990d","line":824,"range":{"start_line":824,"start_character":13,"end_line":824,"end_character":30},"updated":"2022-11-29 21:40:22.000000000","message":"note to reviewers: this change is not mentioned in the commit message. This was \u0027nova.exception.CPUPinningInvalid\u0027 in ussuri (and on newer branches). I could not find why nova.exception cannot be used anymore, but the test works only with this, so this is needed. This is also the change that causes the conflicts in the 2 patches on top of this patch.","commit_id":"9b58ea81aa6145140c55841eccc50588ced9aaa1"}]}