)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d94b82ed96c8f14964e6ba7a8426df2867e1b3f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the original reproduction"},{"line_number":10,"context_line":"I4be429c56aaa15ee12f448978c38214e741eae63 to cover"},{"line_number":11,"context_line":"bug 1952915 as well as they have a common root cause."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I57982131768d87e067d1413012b96f1baa68052b"},{"line_number":14,"context_line":"Related-Bug: #1953359"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2f721bfd_e9715db6","line":11,"updated":"2022-11-29 21:49:10.000000000","message":"Conflicts:\n  nova/tests/functional/libvirt/test_numa_servers.py\n\nConflict is caused by having only\n- \u0027CPUPinning\u0027 instead of \u0027nova.exception.CPUPinning\u0027\n- \u0027CPUUnpinning\u0027 instead of \u0027nova.exception.CPUUnpinning\u0027\nin the code (introduced in the parent patch, as I explained in my comment on that patch).","commit_id":"42c6707c1e4c03186964586100f99accec52b71d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8f0247bc92c2d82ed37c05c88db0769fa1f69fa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4634534_ce1388bd","updated":"2022-05-26 13:43:02.000000000","message":"The cherry pick is not a clean cherry pick. See my question inline.","commit_id":"c5a7757b8c58d7f6ca41850abd45a533e9ccec17"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d94b82ed96c8f14964e6ba7a8426df2867e1b3f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2fdbb102_ecfcbc6b","updated":"2022-11-29 21:49:10.000000000","message":"The backport looks good, the conflicts could have been mentioned in the commit message (discussed in the comments), nevertheless, the conflicts resolved correctly, tests are passing + the ussuri backport has merged.","commit_id":"42c6707c1e4c03186964586100f99accec52b71d"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8f0247bc92c2d82ed37c05c88db0769fa1f69fa0","unresolved":true,"context_lines":[{"line_number":850,"context_line":"        self.assertEqual(\u0027ERROR\u0027, server[\u0027status\u0027])"},{"line_number":851,"context_line":"        self.assertIn("},{"line_number":852,"context_line":"            \u0027CPUPinningInvalid: CPU set to pin [0] must be \u0027"},{"line_number":853,"context_line":"            \u0027a subset of free CPU set [1]\u0027,"},{"line_number":854,"context_line":"            self.stdlog.logger.output,"},{"line_number":855,"context_line":"        )"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"535c2379_5c9383c4","line":853,"updated":"2022-05-26 13:43:02.000000000","message":"This is different compared to the patch in ussuri, there we have:\n            \u0027nova.exception.CPUUnpinningInvalid: CPU set to unpin [1] must be \u0027\n            \u0027a subset of pinned CPU set [0]\u0027,\nIs there any reason why this differs from that patch?","commit_id":"c5a7757b8c58d7f6ca41850abd45a533e9ccec17"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"beda236064a5e529169cfafc42375a467e5ebb2f","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        self.assertEqual(\u0027ERROR\u0027, server[\u0027status\u0027])"},{"line_number":851,"context_line":"        self.assertIn("},{"line_number":852,"context_line":"            \u0027CPUPinningInvalid: CPU set to pin [0] must be \u0027"},{"line_number":853,"context_line":"            \u0027a subset of free CPU set [1]\u0027,"},{"line_number":854,"context_line":"            self.stdlog.logger.output,"},{"line_number":855,"context_line":"        )"},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"adb37188_93ca82e7","line":853,"in_reply_to":"535c2379_5c9383c4","updated":"2022-06-01 09:24:18.000000000","message":"I\u0027m not sure how I managed to break that. But simply adding what was in the ussuri version (minus the nova.exception) still makes the test pass. I hope I don\u0027t have to dig up what changed in our logging that not the full exception name is logged just the class name. The rest is now clean.","commit_id":"c5a7757b8c58d7f6ca41850abd45a533e9ccec17"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d94b82ed96c8f14964e6ba7a8426df2867e1b3f6","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            log \u003d self.stdlog.logger.output"},{"line_number":812,"context_line":"            self.assertIn(\u0027Error updating resources for node compute2\u0027, log)"},{"line_number":813,"context_line":"            self.assertIn("},{"line_number":814,"context_line":"                \u0027CPUPinningInvalid: CPU set to pin [0] must be \u0027"},{"line_number":815,"context_line":"                \u0027a subset of free CPU set [1]\u0027,"},{"line_number":816,"context_line":"                log,"},{"line_number":817,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"c15ee996_60cbf265","line":814,"range":{"start_line":814,"start_character":17,"end_line":814,"end_character":34},"updated":"2022-11-29 21:49:10.000000000","message":"This was nova.exception.CPUPinningInvalid in the original patch on ussuri.","commit_id":"42c6707c1e4c03186964586100f99accec52b71d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d94b82ed96c8f14964e6ba7a8426df2867e1b3f6","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        server \u003d self.api.get_server(server[\u0027id\u0027])"},{"line_number":850,"context_line":"        self.assertEqual(\u0027ERROR\u0027, server[\u0027status\u0027])"},{"line_number":851,"context_line":"        self.assertIn("},{"line_number":852,"context_line":"            \u0027CPUUnpinningInvalid: CPU set to unpin [1] must be \u0027"},{"line_number":853,"context_line":"            \u0027a subset of pinned CPU set [0]\u0027,"},{"line_number":854,"context_line":"            self.stdlog.logger.output,"},{"line_number":855,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"01a3600a_441617a5","line":852,"range":{"start_line":852,"start_character":13,"end_line":852,"end_character":32},"updated":"2022-11-29 21:49:10.000000000","message":"This was nova.exception.CPUUnpinningInvalid in the original patch on ussuri.","commit_id":"42c6707c1e4c03186964586100f99accec52b71d"}]}
