)]}'
{"nova/api/openstack/compute/contrib/floating_ips.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fea8878e523ed9a421903658d4ded1c18e04beb9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":260,"context_line":"        except exception.FloatingIpNotFoundForAddress:"},{"line_number":261,"context_line":"            msg \u003d _(\u0027floating ip not found\u0027)"},{"line_number":262,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":263,"context_line":"        except exception.Forbidden as e:"},{"line_number":264,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.format_message())"},{"line_number":265,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BA9w%3D","line":262,"updated":"2014-03-31 14:38:23.000000000","message":"Seems like we should use the message from FloatingIpNotFoundForAddress since that actually has the address in the message, which would be more clear than what\u0027s passed to HTTPNotFound here....","commit_id":"cfb26b3b099bc31dbe4f6362eb3602ec30d3e3c4"}],"nova/tests/api/openstack/compute/contrib/test_floating_ips.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"46a12145433674e5e1ad8b4be93d0033fc441f02","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    def test_associate_not_allocated_floating_ip_to_instance(self):"},{"line_number":406,"context_line":"        def fake_associate_floating_ip(self, context, instance,"},{"line_number":407,"context_line":"                              floating_address, fixed_address,"},{"line_number":408,"context_line":"                              affect_auto_assigned\u003dFalse):"},{"line_number":409,"context_line":"            raise exception.Forbidden()"},{"line_number":410,"context_line":"        self.stubs.Set(network.api.API, \"associate_floating_ip\","},{"line_number":411,"context_line":"                       fake_associate_floating_ip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BEpw%3D","line":408,"updated":"2014-03-31 04:43:48.000000000","message":"It is better to change here to exception.FloatingIpNotFoundForAddress and keep current assertEqual()s for its test name.\n\nand nice to add a new other test to cover exception.Forbidden() because the behaviors of Forbidden and FloatingIpNotFoundForAddress are separated.","commit_id":"e29f6f8bf4fcc6d016308e9331c8e9bcf817f4a2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"292c0d3318db61c9e15045d6675bfcde8398e281","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    def test_associate_not_allocated_floating_ip_to_instance(self):"},{"line_number":406,"context_line":"        def fake_associate_floating_ip(self, context, instance,"},{"line_number":407,"context_line":"                              floating_address, fixed_address,"},{"line_number":408,"context_line":"                              affect_auto_assigned\u003dFalse):"},{"line_number":409,"context_line":"            raise exception.Forbidden()"},{"line_number":410,"context_line":"        self.stubs.Set(network.api.API, \"associate_floating_ip\","},{"line_number":411,"context_line":"                       fake_associate_floating_ip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BDyc%3D","line":408,"in_reply_to":"AAAAWH%2F%2BEpw%3D","updated":"2014-03-31 07:54:31.000000000","message":"+1","commit_id":"e29f6f8bf4fcc6d016308e9331c8e9bcf817f4a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29be79c356179d43dfd0f5ad32d559dd8adea65c","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    def test_associate_not_allocated_floating_ip_to_instance(self):"},{"line_number":406,"context_line":"        def fake_associate_floating_ip(self, context, instance,"},{"line_number":407,"context_line":"                              floating_address, fixed_address,"},{"line_number":408,"context_line":"                              affect_auto_assigned\u003dFalse):"},{"line_number":409,"context_line":"            raise exception.Forbidden()"},{"line_number":410,"context_line":"        self.stubs.Set(network.api.API, \"associate_floating_ip\","},{"line_number":411,"context_line":"                       fake_associate_floating_ip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BBo8%3D","line":408,"in_reply_to":"AAAAWH%2F%2BEpw%3D","updated":"2014-03-31 13:26:32.000000000","message":"Hmm, good point, although as you can see the test was never written that way in the first place, so it\u0027s always been wrong, but yeah I can do that.","commit_id":"e29f6f8bf4fcc6d016308e9331c8e9bcf817f4a2"}]}