)]}'
{"id":"openstack%2Fnova~840851","triplet_id":"openstack%2Fnova~stable%2Fussuri~If9ab424cc7375a1f0d41b03f01c4a823216b3eb8","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1969496","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2024-02-07 12:48:41.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"If9ab424cc7375a1f0d41b03f01c4a823216b3eb8","subject":"Remove unavailable but not reported PCI devices at startup","status":"ABANDONED","created":"2022-05-06 09:18:28.000000000","updated":"2024-02-07 12:48:41.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"db6f83df76e58a08d0d3990d33868f18e4f9c2d4","_number":840851,"virtual_id_number":840851,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-05-06 11:00:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-06 11:00:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-06 12:16:39.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-07 12:48:40.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"81626f6fa355739f160690cd6ae7a1a888cc6066","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-05-06 09:18:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5ebb12a5965911a0b7b5d1743c0af224e09f24ee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-06 11:00:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/b7bba381685b42fa95ea045a56040827 : FAILURE in 24m 36s (non-voting)\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8b5d02745e03442289fd956ec97c50f3 : SUCCESS in 1h 28m 22s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/82519ee30fce49e7917180ef5c913c9f : SUCCESS in 59m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/809f12bef0df467c8aca0916fd19a3c8 : SUCCESS in 18m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/217db20150bb4054865a92f41bfb7906 : SUCCESS in 7m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/16461b3d589a4755a534582a7a0142b0 : SUCCESS in 12m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8e1011c51b4f4bb5a9cfb7e15a940840 : SUCCESS in 15m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/410ebd0330c14187bca467d225b9eb1e : SUCCESS in 11m 22s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ef9f532fa935420997fdfdab10c76040 : FAILURE in 1h 05m 35s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/de6a3ec66b9546a28e4ecf6d573b479a : SUCCESS in 1h 29m 48s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3b1fcfbf3dc8417f926820ddbd26c653 : SUCCESS in 47m 02s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/06f86d610101431b88d05c7804961e09 : SUCCESS in 1h 36m 27s\n- nova-next https://zuul.opendev.org/t/openstack/build/2503f9305a9942d8b21e7dcb99d30df1 : SUCCESS in 1h 23m 27s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/28335c82985a49c4acb639345b40cf2a : SUCCESS in 20m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/a66e9db627c048b7ae57d390ffe3e028 : FAILURE in 5m 12s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/85a0feb26240423d9554a2103ee74847 : RETRY_LIMIT in 3m 55s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/8a9b5c4181924816a655dcba96627460 : SUCCESS in 1h 15m 08s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/47ec9a07dcb747be99941421ae20d51a : SUCCESS in 54m 20s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/86381215eca54de6af2a3c46e952fd46 : SUCCESS in 28m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ca78da45bf31799b8e6a07bb1ef75b11a099ad39","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-05-06 12:16:39.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/51/840851/1/check/tempest-dsvm-full-bionic-py3/b33b3de/ : SUCCESS in 2h 20m 43s","accounts_in_message":[],"_revision_number":1},{"id":"db6f83df76e58a08d0d3990d33868f18e4f9c2d4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 12:48:41.000000000","message":"Abandoned\n\nstable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"28c8ebc7b21a4606c7c652c185ba80eaefd5d537","revisions":{"28c8ebc7b21a4606c7c652c185ba80eaefd5d537":{"kind":"REWORK","_number":1,"created":"2022-05-06 09:18:28.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/51/840851/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/840851/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/840851/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/840851/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/840851/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/840851/1"}}},"commit":{"parents":[{"commit":"cc705b6258c2ca270922c5f07d55e2413c16ec40","subject":"Isolate PCI tracker unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cc705b6258c2ca270922c5f07d55e2413c16ec40"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-04-19 15:50:34.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-05-06 09:18:31.000000000","tz":120},"subject":"Remove unavailable but not reported PCI devices at startup","message":"Remove unavailable but not reported PCI devices at startup\n\nWe saw in the field that the pci_devices table can end up in\ninconsistent state after a compute node HW failure and re-deployment.\nThere could be dependent devices where the parent PF is in available\nstate while the children VFs are in unavailable state. (Before the HW\nfault the PF was allocated hence the VFs was marked unavailable).\n\nIn this state this PF is still schedulable but during the\nPCI claim the handling of dependent devices in the PCI tracker fill fail\nwith the error: \"Attempt to consume PCI device XXX from empty pool\".\n\nThe reason of the failure is that when the PF is claimed, all the\nchildren VFs are marked unavailable. But if the VF is already\nunavailable such step fails.\n\nOne way the deployer might try to recover from this state is to remove\nthe VFs from the hypervisor and restart the compute agent. The compute\nstartup already has a logic to delete PCI devices that are unused and\nnot reported by the hypervisor. However this logic only removed devices\nin \u0027available\u0027 state and ignored devices in \u0027unavailable\u0027 state.\n\nIf a device is unused and the hypervisor is not reporting the device any\nmore then it is safe to delete that device from the PCI tracker. So this\npatch extends the logic to allow deleting \u0027unavailable\u0027 devices. There\nis a small window when dependent PCI device is in \u0027unclaimable\u0027 state.\nFrom cleanup perspective this is an analogous state. So it is also\nadded to the cleanup logic.\n\nRelated-Bug: #1969496\nChange-Id: If9ab424cc7375a1f0d41b03f01c4a823216b3eb8\n(cherry picked from commit 284ea72e96604bdf16d1c5c4db47247334841b2f)\n(cherry picked from commit d7bca631fea348fb56cc46c5680643bacd82513e)\n(cherry picked from commit 580a4b14ae367e327229482decca0cb6cdf6e9d8)\n(cherry picked from commit 59ae44754ebce106b23bc697a822d181cdda41c6)\n(cherry picked from commit fdf52a1b099683ec65f6f0488ef73c952d90e002)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/28c8ebc7b21a4606c7c652c185ba80eaefd5d537"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/28c8ebc7b21a4606c7c652c185ba80eaefd5d537"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}