)]}'
{"id":"openstack%2Fnova~840854","triplet_id":"openstack%2Fnova~stable%2Ftrain~I20fb4ea96d5dfabfc4be3b5ecec0e4e6c5b3a318","project":"openstack/nova","branch":"stable/train","topic":"bug/1969496","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2022-06-01 09:30:56.000000000","reason":"Removed by gibi by clicking the attention icon"}},"hashtags":[],"change_id":"I20fb4ea96d5dfabfc4be3b5ecec0e4e6c5b3a318","subject":"Isolate PCI tracker unit tests","status":"ABANDONED","created":"2022-05-06 09:20:21.000000000","updated":"2023-09-01 16:54:29.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"12e5e955f4129728a4b32584c3bbb71c8d727a7f","_number":840854,"virtual_id_number":840854,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-05-31 13:20:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-06 10:13:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-31 13:20:43.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"}],"messages":[{"id":"8ad95335018e90cef0fb5b3644248a84df5af59a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-05-06 09:20:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c882c4bf6c397fbfd982a8a829aef3c48a3e3c9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-06 10:13:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/14a1e24c2930462095fe7eeedf5a2af7 : FAILURE in 15m 43s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f9481f2c0f3f4a869e218caee76e2221 : SUCCESS in 50m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a92e57681483481e91cbc77d2956392d : SUCCESS in 18m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4ca56fa7829b498b85d01308639a606a : RETRY_LIMIT in 4m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/34c0f1fb9a4e42f5b3a8363828d950d7 : SUCCESS in 10m 21s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f45c28d06c08429cb3d66c038e2ec638 : SUCCESS in 17m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b37a37d9fd9a47ebbe8b0bbcbe5f9d3f : SUCCESS in 12m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2d299e5ae8284905b61c5cec3b4ac380 : SUCCESS in 12m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0e48cb7bfec640ca96b5fce549058da5 : SUCCESS in 11m 10s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/0d4b75d10ccf4521b116fa1a0d8ee9dd : SUCCESS in 19m 54s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d60d7df95a554856b47e2ac46ccb5bea : SUCCESS in 19m 10s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/5e91810b41cf4831be8f88dfb1df935d : FAILURE in 4m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"da55c4d3575002e3a2d7e537c882e0d93660dfb0","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-05-31 12:33:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d251ea4ac81581881531cfa5d598e8dc207cc72a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-31 13:20:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1abe2f57a89340c6a843525d2747326e : SUCCESS in 44m 28s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/093b988a9c9845de8c61a3ef3c622374 : SUCCESS in 17m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1e76294cf75c4ef2b988d29c520e9488 : SUCCESS in 12m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/441963f84d7348d0adc6c72d85c5d1ca : SUCCESS in 14m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/59a9f30b5ccb424f85c8cd5b19084d7d : SUCCESS in 11m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b2a56b78c9e048e2a550af6d8a943440 : SUCCESS in 12m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e29d1828f49644a59e8d0417662ee201 : SUCCESS in 9m 59s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/2bfbc3a0435c49a699428079829df8f7 : SUCCESS in 19m 30s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/613382a5dfca4474bedd54fc32337bfe : SUCCESS in 17m 10s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/2e561ac66de14f3782748921ba7fcce1 : FAILURE in 5m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3332593d2f1a2b6a9708afd021092717ed93daa9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2022-05-31 13:20:43.000000000","message":"Patch Set 1:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1},{"id":"12e5e955f4129728a4b32584c3bbb71c8d727a7f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:54:29.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f893777553857f7901354333d77e21431aa80a93","revisions":{"f893777553857f7901354333d77e21431aa80a93":{"kind":"REWORK","_number":1,"created":"2022-05-06 09:20:21.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/54/840854/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/840854/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/840854/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/840854/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/840854/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/840854/1"}}},"commit":{"parents":[{"commit":"a5da31ec1ea1d1c7b4df146857982699ebdc328e","subject":"Ensure MAC addresses characters are in the same case","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a5da31ec1ea1d1c7b4df146857982699ebdc328e"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-04-28 13:43:13.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-05-06 09:19:45.000000000","tz":120},"subject":"Isolate PCI tracker unit tests","message":"Isolate PCI tracker unit tests\n\nDuring the testing If9ab424cc7375a1f0d41b03f01c4a823216b3eb8 we noticed\nthat the unit test cases of PciTracker._set_hvdev are changing and\nleaking global state leading to unstable tests.\n\nTo reproduce on master, duplicate the\ntest_set_hvdev_remove_tree_maintained_with_allocations test case and run\nPciDevTrackerTestCase serially. The duplicated test case will fail with\n\n  File \"/nova/nova/objects/pci_device.py\", line 238, in _from_db_object\n  setattr(pci_device, key, db_dev[key])\n  KeyError: \u0027id\u0027\n\nThis is caused by the fact that the test data is defined on module\nlevel, both _create_tracker and _set_hvdevs modifies the devices\npassed to them, and some test mixes passing db dicts to _set_hvdevs\nthat expects pci dicts from the hypervisor.\n\nThis patch fixes multiple related issues:\n* always deepcopy what _create_tracker takes as that list is later\n  returned to the PciTracker via a mock and the tracker might modify\n  what it got\n\n* ensure that _create_tracker takes db dicts (with id field) while\n  _set_hvdevs takes pci dicts in the hypervisor format (without id\n  field)\n\n* always deepcopy what is passed to _set_hvdevs as the PciTracker modify\n  what it gets.\n\n* normalize when the deepcopy happens to give a safe patter for future\n  test cases\n\nChange-Id: I20fb4ea96d5dfabfc4be3b5ecec0e4e6c5b3a318\n(cherry picked from commit c58376db75917444831934963fa75b4b57f08818)\n(cherry picked from commit f04cfd42359d555e746df0e2c48d989d0c3244f1)\n(cherry picked from commit 1023580f6d9008f5e56f6d3905b6e227bd2bff67)\n(cherry picked from commit 3335d9317994ea3490fbc9945e0e961c42aef907)\n(cherry picked from commit 2fb300f71e87490f3e91d03dd5ce8eb88a5996a7)\n(cherry picked from commit cc705b6258c2ca270922c5f07d55e2413c16ec40)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f893777553857f7901354333d77e21431aa80a93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f893777553857f7901354333d77e21431aa80a93"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}