)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"9bc27dda741eab38116424641896185e23c789e0","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note that this patch is blocked by CI until the partial/rolling"},{"line_number":18,"context_line":"upgrade test is updated to test Icehouse-\u003eJuno.  Until then it\u0027s"},{"line_number":19,"context_line":"testing Havana-\u003eJuno, which is broken by this change (intentionally)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"UpgradeImpact"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_f7590536","line":19,"updated":"2014-06-18 11:06:22.000000000","message":"This change is not blocked anymore so the above comment can be removed.","commit_id":"72ee7b3c70ca73ba6c17b9ed389ebe54d03c89f6"}],"nova/conductor/api.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"53d0a78f7cd781c4bb7e2f0b51c8eeae6585c05e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":78,"context_line":"        return self._manager.instance_get_all_by_host("},{"line_number":79,"context_line":"            context, host, None, columns_to_join\u003dcolumns_to_join)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def instance_get_all_by_host_and_node(self, context, host, node):"},{"line_number":82,"context_line":"        return self._manager.instance_get_all_by_host(context, host, node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FaWM%3D","line":79,"updated":"2014-04-14 19:01:21.000000000","message":"Should the rpcapi method signature be updated to match this?\n\n(the same goes for all updated methods)","commit_id":"510770a0005469d356776506addfbf5f9f26a1ed"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"22da2a7740d2185ff8c6c595e593245210d29e76","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":78,"context_line":"        return self._manager.instance_get_all_by_host("},{"line_number":79,"context_line":"            context, host, None, columns_to_join\u003dcolumns_to_join)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def instance_get_all_by_host_and_node(self, context, host, node):"},{"line_number":82,"context_line":"        return self._manager.instance_get_all_by_host(context, host, node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FZLg%3D","line":79,"in_reply_to":"AAAAW3%2F%2FZw8%3D","updated":"2014-04-14 23:06:12.000000000","message":"Just think that it sometimes can help improve readability if there  is consistency between the methods, but I\u0027ll survive :)","commit_id":"510770a0005469d356776506addfbf5f9f26a1ed"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"ff31590ddb25d557fa83535992827178511d862d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":78,"context_line":"        return self._manager.instance_get_all_by_host("},{"line_number":79,"context_line":"            context, host, None, columns_to_join\u003dcolumns_to_join)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def instance_get_all_by_host_and_node(self, context, host, node):"},{"line_number":82,"context_line":"        return self._manager.instance_get_all_by_host(context, host, node,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FZw8%3D","line":79,"in_reply_to":"AAAAW3%2F%2FaWM%3D","updated":"2014-04-14 20:25:14.000000000","message":"They can be, but it really doesn\u0027t hurt to leave it.  The important thing is the manager side, and whether or not they have to tolerate an argument not being present. That is what is covered.","commit_id":"510770a0005469d356776506addfbf5f9f26a1ed"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"53d0a78f7cd781c4bb7e2f0b51c8eeae6585c05e","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def service_get_all(self, context):"},{"line_number":177,"context_line":"        return self._manager.service_get_all_by(context, host\u003dNone, topic\u003dNone,"},{"line_number":178,"context_line":"                binary\u003dNone)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def service_get_all_by_topic(self, context, topic):"},{"line_number":181,"context_line":"        return self._manager.service_get_all_by(context, topic\u003dtopic,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FaYg%3D","line":178,"updated":"2014-04-14 19:01:21.000000000","message":"Why aren\u0027t these changed to positional arguments so they match the updated manager method?","commit_id":"510770a0005469d356776506addfbf5f9f26a1ed"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"22da2a7740d2185ff8c6c595e593245210d29e76","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def service_get_all(self, context):"},{"line_number":177,"context_line":"        return self._manager.service_get_all_by(context, host\u003dNone, topic\u003dNone,"},{"line_number":178,"context_line":"                binary\u003dNone)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def service_get_all_by_topic(self, context, topic):"},{"line_number":181,"context_line":"        return self._manager.service_get_all_by(context, topic\u003dtopic,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FY8A%3D","line":178,"in_reply_to":"AAAAW3%2F%2FZwY%3D","updated":"2014-04-14 23:06:12.000000000","message":"Not going to hold up the patch on this as it will work either way. My point is just, as stated above, that I think it helps readability to have some consistency (this applies to the rpc code in general). The conversion to kwargs is as far as I know taken care of by the rpcapi layer so I think that instead aligning the call here (and the rpcapi signature) with the manager makes most sense.","commit_id":"510770a0005469d356776506addfbf5f9f26a1ed"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"ff31590ddb25d557fa83535992827178511d862d","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def service_get_all(self, context):"},{"line_number":177,"context_line":"        return self._manager.service_get_all_by(context, host\u003dNone, topic\u003dNone,"},{"line_number":178,"context_line":"                binary\u003dNone)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def service_get_all_by_topic(self, context, topic):"},{"line_number":181,"context_line":"        return self._manager.service_get_all_by(context, topic\u003dtopic,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FZwY%3D","line":178,"in_reply_to":"AAAAW3%2F%2FaYg%3D","updated":"2014-04-14 20:25:14.000000000","message":"manager methods are actually only ever called with kwargs when called via rpc, so this actually matches better than using positional arguments","commit_id":"510770a0005469d356776506addfbf5f9f26a1ed"}],"nova/conductor/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"525474042c37957d3ece55c302cfb4b6419f5968","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            self.db.instance_get_by_uuid(context, instance_uuid,"},{"line_number":137,"context_line":"                columns_to_join))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def instance_get_all_by_host(self, context, host, node,"},{"line_number":140,"context_line":"                                 columns_to_join):"},{"line_number":141,"context_line":"        if node is not None:"},{"line_number":142,"context_line":"            result \u003d self.db.instance_get_all_by_host_and_node("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9Vmk%3D","line":139,"updated":"2014-04-06 16:44:57.000000000","message":"why do we need to change the signature of this method?","commit_id":"3a3997038c5ddbe04151e4ccc624fdb335f86186"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"525474042c37957d3ece55c302cfb4b6419f5968","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        result \u003d self.db.aggregate_metadata_get_by_host(context, host, key)"},{"line_number":170,"context_line":"        return jsonutils.to_primitive(result)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def bw_usage_update(self, context, uuid, mac, start_period,"},{"line_number":173,"context_line":"                        bw_in, bw_out, last_ctr_in, last_ctr_out,"},{"line_number":174,"context_line":"                        last_refreshed, update_cells):"},{"line_number":175,"context_line":"        if [bw_in, bw_out, last_ctr_in, last_ctr_out].count(None) !\u003d 4:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9Vmc%3D","line":172,"updated":"2014-04-06 16:44:57.000000000","message":"ditto","commit_id":"3a3997038c5ddbe04151e4ccc624fdb335f86186"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"385c1ec6725d2b70b9cf66f60999dcc78a42b688","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        instance.system_metadata \u003d sys_meta"},{"line_number":671,"context_line":"        instance.save()"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"class _ConductorManagerV2Proxy(object):"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    target \u003d messaging.Target(version\u003d\u00272.0\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2Fl8Y%3D","line":673,"updated":"2014-04-11 22:19:42.000000000","message":"Shouldn\u0027t we remove this now?","commit_id":"9229652a0c6f4f183af088dc6cf4724de546cf1d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"838c1a26df02ceea98c10e8d49f9b3953f150064","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        instance.system_metadata \u003d sys_meta"},{"line_number":671,"context_line":"        instance.save()"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"class _ConductorManagerV2Proxy(object):"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    target \u003d messaging.Target(version\u003d\u00272.0\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FkVc%3D","line":673,"in_reply_to":"AAAAW3%2F%2Fl8Y%3D","updated":"2014-04-12 12:29:30.000000000","message":"I\u0027m sure you\u0027re right, but I don\u0027t know what you\u0027re referring to exactly ... can you expand on what/why?","commit_id":"9229652a0c6f4f183af088dc6cf4724de546cf1d"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"2ed678847ef3321b6f1fcba62c4ee607af220cd3","unresolved":false,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    target \u003d messaging.Target(version\u003d\u00272.0\u0027)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def __init__(self, manager):"},{"line_number":679,"context_line":"        self.manager \u003d manager"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def instance_update(self, context, instance_uuid, updates,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FkSU%3D","line":678,"updated":"2014-04-12 13:31:28.000000000","message":"I guess Dan talks about the V2 proxy class? This should be removed right?","commit_id":"9229652a0c6f4f183af088dc6cf4724de546cf1d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f3dd35ffb99d11bd54ec7d906b16c14a69fa3b73","unresolved":false,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    target \u003d messaging.Target(version\u003d\u00272.0\u0027)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def __init__(self, manager):"},{"line_number":679,"context_line":"        self.manager \u003d manager"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def instance_update(self, context, instance_uuid, updates,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FcQY%3D","line":678,"in_reply_to":"AAAAW3%2F%2FkSU%3D","updated":"2014-04-14 15:16:50.000000000","message":"could be.  if so, of course.  :)","commit_id":"9229652a0c6f4f183af088dc6cf4724de546cf1d"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"9bc27dda741eab38116424641896185e23c789e0","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        instance.system_metadata \u003d sys_meta"},{"line_number":711,"context_line":"        instance.save()"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"class _ConductorManagerV2Proxy(object):"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    target \u003d messaging.Target(version\u003d\u00272.0\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_1c5db648","line":713,"updated":"2014-06-18 11:06:22.000000000","message":"proxy class is no longer used and can be removed","commit_id":"72ee7b3c70ca73ba6c17b9ed389ebe54d03c89f6"}]}