)]}'
{"nova/objects/migrate_data.py":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"7d7080e7035f39a461174476c261b5a9556bb119","unresolved":true,"context_lines":[{"line_number":279,"context_line":"        if (target_version \u003c (1, 10) and"},{"line_number":280,"context_line":"                \u0027src_supports_numa_live_migration\u0027 in primitive):"},{"line_number":281,"context_line":"            del primitive[\u0027src_supports_numa_live_migration\u0027]"},{"line_number":282,"context_line":"        if (target_version \u003c (1, 10) and"},{"line_number":283,"context_line":"                \u0027dst_supports_numa_live_migration\u0027 in primitive):"},{"line_number":284,"context_line":"            del primitive[\u0027dst_supports_numa_live_migration\u0027]"},{"line_number":285,"context_line":"        if target_version \u003c (1, 10) and \u0027dst_numa_info\u0027 in primitive:"},{"line_number":286,"context_line":"            del primitive[\u0027dst_numa_info\u0027]"},{"line_number":287,"context_line":"        if target_version \u003c (1, 9) and \u0027vifs\u0027 in primitive:"}],"source_content_type":"text/x-python","patch_set":3,"id":"273a0744_979b2aa3","line":284,"range":{"start_line":282,"start_character":0,"end_line":284,"end_character":61},"updated":"2022-05-26 12:45:07.000000000","message":"This looks like a change in nova object/logic to me and there is a possible minor bug. Maybe it is better to have a separate change for it?","commit_id":"24ddb4ac28da9c63edbe549fef5cb31282f8e00e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2e0c8f72b1dab8f24f8e3cca9f4a5ed1ec6deb86","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        if (target_version \u003c (1, 10) and"},{"line_number":280,"context_line":"                \u0027src_supports_numa_live_migration\u0027 in primitive):"},{"line_number":281,"context_line":"            del primitive[\u0027src_supports_numa_live_migration\u0027]"},{"line_number":282,"context_line":"        if (target_version \u003c (1, 10) and"},{"line_number":283,"context_line":"                \u0027dst_supports_numa_live_migration\u0027 in primitive):"},{"line_number":284,"context_line":"            del primitive[\u0027dst_supports_numa_live_migration\u0027]"},{"line_number":285,"context_line":"        if target_version \u003c (1, 10) and \u0027dst_numa_info\u0027 in primitive:"},{"line_number":286,"context_line":"            del primitive[\u0027dst_numa_info\u0027]"},{"line_number":287,"context_line":"        if target_version \u003c (1, 9) and \u0027vifs\u0027 in primitive:"}],"source_content_type":"text/x-python","patch_set":3,"id":"413eab76_25c6ecc5","line":284,"range":{"start_line":282,"start_character":0,"end_line":284,"end_character":61},"in_reply_to":"273a0744_979b2aa3","updated":"2022-05-27 04:29:26.000000000","message":"I have reported separate bug for this [1] and submitted patch as well [2].\n\n[1] https://bugs.launchpad.net/nova/+bug/1975891\n[2] https://review.opendev.org/c/openstack/nova/+/843565\n\nThanks for your suggestion.","commit_id":"24ddb4ac28da9c63edbe549fef5cb31282f8e00e"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"74023e9f93edf9646e0e64f654d38ee2e415e82a","unresolved":true,"context_lines":[{"line_number":1354,"context_line":"            hard_delete\u003dFalse)"},{"line_number":1355,"context_line":""},{"line_number":1356,"context_line":"    def _fake_do_delete(context, instance, bdms,"},{"line_number":1357,"context_line":"                        reservations\u003dNone, local\u003dFalse):"},{"line_number":1358,"context_line":"        pass"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"15a9e75b_7f222e47","line":1357,"range":{"start_line":1357,"start_character":24,"end_line":1357,"end_character":41},"updated":"2022-05-27 11:33:44.000000000","message":"IMO it is better to simply delete this definition/argument because it is no longer used in _local_delete:\n\ncb(context, instance, bdms, local\u003dTrue)\nhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L2580-L2606","commit_id":"d1074ff7f00cf5f6af921b031082bf65d33b7c9a"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"b4fa56f2b20d6d7a7e6e129cfa52a2c61c1ad544","unresolved":true,"context_lines":[{"line_number":1354,"context_line":"            hard_delete\u003dFalse)"},{"line_number":1355,"context_line":""},{"line_number":1356,"context_line":"    def _fake_do_delete(context, instance, bdms,"},{"line_number":1357,"context_line":"                        reservations\u003dNone, local\u003dFalse):"},{"line_number":1358,"context_line":"        pass"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a4483186_16795b97","line":1357,"range":{"start_line":1357,"start_character":24,"end_line":1357,"end_character":41},"in_reply_to":"15a9e75b_7f222e47","updated":"2022-05-30 10:29:03.000000000","message":"Should we separate patch in different patches ? Like\n\none for fixing typos in help and log messages and doc string. (so that we could backport it if required)\n\none for fixing typos in comments and in tests etc.","commit_id":"d1074ff7f00cf5f6af921b031082bf65d33b7c9a"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"6510c28095e17dc26aee2def3ede2f3e0dd1d30f","unresolved":true,"context_lines":[{"line_number":1354,"context_line":"            hard_delete\u003dFalse)"},{"line_number":1355,"context_line":""},{"line_number":1356,"context_line":"    def _fake_do_delete(context, instance, bdms,"},{"line_number":1357,"context_line":"                        reservations\u003dNone, local\u003dFalse):"},{"line_number":1358,"context_line":"        pass"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b936fb93_3c469bbc","line":1357,"range":{"start_line":1357,"start_character":24,"end_line":1357,"end_character":41},"in_reply_to":"a4483186_16795b97","updated":"2022-05-30 12:05:16.000000000","message":"IMO if we want to remove this, we should do that in separate patch, instead of doing in this patch where we are just fixing typos. WDYT ?","commit_id":"d1074ff7f00cf5f6af921b031082bf65d33b7c9a"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"6f42883a085ac20cf6b539a9c83e9fcc62f3dc0c","unresolved":true,"context_lines":[{"line_number":1354,"context_line":"            hard_delete\u003dFalse)"},{"line_number":1355,"context_line":""},{"line_number":1356,"context_line":"    def _fake_do_delete(context, instance, bdms,"},{"line_number":1357,"context_line":"                        reservations\u003dNone, local\u003dFalse):"},{"line_number":1358,"context_line":"        pass"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bdba170f_43f216e8","line":1357,"range":{"start_line":1357,"start_character":24,"end_line":1357,"end_character":41},"in_reply_to":"b936fb93_3c469bbc","updated":"2022-05-30 12:58:57.000000000","message":"I think that both options should work. Separate patch is probably better aligns with developer\u0027s guidelines and this point doesn\u0027t look like a blocker to me.","commit_id":"d1074ff7f00cf5f6af921b031082bf65d33b7c9a"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"1da3d58a3cedadacfaef6566d21e3cc042dc161e","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"            hard_delete\u003dFalse)"},{"line_number":1355,"context_line":""},{"line_number":1356,"context_line":"    def _fake_do_delete(context, instance, bdms,"},{"line_number":1357,"context_line":"                        reservations\u003dNone, local\u003dFalse):"},{"line_number":1358,"context_line":"        pass"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"    @mock.patch.object(compute_utils, \u0027notify_about_instance_action\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"edb0279d_b22fa0d9","line":1357,"range":{"start_line":1357,"start_character":24,"end_line":1357,"end_character":41},"in_reply_to":"bdba170f_43f216e8","updated":"2022-06-01 12:16:17.000000000","message":"https://review.opendev.org/c/openstack/nova/+/844285","commit_id":"d1074ff7f00cf5f6af921b031082bf65d33b7c9a"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7005321097feb49b587ec3d3919f180b33d67a56","unresolved":true,"context_lines":[{"line_number":5002,"context_line":"            mock.patch(\u0027nova.objects.Instance.get_by_uuid\u0027)"},{"line_number":5003,"context_line":"        ) as (_get_instances_on_driver, destroy, migration_list,"},{"line_number":5004,"context_line":"              migration_save, get_resources, remove_allocation,"},{"line_number":5005,"context_line":"              instance_get_by_uuid):"},{"line_number":5006,"context_line":"            migration_list.return_value \u003d [migration_1]"},{"line_number":5007,"context_line":"            instance_get_by_uuid.return_value \u003d instance_1"},{"line_number":5008,"context_line":"            get_resources.return_value \u003d mock.sentinel.resources"}],"source_content_type":"text/x-python","patch_set":7,"id":"56cee4db_2fa3ac19","line":5005,"updated":"2022-06-01 08:17:56.000000000","message":"as you need to reflow the lines I would do and format the whole context manager as:\n\n        with test.nested(\n            mock.patch.object(\n                self.compute, \"_get_instances_on_driver\", return_value\u003d[]\n            ),\n            mock.patch.object(self.compute.driver, \"destroy\"),\n            mock.patch(\"nova.objects.MigrationList.get_by_filters\"),\n            mock.patch(\"nova.objects.Migration.save\"),\n            mock.patch(\"nova.scheduler.utils.resources_from_flavor\"),\n            mock.patch.object(\n                self.compute.reportclient,\n                \"remove_provider_tree_from_instance_allocation\",\n            ),\n            mock.patch(\"nova.objects.Instance.get_by_uuid\"),\n        ) as (\n            _get_instances_on_driver,\n            destroy,\n            migration_list,\n            migration_save,\n            get_resources,\n            remove_allocation,\n            instance_get_by_uuid,\n        ):","commit_id":"2521810e553593f8d02adeef0f089b60bc7f71a6"}],"nova/tests/unit/scheduler/weights/test_weights_metrics.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7005321097feb49b587ec3d3919f180b33d67a56","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        setting \u003d [idle + \u0027\u003d-2\u0027, idle + \u0027\u003d1\u0027]"},{"line_number":115,"context_line":"        self._do_test(setting, 1.0, \u0027host1\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_single_resourcenegative_ratio(self):"},{"line_number":118,"context_line":"        # host1: idle\u003d512"},{"line_number":119,"context_line":"        # host2: idle\u003d1024"},{"line_number":120,"context_line":"        # host3: idle\u003d3072"}],"source_content_type":"text/x-python","patch_set":7,"id":"fcdcb6f5_fd5aeccd","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":42},"updated":"2022-06-01 08:17:56.000000000","message":"I would fix the naming too:\n  test_single_resource_negative_ratio","commit_id":"2521810e553593f8d02adeef0f089b60bc7f71a6"}]}