)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6aa9f4055ebcdd3742dcb7e145c4b507c460231a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29a5385e_5b6758a6","updated":"2022-05-25 10:15:13.000000000","message":"minor nit as i would prefer to use oslo but nice find.","commit_id":"89a397df8cba1e8ec62ce67fd92d4e4a6792386b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9274de4a114d11aca32ed58ac67bbde794ff52c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c747595_478ac73d","updated":"2022-05-25 10:33:28.000000000","message":"cool thanks for addressing my nit\nthis looks good to me.\n\nfor context to others the kernel started chaning some of the values in /sys to be y/n instead of 1/0 sometime in the later half of the 5.x series. it seams to be module specific form chating on irc breilfly but that is the reason this change is needed.\n\nusing oslo shoudl insulate us form any future changes provide the values remain relaitvly sane for convertion to bool so +2","commit_id":"ab51a5dd25b8d4c66562148b43b1022eb5ceed7e"}],"nova/tests/unit/virt/libvirt/test_host.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9274de4a114d11aca32ed58ac67bbde794ff52c0","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"        fake_exists.assert_called_once_with("},{"line_number":1957,"context_line":"            \u0027/sys/module/kvm_amd/parameters/sev\u0027)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"    @ddt.data("},{"line_number":1960,"context_line":"        (\u00270\\n\u0027, False),"},{"line_number":1961,"context_line":"        (\u0027N\\n\u0027, False),"},{"line_number":1962,"context_line":"        (\u00271\\n\u0027, True),"}],"source_content_type":"text/x-python","patch_set":2,"id":"acd1d0ba_041b8b2e","line":1959,"range":{"start_line":1959,"start_character":3,"end_line":1959,"end_character":14},"updated":"2022-05-25 10:33:28.000000000","message":"i always like to see ddt based tests.\ni shoudl write them more often :)","commit_id":"ab51a5dd25b8d4c66562148b43b1022eb5ceed7e"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6aa9f4055ebcdd3742dcb7e145c4b507c460231a","unresolved":true,"context_lines":[{"line_number":1702,"context_line":"            content \u003d f.read()"},{"line_number":1703,"context_line":"            LOG.debug(\"%s contains [%s]\", SEV_KERNEL_PARAM_FILE, content)"},{"line_number":1704,"context_line":"            content \u003d content.strip().lower()"},{"line_number":1705,"context_line":"            return content in [\"1\", \"y\"]"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    @property"},{"line_number":1708,"context_line":"    def supports_amd_sev(self) -\u003e bool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"14f54017_72dfd4c6","line":1705,"range":{"start_line":1705,"start_character":19,"end_line":1705,"end_character":40},"updated":"2022-05-25 10:15:13.000000000","message":"rather then this can we just use oslo\u0027s bool_from_string instead https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L131\u003d","commit_id":"89a397df8cba1e8ec62ce67fd92d4e4a6792386b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d32ae8a13f8379e8d409f59d48e9651ad8aa4801","unresolved":false,"context_lines":[{"line_number":1702,"context_line":"            content \u003d f.read()"},{"line_number":1703,"context_line":"            LOG.debug(\"%s contains [%s]\", SEV_KERNEL_PARAM_FILE, content)"},{"line_number":1704,"context_line":"            content \u003d content.strip().lower()"},{"line_number":1705,"context_line":"            return content in [\"1\", \"y\"]"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    @property"},{"line_number":1708,"context_line":"    def supports_amd_sev(self) -\u003e bool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5743f472_8717c1b9","line":1705,"range":{"start_line":1705,"start_character":19,"end_line":1705,"end_character":40},"in_reply_to":"14f54017_72dfd4c6","updated":"2022-05-25 10:18:16.000000000","message":"Done","commit_id":"89a397df8cba1e8ec62ce67fd92d4e4a6792386b"}]}