)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c694691dfb940b6882a6271e015ad12f11361d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91afb458_f2f40c60","updated":"2022-05-26 13:06:53.000000000","message":"thanks for tracking this down. I have a suggestion inline","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"}],"tox.ini":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c694691dfb940b6882a6271e015ad12f11361d15","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  Run style checks."},{"line_number":93,"context_line":"deps \u003d"},{"line_number":94,"context_line":"  {[testenv]deps}"},{"line_number":95,"context_line":"  autopep8\u003d\u003d1.5.5"},{"line_number":96,"context_line":"extras \u003d"},{"line_number":97,"context_line":"commands \u003d"},{"line_number":98,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"d12edaa2_313107e0","line":95,"updated":"2022-05-26 13:06:53.000000000","message":"I suggest to move the whole autopep8 dependency to the test-requirements.txt instead","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50ccadaca50793175ac4e0b0ba5178702ae974ae","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  Run style checks."},{"line_number":93,"context_line":"deps \u003d"},{"line_number":94,"context_line":"  {[testenv]deps}"},{"line_number":95,"context_line":"  autopep8\u003d\u003d1.5.5"},{"line_number":96,"context_line":"extras \u003d"},{"line_number":97,"context_line":"commands \u003d"},{"line_number":98,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"929216e7_3130d78e","line":95,"in_reply_to":"1f9cbf71_cfb53b8e","updated":"2022-05-31 09:36:49.000000000","message":"we can add it to global requireemtns if we want too","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a554c365a3c4b5e24019b86bc1dc32d56cb5ace9","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  Run style checks."},{"line_number":93,"context_line":"deps \u003d"},{"line_number":94,"context_line":"  {[testenv]deps}"},{"line_number":95,"context_line":"  autopep8\u003d\u003d1.5.5"},{"line_number":96,"context_line":"extras \u003d"},{"line_number":97,"context_line":"commands \u003d"},{"line_number":98,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"d8dbde2d_75830c02","line":95,"in_reply_to":"929216e7_3130d78e","updated":"2022-05-31 11:23:51.000000000","message":"\u003e we can add it to global requireemtns if we want too\n\nLinters should be blacklisted [1]\n\n[1] https://github.com/openstack/requirements/blob/master/blacklist.txt","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aecd50863d4bfbfd278324cb3d1818870dec43e6","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  Run style checks."},{"line_number":93,"context_line":"deps \u003d"},{"line_number":94,"context_line":"  {[testenv]deps}"},{"line_number":95,"context_line":"  autopep8\u003d\u003d1.5.5"},{"line_number":96,"context_line":"extras \u003d"},{"line_number":97,"context_line":"commands \u003d"},{"line_number":98,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9596caac_a0fbfc6d","line":95,"in_reply_to":"929216e7_3130d78e","updated":"2022-05-31 11:28:20.000000000","message":"I\u0027ve pushed a patch to global reqs https://review.opendev.org/c/openstack/requirements/+/844038 When that lands we can add autpep8 test-requirements in nova.","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"},{"author":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"change_message_id":"be33245f94875229bda1ed3a325e940303ad524d","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  Run style checks."},{"line_number":93,"context_line":"deps \u003d"},{"line_number":94,"context_line":"  {[testenv]deps}"},{"line_number":95,"context_line":"  autopep8\u003d\u003d1.5.5"},{"line_number":96,"context_line":"extras \u003d"},{"line_number":97,"context_line":"commands \u003d"},{"line_number":98,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"fc3f94c4_bee498b0","line":95,"in_reply_to":"d12edaa2_313107e0","updated":"2022-05-27 13:53:33.000000000","message":"My understanding from comment #3 in the LP[1] was that we aren\u0027t supposed to pin specific versions (or set max versions) in test-requirements.txt\n\nEven if we can, given that autopep8 is only used in the pep8 testenv, it might make sense to keep the dep in there as it saves other testenvs from installing it pointlessly. This bug would\u0027ve broken all testenvs in impacted runtimes if autopep8 had been in test-requirements.txt\n\nNot a strong preference on my part, I\u0027ll defer to you and others with more of a stake in the project.\n\n[1] https://bugs.launchpad.net/nova/+bug/1975711/comments/3","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac73126bbaa46cbbccdccb15c4c6d28358a328fc","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  Run style checks."},{"line_number":93,"context_line":"deps \u003d"},{"line_number":94,"context_line":"  {[testenv]deps}"},{"line_number":95,"context_line":"  autopep8\u003d\u003d1.5.5"},{"line_number":96,"context_line":"extras \u003d"},{"line_number":97,"context_line":"commands \u003d"},{"line_number":98,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f9cbf71_cfb53b8e","line":95,"in_reply_to":"fc3f94c4_bee498b0","updated":"2022-05-31 08:06:32.000000000","message":"I\u0027m not sure how test-requirements are handled in global requirements but autopep8 is not in https://github.com/openstack/requirements/blob/master/global-requirements.txt So it is not constraint globally. If it would be there then I would suggest to pin in there.","commit_id":"cffe8b28bc323329d21fc64643343b3f81699502"}]}