)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f9be680631a00541158243c55609a5804cc7777d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"on the destination via the driver bdm objects we provide in"},{"line_number":21,"context_line":"block_device_info."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The following FUP commits were squashed into this one for backport"},{"line_number":24,"context_line":"purposes:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"fup: Make connection_info returned by CinderFixture unique per attachment"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"49b95f9d_d3a9cf2e","line":23,"updated":"2022-06-03 08:33:09.000000000","message":"I\u0027m not 100% sure about the squash. What is the benefit of it? I see a drawback. If  somebody look for the change ID of the squashed commits via gerrit, or look for the included-in tab in gerrit then these fups will not be visible on the older stable branches even though the change itself will be there. I\u0027m not sure what is the stable policy about this. So I hope @Elod or @Melanie can comment on it","commit_id":"9ccd2bc36287e0cc217609c503d74bb036b9d93b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9173e3aa9608be2e451e0daa06180eb30040d394","unresolved":true,"context_lines":[{"line_number":20,"context_line":"on the destination via the driver bdm objects we provide in"},{"line_number":21,"context_line":"block_device_info."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The following FUP commits were squashed into this one for backport"},{"line_number":24,"context_line":"purposes:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"fup: Make connection_info returned by CinderFixture unique per attachment"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"006902af_55b94594","line":23,"in_reply_to":"281a233e_60e129ba","updated":"2022-06-03 16:04:16.000000000","message":"Agree with Elod. Generally the only time we squash backports is if it\u0027s a chicken and egg problem in a gate breakage where each backported patch would fail CI without the other.","commit_id":"9ccd2bc36287e0cc217609c503d74bb036b9d93b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"882dfb60fac51eadb5732212dfbdf59b7620d30f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"on the destination via the driver bdm objects we provide in"},{"line_number":21,"context_line":"block_device_info."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The following FUP commits were squashed into this one for backport"},{"line_number":24,"context_line":"purposes:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"fup: Make connection_info returned by CinderFixture unique per attachment"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"281a233e_60e129ba","line":23,"in_reply_to":"49b95f9d_d3a9cf2e","updated":"2022-06-03 08:59:41.000000000","message":"well, the change-ids are there, but still, it\u0027s better to avoid squashes. (for some cases it is necessary: blocked gate, introduced bug without the squash)\n\nWith a quick look at this patch i think these can be kept separate, no reason to squash them.","commit_id":"9ccd2bc36287e0cc217609c503d74bb036b9d93b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d2261064c5a4c3f0ea7fec6b78f29cf7afae4534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"883c8d95_708d5785","updated":"2022-05-27 19:26:46.000000000","message":"recheck","commit_id":"01af5b2f216fa211297a0ae65c6a35853b71d7d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2a8b1727108965846f0e3cf50de284e9bf86714c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c4ede66b_10c1cd41","updated":"2022-05-30 18:22:52.000000000","message":"recheck https://review.opendev.org/c/openstack/tempest/+/843946","commit_id":"9ccd2bc36287e0cc217609c503d74bb036b9d93b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b366b507a61b07fd340d0496a12b735b42b72332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ab076b6a_14068464","updated":"2022-06-14 00:25:52.000000000","message":"Change otherwise looks good, clean backport of an important bug fix, will change to +2 once CI passes.","commit_id":"aad7dabc5a9d790193d42b2155f186e7ec74a408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"28049a545207408b6e07f996da6d95ee54341910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"de827b5b_2364dc51","updated":"2022-06-14 02:06:22.000000000","message":"Upgrading to +2","commit_id":"aad7dabc5a9d790193d42b2155f186e7ec74a408"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"83db6d404e4542da73edad75a1daab21222c850e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4d3aa2fa_da730ffd","updated":"2022-06-13 23:52:16.000000000","message":"recheck https://review.opendev.org/c/openstack/devstack/+/805008 has merged","commit_id":"aad7dabc5a9d790193d42b2155f186e7ec74a408"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b7fedc79422f16ba2a4104a3df308221c0f4153b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5c8448f0_be4ed70c","updated":"2022-06-22 08:18:26.000000000","message":"Looks good. I hold +A until the CI finishes","commit_id":"9bccc5a04354b0490fbe7e0f0b98cf55d4b7c9c4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f875f206b97f6338e2eaa04b9cfc47e77d98dc3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fa91517b_585bd5ed","updated":"2022-06-30 13:29:09.000000000","message":"recheck  Kernel panic - not syncing: IO-APIC + timer doesn\u0027t work!  Boot with apic\u003ddebug and send a report.  Then try booting with the \u0027noapic\u0027 option.\n\ni havent seen that failure in a while but that was the only issue with nova-next\ni dont think its related and the ci will reject it if it failes again so given this has 2 +2s already and it looks valid to me too im going to +w and the gate will kick it back if it failes agin.","commit_id":"9bccc5a04354b0490fbe7e0f0b98cf55d4b7c9c4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"14522fb8e720595d6f2849ec9c92a98fd72bf4e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"17ef893a_2a491c66","updated":"2022-06-22 07:04:29.000000000","message":"recheck bug 1979052 (got fixed in tempest)","commit_id":"9bccc5a04354b0490fbe7e0f0b98cf55d4b7c9c4"}],"nova/tests/fixtures.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f9be680631a00541158243c55609a5804cc7777d","unresolved":true,"context_lines":[{"line_number":2608,"context_line":"                attachment_id\u003dattachment_id)"},{"line_number":2609,"context_line":""},{"line_number":2610,"context_line":"        def _find_connection_info(volume_id, attachment_id):"},{"line_number":2611,"context_line":"            \"\"\"Find the connection_info associated with an attachment"},{"line_number":2612,"context_line":"            :returns: A connection_info dict based on a deepcopy associated"},{"line_number":2613,"context_line":"                with the volume_id but containing the attachment_id, making it"},{"line_number":2614,"context_line":"                unique for the attachment."}],"source_content_type":"text/x-python","patch_set":6,"id":"4650ef99_41a3cccd","line":2611,"updated":"2022-06-03 08:33:09.000000000","message":"nit: missing empty line after this line compared to the master patch","commit_id":"9ccd2bc36287e0cc217609c503d74bb036b9d93b"}]}
