)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2b5c2662a70789d58b8a832a5039df6e60f900e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"passthrough_whitelist name and introduce a better one."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the usage of CONF.pci.passthrough_whitelist is now changed over to"},{"line_number":15,"context_line":"the new device_list config. Also the in tree documentation is updated"},{"line_number":16,"context_line":"accordinly."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However the nova code still has a bunch of references to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8d620048_6e656986","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":19},"updated":"2022-07-11 08:43:08.000000000","message":"device_spec","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3e9de10d0e14fb220a6cf4cf57e0c988fc37012","unresolved":false,"context_lines":[{"line_number":12,"context_line":"passthrough_whitelist name and introduce a better one."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the usage of CONF.pci.passthrough_whitelist is now changed over to"},{"line_number":15,"context_line":"the new device_list config. Also the in tree documentation is updated"},{"line_number":16,"context_line":"accordinly."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However the nova code still has a bunch of references to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f0936a2d_4b2eeea4","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":19},"in_reply_to":"8d620048_6e656986","updated":"2022-07-19 18:45:04.000000000","message":"Done","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7f86ad0d9f6b1d717ff74d42251acc4ef42bb52","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"All the usage of CONF.pci.passthrough_whitelist is now changed over to"},{"line_number":15,"context_line":"the new device_spec config. Also the in tree documentation is updated"},{"line_number":16,"context_line":"accordinly."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However the nova code still has a bunch of references to the"},{"line_number":19,"context_line":"\"whitelist\" terminology. That will be handled in subsequent patches."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"c61793c3_39bae027","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"updated":"2022-08-09 16:55:35.000000000","message":"accordingly","commit_id":"d26ff3b69597b3cf3eea18262b042ccc124488fc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6f40f0f7e1309346e1823b9283418ec9b1588221","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f8ea5a4_8073b495","updated":"2022-05-30 12:44:57.000000000","message":"recheck \n* nova-ovs-hybrid-plug failed with:\n  ERROR: No matching distribution found for setuptools\u003e\u003d42\n  https://zuul.opendev.org/t/openstack/build/3932edb85ed74c319d2f56ab525372e7/log/job-output.txt#12417\n* nova-grenade-multinode failed as the compute service was not up, but based on the log directory there was no nova controller service was even deployed ?!\n  https://zuul.opendev.org/t/openstack/build/b5bc8c5cb81b41b28f70cc4adf123ae5/log/job-output.txt#17610","commit_id":"ebc384b761b24be54f9d1d481aa25420a7752dd9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2b5c2662a70789d58b8a832a5039df6e60f900e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29b45a23_a0391916","updated":"2022-07-11 08:43:08.000000000","message":"there is some minor inconsitency in your use of jsonutils but i dont think we need to hold the patch for that. if you resping it woul be nice to choose one form or the other but it can always be adressed in a follow up later in the series","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"}],"nova/tests/unit/pci/test_manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7f86ad0d9f6b1d717ff74d42251acc4ef42bb52","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        self.flags("},{"line_number":237,"context_line":"            group\u003d\u0027pci\u0027,"},{"line_number":238,"context_line":"            device_spec\u003d["},{"line_number":239,"context_line":"                \u0027{\"product_id\":\"2032\", \"vendor_id\":\"8086\"}\u0027])"},{"line_number":240,"context_line":"        # There are systems where 32 bit PCI domain is used. See bug 1897528"},{"line_number":241,"context_line":"        # for example. While nova (and qemu) does not support assigning such"},{"line_number":242,"context_line":"        # devices but the existence of such device in the system should not"}],"source_content_type":"text/x-python","patch_set":9,"id":"e4a5ea5c_92357a97","line":239,"updated":"2022-08-09 16:55:35.000000000","message":"nit: one line?","commit_id":"d26ff3b69597b3cf3eea18262b042ccc124488fc"}],"nova/tests/unit/pci/test_stats.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2b5c2662a70789d58b8a832a5039df6e60f900e","unresolved":true,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def setUp(self):"},{"line_number":468,"context_line":"        super(PciDeviceStatsWithTagsTestCase, self).setUp()"},{"line_number":469,"context_line":"        white_list \u003d [\u0027{\"vendor_id\":\"1137\",\"product_id\":\"0071\",\u0027"},{"line_number":470,"context_line":"                        \u0027\"address\":\"*:0a:00.*\",\"physical_network\":\"physnet1\"}\u0027,"},{"line_number":471,"context_line":"                      \u0027{\"vendor_id\":\"1137\",\"product_id\":\"0072\"}\u0027,"},{"line_number":472,"context_line":"                      \u0027{\"vendor_id\":\"15b3\",\"product_id\":\"101e\", \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5fb754b_c356cd38","line":469,"range":{"start_line":469,"start_character":8,"end_line":469,"end_character":19},"updated":"2022-07-11 08:43:08.000000000","message":"any reason you are not using jsonutils.dumps here","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3e9de10d0e14fb220a6cf4cf57e0c988fc37012","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def setUp(self):"},{"line_number":468,"context_line":"        super(PciDeviceStatsWithTagsTestCase, self).setUp()"},{"line_number":469,"context_line":"        white_list \u003d [\u0027{\"vendor_id\":\"1137\",\"product_id\":\"0071\",\u0027"},{"line_number":470,"context_line":"                        \u0027\"address\":\"*:0a:00.*\",\"physical_network\":\"physnet1\"}\u0027,"},{"line_number":471,"context_line":"                      \u0027{\"vendor_id\":\"1137\",\"product_id\":\"0072\"}\u0027,"},{"line_number":472,"context_line":"                      \u0027{\"vendor_id\":\"15b3\",\"product_id\":\"101e\", \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b3269b7_05a01cb3","line":469,"range":{"start_line":469,"start_character":8,"end_line":469,"end_character":19},"in_reply_to":"a5fb754b_c356cd38","updated":"2022-07-19 18:45:04.000000000","message":"Done","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f2b5c2662a70789d58b8a832a5039df6e60f900e","unresolved":true,"context_lines":[{"line_number":714,"context_line":"    def setUp(self):"},{"line_number":715,"context_line":"        super(PciDeviceVFPFStatsTestCase, self).setUp()"},{"line_number":716,"context_line":"        device_spec \u003d ["},{"line_number":717,"context_line":"            jsonutils.dumps({\"vendor_id\": \"8086\", \"product_id\": \"1528\"}),"},{"line_number":718,"context_line":"            jsonutils.dumps({\"vendor_id\": \"8086\", \"product_id\": \"1515\"}),"},{"line_number":719,"context_line":"            jsonutils.dumps("},{"line_number":720,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":2,"id":"38562968_59566b9d","line":717,"range":{"start_line":717,"start_character":12,"end_line":717,"end_character":27},"updated":"2022-07-11 08:43:08.000000000","message":"i mean you dont really need ot use jsonutils.dumps here either but it would be nice to be consitent by either using one form or the other.\n\nit does not really matter one way or another","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3e9de10d0e14fb220a6cf4cf57e0c988fc37012","unresolved":false,"context_lines":[{"line_number":714,"context_line":"    def setUp(self):"},{"line_number":715,"context_line":"        super(PciDeviceVFPFStatsTestCase, self).setUp()"},{"line_number":716,"context_line":"        device_spec \u003d ["},{"line_number":717,"context_line":"            jsonutils.dumps({\"vendor_id\": \"8086\", \"product_id\": \"1528\"}),"},{"line_number":718,"context_line":"            jsonutils.dumps({\"vendor_id\": \"8086\", \"product_id\": \"1515\"}),"},{"line_number":719,"context_line":"            jsonutils.dumps("},{"line_number":720,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":2,"id":"209312eb_737fc870","line":717,"range":{"start_line":717,"start_character":12,"end_line":717,"end_character":27},"in_reply_to":"38562968_59566b9d","updated":"2022-07-19 18:45:04.000000000","message":"Done","commit_id":"55770e4c1473249651b103a3c8b52aa2988dcc2d"}],"releasenotes/notes/deprecate-passthrough_whitelist-config-name-0530d502c960d753.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7f86ad0d9f6b1d717ff74d42251acc4ef42bb52","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The [pci]passthrough_whitelist config option is renamed to"},{"line_number":5,"context_line":"    [pci]device_spec. The old name is deprecated and aliased to the new one."},{"line_number":6,"context_line":"    The old name will be removed in a future release."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"12a7ae14_413dbd37","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":34},"updated":"2022-08-09 16:55:35.000000000","message":"nit:\n\n  ``code``","commit_id":"d26ff3b69597b3cf3eea18262b042ccc124488fc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7f86ad0d9f6b1d717ff74d42251acc4ef42bb52","unresolved":true,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The [pci]passthrough_whitelist config option is renamed to"},{"line_number":5,"context_line":"    [pci]device_spec. The old name is deprecated and aliased to the new one."},{"line_number":6,"context_line":"    The old name will be removed in a future release."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f4a56033_81605424","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":20},"updated":"2022-08-09 16:55:35.000000000","message":"ditto","commit_id":"d26ff3b69597b3cf3eea18262b042ccc124488fc"}]}