)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c9252fefba351d4c6095b1c4a908ed64d2e73b31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"09deef64_afa088d1","updated":"2022-06-14 02:41:38.000000000","message":"One question, other comments are just notes.","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d84e1b32464d3ba86ba7b52ae5210e4040efded6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c669e4f_2a126772","updated":"2022-06-15 00:18:00.000000000","message":"This looks OK to me, differences from the cherry picked change are explained in the commit message and make sense, LGTM","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5dcf5d99d622d99208ba22b2eb27e1a7e6ca5da0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e3045b36_ecafc107","updated":"2022-06-22 07:43:26.000000000","message":"recheck openstacksdk-functional-devstack failed with conflicts in test data. ","commit_id":"fa69b4c438276ea1f03782b77afce0c8a5814201"}],"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c9252fefba351d4c6095b1c4a908ed64d2e73b31","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            svc \u003d self.start_service(\u0027compute\u0027, host\u003dhostname)"},{"line_number":97,"context_line":"            svc.driver._host.get_connection \u003d lambda: fake_connection"},{"line_number":98,"context_line":"            return svc"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _setup_compute_service(self):"},{"line_number":101,"context_line":"        # NOTE(stephenfin): We don\u0027t start the compute service here as we wish"},{"line_number":102,"context_line":"        # to configure the host capabilities first. We instead start the"}],"source_content_type":"text/x-python","patch_set":5,"id":"77c6b166_bd6cb993","line":99,"updated":"2022-06-14 02:41:38.000000000","message":"I expected this to be an exact copy of something in later branches but didn\u0027t find anything just like it. This in ussuri is similar but doesn\u0027t have the HostInfo part: \n\nhttps://github.com/openstack/nova/blob/46d470fcd20fc685b837e1887677c87140e99d6b/nova/tests/functional/libvirt/base.py#L139\n\nIs there a reason it is different?","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9b0739fba100a3eab0fbac2fcb3863cd66817605","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            svc \u003d self.start_service(\u0027compute\u0027, host\u003dhostname)"},{"line_number":97,"context_line":"            svc.driver._host.get_connection \u003d lambda: fake_connection"},{"line_number":98,"context_line":"            return svc"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _setup_compute_service(self):"},{"line_number":101,"context_line":"        # NOTE(stephenfin): We don\u0027t start the compute service here as we wish"},{"line_number":102,"context_line":"        # to configure the host capabilities first. We instead start the"}],"source_content_type":"text/x-python","patch_set":5,"id":"60723559_28479d9d","line":99,"in_reply_to":"19a3131c_ee49a3a1","updated":"2022-06-15 17:15:40.000000000","message":"Perfect!","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d84e1b32464d3ba86ba7b52ae5210e4040efded6","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            svc \u003d self.start_service(\u0027compute\u0027, host\u003dhostname)"},{"line_number":97,"context_line":"            svc.driver._host.get_connection \u003d lambda: fake_connection"},{"line_number":98,"context_line":"            return svc"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _setup_compute_service(self):"},{"line_number":101,"context_line":"        # NOTE(stephenfin): We don\u0027t start the compute service here as we wish"},{"line_number":102,"context_line":"        # to configure the host capabilities first. We instead start the"}],"source_content_type":"text/x-python","patch_set":5,"id":"d58e05cb_19fd2c92","line":99,"in_reply_to":"315b1e22_bcfc0b7e","updated":"2022-06-15 00:18:00.000000000","message":"OK, I see now about the start_computes() being how it\u0027s done differently in ussuri. And here we don\u0027t need start_computes().","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"fa0de74e141f0797404fd28156dd4e561fb8ec0f","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            svc \u003d self.start_service(\u0027compute\u0027, host\u003dhostname)"},{"line_number":97,"context_line":"            svc.driver._host.get_connection \u003d lambda: fake_connection"},{"line_number":98,"context_line":"            return svc"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _setup_compute_service(self):"},{"line_number":101,"context_line":"        # NOTE(stephenfin): We don\u0027t start the compute service here as we wish"},{"line_number":102,"context_line":"        # to configure the host capabilities first. We instead start the"}],"source_content_type":"text/x-python","patch_set":5,"id":"315b1e22_bcfc0b7e","line":99,"in_reply_to":"77c6b166_bd6cb993","updated":"2022-06-14 16:15:01.000000000","message":"So this is essentially a from-scratch re-implementation of the helper, and the HostInfo is here because it\u0027s only needed for tests that use the libvirt driver (and fakelibvirt underneath). Compute tests that use the fake virt driver don\u0027t need this. The ussuri version kinda does have the default HostInfo part, because it\u0027s handled by the outer method (start_computes())","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"27d2c0d0d3c89eb36e614cd977a6175a9accd04c","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            svc \u003d self.start_service(\u0027compute\u0027, host\u003dhostname)"},{"line_number":97,"context_line":"            svc.driver._host.get_connection \u003d lambda: fake_connection"},{"line_number":98,"context_line":"            return svc"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _setup_compute_service(self):"},{"line_number":101,"context_line":"        # NOTE(stephenfin): We don\u0027t start the compute service here as we wish"},{"line_number":102,"context_line":"        # to configure the host capabilities first. We instead start the"}],"source_content_type":"text/x-python","patch_set":5,"id":"19a3131c_ee49a3a1","line":99,"in_reply_to":"d58e05cb_19fd2c92","updated":"2022-06-15 16:32:35.000000000","message":"So by pure coincidence, https://review.opendev.org/c/openstack/nova/+/751364 merged, so I can just rebase on top, and this will go away.","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"}],"nova/tests/functional/regressions/test_bug_1939545.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c9252fefba351d4c6095b1c4a908ed64d2e73b31","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        server[\u0027host\u0027] \u003d \u0027test_compute0\u0027"},{"line_number":85,"context_line":"        server[\u0027networks\u0027] \u003d \u0027none\u0027"},{"line_number":86,"context_line":"        self.server \u003d self.api.post_server({\u0027server\u0027: server})"},{"line_number":87,"context_line":"        self._wait_for_state_change(self.server, \u0027BUILD\u0027)"},{"line_number":88,"context_line":"        volume_id \u003d self.cinder.ISCSI_BACKED_VOL"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # TODO(lyarwood): As above, move this into the os-brick fixture."}],"source_content_type":"text/x-python","patch_set":5,"id":"5116e711_6620e547","line":87,"updated":"2022-06-14 02:41:38.000000000","message":"Note to self: I guess this is ServersTestBase._wait_for_state_change (rather than InstanceHelperMixin._wait_for_state_change) because ServersTestBase is the first base class in this class\u0027s definition.","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c9252fefba351d4c6095b1c4a908ed64d2e73b31","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        post \u003d {\u0027os-migrateLive\u0027: {\u0027host\u0027: None, \u0027block_migration\u0027: \u0027auto\u0027}}"},{"line_number":106,"context_line":"        self.api.post_server_action(self.server[\u0027id\u0027], post)"},{"line_number":107,"context_line":"        server \u003d self._wait_for_state_change(self.server, \u0027MIGRATING\u0027)"},{"line_number":108,"context_line":"        self.assertEqual(\u0027test_compute1\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # FIXME(lyarwood): This is bug #1939545, again get the volume bdm and"},{"line_number":111,"context_line":"        # assert that the saved connection_info doesn\u0027t contain device_path."}],"source_content_type":"text/x-python","patch_set":5,"id":"8605ef52_2a6ca714","line":108,"updated":"2022-06-14 02:41:38.000000000","message":"Note to self: this assert is needed because the server create did not specify which host to create the instance on.\n\nAlthough, the _live_migrate() method in \u003e\u003d ussuri doesn\u0027t verify the instance moved either, it checks for a completed migration. So I think the equivalent here would be self._wait_for_migration_status(server, [\u0027completed\u0027]). To be clear, I\u0027m not asking for this to be changed.","commit_id":"4e5c85bf627be41eeabe0cfe36a4344ca87ee89c"}]}