)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6d2a54f9be796fd822b9278a1e4a91da79a64511","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-31 19:35:56 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update nova to use black for code formating."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9ca46ee7942982c4fc7739affb5c98d1349b66d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"98293b16_d4f66080","line":8,"updated":"2022-06-01 08:34:43.000000000","message":"Probably we need some reasoning here to convince the rest of the cores to accept it.\n\nMy view:\nPros\n* no need to manually format code -\u003e less mental load on the developer\n* no need to review code formatting -\u003e less mental load on the reviewer\n* consistent style across the whole code base -\u003e easier to read and navigate code\n\nCons\n* when we merge this all the open reviews will go into merge conflict. It is a one time pain that can be fixed with: checkout patch, run black and commit, rebase patch, push for review\n* merge conflict on backport to stable branches. Possible solutions: a) do the blackification on stable brances too b) live with the pain\n* git blame will show Sean for almost everything. Solution is to add this commit to .git-blame-ignore-revs . That will work in git but we need to see if it works in other tools (gerrit, gitea) too.\n* devs and reviewers need to get used to reading the new style. I think this will be easy as the new style is pretty readable. (Note, you never need to write this style, black will do it for you)","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6101d575780bef063843dd05da0e6e0c4cbf08e9","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-31 19:35:56 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update nova to use black for code formating."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9ca46ee7942982c4fc7739affb5c98d1349b66d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0201fb4c_d2bc3073","line":8,"in_reply_to":"98293b16_d4f66080","updated":"2022-06-01 09:35:47.000000000","message":"on the backport topic just one other thing to note is that ignoring line-lenght which i am going to try reduicng in another patch to 79 black is actully psep8 compliant as can be seen by the fact ti can pass flake8. yes i had to disabel one or two checks but we have autopep8 on yoga so it should be able to fix those issue on backport to yoga automatically incloding possibel automatically reformating the code for the small line limit.\n\nso im hopeful that for backports if we dont add black to stable that autopep8 will do most of the work when backporting form zed to yoga or that this will be pretty minimal to do manually.","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1a2ef3596cf0c88efe63731ea44212c9e9f40947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9199acf_9c2c1fb1","updated":"2022-05-31 18:47:06.000000000","message":"I would like to live in an universe where nova is black :)\n","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"}],"tox.ini":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1a2ef3596cf0c88efe63731ea44212c9e9f40947","unresolved":true,"context_lines":[{"line_number":234,"context_line":"  Run style checks."},{"line_number":235,"context_line":"deps \u003d"},{"line_number":236,"context_line":"  {[testenv]deps}"},{"line_number":237,"context_line":"  black\u003d\u003d22.3.0"},{"line_number":238,"context_line":"extras \u003d"},{"line_number":239,"context_line":"commands \u003d"},{"line_number":240,"context_line":"  {[testenv:mypy]commands}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"a2ef2db8_70d0471d","line":237,"updated":"2022-05-31 18:47:06.000000000","message":"black is not used in this env","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2f4a717bc6149d27096c43a13482164313d1535","unresolved":true,"context_lines":[{"line_number":238,"context_line":"extras \u003d"},{"line_number":239,"context_line":"commands \u003d"},{"line_number":240,"context_line":"  {[testenv:mypy]commands}"},{"line_number":241,"context_line":"  black --check nova"},{"line_number":242,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":243,"context_line":"  # Check that all JSON files don\u0027t have \\r\\n in line."},{"line_number":244,"context_line":"  bash -c \"! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\\r\u0027\""}],"source_content_type":"text/x-properties","patch_set":1,"id":"a8d97ced_302a962b","line":241,"range":{"start_line":241,"start_character":2,"end_line":241,"end_character":20},"updated":"2022-05-31 18:53:24.000000000","message":"its used here.\n\nto ensure that no change would happen.\n\ne.g. this will check if black woudl change something and fail the pep8 tox env and therefor the pep8 job in the ci.\n\nthis way the ci will not change the code submited the author mus by running\ntox -e black","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1a2ef3596cf0c88efe63731ea44212c9e9f40947","unresolved":true,"context_lines":[{"line_number":259,"context_line":"usedevelop \u003d False"},{"line_number":260,"context_line":"deps \u003d"},{"line_number":261,"context_line":"  {[testenv]deps}"},{"line_number":262,"context_line":"  black\u003d\u003d22.3.0"},{"line_number":263,"context_line":"extras \u003d"},{"line_number":264,"context_line":"commands \u003d"},{"line_number":265,"context_line":"  black nova"}],"source_content_type":"text/x-properties","patch_set":1,"id":"320f84ac_d9f725ba","line":262,"updated":"2022-05-31 18:47:06.000000000","message":"I would move this to the global reqs, upper-constraints and test-requirement.txt eventually","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2f4a717bc6149d27096c43a13482164313d1535","unresolved":true,"context_lines":[{"line_number":259,"context_line":"usedevelop \u003d False"},{"line_number":260,"context_line":"deps \u003d"},{"line_number":261,"context_line":"  {[testenv]deps}"},{"line_number":262,"context_line":"  black\u003d\u003d22.3.0"},{"line_number":263,"context_line":"extras \u003d"},{"line_number":264,"context_line":"commands \u003d"},{"line_number":265,"context_line":"  black nova"}],"source_content_type":"text/x-properties","patch_set":1,"id":"11549428_9e5e7e11","line":262,"in_reply_to":"320f84ac_d9f725ba","updated":"2022-05-31 18:53:24.000000000","message":"yes we could","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1a2ef3596cf0c88efe63731ea44212c9e9f40947","unresolved":true,"context_lines":[{"line_number":293,"context_line":"max-complexity \u003d 40"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"}],"source_content_type":"text/x-properties","patch_set":1,"id":"cd3cc402_aae3084e","line":296,"updated":"2022-05-31 18:47:06.000000000","message":"If it is not extremely hard I would keep 79","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56aa4db2338161b6ca2bfe693cd62bbe0cc1f61a","unresolved":true,"context_lines":[{"line_number":293,"context_line":"max-complexity \u003d 40"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"}],"source_content_type":"text/x-properties","patch_set":1,"id":"c5e2e495_83a79095","line":296,"in_reply_to":"5fbbb8c7_1efa0d86","updated":"2022-06-01 08:27:51.000000000","message":"To be honest I think this should be done now. If we\u0027re doing big bang changes, it should really be a big bang change (i.e. done in one go)","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6d2a54f9be796fd822b9278a1e4a91da79a64511","unresolved":true,"context_lines":[{"line_number":293,"context_line":"max-complexity \u003d 40"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"}],"source_content_type":"text/x-properties","patch_set":1,"id":"c664d19c_183102de","line":296,"in_reply_to":"5fbbb8c7_1efa0d86","updated":"2022-06-01 08:34:43.000000000","message":"cool","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6101d575780bef063843dd05da0e6e0c4cbf08e9","unresolved":true,"context_lines":[{"line_number":293,"context_line":"max-complexity \u003d 40"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"}],"source_content_type":"text/x-properties","patch_set":1,"id":"a06e692e_1d2daa3f","line":296,"in_reply_to":"c664d19c_183102de","updated":"2022-06-01 09:35:47.000000000","message":"ill try updating it to to 79 but the reason i was going to do this in a second patch and then squah if we decied we need/wanted to keep 79 is i will need to use project.toml to set that propertly.\n\ni can hack around it and pass it on the commandline to black in the tox env but it would be nicer to do it with project.toml since it woudl work for people with ides too then.","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1b434eae506dd2fecfdeea61e94b244c4a76f235","unresolved":true,"context_lines":[{"line_number":293,"context_line":"max-complexity \u003d 40"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5fbbb8c7_1efa0d86","line":296,"in_reply_to":"cd3cc402_aae3084e","updated":"2022-05-31 18:54:56.000000000","message":"i will try that in a followup patch. and we can squash the two if we prefer that i just wanted to push what i had first.","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"56aa4db2338161b6ca2bfe693cd62bbe0cc1f61a","unresolved":true,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"4cc5d062_d63224e5","line":297,"updated":"2022-06-01 08:27:51.000000000","message":"Can you call out why these are needed. I don\u0027t think you\u0027ll need W503 here for one.","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"fb44f8ab8cde278d371f10a09f091aaf942df538","unresolved":true,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"f609c518_087f4c97","line":297,"in_reply_to":"48bba74c_5d7736ad","updated":"2022-07-15 15:49:16.000000000","message":"I\u0027d advocate to ditch pycodestyle completely, and use flake8/pyflakes only for code smells (unused imports/variables, undeclared variables etc \u003d\u003d F* error codes) and leave all the code formatting exclusively to black.\n\nso that your tox.ini would be smth like\n  \n  [pep8]\n  commands \u003d\n      flake8 ..\n      black --check --diff ..\n  [flake8]\n  extend-ignore \u003d E,W\n\nThis way new versions of flake8/pycodestyle and black won\u0027t be conflicting with each other in the future.","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6101d575780bef063843dd05da0e6e0c4cbf08e9","unresolved":true,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# compatibility with black"},{"line_number":296,"context_line":"max-line-length \u003d 88"},{"line_number":297,"context_line":"extend-ignore \u003d E203,W503,H301,H401"},{"line_number":298,"context_line":"[hacking]"},{"line_number":299,"context_line":"import_exceptions \u003d typing,nova.i18n"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"48bba74c_5d7736ad","line":297,"in_reply_to":"4cc5d062_d63224e5","updated":"2022-06-01 09:35:47.000000000","message":"sure ill have to look up the two hacking ones specifcaly again but\nE203,W503 come from blacks docs for flake8\n\nhttps://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8\n\nE203: \n\"\"\"In some cases, as determined by PEP 8, Black will enforce an equal amount of whitespace around slice operators. Due to this, Flake8 will raise E203 whitespace before \u0027:\u0027 warnings. Since this warning is not PEP 8 compliant, Flake8 should be configured to ignore it via extend-ignore \u003d E203.\"\"\"\"\n\nW503:\n\"\"\"\nWhen breaking a line, Black will break it before a binary operator. This is compliant with PEP 8 as of April 2016. There’s a disabled-by-default warning in Flake8 which goes against this PEP 8 recommendation called W503 line break before binary operator. It should not be enabled in your \n\"\"\"\n\nin openstack we chose to break after the binary operator which is why we supress w504 already. apprently we had two choices and chosse the wrong one.\n\n\ni belive H301 or H401 was becasue it miss recognised the way black formated imports as multiple imports per line. that is not actully what black was doing \n\nthis is an example \nhttps://review.opendev.org/c/openstack/nova/+/844120/1/nova/api/openstack/compute/instance_actions.py#22\nfrom nova.api.openstack.compute.schemas import (\n    instance_actions as schema_instance_actions,\n)\n\nthats actully just one import but i think the addtion of the , i miss matching.\n\ni might be able to just removce that and  black might not add it back.\n\ni cant recal what the other one was off the top of my head but it was a similar issue witht he hacking check giving a false positive. since it did not come form the intree ones i chose to ignore it since it was asserting somethign that was not managed by black and as a result the check was not useful.","commit_id":"d97dcd89e2079abd579c24b7795da4b3ab79d2a5"}]}