)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e46c260c8e25688dac302b650b050e6677fa7e6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Stupnikov \u003caleksey.stupnikov@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-02 17:32:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Optimize _local_delete calls by compute unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"_fake_do_delete function from nova/tests/unit/compute/test_api.py is"},{"line_number":10,"context_line":"called with reservations\u003dNone argument. This argument is no longer used"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6ec30a65_12952309","line":7,"updated":"2022-07-12 09:22:45.000000000","message":"I guess I don\u0027t think this really optimises anything except perhaps Lins of code","commit_id":"f55144780441c37310174b20afd4cf3b8efdae04"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8a8ac55c383186de970e7b67d77aebe870727f1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00554b4c_4736253b","updated":"2022-06-02 15:37:44.000000000","message":"Thanks! LGTM","commit_id":"f55144780441c37310174b20afd4cf3b8efdae04"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e46c260c8e25688dac302b650b050e6677fa7e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fbc8ba88_72e60a94","updated":"2022-07-12 09:22:45.000000000","message":"this is not harmful but I don\u0027t think it actually fixes anything either so I\u0027m kind of meh on this patch overall. but since it should not break anything and Melanie seems ok with it +2w","commit_id":"f55144780441c37310174b20afd4cf3b8efdae04"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9a58e5b727e763c0703d7d3af579e32748760e63","unresolved":true,"context_lines":[{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"        self.compute_api._local_delete(self.context, inst, bdms,"},{"line_number":1381,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1382,"context_line":"                                       self._fake_do_delete)"},{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":"        mock_notify_legacy.assert_has_calls(["},{"line_number":1385,"context_line":"            mock.call(self.compute_api.notifier, self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7529388c_1f5c8ddc","line":1382,"updated":"2022-06-02 11:48:52.000000000","message":"I mean at this point just replace the fake one with `lambda *args, **kwargs: True`, it\u0027s not like the fake method does anything useful or asserts any calls...","commit_id":"e16bddbb69dba0154a30844597c674e213183442"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"24192f949da64f6a9368d054c68fc7489fe34e0e","unresolved":false,"context_lines":[{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"        self.compute_api._local_delete(self.context, inst, bdms,"},{"line_number":1381,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1382,"context_line":"                                       self._fake_do_delete)"},{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":"        mock_notify_legacy.assert_has_calls(["},{"line_number":1385,"context_line":"            mock.call(self.compute_api.notifier, self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ee6bb3a7_921d07dd","line":1382,"in_reply_to":"7529388c_1f5c8ddc","updated":"2022-06-02 13:42:12.000000000","message":"Done","commit_id":"e16bddbb69dba0154a30844597c674e213183442"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"78cd7044f49d1fc05b4b94a96ba9bb2603df884b","unresolved":true,"context_lines":[{"line_number":1378,"context_line":"        # called by compute_api._local_delete"},{"line_number":1379,"context_line":"        self.compute_api._local_delete(self.context, inst, bdms,"},{"line_number":1380,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1381,"context_line":"                                       lambda *args, **kwargs: True)"},{"line_number":1382,"context_line":""},{"line_number":1383,"context_line":"        mock_notify_legacy.assert_has_calls(["},{"line_number":1384,"context_line":"            mock.call(self.compute_api.notifier, self.context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a615c679_dac2b6e0","line":1381,"range":{"start_line":1381,"start_character":63,"end_line":1381,"end_character":67},"updated":"2022-06-02 15:06:05.000000000","message":"FYI technically this isn\u0027t equivalent to the method being replaced -- should be None instead (when methods don\u0027t return anything they, by default, return None).","commit_id":"981e8ce254674ce4678113b08a6228a167b1e818"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"01cfb9ed0c860691e47f11e2116c0d2398f90db5","unresolved":false,"context_lines":[{"line_number":1378,"context_line":"        # called by compute_api._local_delete"},{"line_number":1379,"context_line":"        self.compute_api._local_delete(self.context, inst, bdms,"},{"line_number":1380,"context_line":"                                       \u0027delete\u0027,"},{"line_number":1381,"context_line":"                                       lambda *args, **kwargs: True)"},{"line_number":1382,"context_line":""},{"line_number":1383,"context_line":"        mock_notify_legacy.assert_has_calls(["},{"line_number":1384,"context_line":"            mock.call(self.compute_api.notifier, self.context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a455641_7b185a95","line":1381,"range":{"start_line":1381,"start_character":63,"end_line":1381,"end_character":67},"in_reply_to":"a615c679_dac2b6e0","updated":"2022-06-02 15:33:57.000000000","message":"Thank you very much for pointing this out. I thought about this, but skipped investigating options.","commit_id":"981e8ce254674ce4678113b08a6228a167b1e818"}]}