)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"3610cb262ce66c2f2c10903cf768e42fe3aed68c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: treat cases when SOAP reply does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are cases when the SOAP reply does not return a body (for"},{"line_number":10,"context_line":"example UnregisterVM may return this when running the CI)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch ensures that an exception is not thrown."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad9bd40_54855cab","line":10,"updated":"2014-05-05 08:58:17.000000000","message":"This does not sound like an accurate description to me. \n\nIIUC the bug trace correctly - the client sends the malformed request on some occasions (when sudsobject.Property returns None?! I am not even sure how that can happen looking at the code).\n\nAssuming that this fix is correct (and I am not entirely sure it is TBH) this message needs to be updates.\n\nAlso - I wonder how does it work with the sync between oslo and nova when it comes to vmware as the bug suggests the fix is alredy in oslo...","commit_id":"5cf8dc531667d240a5e6e25154408a7222cd0912"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"55090a3e4aaecbf8b2f75177b7374cb68277bba8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: treat cases when SOAP reply does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are cases when the SOAP reply does not return a body (for"},{"line_number":10,"context_line":"example UnregisterVM may return this when running the CI)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch ensures that an exception is not thrown."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad9bd40_5fcad56e","line":10,"in_reply_to":"9ad9bd40_54855cab","updated":"2014-05-05 13:57:56.000000000","message":"i\u0027ll update following what we spoke about on irc.\nin addition to this i will log the input so that we can be sure","commit_id":"5cf8dc531667d240a5e6e25154408a7222cd0912"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"42a1626d507d405bdb0107b7fb62087d3400e89c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-04 08:33:18 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: treat cases when SOAP request does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Attempting to delete a instance that does not exist on the backend"},{"line_number":10,"context_line":"throws and exception (for example UnregisterVM may return this when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_c55c091c","line":7,"updated":"2014-06-05 07:15:29.000000000","message":"I think you need to update the first line to reflect your latest changes","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"932ad069c6fe61d574b13a69dcfe037b7b159393","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-04 08:33:18 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: treat cases when SOAP request does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Attempting to delete a instance that does not exist on the backend"},{"line_number":10,"context_line":"throws and exception (for example UnregisterVM may return this when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_357a3624","line":7,"in_reply_to":"1ae5cdf2_c55c091c","updated":"2014-06-05 10:04:39.000000000","message":"Done","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"42a1626d507d405bdb0107b7fb62087d3400e89c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: treat cases when SOAP request does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Attempting to delete a instance that does not exist on the backend"},{"line_number":10,"context_line":"throws and exception (for example UnregisterVM may return this when"},{"line_number":11,"context_line":"running the CI)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_6544154a","line":9,"updated":"2014-06-05 07:15:29.000000000","message":"typo: an instance","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"932ad069c6fe61d574b13a69dcfe037b7b159393","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: treat cases when SOAP request does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Attempting to delete a instance that does not exist on the backend"},{"line_number":10,"context_line":"throws and exception (for example UnregisterVM may return this when"},{"line_number":11,"context_line":"running the CI)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_55750230","line":9,"in_reply_to":"1ae5cdf2_6544154a","updated":"2014-06-05 10:04:39.000000000","message":"Done","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"42a1626d507d405bdb0107b7fb62087d3400e89c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: treat cases when SOAP request does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Attempting to delete a instance that does not exist on the backend"},{"line_number":10,"context_line":"throws and exception (for example UnregisterVM may return this when"},{"line_number":11,"context_line":"running the CI)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1b95caec2dad6580db576aa6f80f47913b7c066e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_c545e943","line":10,"updated":"2014-06-05 07:15:29.000000000","message":"typo: an exception","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"932ad069c6fe61d574b13a69dcfe037b7b159393","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: treat cases when SOAP request does not have a body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Attempting to delete a instance that does not exist on the backend"},{"line_number":10,"context_line":"throws and exception (for example UnregisterVM may return this when"},{"line_number":11,"context_line":"running the CI)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1b95caec2dad6580db576aa6f80f47913b7c066e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_75703e40","line":10,"in_reply_to":"1ae5cdf2_c545e943","updated":"2014-06-05 10:04:39.000000000","message":"Done","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"}],"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"42a1626d507d405bdb0107b7fb62087d3400e89c","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"    def test_destroy_instance_without_vm_ref(self):"},{"line_number":1402,"context_line":"        with mock.patch.object(self.conn._session,"},{"line_number":1403,"context_line":"                               \u0027_call_method\u0027) as mock_call:"},{"line_number":1404,"context_line":"            self.conn.destroy(self.context, self.instance_without_compute,"},{"line_number":1405,"context_line":"                              self.network_info,"},{"line_number":1406,"context_line":"                              None, True)"},{"line_number":1407,"context_line":"            self.assertFalse(mock_call.called)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_653df5c3","line":1404,"updated":"2014-06-05 07:15:29.000000000","message":"with instance_without_compute you won\u0027t call vmops.destroy() in the first place","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"932ad069c6fe61d574b13a69dcfe037b7b159393","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"    def test_destroy_instance_without_vm_ref(self):"},{"line_number":1402,"context_line":"        with mock.patch.object(self.conn._session,"},{"line_number":1403,"context_line":"                               \u0027_call_method\u0027) as mock_call:"},{"line_number":1404,"context_line":"            self.conn.destroy(self.context, self.instance_without_compute,"},{"line_number":1405,"context_line":"                              self.network_info,"},{"line_number":1406,"context_line":"                              None, True)"},{"line_number":1407,"context_line":"            self.assertFalse(mock_call.called)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_157ffa15","line":1404,"in_reply_to":"1ae5cdf2_653df5c3","updated":"2014-06-05 10:04:39.000000000","message":"the self.instance_without_compute creates a nova instance but not an instance on the backend. this is ok here","commit_id":"46e826f38e87d133a9bbda428399be9ba1353472"}],"nova/tests/virt/vmwareapi/test_vim.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"767c802f21e0aa9e4d9143626a6cde3dbb608d97","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        super(VimTest, self).setUp()"},{"line_number":31,"context_line":"        patcher \u003d mock.patch(\u0027suds.client.Client\u0027)"},{"line_number":32,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":33,"context_line":"        self.SudsClientMock \u003d patcher.start()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch.object(vim.Vim, \u0027_request_managed_object_builder\u0027,"},{"line_number":36,"context_line":"                       return_value\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9yrY%3D","line":33,"updated":"2014-04-02 05:26:02.000000000","message":"I don\u0027t see self.SudsClientMock used anywhere. Would be just easier to do @mock.patch(\u0027suds.client.Client\u0027) on the test_vim_request() method below, yes?","commit_id":"95506f4b257099f18df611082ffbde3e81bd9bed"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"36854f4bc23c9b42001a92d84ace19762fe7bb7a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        super(VimTest, self).setUp()"},{"line_number":31,"context_line":"        patcher \u003d mock.patch(\u0027suds.client.Client\u0027)"},{"line_number":32,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":33,"context_line":"        self.SudsClientMock \u003d patcher.start()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch.object(vim.Vim, \u0027_request_managed_object_builder\u0027,"},{"line_number":36,"context_line":"                       return_value\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9x1w%3D","line":33,"in_reply_to":"AAAAWH%2F9yrY%3D","updated":"2014-05-04 06:31:54.000000000","message":"Done","commit_id":"95506f4b257099f18df611082ffbde3e81bd9bed"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"025efefc5a16502069a3c4160b352e5bdf867d19","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @mock.patch(\u0027suds.client.Client\u0027)"},{"line_number":30,"context_line":"    @mock.patch.object(vim.Vim, \u0027_request_managed_object_builder\u0027,"},{"line_number":31,"context_line":"                       return_value\u003dNone)"},{"line_number":32,"context_line":"    def test_vim_request_handler(self, mock_suds_client, mock_mo):"},{"line_number":33,"context_line":"        managed_object \u003d \u0027VirtualMachine\u0027"},{"line_number":34,"context_line":"        vim_obj \u003d vim.Vim()"},{"line_number":35,"context_line":"        attr_name \u003d \u0027UnregisterVM\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_be7223e1","line":32,"updated":"2014-05-02 20:52:02.000000000","message":"Is mock_suds_client and mock_mo backwards?  Should it be\n    def test_vim_request_handler(self, mock_mo, mock_suds_client):\nsince @mock.patch(\u0027suds.client.Client\u0027) is the outermost decorator?","commit_id":"f3a95c883309005cba2b2ef8b9c553269bb4d26c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e9b72bfb4c404485df2b8585dd4d1183228a6a01","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @mock.patch(\u0027suds.client.Client\u0027)"},{"line_number":30,"context_line":"    @mock.patch.object(vim.Vim, \u0027_request_managed_object_builder\u0027,"},{"line_number":31,"context_line":"                       return_value\u003dNone)"},{"line_number":32,"context_line":"    def test_vim_request_handler(self, mock_suds_client, mock_mo):"},{"line_number":33,"context_line":"        managed_object \u003d \u0027VirtualMachine\u0027"},{"line_number":34,"context_line":"        vim_obj \u003d vim.Vim()"},{"line_number":35,"context_line":"        attr_name \u003d \u0027UnregisterVM\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_79b18b8e","line":32,"in_reply_to":"9ad9bd40_be7223e1","updated":"2014-05-04 06:31:33.000000000","message":"Yes, you are correct. Thanks!","commit_id":"f3a95c883309005cba2b2ef8b9c553269bb4d26c"}],"nova/virt/vmwareapi/vim.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"220f25c59896573bca6b28b391adc98121229271","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                             managed_object)"},{"line_number":175,"context_line":"                if request_mo is None:"},{"line_number":176,"context_line":"                    LOG.error(_(\u0027Unable to get managed object for %s\u0027),"},{"line_number":177,"context_line":"                              managed_object)"},{"line_number":178,"context_line":"                    return"},{"line_number":179,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":180,"context_line":"                response \u003d request(request_mo, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_42caf96e","line":177,"updated":"2014-05-05 13:08:14.000000000","message":"If UnregisterVM is not supposed to return a body, do we really want to log an error if that is an expected behaviour?","commit_id":"b33e9a6fa3d06c7a88d410b7ce2d4c0fa6702665"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"17d4e6dcf9c98373354ad09b0ef5601d02b12ee3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                             managed_object)"},{"line_number":175,"context_line":"                if request_mo is None:"},{"line_number":176,"context_line":"                    LOG.error(_(\u0027Unable to get managed object for %s\u0027),"},{"line_number":177,"context_line":"                              managed_object)"},{"line_number":178,"context_line":"                    return"},{"line_number":179,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":180,"context_line":"                response \u003d request(request_mo, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_9800ee02","line":177,"in_reply_to":"9ad9bd40_42caf96e","updated":"2014-05-05 13:58:58.000000000","message":"i will remove this, in the repvious review we just wanted to validate something. once the CI results are up i\u0027ll drop this","commit_id":"b33e9a6fa3d06c7a88d410b7ce2d4c0fa6702665"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c041a28dc31aedd45cadb1018c54f983ef130d52","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            try:"},{"line_number":170,"context_line":"                request_mo \u003d self._request_managed_object_builder("},{"line_number":171,"context_line":"                             managed_object)"},{"line_number":172,"context_line":"                if request_mo is None:"},{"line_number":173,"context_line":"                    return"},{"line_number":174,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":175,"context_line":"                response \u003d request(request_mo, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad9bd40_cab7e438","line":172,"updated":"2014-05-06 09:38:51.000000000","message":"I am not sure I like the idea of just having None returned.\n\nReally - this bug means that managed_object passed in here is invalid - why not deal with that properly when it happens instead of just swallowing it here.\n\nAlso - big concerns about syncing this code with oslo :( - we should fix these concerns there first (we swallow the obvious issue there as well)","commit_id":"4deece477c7fc5958173c4b838cdfd4c4ce6ca6b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"14345eaa8aed8f1e55e467d7fcd7a01530624992","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            try:"},{"line_number":170,"context_line":"                request_mo \u003d self._request_managed_object_builder("},{"line_number":171,"context_line":"                             managed_object)"},{"line_number":172,"context_line":"                if request_mo is None:"},{"line_number":173,"context_line":"                    return"},{"line_number":174,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":175,"context_line":"                response \u003d request(request_mo, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_7930c79e","line":172,"in_reply_to":"9ad9bd40_cab7e438","updated":"2014-06-01 12:39:48.000000000","message":"i have addressed your concerns. i have found the source of the issue","commit_id":"4deece477c7fc5958173c4b838cdfd4c4ce6ca6b"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"88041e87df61c229e53c6adea82930b240fad600","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            try:"},{"line_number":174,"context_line":"                request_mo \u003d self._request_managed_object_builder("},{"line_number":175,"context_line":"                             managed_object)"},{"line_number":176,"context_line":"                if request_mo is None:"},{"line_number":177,"context_line":"                    return"},{"line_number":178,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":179,"context_line":"                response \u003d request(request_mo, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_dd55da1e","line":176,"updated":"2014-06-04 14:11:02.000000000","message":"do we need to revert this change as you found the root cause in vmops.py?","commit_id":"c74874792fbd4bb4a3c7a2d95d435c13daa84e34"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f884b6223920ae4f71fe0736e3be9e1f5a5610c6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            try:"},{"line_number":174,"context_line":"                request_mo \u003d self._request_managed_object_builder("},{"line_number":175,"context_line":"                             managed_object)"},{"line_number":176,"context_line":"                if request_mo is None:"},{"line_number":177,"context_line":"                    return"},{"line_number":178,"context_line":"                request \u003d getattr(self.client.service, attr_name)"},{"line_number":179,"context_line":"                response \u003d request(request_mo, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_ca426d67","line":176,"in_reply_to":"1ae5cdf2_dd55da1e","updated":"2014-06-04 15:37:26.000000000","message":"yes, i can drop this.","commit_id":"c74874792fbd4bb4a3c7a2d95d435c13daa84e34"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"88041e87df61c229e53c6adea82930b240fad600","unresolved":false,"context_lines":[{"line_number":865,"context_line":"        try:"},{"line_number":866,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session, instance_name)"},{"line_number":867,"context_line":"            if not vm_ref:"},{"line_number":868,"context_line":"                LOG.debug(\u0027Instance does not exist\u0027)"},{"line_number":869,"context_line":"                return"},{"line_number":870,"context_line":"            lst_properties \u003d [\"config.files.vmPathName\", \"runtime.powerState\","},{"line_number":871,"context_line":"                              \"datastore\"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_1d9742ed","line":868,"updated":"2014-06-04 14:11:02.000000000","message":"log the instance name","commit_id":"c74874792fbd4bb4a3c7a2d95d435c13daa84e34"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f884b6223920ae4f71fe0736e3be9e1f5a5610c6","unresolved":false,"context_lines":[{"line_number":865,"context_line":"        try:"},{"line_number":866,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session, instance_name)"},{"line_number":867,"context_line":"            if not vm_ref:"},{"line_number":868,"context_line":"                LOG.debug(\u0027Instance does not exist\u0027)"},{"line_number":869,"context_line":"                return"},{"line_number":870,"context_line":"            lst_properties \u003d [\"config.files.vmPathName\", \"runtime.powerState\","},{"line_number":871,"context_line":"                              \"datastore\"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_0a60d5ff","line":868,"in_reply_to":"1ae5cdf2_1d9742ed","updated":"2014-06-04 15:37:26.000000000","message":"Done","commit_id":"c74874792fbd4bb4a3c7a2d95d435c13daa84e34"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"8f148eddb9d218b7f16669e6decaf6b46591b3c8","unresolved":false,"context_lines":[{"line_number":865,"context_line":"        try:"},{"line_number":866,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session, instance_name)"},{"line_number":867,"context_line":"            if not vm_ref:"},{"line_number":868,"context_line":"                LOG.debug(\u0027Instance does not exist on backend\u0027,"},{"line_number":869,"context_line":"                          instance\u003dinstance)"},{"line_number":870,"context_line":"                return"},{"line_number":871,"context_line":"            lst_properties \u003d [\"config.files.vmPathName\", \"runtime.powerState\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_dbfdc16f","line":868,"updated":"2014-06-05 11:16:40.000000000","message":"A comment about the LOG.\nSince someone asked to remove a VM that does not exist, it makes sense to use \u0027warning\u0027 and not \u0027debug\u0027","commit_id":"7df4be3f3af48b19dfec21fb085c0b5e2aef8764"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d14e782143ef4e7bc8fc74ce14e95ec712d9bab9","unresolved":false,"context_lines":[{"line_number":865,"context_line":"        try:"},{"line_number":866,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session, instance_name)"},{"line_number":867,"context_line":"            if not vm_ref:"},{"line_number":868,"context_line":"                LOG.debug(\u0027Instance does not exist on backend\u0027,"},{"line_number":869,"context_line":"                          instance\u003dinstance)"},{"line_number":870,"context_line":"                return"},{"line_number":871,"context_line":"            lst_properties \u003d [\"config.files.vmPathName\", \"runtime.powerState\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_1238e33b","line":868,"in_reply_to":"1ae5cdf2_dbfdc16f","updated":"2014-06-05 16:01:58.000000000","message":"Done","commit_id":"7df4be3f3af48b19dfec21fb085c0b5e2aef8764"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"b69ee694e5c257939ae2e0e67e9b6a38eac87ec2","unresolved":false,"context_lines":[{"line_number":864,"context_line":"            instance_name \u003d instance[\u0027uuid\u0027]"},{"line_number":865,"context_line":"        try:"},{"line_number":866,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session, instance_name)"},{"line_number":867,"context_line":"            if not vm_ref:"},{"line_number":868,"context_line":"                LOG.warning(_(\u0027Instance does not exist on backend\u0027),"},{"line_number":869,"context_line":"                            instance\u003dinstance)"},{"line_number":870,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_4ed08c53","line":867,"updated":"2014-06-10 09:17:25.000000000","message":"If vm_ref is None ;)","commit_id":"a95a2bfa4894178a5fa090bda095d6483ff88f9d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcc131c195185de7bc2fd0f0fc170e29cb3c05c2","unresolved":false,"context_lines":[{"line_number":864,"context_line":"            instance_name \u003d instance[\u0027uuid\u0027]"},{"line_number":865,"context_line":"        try:"},{"line_number":866,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session, instance_name)"},{"line_number":867,"context_line":"            if not vm_ref:"},{"line_number":868,"context_line":"                LOG.warning(_(\u0027Instance does not exist on backend\u0027),"},{"line_number":869,"context_line":"                            instance\u003dinstance)"},{"line_number":870,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_ae859008","line":867,"in_reply_to":"1ae5cdf2_4ed08c53","updated":"2014-06-10 09:26:39.000000000","message":"Done","commit_id":"a95a2bfa4894178a5fa090bda095d6483ff88f9d"}]}