)]}'
{"nova/pci/devspec.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"443971bffc0940ae3eb41e0b34fa598405771514","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    _every match() call_. So if the devname not exists at __init__ it is not"},{"line_number":277,"context_line":"    an error. If the devname not exists at match() then this spec will not"},{"line_number":278,"context_line":"    match to any device. This is done by not storing self.address but"},{"line_number":279,"context_line":"    recalculating it for each match."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    If the PCI device is defined via PCI address (with or without wildcard)"},{"line_number":282,"context_line":"    the address is parsed only once and stored in self.address"}],"source_content_type":"text/x-python","patch_set":3,"id":"122167e5_93065445","line":279,"updated":"2022-07-12 08:43:54.000000000","message":"I was not aware of this additional performance hit and extra failure mode for devname. this is another reason to be glad we are removing it","commit_id":"2fa2825afb4b856fc2dd0274f88db9d8820abc49"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c02342e8ea7b084dfc5b5e10e81aceacf553f065","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    _every match() call_. So if the devname not exists at __init__ it is not"},{"line_number":277,"context_line":"    an error. If the devname not exists at match() then this spec will not"},{"line_number":278,"context_line":"    match to any device. This is done by not storing self.address but"},{"line_number":279,"context_line":"    recalculating it for each match."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    If the PCI device is defined via PCI address (with or without wildcard)"},{"line_number":282,"context_line":"    the address is parsed only once and stored in self.address"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a363956_3c4632c1","line":279,"in_reply_to":"122167e5_93065445","updated":"2022-07-25 16:12:21.000000000","message":"Ack","commit_id":"2fa2825afb4b856fc2dd0274f88db9d8820abc49"}],"nova/tests/unit/pci/test_whitelist.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a4d8f197d4e268b86b31165b3fbbbf7b1b4e24d4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                    (\"0000:00:0a.1\", False),"},{"line_number":122,"context_line":"                    (\"0000:00:0a.1\", False),"},{"line_number":123,"context_line":"                ],"},{"line_number":124,"context_line":"            ) as mock_pci_address_by_ifname,"},{"line_number":125,"context_line":"            mock.patch("},{"line_number":126,"context_line":"                \"nova.pci.utils.is_physical_function\", return_value\u003dFalse"},{"line_number":127,"context_line":"            ) as mock_is_phy_func,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3b4af7_43110ab1","line":124,"in_reply_to":"ca163e30_9ebb9b0e","updated":"2022-06-14 14:49:40.000000000","message":"\u003e pep8: E999 SyntaxError: invalid syntax\n\nCan we drop py38 support? ;) (The above syntax works in py39 and newer)\n\nDowngraded my syntax to support py38 for now","commit_id":"940d584fa8d56644eba3922c6d759a11b79d7769"}]}