)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"c47183452623c300f5a926d5b115d484a1f06676","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the exception message for duplicate pgpu addresses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When config one vgpu type and multiple pgpu pci addresses, nova-compute rasie"},{"line_number":10,"context_line":"the excpetion message is: duplicate types for PCI ID 0000:85:00.0, i would"},{"line_number":11,"context_line":"like the exception message is: duplicate PCI ID for vgpu type nvidia-181."},{"line_number":12,"context_line":"      [devices]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"87f42595_0eb82037","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":77},"updated":"2022-06-08 10:53:04.000000000","message":"typo","commit_id":"511a4870217b08bba951dc9795ad95acddfaf18b"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"c47183452623c300f5a926d5b115d484a1f06676","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix the exception message for duplicate pgpu addresses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When config one vgpu type and multiple pgpu pci addresses, nova-compute rasie"},{"line_number":10,"context_line":"the excpetion message is: duplicate types for PCI ID 0000:85:00.0, i would"},{"line_number":11,"context_line":"like the exception message is: duplicate PCI ID for vgpu type nvidia-181."},{"line_number":12,"context_line":"      [devices]"},{"line_number":13,"context_line":"      enabled_mdev_types \u003d nvidia-181"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"99f8e176_29638e01","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":13},"updated":"2022-06-08 10:53:04.000000000","message":"typo","commit_id":"511a4870217b08bba951dc9795ad95acddfaf18b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a929e4f035cc6c4665015b0394f848b8f0ef6e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47ca4e34_93ea27fe","updated":"2022-06-05 02:34:39.000000000","message":"Good catch, this code missed UT about the exception scenario.","commit_id":"511a4870217b08bba951dc9795ad95acddfaf18b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"35568ee2469134a1069382b33406a0cd7fadbefe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f6f3342_c50104d1","updated":"2022-06-09 10:18:44.000000000","message":"I\u0027m afraid of the fact this modification would be less explaining the issue.","commit_id":"a4bfff0ce9efdf5744dd95a43799be0afe4faef7"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"c47183452623c300f5a926d5b115d484a1f06676","unresolved":true,"context_lines":[{"line_number":25708,"context_line":"                          drvr.mdev_class_mapping)"},{"line_number":25709,"context_line":"        self.assertEqual({orc.VGPU, \u0027CUSTOM_NOTVGPU\u0027}, drvr.mdev_classes)"},{"line_number":25710,"context_line":"        mock_warning.assert_not_called()"},{"line_number":25711,"context_line":""},{"line_number":25712,"context_line":"        # One type and multi pGPU addresses will raise duplicate PCI ID"},{"line_number":25713,"context_line":"        # exception"},{"line_number":25714,"context_line":"        self.flags(device_addresses\u003d[\u00270000:84:00.0\u0027], group\u003d\u0027mdev_nvidia-11\u0027)"},{"line_number":25715,"context_line":"        self.flags(device_addresses\u003d[\u00270000:85:00.0\u0027], group\u003d\u0027mdev_nvidia-11\u0027)"},{"line_number":25716,"context_line":"        self.assertRaises(exception.InvalidLibvirtMdevConfig,"},{"line_number":25717,"context_line":"                          libvirt_driver.LibvirtDriver,"},{"line_number":25718,"context_line":"                          fake.FakeVirtAPI(), False)"},{"line_number":25719,"context_line":""},{"line_number":25720,"context_line":"    def test_get_supported_vgpu_types_with_duplicate_types(self):"},{"line_number":25721,"context_line":"        self.flags(enabled_mdev_types\u003d[\u0027nvidia-11\u0027, \u0027nvidia-12\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d6af9ef_63c8200a","line":25718,"range":{"start_line":25711,"start_character":0,"end_line":25718,"end_character":52},"updated":"2022-06-08 10:53:04.000000000","message":"I think that it would be better to introduce different group name to avoid possible interference with previous checks.","commit_id":"511a4870217b08bba951dc9795ad95acddfaf18b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"35568ee2469134a1069382b33406a0cd7fadbefe","unresolved":true,"context_lines":[{"line_number":25714,"context_line":"        # exception"},{"line_number":25715,"context_line":"        self.flags(enabled_mdev_types\u003d[\u0027nvidia-11\u0027], group\u003d\u0027devices\u0027)"},{"line_number":25716,"context_line":"        nova.conf.devices.register_dynamic_opts(CONF)"},{"line_number":25717,"context_line":"        self.flags(device_addresses\u003d[\u00270000:84:00.0\u0027, \u00270000:84:00.0\u0027],"},{"line_number":25718,"context_line":"            group\u003d\u0027mdev_nvidia-11\u0027)"},{"line_number":25719,"context_line":"        self.assertRaises(exception.InvalidLibvirtMdevConfig,"},{"line_number":25720,"context_line":"                          libvirt_driver.LibvirtDriver,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a053b899_b2b9257b","line":25717,"range":{"start_line":25717,"start_character":54,"end_line":25717,"end_character":66},"updated":"2022-06-09 10:18:44.000000000","message":"that seems pointless if you provide the same PCI ID as the definition would be on the same configuration option, right?","commit_id":"a4bfff0ce9efdf5744dd95a43799be0afe4faef7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"35568ee2469134a1069382b33406a0cd7fadbefe","unresolved":true,"context_lines":[{"line_number":25728,"context_line":"        nova.conf.devices.register_dynamic_opts(CONF)"},{"line_number":25729,"context_line":"        # Provide the same pGPU PCI ID for two different types"},{"line_number":25730,"context_line":"        self.flags(device_addresses\u003d[\u00270000:84:00.0\u0027], group\u003d\u0027mdev_nvidia-11\u0027)"},{"line_number":25731,"context_line":"        self.flags(device_addresses\u003d[\u00270000:84:00.0\u0027], group\u003d\u0027mdev_nvidia-12\u0027)"},{"line_number":25732,"context_line":"        self.assertRaises(exception.InvalidLibvirtMdevConfig,"},{"line_number":25733,"context_line":"                          libvirt_driver.LibvirtDriver,"},{"line_number":25734,"context_line":"                          fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"37451979_99ee892a","line":25731,"updated":"2022-06-09 10:18:44.000000000","message":"see, this test is explaining the problem.","commit_id":"a4bfff0ce9efdf5744dd95a43799be0afe4faef7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"35568ee2469134a1069382b33406a0cd7fadbefe","unresolved":true,"context_lines":[{"line_number":7707,"context_line":"            for device_address in group.device_addresses:"},{"line_number":7708,"context_line":"                if device_address in self.pgpu_type_mapping:"},{"line_number":7709,"context_line":"                    raise exception.InvalidLibvirtMdevConfig("},{"line_number":7710,"context_line":"                        reason\u003d\"duplicate PCI ID for vgpu type %s\" % vgpu_type"},{"line_number":7711,"context_line":"                    )"},{"line_number":7712,"context_line":"                # Just checking whether the operator fat-fingered the address."},{"line_number":7713,"context_line":"                # If it\u0027s wrong, it will return an exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"393a38a6_48f8fd5f","line":7710,"updated":"2022-06-09 10:18:44.000000000","message":"I guess you misunderstood the reason of this check.\n\nThis is not for preventing to add twice the same PCI ID, this check is rather for ensuring that the same PCI device can\u0027t accidentally be set for two different types.","commit_id":"a4bfff0ce9efdf5744dd95a43799be0afe4faef7"}]}