)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"539b161a2c2a8c2ed4d21ae98c25f71e0f8c889d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the upgrade check command."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Since this can lead to Nova control services failing to start, make the"},{"line_number":14,"context_line":"upgrade check a failure instead, so it results in a non-zero exit code."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1956983"},{"line_number":17,"context_line":"Change-Id: Ia3ce6a0b0b810667ac0a66502a43038fe43c5aed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b215b093_4f4f49f7","line":14,"updated":"2022-06-13 08:31:11.000000000","message":"Good point. If the service fails to start then the upgrade check should be a failure too","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"274181687578b84cc7f4293708941bca19ff675b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3d0aae1_05152467","updated":"2022-06-09 17:49:13.000000000","message":"you should update ut \u0027nova.tests.unit.cmd.test_status.TestUpgradeCheckOldCompute.test_old_compute\u0027","commit_id":"46f8d5124210892bf41638f533ab8294a9bd9158"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7649a5d8353e188a1fd5c8f4f15987446375d172","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b53097d_e9ea2b7a","updated":"2022-06-13 08:44:58.000000000","message":"Excellent and useful patch, thanks for contributing.","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a64758b421702fe0d8eb8cb7464cc78a22ba26d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"097b279e_aa408f8b","updated":"2022-06-17 07:46:44.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a792705a7e40222b615b540be909cf3e1bd10197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0fa64194_e789dfaf","updated":"2022-06-15 13:23:33.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"e53c4ab17200677fe43cd94a50efec66929663ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ab611f2_5e7186ad","updated":"2022-06-14 11:21:31.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f11b4dbba377fc42faae9bb0c6b5ec89a9b42b16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bfac39e_86ecc79d","updated":"2022-06-13 14:48:08.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"45a44a84d2aac9c874ce8662b0453b318a9d8b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c926c69_6a126d1b","updated":"2022-06-23 07:51:07.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cacaada01c250701d585077a48fa0b1033201ecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c6cc315_f363d18d","updated":"2022-06-14 15:49:18.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"21c9d2e8a541eecd2b7ff37c4ee9e393cce2ae4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"903f3711_16af40de","updated":"2022-06-15 07:39:19.000000000","message":"recheck","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0564d3be7a409e9152cbe64c8d9d9aa7b21e893d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2b66077_5d381f4c","updated":"2022-06-13 10:58:04.000000000","message":"recheck test_create_list_show_delete_interfaces_by_network_port failed which is unrelated to this patch ","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"}],"nova/cmd/status.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6497690a96ec06171e4c546ab62bba58edf27643","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            utils.raise_if_old_compute()"},{"line_number":321,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":322,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, str(e))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9b15cb82_ba16c3f8","line":322,"updated":"2022-06-13 10:23:47.000000000","message":"so we proably should make 2 changes to this\n\none update the  error message https://github.com/openstack/nova/blob/master/nova/exception.py#L598-L604\u003d\n\nto mention the workaround config option to make this a warning on startup.\n\nand also make the nova status check depend on [workarounds]/disable_compute_service_check_for_ffu\n https://github.com/openstack/nova/blob/master/nova/conf/workarounds.py#L377-L386\u003d\n\nto determin if its a warning or an error.\n\n\ncode \u003d (upgradecheck.Code.WARNING \n        if disable_compute_service_check_for_ffu \n        else upgradecheck.Code.FAILURE\n)\nupgradecheck.Result(code, str(e))","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e9662a979d0c2af6f9106ecce830f8466882b306","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            utils.raise_if_old_compute()"},{"line_number":321,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":322,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, str(e))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"52d8ffbc_48e425f5","line":322,"in_reply_to":"01bc67ed_c7493547","updated":"2022-06-13 10:47:43.000000000","message":"Philosophically: Do we really support FFU from upstream perspective? (I don\u0027t think we test it)\n\nTechnically: Changing from Failure to Warning only make sense for me if the check could decide that the FFU will not hit this issue. But to decide that all host config should be read and checked to have [workarounds]/disable_compute_service_check_for_ffu set to True.\n\nSo I\u0027m more inclined to document that if you are using FFU the you _might_ be able to ignore this check, if you have proper configuration. But again that might suggest that we support FFU. :/","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79b0bc5de1e74a291b8117c3c7d96dce7c6b6282","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            utils.raise_if_old_compute()"},{"line_number":321,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":322,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, str(e))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"01bc67ed_c7493547","line":322,"in_reply_to":"200cbe29_cc70a0f3","updated":"2022-06-13 10:31:45.000000000","message":"i belive we just do it once form a contoler.\nwe proably could leave the error message as it is but  whether this is a warning or not proably should take ffu into account.\n\nfor FFU i belive you will run the nova status upgrade check usign the target version once on a single host.","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36d2e8e734c36f0806f1007b10545cf163853d93","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            utils.raise_if_old_compute()"},{"line_number":321,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":322,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, str(e))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b4c50885_1f74bc13","line":322,"in_reply_to":"52d8ffbc_48e425f5","updated":"2022-06-13 10:56:14.000000000","message":"ack ok you got me with implying we support FFU\nwe dont and we dont recomend you upgrade that way.\n\ni woudl like to say the same is ture for your downstream product but its not....\nim droping my -1 lets keep this as is.\n\nyour totally right i dont want to imply that nova support ffu.","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"faa6756bdf1eef39a64692851ab9afaea3800580","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            utils.raise_if_old_compute()"},{"line_number":321,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":322,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, str(e))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"200cbe29_cc70a0f3","line":322,"in_reply_to":"9b15cb82_ba16c3f8","updated":"2022-06-13 10:28:50.000000000","message":"\u003e so we proably should make 2 changes to this\n\u003e \n\u003e one update the  error message https://github.com/openstack/nova/blob/master/nova/exception.py#L598-L604\u003d\n\u003e \n\u003e to mention the workaround config option to make this a warning on startup.\n\nI don\u0027t think we need to do that. I would not really promote that WA flag. But if other see this as a good idea then I think that can be done independently from the upgrade check.\n\n\u003e \n\u003e and also make the nova status check depend on [workarounds]/disable_compute_service_check_for_ffu\n\u003e  https://github.com/openstack/nova/blob/master/nova/conf/workarounds.py#L377-L386\u003d\n\u003e \n\u003e to determin if its a warning or an error.\n\u003e \n\u003e \n\u003e code \u003d (upgradecheck.Code.WARNING \n\u003e         if disable_compute_service_check_for_ffu \n\u003e         else upgradecheck.Code.FAILURE\n\u003e )\n\u003e upgradecheck.Result(code, str(e))\n\n\nDo we run upgrade checks in all hosts including controller and computes? If not then simply reading the [workarounds]/disable_compute_service_check_for_ffu config option from the current host can be really misleading.","commit_id":"9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d"}]}