)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3a3598ddb2056823b27c29b9ca837072b1931b01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2161b02c_9c546091","updated":"2022-06-10 09:44:46.000000000","message":"Yep, easy cleanup, thanks!","commit_id":"65e0a2093934b6e6be8f47962e8f8f1ce17a3e53"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e61328631eb4fc602b64f8367ce3cc164ca59ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e82214d_56f16ed0","updated":"2022-06-10 11:46:24.000000000","message":"Done. Thanks!","commit_id":"72ae9f7fb3ad35cbfbbe6dfee22ca05c57b2d08e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2a31cd5b7b443ad2f4379749edb1c08ff725907d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bef652f1_a13c96ce","updated":"2022-06-16 12:50:32.000000000","message":"recheck","commit_id":"72ae9f7fb3ad35cbfbbe6dfee22ca05c57b2d08e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7ddf3ff64a2afcf2971c9e88b20da4f48d0c7f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff27ad83_d4a01bf7","updated":"2022-06-10 16:08:19.000000000","message":"recheck","commit_id":"72ae9f7fb3ad35cbfbbe6dfee22ca05c57b2d08e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f89c5b4014f3087f4d88a6c4adbafbf2b043967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65aff372_0c5779db","updated":"2022-07-06 12:53:05.000000000","message":"Trivial fix, thanks for it.","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7b5fbaacbaf9b0ac854c8a66af536ac565245aa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"35cf4e67_48ef8917","updated":"2022-07-06 15:46:59.000000000","message":"recheck","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"cc17efd5fc2ee412a0108242588bcf6951fae0cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"764ce600_5680c4e6","updated":"2022-07-10 08:48:16.000000000","message":"recheck","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"53ff5531b940551d49d45c56686609cc4cab05a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9aa9183f_9e72d2bb","updated":"2022-07-07 10:16:05.000000000","message":"recheck","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"cd2f8e745790d20108ebf6bc1d123512ac7f7ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5d094dc_f9d96dac","updated":"2022-07-08 17:24:27.000000000","message":"recheck die 2385 \u0027Neutron did not start\u0027","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"096654e8f04a7f3d54d9c5801f57b772f7036574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8fabf63_11ac4677","updated":"2022-07-06 12:49:05.000000000","message":"the logic around why this should be done seams correct but if we want to backport this we need a bug filed so +1 for general direction but i think we want dan or someone else to confirm.\n\ni dont know why we would have a return here and the fucntional and unit tests seam happy just want to confirm.","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"13cb18879781f538a06f83e87ad455a759b01f0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a66f6d8d_10b63dd9","updated":"2022-07-06 13:04:14.000000000","message":"we discussed this upstream and aggreed there is no api change here\nand that technically the sable policy does not require bugs for backports even if they are strongly encouraged so upgrading to +2w","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9a32107ee2fd12682a4511c396e756ccde693224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c9332c1_a3d07da8","in_reply_to":"761728b2_d725da1b","updated":"2022-07-07 11:36:13.000000000","message":"Thanks for clarification.\n\nI will create a backport to stable release today.","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbc0fdc319b7adfd2f7ab9ec8746902216956aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e14bc9a8_2620c8a1","in_reply_to":"9aa9183f_9e72d2bb","updated":"2022-07-07 11:25:32.000000000","message":"rajesh you shoudl avoid doing a \"naked\" recheck\n\nwe are trying to change this cultrually across all of openstack\n\nbut basicaly if you are doing a recheck you should always state why\n\nso \"\"\"recheck die 2385 \u0027Neutron did not start\"\"\" in the cause of your failures in nova-next\n\nalthough this is the 4 time i have seen that today so it looks like we have a gate bug\n\nthat is why its importnat to have a message as others seeing the recheck might see a pattren\nso going for please try to see why the job failed and note it in the message wenn rechecking","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5f1f8455769d6b6d07bebe13907c9617e2c53391","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d932b61_d3d49935","in_reply_to":"b5d094dc_f9d96dac","updated":"2022-07-08 17:48:42.000000000","message":"Note: this was https://bugs.launchpad.net/os-vif/+bug/1980948 (which fix merged yesterday).","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9a32107ee2fd12682a4511c396e756ccde693224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70596190_ea1e04c7","in_reply_to":"e14bc9a8_2620c8a1","updated":"2022-07-07 11:36:13.000000000","message":"Thanks, I will take care of that next time onwards.","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b8a707a0c4394f30bce9f94566ee1dba1ce37db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"761728b2_d725da1b","in_reply_to":"e8fabf63_11ac4677","updated":"2022-07-06 13:04:47.000000000","message":"\u003e the logic around why this should be done seams correct but if we want to backport this we need a bug filed so +1 for general direction but i think we want dan or someone else to confirm.\n\n\nFWIW, the stable policy allows us to backport a change that\u0027s not purely a bugfix :\n\n\"It’s nevertheless allowed to backport fixes for other bugs if their safety can be easily proved. For example, documentation fixes, debug log message typo corrections, test only changes, patches that enhance test coverage, configuration file content fixes can apply to all supported branches. For those types of backports, stable maintainers will decide on case by case basis.\"\nhttps://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes\n\nSo we can propose a backport to stable/yoga if we want without proper Launchpad tracking.","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"91f82869d920193b891d916dd59688e9734f2c4e","unresolved":true,"context_lines":[{"line_number":1503,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":1504,"context_line":"        cctxt \u003d client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":1505,"context_line":"                version\u003dversion)"},{"line_number":1506,"context_line":"        cctxt.cast(ctxt, \"trigger_crash_dump\", instance\u003dinstance)"},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":"    def cache_images(self, ctxt, host, image_ids):"},{"line_number":1509,"context_line":"        version \u003d self._ver(ctxt, \u00275.4\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"40168cb8_4a1af8a8","line":1506,"updated":"2022-07-06 12:57:39.000000000","message":"to clarify, oslo.messaging cast() doesn\u0027t return anyway, so it won\u0027t change anything :\n\nhttps://github.com/openstack/oslo.messaging/blob/f1b47b6ba8ee4888f6cba1efac0fbf747c5406e6/oslo_messaging/rpc/client.py#L476","commit_id":"7824471b790acdbab8c99f965e87e7fb49c32719"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"41a15f2466b56086df9979495331f17b74f75efc","unresolved":true,"context_lines":[{"line_number":346,"context_line":"            call_monitor_timeout\u003dCONF.rpc_response_timeout,"},{"line_number":347,"context_line":"            timeout\u003dCONF.long_rpc_timeout)"},{"line_number":348,"context_line":"        if do_cast:"},{"line_number":349,"context_line":"            cctxt.cast(context, \u0027migrate_server\u0027, **kw)"},{"line_number":350,"context_line":"        return cctxt.call(context, \u0027migrate_server\u0027, **kw)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def build_instances(self, context, instances, image, filter_properties,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a725c7d5_633fa990","line":349,"updated":"2022-06-10 11:02:11.000000000","message":"Ah, right, without the return it\u0027ll continue executing to the call below","commit_id":"65e0a2093934b6e6be8f47962e8f8f1ce17a3e53"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e61328631eb4fc602b64f8367ce3cc164ca59ed7","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            call_monitor_timeout\u003dCONF.rpc_response_timeout,"},{"line_number":347,"context_line":"            timeout\u003dCONF.long_rpc_timeout)"},{"line_number":348,"context_line":"        if do_cast:"},{"line_number":349,"context_line":"            cctxt.cast(context, \u0027migrate_server\u0027, **kw)"},{"line_number":350,"context_line":"        return cctxt.call(context, \u0027migrate_server\u0027, **kw)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def build_instances(self, context, instances, image, filter_properties,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4483ef28_320eb850","line":349,"in_reply_to":"a725c7d5_633fa990","updated":"2022-06-10 11:46:24.000000000","message":"Done","commit_id":"65e0a2093934b6e6be8f47962e8f8f1ce17a3e53"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"41a15f2466b56086df9979495331f17b74f75efc","unresolved":true,"context_lines":[{"line_number":464,"context_line":"        kw \u003d {\u0027instance\u0027: instance, \u0027migration\u0027: migration}"},{"line_number":465,"context_line":"        cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":466,"context_line":"        if do_cast:"},{"line_number":467,"context_line":"            cctxt.cast(ctxt, \u0027confirm_snapshot_based_resize\u0027, **kw)"},{"line_number":468,"context_line":"        return cctxt.call(ctxt, \u0027confirm_snapshot_based_resize\u0027, **kw)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def revert_snapshot_based_resize(self, ctxt, instance, migration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5566d0c4_daa0844a","line":467,"updated":"2022-06-10 11:02:11.000000000","message":"Ditto","commit_id":"65e0a2093934b6e6be8f47962e8f8f1ce17a3e53"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"e61328631eb4fc602b64f8367ce3cc164ca59ed7","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        kw \u003d {\u0027instance\u0027: instance, \u0027migration\u0027: migration}"},{"line_number":465,"context_line":"        cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":466,"context_line":"        if do_cast:"},{"line_number":467,"context_line":"            cctxt.cast(ctxt, \u0027confirm_snapshot_based_resize\u0027, **kw)"},{"line_number":468,"context_line":"        return cctxt.call(ctxt, \u0027confirm_snapshot_based_resize\u0027, **kw)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def revert_snapshot_based_resize(self, ctxt, instance, migration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"36090e9a_8ae54842","line":467,"in_reply_to":"5566d0c4_daa0844a","updated":"2022-06-10 11:46:24.000000000","message":"Done","commit_id":"65e0a2093934b6e6be8f47962e8f8f1ce17a3e53"}]}