)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33cc06dc9723edd8e0eddf7f67291a263fe8bd90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01e5a7c3_732530f6","updated":"2024-08-29 23:35:31.000000000","message":"LGTM","commit_id":"0246a5d66aae449d80ff99593830ecbe7e2a3acb"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"79aa15b76565e10112c04809d9df99d13b65802e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"07bcdb3c_d127eb0a","updated":"2024-03-06 09:57:56.000000000","message":"lgtm","commit_id":"0246a5d66aae449d80ff99593830ecbe7e2a3acb"}],"nova/tests/functional/libvirt/test_vgpu.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4658c273a773a936d55843ca6cdf6b51703f3bde","unresolved":true,"context_lines":[{"line_number":311,"context_line":"        # Let\u0027s try to ask for two vGPUs with each of them be in a different"},{"line_number":312,"context_line":"        # physical GPU."},{"line_number":313,"context_line":"        extra_spec \u003d {\"resources1:VGPU\": \"1\", \"resources2:VGPU\": \"1\","},{"line_number":314,"context_line":"                      \"group_policy\": \"isolate\"}"},{"line_number":315,"context_line":"        flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":316,"context_line":"        self._create_server("},{"line_number":317,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4737b2af_90c225ce","line":314,"updated":"2024-01-18 14:47:51.000000000","message":"that one way to do that but a better way would be via resource classes or traits\n\n \"group_policy\": \"isolate\" is more or less broken by design so we shoudl not really recommend that people use that. \n \nthis does reproduce the issue so i think that fine but it would be nice to have a more real world example.\n\nif i got a bug report with someone using  \"group_policy\": \"isolate\"\nmy frist responce would be dont do that :)","commit_id":"0e4fdf326bdda62fc088b94deb681c46f2635e3d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7d5b56b223f4e615ab7cacee1f5efca9b3d52535","unresolved":true,"context_lines":[{"line_number":311,"context_line":"        # Let\u0027s try to ask for two vGPUs with each of them be in a different"},{"line_number":312,"context_line":"        # physical GPU."},{"line_number":313,"context_line":"        extra_spec \u003d {\"resources1:VGPU\": \"1\", \"resources2:VGPU\": \"1\","},{"line_number":314,"context_line":"                      \"group_policy\": \"isolate\"}"},{"line_number":315,"context_line":"        flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":316,"context_line":"        self._create_server("},{"line_number":317,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c1ee2d7_6512b999","line":314,"in_reply_to":"4737b2af_90c225ce","updated":"2024-01-19 11:29:02.000000000","message":"I agree. Let\u0027s fix it here or in a FUP.\n//later\nBased on the doc in the next patch, isolate is actually mandatory for this to work.","commit_id":"0e4fdf326bdda62fc088b94deb681c46f2635e3d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63feb24198594671dfa69ccfe2250870c9e9d462","unresolved":true,"context_lines":[{"line_number":311,"context_line":"        # Let\u0027s try to ask for two vGPUs with each of them be in a different"},{"line_number":312,"context_line":"        # physical GPU."},{"line_number":313,"context_line":"        extra_spec \u003d {\"resources1:VGPU\": \"1\", \"resources2:VGPU\": \"1\","},{"line_number":314,"context_line":"                      \"group_policy\": \"isolate\"}"},{"line_number":315,"context_line":"        flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":316,"context_line":"        self._create_server("},{"line_number":317,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e015363a_3189e87f","line":314,"in_reply_to":"8c1ee2d7_6512b999","updated":"2024-01-19 15:04:46.000000000","message":"it is mandaroy if you are using teh same resouce class with no traits yes.\n\nbut it breaks other things so without the placmenet feature to allwo us to apply the isolate logic to only specired rescource# groups instead of all of them its not \"portable\" (perhaps \"itneroperable\" is a better phasing) with other placement reqeust form ports ectra. so i dont agree wtih documenting any recomendation to use \n\ngroup_policy: isolate.","commit_id":"0e4fdf326bdda62fc088b94deb681c46f2635e3d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f8ac70bbdde44da473ad6ab59bdb7a7e3bfcd32","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        # Let\u0027s try to ask for two vGPUs with each of them be in a different"},{"line_number":312,"context_line":"        # physical GPU."},{"line_number":313,"context_line":"        extra_spec \u003d {\"resources1:VGPU\": \"1\", \"resources2:VGPU\": \"1\","},{"line_number":314,"context_line":"                      \"group_policy\": \"isolate\"}"},{"line_number":315,"context_line":"        flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":316,"context_line":"        self._create_server("},{"line_number":317,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac5de74_4dd9d41b","line":314,"in_reply_to":"e015363a_3189e87f","updated":"2024-01-19 16:40:41.000000000","message":"I tried to better document the alternatives in the followup patch.","commit_id":"0e4fdf326bdda62fc088b94deb681c46f2635e3d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7d5b56b223f4e615ab7cacee1f5efca9b3d52535","unresolved":true,"context_lines":[{"line_number":317,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":318,"context_line":"            flavor_id\u003dflavor, networks\u003d\u0027auto\u0027, host\u003dself.compute1.host)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # FIXME(sbauza): Unfortunately, we only accept one allocation per"},{"line_number":321,"context_line":"        # instance by the libvirt driver as you can see in _allocate_mdevs()."},{"line_number":322,"context_line":"        # So, eventually, we only have one vGPU for this instance."},{"line_number":323,"context_line":"        self.assert_mdev_usage(self.compute1, expected_amount\u003d1)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"class VGPUMultipleTypesTests(VGPUTestBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"62ae657e_a1efcdc4","line":323,"range":{"start_line":320,"start_character":0,"end_line":323,"end_character":64},"updated":"2024-01-19 11:29:02.000000000","message":"Ohh so it is not even failing but ignoring the second requested GPU. Bad bug :/","commit_id":"0ebb22577d321fc42f352165321f0144b2bc375e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f8ac70bbdde44da473ad6ab59bdb7a7e3bfcd32","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":318,"context_line":"            flavor_id\u003dflavor, networks\u003d\u0027auto\u0027, host\u003dself.compute1.host)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # FIXME(sbauza): Unfortunately, we only accept one allocation per"},{"line_number":321,"context_line":"        # instance by the libvirt driver as you can see in _allocate_mdevs()."},{"line_number":322,"context_line":"        # So, eventually, we only have one vGPU for this instance."},{"line_number":323,"context_line":"        self.assert_mdev_usage(self.compute1, expected_amount\u003d1)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"class VGPUMultipleTypesTests(VGPUTestBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ac528507_f7a0c478","line":323,"range":{"start_line":320,"start_character":0,"end_line":323,"end_character":64},"in_reply_to":"62ae657e_a1efcdc4","updated":"2024-01-19 16:40:41.000000000","message":"Acknowledged","commit_id":"0ebb22577d321fc42f352165321f0144b2bc375e"}]}