)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"1c88c5babf9b623e23453bc6cb538eb53b5a12a1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Amit Uniyal \u003cauniyal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-22 06:15:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added validation for hw machine type in host capabilities"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- accept host capabilities and machine type"},{"line_number":10,"context_line":"- look fo machine type in host capabilities object"},{"line_number":11,"context_line":"- raises InvalidMachineType exception for invalid machine type"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1933097"},{"line_number":14,"context_line":"Change-Id: I59d22c0342d6b0f3c0398ce62ec177dae39b5677"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a9f8a44b_e976900c","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":62},"updated":"2022-06-22 11:56:35.000000000","message":"Please follow developer guidelines for commit messages.\n\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#committing-changes","commit_id":"ed8149318e167742777e6e79c5c912ef870bddff"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"31288966144d6b66b7b81dbaf0b1067d791cc5a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amit Uniyal \u003cauniyal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-22 06:15:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added validation for hw machine type in host capabilities"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- accept host capabilities and machine type"},{"line_number":10,"context_line":"- look fo machine type in host capabilities object"},{"line_number":11,"context_line":"- raises InvalidMachineType exception for invalid machine type"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1933097"},{"line_number":14,"context_line":"Change-Id: I59d22c0342d6b0f3c0398ce62ec177dae39b5677"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"01a13384_650eb5f8","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":62},"in_reply_to":"a9f8a44b_e976900c","updated":"2022-06-23 11:21:01.000000000","message":"updated commit msg","commit_id":"ed8149318e167742777e6e79c5c912ef870bddff"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"f08fdddc2503558f68cf1e32bb9b5231c460d167","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function accept host capabilities (caps) and machine type as param"},{"line_number":10,"context_line":"and look for machine type in host caps object"},{"line_number":11,"context_line":"if mahcine type is not found raises exception InvalidMachineType"},{"line_number":12,"context_line":"else return None"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1933097"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"09f0d91d_080cbef4","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":10},"updated":"2022-06-23 13:23:02.000000000","message":"*machine","commit_id":"605651a934d2add5c1bc50a08d8ae7fc83aaf039"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b284b164b05fccd791139a10fa01a254546bdb68","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function accept host capabilities (caps) and machine type as param"},{"line_number":10,"context_line":"and look for machine type in host caps object"},{"line_number":11,"context_line":"if mahcine type is not found raises exception InvalidMachineType"},{"line_number":12,"context_line":"else return None"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1933097"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da92a910_abd00ced","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":10},"in_reply_to":"09f0d91d_080cbef4","updated":"2022-06-23 18:20:59.000000000","message":"fixed","commit_id":"605651a934d2add5c1bc50a08d8ae7fc83aaf039"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffc4decafa81585c19163c9d0ce61db688dad78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac9bdaa8_e9faa7f0","updated":"2022-06-22 09:02:33.000000000","message":"ill take a look at this again but overall i think this is more or less the right aproch i need to chenc why the  zuul jobs failed although it proably is not realted","commit_id":"ed8149318e167742777e6e79c5c912ef870bddff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2ac8f53202eb8025f8de918f3e58680c7110f5a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cdb5ee34_d83c4987","updated":"2022-06-22 09:06:09.000000000","message":"oh the test failures are relatd to your patch.\nin some case the machine type selection is being mocked and returning python None which is not a valid machine type so you need to fix the other tests","commit_id":"ed8149318e167742777e6e79c5c912ef870bddff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"020f2d88fb7a091662ae585b3bcb3135266c67d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"feecdf7e_6420d5e4","updated":"2022-06-24 04:57:48.000000000","message":"i think this is close.\n\na minor style nit in the tests regarding mock.patch\n\nother wise it would be nice to add a fixes release note \n\nrun tox -e venv —— reno new validate-machine-type\n\nto create a default release note and then add a sentance or two describing the\nfix to an operator as you have in the commit message.\n\nother then that im +2 on it so if you make those chnage ill +2 when im working again on monday.\n\nim taking today off to recover so reach out to sylvain or the rest of the team if you need any help with the release note.","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b284b164b05fccd791139a10fa01a254546bdb68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4acd8162_d087cb41","updated":"2022-06-23 18:20:59.000000000","message":"recheck","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"18da897f6f3caef72c9a701d7d2c52abd76502bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8299eb2a_f2206b6c","updated":"2022-06-24 14:16:47.000000000","message":"fixed mocks and added release notes","commit_id":"632b477b5f230565b0170131679e7037500703d0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2dab2a63d6138bc6a924be3b7e53d1f5e199036b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2f667742_8a4e0a9e","updated":"2022-07-01 13:43:27.000000000","message":"I have some comments but none of them need to hold the merge.","commit_id":"7b9312ef8e3064932107daec8b823d7031a89ae6"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"020f2d88fb7a091662ae585b3bcb3135266c67d6","unresolved":true,"context_lines":[{"line_number":2677,"context_line":"        self.assertEqual(33550336,"},{"line_number":2678,"context_line":"                         cfg.metadata[0].flavor.swap)"},{"line_number":2679,"context_line":""},{"line_number":2680,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", return_value\u003dNone)"},{"line_number":2681,"context_line":"    def test_get_guest_config_q35(self, mock_caps):"},{"line_number":2682,"context_line":"        self.flags(virt_type\u003d\"kvm\","},{"line_number":2683,"context_line":"                   group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c5fe781e_6ac2654c","line":2680,"updated":"2022-06-24 04:57:48.000000000","message":"since you are not using mock_caps to make any assertions in the test there is a differnt syntax you should use to intoduce the mock without introducing a name for the mock.","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"18da897f6f3caef72c9a701d7d2c52abd76502bb","unresolved":false,"context_lines":[{"line_number":2677,"context_line":"        self.assertEqual(33550336,"},{"line_number":2678,"context_line":"                         cfg.metadata[0].flavor.swap)"},{"line_number":2679,"context_line":""},{"line_number":2680,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", return_value\u003dNone)"},{"line_number":2681,"context_line":"    def test_get_guest_config_q35(self, mock_caps):"},{"line_number":2682,"context_line":"        self.flags(virt_type\u003d\"kvm\","},{"line_number":2683,"context_line":"                   group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3b900614_20ac546b","line":2680,"in_reply_to":"c5fe781e_6ac2654c","updated":"2022-06-24 14:16:47.000000000","message":"Done","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"020f2d88fb7a091662ae585b3bcb3135266c67d6","unresolved":true,"context_lines":[{"line_number":2750,"context_line":""},{"line_number":2751,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", return_value\u003dNone)"},{"line_number":2752,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.utils.get_default_machine_type\u0027,"},{"line_number":2753,"context_line":"                new\u003dmock.Mock(return_value\u003d\u0027config-machine_type\u0027))"},{"line_number":2754,"context_line":"    def test_get_guest_config_records_machine_type_in_instance("},{"line_number":2755,"context_line":"            self, mock_caps):"},{"line_number":2756,"context_line":"        # Assert that the config derived machine type is used when it"}],"source_content_type":"text/x-python","patch_set":7,"id":"119d1778_9652691d","line":2753,"updated":"2022-06-24 04:57:48.000000000","message":"this is an example of the ohter syntax using new\n\nso you should replace @mock.patch.object here and in the rest of the file\nwith \n\n@mock.patch.object(host.Host, \"_check_machine_type\", new\u003dmock.Mock())\nthen you do not need to add mock_caps to the funciton signiture\n\nyou also do not need to set return_value\u003dNone since that is the default","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"18da897f6f3caef72c9a701d7d2c52abd76502bb","unresolved":false,"context_lines":[{"line_number":2750,"context_line":""},{"line_number":2751,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", return_value\u003dNone)"},{"line_number":2752,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.utils.get_default_machine_type\u0027,"},{"line_number":2753,"context_line":"                new\u003dmock.Mock(return_value\u003d\u0027config-machine_type\u0027))"},{"line_number":2754,"context_line":"    def test_get_guest_config_records_machine_type_in_instance("},{"line_number":2755,"context_line":"            self, mock_caps):"},{"line_number":2756,"context_line":"        # Assert that the config derived machine type is used when it"}],"source_content_type":"text/x-python","patch_set":7,"id":"d7089423_3fe77cdb","line":2753,"in_reply_to":"119d1778_9652691d","updated":"2022-06-24 14:16:47.000000000","message":"Done","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2dab2a63d6138bc6a924be3b7e53d1f5e199036b","unresolved":true,"context_lines":[{"line_number":2677,"context_line":"        self.assertEqual(33550336,"},{"line_number":2678,"context_line":"                         cfg.metadata[0].flavor.swap)"},{"line_number":2679,"context_line":""},{"line_number":2680,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", new\u003dmock.Mock())"},{"line_number":2681,"context_line":"    def test_get_guest_config_q35(self):"},{"line_number":2682,"context_line":"        self.flags(virt_type\u003d\"kvm\","},{"line_number":2683,"context_line":"                   group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"8c24eb2f_4180ddc8","line":2680,"updated":"2022-07-01 13:43:27.000000000","message":"instead of patching every single method, an alternative could have been to add the mock in the setUp() method for the whole test class, but given this test class is checking more than just the get_guest_config() method, I\u0027m fine with using the decorators for each of the needed tests.","commit_id":"7b9312ef8e3064932107daec8b823d7031a89ae6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2dab2a63d6138bc6a924be3b7e53d1f5e199036b","unresolved":true,"context_lines":[{"line_number":3656,"context_line":"    @mock.patch.object("},{"line_number":3657,"context_line":"        host.Host, \"is_cpu_control_policy_capable\", return_value\u003dTrue)"},{"line_number":3658,"context_line":"    def test_get_guest_config_numa_host_instance_topo("},{"line_number":3659,"context_line":"            self, is_able):"},{"line_number":3660,"context_line":"        self.flags(cpu_shared_set\u003d\u00270-5\u0027, cpu_dedicated_set\u003dNone,"},{"line_number":3661,"context_line":"                   group\u003d\u0027compute\u0027)"},{"line_number":3662,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"b0db9048_36efe158","line":3659,"updated":"2022-07-01 13:43:27.000000000","message":"unnecessary change but OK","commit_id":"7b9312ef8e3064932107daec8b823d7031a89ae6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2dab2a63d6138bc6a924be3b7e53d1f5e199036b","unresolved":true,"context_lines":[{"line_number":4012,"context_line":""},{"line_number":4013,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", new\u003dmock.Mock())"},{"line_number":4014,"context_line":"    def test_get_guest_config_numa_host_instance_cpu_mixed_isolated_emu("},{"line_number":4015,"context_line":"            self):"},{"line_number":4016,"context_line":"        \"\"\"Test to create mixed instance libvirt configuration which has an"},{"line_number":4017,"context_line":"        ISOLATED emulator thread policy and verify the NUMA topology related"},{"line_number":4018,"context_line":"        settings."}],"source_content_type":"text/x-python","patch_set":10,"id":"e2700a55_fab6c58e","line":4015,"updated":"2022-07-01 13:43:27.000000000","message":"unnecessary change","commit_id":"7b9312ef8e3064932107daec8b823d7031a89ae6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2dab2a63d6138bc6a924be3b7e53d1f5e199036b","unresolved":true,"context_lines":[{"line_number":4301,"context_line":""},{"line_number":4302,"context_line":"    @mock.patch.object(host.Host, \"_check_machine_type\", new\u003dmock.Mock())"},{"line_number":4303,"context_line":"    def test_get_guest_config_numa_host_instance_cpu_pinning_realtime("},{"line_number":4304,"context_line":"            self):"},{"line_number":4305,"context_line":"        self.flags(cpu_shared_set\u003dNone, cpu_dedicated_set\u003d\u00274-7\u0027,"},{"line_number":4306,"context_line":"                   group\u003d\u0027compute\u0027)"},{"line_number":4307,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9192bab7_fc98a547","line":4304,"updated":"2022-07-01 13:43:27.000000000","message":"unnecessary change","commit_id":"7b9312ef8e3064932107daec8b823d7031a89ae6"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55be5325597b5e160588c27c62a8323909a4b647","unresolved":true,"context_lines":[{"line_number":6450,"context_line":""},{"line_number":6451,"context_line":"            guest.os_mach_type \u003d mach_type"},{"line_number":6452,"context_line":""},{"line_number":6453,"context_line":"            self._host._check_machine_type(caps, mach_type)"},{"line_number":6454,"context_line":""},{"line_number":6455,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":6456,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7ce596a9_0af3b32b","line":6453,"range":{"start_line":6453,"start_character":12,"end_line":6453,"end_character":59},"updated":"2022-06-23 08:51:19.000000000","message":"Why are you calling this function two times?","commit_id":"f3fb22f2ede47a9f97f88b534cf09ea385ae2fc5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"31288966144d6b66b7b81dbaf0b1067d791cc5a7","unresolved":false,"context_lines":[{"line_number":6450,"context_line":""},{"line_number":6451,"context_line":"            guest.os_mach_type \u003d mach_type"},{"line_number":6452,"context_line":""},{"line_number":6453,"context_line":"            self._host._check_machine_type(caps, mach_type)"},{"line_number":6454,"context_line":""},{"line_number":6455,"context_line":"            hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":6456,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"65b4a04e_19aa440b","line":6453,"range":{"start_line":6453,"start_character":12,"end_line":6453,"end_character":59},"in_reply_to":"7ce596a9_0af3b32b","updated":"2022-06-23 11:21:01.000000000","message":"Fixed","commit_id":"f3fb22f2ede47a9f97f88b534cf09ea385ae2fc5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"020f2d88fb7a091662ae585b3bcb3135266c67d6","unresolved":true,"context_lines":[{"line_number":6446,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":6447,"context_line":""},{"line_number":6448,"context_line":"            mach_type \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":6449,"context_line":"            self._host._check_machine_type(caps, mach_type)"},{"line_number":6450,"context_line":""},{"line_number":6451,"context_line":"            guest.os_mach_type \u003d mach_type"},{"line_number":6452,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"72cdab6d_567a059e","line":6449,"updated":"2022-06-24 04:57:48.000000000","message":"+1","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"18da897f6f3caef72c9a701d7d2c52abd76502bb","unresolved":false,"context_lines":[{"line_number":6446,"context_line":"                guest.os_smbios \u003d vconfig.LibvirtConfigGuestSMBIOS()"},{"line_number":6447,"context_line":""},{"line_number":6448,"context_line":"            mach_type \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":6449,"context_line":"            self._host._check_machine_type(caps, mach_type)"},{"line_number":6450,"context_line":""},{"line_number":6451,"context_line":"            guest.os_mach_type \u003d mach_type"},{"line_number":6452,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2bca7a0d_bee1744f","line":6449,"in_reply_to":"72cdab6d_567a059e","updated":"2022-06-24 14:16:47.000000000","message":"Ack","commit_id":"eb373bfe50bccdcd5e0ba9cbfd7dc3e5db065036"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffc4decafa81585c19163c9d0ce61db688dad78b","unresolved":true,"context_lines":[{"line_number":1207,"context_line":"        \"\"\""},{"line_number":1208,"context_line":"        possible_machine_types \u003d []"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        caps_tree \u003d etree.fromstring(str(caps))"},{"line_number":1211,"context_line":"        for guest in caps_tree.findall(\u0027guest\u0027):"},{"line_number":1212,"context_line":"            for machine in guest.xpath(\u0027arch/machine\u0027):"},{"line_number":1213,"context_line":"                possible_machine_types.append(machine.text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f12eebf_36e9df6b","line":1210,"updated":"2022-06-22 09:02:33.000000000","message":"what is the type of caps currently?","commit_id":"ed8149318e167742777e6e79c5c912ef870bddff"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"31288966144d6b66b7b81dbaf0b1067d791cc5a7","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        \"\"\""},{"line_number":1208,"context_line":"        possible_machine_types \u003d []"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        caps_tree \u003d etree.fromstring(str(caps))"},{"line_number":1211,"context_line":"        for guest in caps_tree.findall(\u0027guest\u0027):"},{"line_number":1212,"context_line":"            for machine in guest.xpath(\u0027arch/machine\u0027):"},{"line_number":1213,"context_line":"                possible_machine_types.append(machine.text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fc8a850_dea1fc17","line":1210,"in_reply_to":"5f12eebf_36e9df6b","updated":"2022-06-23 11:21:01.000000000","message":"caps type is LibvirtConfigCaps\n\n\u003cclass \u0027nova.virt.libvirt.config.LibvirtConfigCaps\u0027\u003e","commit_id":"ed8149318e167742777e6e79c5c912ef870bddff"}],"releasenotes/notes/validate-machine-type-0d5f3dbd1e2ace31.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c7566bd724ada936a5c63e4cac72d3907ea8f4a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added validation for image machine type property. Different API which"},{"line_number":5,"context_line":"    uses machine type for server creation, resize or rebuild will raise"},{"line_number":6,"context_line":"    InvalidMachineType exception with message \"provided machine type is not"},{"line_number":7,"context_line":"    supported by host\" and suggest possible/valid machine types in compute logs."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6e32b739_1c4b080b","line":4,"range":{"start_line":4,"start_character":64,"end_line":4,"end_character":67},"updated":"2022-06-27 11:21:42.000000000","message":"nit APIs","commit_id":"7ea0b75b244dec4afc608db95ce1b4bfa43f1f6b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7bf54d4920ec9381b332996293418c5d3ed07fdf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added validation for image machine type property. Different API which"},{"line_number":5,"context_line":"    uses machine type for server creation, resize or rebuild will raise"},{"line_number":6,"context_line":"    InvalidMachineType exception with message \"provided machine type is not"},{"line_number":7,"context_line":"    supported by host\" and suggest possible/valid machine types in compute logs."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"359dd677_838431c4","line":4,"range":{"start_line":4,"start_character":64,"end_line":4,"end_character":67},"in_reply_to":"6e32b739_1c4b080b","updated":"2022-07-01 11:00:12.000000000","message":"Done","commit_id":"7ea0b75b244dec4afc608db95ce1b4bfa43f1f6b"}]}