)]}'
{"id":"openstack%2Fnova~84755","triplet_id":"openstack%2Fnova~stable%2Fhavana~I54135effe4e083f73cb7d912ac9e82fd182e2b2d","project":"openstack/nova","branch":"stable/havana","topic":"bug/1301436","hashtags":[],"change_id":"I54135effe4e083f73cb7d912ac9e82fd182e2b2d","subject":"Fix \u0027icehouse-compat\u0027 processing for compute rpc","status":"MERGED","created":"2014-04-02 15:25:53.000000000","updated":"2014-04-02 20:08:27.000000000","submitted":"2014-04-02 20:08:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b688bf61625429871a85dd2ffb03bb04ff6a2d97","_number":84755,"virtual_id_number":84755,"owner":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2014-04-02 16:37:07.000000000","_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2014-04-02 20:08:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"all":[{"value":2,"date":"2014-04-02 18:25:43.000000000","_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":1,"date":"2014-04-02 17:47:21.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":2,"date":"2014-04-02 15:39:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2014-04-02 18:00:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":2,"date":"2014-04-02 18:04:25.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"all":[{"value":1,"date":"2014-04-02 18:25:43.000000000","_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"date":"2014-04-02 17:47:21.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"date":"2014-04-02 15:39:55.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2014-04-02 18:00:22.000000000","_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"date":"2014-04-02 18:04:25.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-04-02 15:39:55.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2014-04-02 16:37:07.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-04-02 17:47:21.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2014-04-02 18:00:22.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2014-04-02 18:04:25.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2014-04-02 18:25:43.000000000","updated_by":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"reviewer":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"state":"REVIEWER"},{"updated":"2014-04-02 20:08:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"db95e9f75240fa3fe532961d42f674b29fe7ca8f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 15:25:56.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"77497d9603970f599a27d8c149ee9a1539448770","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2014-04-02 15:28:56.000000000","message":"Patch Set 1:\n\nNote that this doesn\u0027t include new test cases, but existing test cases cover all of these code paths.\n\nAdditional test coverage would require doing validation of the combination of message version and data types.  We\u0027re not doing that for *any* rpc code right now, though, so I don\u0027t think it\u0027s worth the effort for this.","accounts_in_message":[],"_revision_number":1},{"id":"92d66b84455fe30d4a91b1a37f6d9e53de8de065","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-04-02 15:32:50.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThis fix is definitely needed in order to make upgrades work.\n\nFound one issue inline I think.","accounts_in_message":[],"_revision_number":1},{"id":"ca4a01c10f6cad86c2e977cdadcfa20588868b1b","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2014-04-02 15:34:59.000000000","message":"Patch Set 1: (1 inline comment)\n\ngood catch","accounts_in_message":[],"_revision_number":1},{"id":"ee47837672a2f7a5e1edccbd2a7088b1730409a6","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2014-04-02 15:35:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b7475877ed167f75ede5a3b10415fb7c250f20f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 15:35:25.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b9774553e6c3a6522c37028f756e7741df8a5ce6","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-04-02 15:39:55.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nThis is extremely important for smooth live upgrades from havana to icehouse. It looks scarier than it is, but it\u0027s a comprehensive fix of the versions havana sends for each call when in icehouse compatibility mode. Havana-\u003eIcehouse was the first release where we attempted such compatibility, so tweaking like this is somewhat expected.","accounts_in_message":[],"_revision_number":2},{"id":"909a11607c2f08595e4bfbb3e2979e6eed0a6120","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2014-04-02 16:09:13.000000000","message":"Patch Set 2:\n\nBuild failed. For rechecking only on the IBM PowerKVM CI, add a review comment with recheck pkvm\n\n- gate-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/84755/2/gate-ibm-tempest-dsvm-full/42f205a : FAILURE in 32m 58s\n- gate-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/84755/2/gate-ibm-tempest-dsvm-postgres-full/18e1940 : FAILURE in 32m 37s\n","accounts_in_message":[],"_revision_number":2},{"id":"d6ef331bd96d44f0ca88759f7d43db718ad45b01","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 16:18:53.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/55/84755/2/check/gate-nova-pep8/a0e3412 : SUCCESS in 7m 49s\n- gate-nova-docs http://docs-draft.openstack.org/55/84755/2/check/gate-nova-docs/977f5c5/doc/build/html/ : SUCCESS in 7m 52s\n- gate-nova-python26 http://logs.openstack.org/55/84755/2/check/gate-nova-python26/30577af : SUCCESS in 17m 28s\n- gate-nova-python27 http://logs.openstack.org/55/84755/2/check/gate-nova-python27/a29e818 : SUCCESS in 13m 48s\n- check-tempest-dsvm-full http://logs.openstack.org/55/84755/2/check/check-tempest-dsvm-full/7c20071 : SUCCESS in 35m 50s\n- check-tempest-dsvm-neutron http://logs.openstack.org/55/84755/2/check/check-tempest-dsvm-neutron/a939c54 : SUCCESS in 31m 39s\n- check-devstack-dsvm-cells http://logs.openstack.org/55/84755/2/check/check-devstack-dsvm-cells/83e04a2 : SUCCESS in 13m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/55/84755/2/check/check-tempest-dsvm-postgres-full/bba5fea : SUCCESS in 35m 46s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/84755/2/check/gate-tempest-dsvm-large-ops/d219d33 : SUCCESS in 13m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/84755/2/check/gate-tempest-dsvm-neutron-large-ops/6876cdf : SUCCESS in 19m 42s\n- check-tempest-dsvm-cells-full http://logs.openstack.org/55/84755/2/check/check-tempest-dsvm-cells-full/54ce039 : FAILURE in 19m 39s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/55/84755/2/check/gate-nova-pylint/216a6c7 : SUCCESS in 14m 31s (non-voting)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"924722f4d47748fba6bf84faee842bc7cb76a38b","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2014-04-02 16:37:07.000000000","message":"Patch Set 2:\n\nBuild failed. For rechecking only on the Hyper-V CI, add a review comment with recheck hyper-v\n\n- http://64.119.130.115/84755/2/ : Test run failed in 1h 01m 20s\n","accounts_in_message":[],"_revision_number":2},{"id":"8c13cb4bee86a9e46b6ff6192b8a0c4d99636c33","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2014-04-02 17:47:21.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b5b925fa8a37d7e102413bfcd568a7baa7a8c6f7","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2014-04-02 18:00:22.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM, but we need a feature freeze exception before this can go into stable.  apevec has proposed one on the mailing list.","accounts_in_message":[],"_revision_number":2},{"id":"1fba3645ee5afbbefb6c56f1aec0936ac3d7d284","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2014-04-02 18:04:25.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"49ae5bef5cbfcb156f915e0692e4475619ada5cb","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2014-04-02 18:25:43.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fffdbab054a076aaf3f3fb2a2b3c9682fad9e12e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 18:25:45.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b1e292f3311c8ceaf0b252c68ef9666a1745719d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 20:08:23.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-nova-docs http://docs-draft.openstack.org/55/84755/2/gate/gate-nova-docs/0a5ee6e/doc/build/html/ : SUCCESS in 7m 21s\n- gate-nova-pep8 http://logs.openstack.org/55/84755/2/gate/gate-nova-pep8/c0e1d87 : SUCCESS in 7m 47s\n- gate-nova-python26 http://logs.openstack.org/55/84755/2/gate/gate-nova-python26/7e64169 : SUCCESS in 16m 47s\n- gate-nova-python27 http://logs.openstack.org/55/84755/2/gate/gate-nova-python27/5a949dc : SUCCESS in 14m 52s\n- gate-tempest-dsvm-full http://logs.openstack.org/55/84755/2/gate/gate-tempest-dsvm-full/923be5f : SUCCESS in 40m 30s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/55/84755/2/gate/gate-tempest-dsvm-neutron/009cd2d : SUCCESS in 31m 52s\n- gate-devstack-dsvm-cells http://logs.openstack.org/55/84755/2/gate/gate-devstack-dsvm-cells/1f168ce : SUCCESS in 13m 02s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/55/84755/2/gate/gate-tempest-dsvm-postgres-full/ccc2640 : SUCCESS in 41m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/55/84755/2/gate/gate-tempest-dsvm-large-ops/eab625a : SUCCESS in 14m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/55/84755/2/gate/gate-tempest-dsvm-neutron-large-ops/2e9ee23 : SUCCESS in 14m 36s\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b98f8c92194cadc20d286064373317b3f914fcb5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 20:08:27.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"feedcb240807cdfa354d27ebe3a4b7f416504a62","revisions":{"63a5fc8ee9d4f965ff76bf99a58c9709fce36fa1":{"kind":"REWORK","_number":1,"created":"2014-04-02 15:25:53.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/55/84755/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/55/84755/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/84755/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/84755/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/84755/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/55/84755/1"}}},"commit":{"parents":[{"commit":"ecb058de339da8ee828b629c072f4dbb8541fc74","subject":"User a more accurate max_delay for reconnects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ecb058de339da8ee828b629c072f4dbb8541fc74"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2014-04-02 15:22:25.000000000","tz":0},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2014-04-02 15:22:25.000000000","tz":0},"subject":"Fix \u0027icehouse-compat\u0027 processing for compute rpc","message":"Fix \u0027icehouse-compat\u0027 processing for compute rpc\n\nCommit 2c63cae921d024f39f7d14459873d20caa5cf9e0 added some havana\nspecific rpc handling to aid with the live upgrade from havana to\nicehouse.  Unfortunately, the processing was broken for some\nmethods.  It would claim to be sending a \u00273.0\u0027 message, but would\nbe sending some of the arguments in an old format, causing some\nmethods to break when processed on the remote end.\n\nThis patch fixes up the logic to ensure that if messages are sent as\n\u00273.0\u0027, that the format of the data sent in the message matches.\n\nNote that this is a stable/havana specific change.\n\nChange-Id: I54135effe4e083f73cb7d912ac9e82fd182e2b2d\nCloses-bug: #1301436\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/63a5fc8ee9d4f965ff76bf99a58c9709fce36fa1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/63a5fc8ee9d4f965ff76bf99a58c9709fce36fa1"}]},"branch":"refs/heads/stable/havana"},"feedcb240807cdfa354d27ebe3a4b7f416504a62":{"kind":"REWORK","_number":2,"created":"2014-04-02 15:35:22.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/55/84755/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/55/84755/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/84755/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/84755/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/84755/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/55/84755/2"}}},"commit":{"parents":[{"commit":"ecb058de339da8ee828b629c072f4dbb8541fc74","subject":"User a more accurate max_delay for reconnects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ecb058de339da8ee828b629c072f4dbb8541fc74"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2014-04-02 15:22:25.000000000","tz":0},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2014-04-02 15:33:38.000000000","tz":0},"subject":"Fix \u0027icehouse-compat\u0027 processing for compute rpc","message":"Fix \u0027icehouse-compat\u0027 processing for compute rpc\n\nCommit 2c63cae921d024f39f7d14459873d20caa5cf9e0 added some havana\nspecific rpc handling to aid with the live upgrade from havana to\nicehouse.  Unfortunately, the processing was broken for some\nmethods.  It would claim to be sending a \u00273.0\u0027 message, but would\nbe sending some of the arguments in an old format, causing some\nmethods to break when processed on the remote end.\n\nThis patch fixes up the logic to ensure that if messages are sent as\n\u00273.0\u0027, that the format of the data sent in the message matches.\n\nNote that this is a stable/havana specific change.\n\nChange-Id: I54135effe4e083f73cb7d912ac9e82fd182e2b2d\nCloses-bug: #1301436\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/feedcb240807cdfa354d27ebe3a4b7f416504a62"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/feedcb240807cdfa354d27ebe3a4b7f416504a62"}]},"branch":"refs/heads/stable/havana"}},"requirements":[],"submit_records":[],"submit_requirements":[]}