)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f33d5881fdba7d17fddabf001e1537a1908ad432","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12596457_6600681e","updated":"2022-08-02 20:30:17.000000000","message":"this needs a release note.\nthe other comments are just me musing about the value of defaulting to false when we hard code to true.\n\nI would personally default to true but im fine with you following the existing pattern.\n\nthe -1 is just for the release note.\n\ncan you call this out in the feature section.\n","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1a223ea7698737604738c71a0dbaae265692056a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7173c16a_b667c872","in_reply_to":"12596457_6600681e","updated":"2022-08-02 20:48:17.000000000","message":"Release note added.","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4a5dffe3bacd30b935a6aac80da6151bbdf95102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d036fb85_106809f5","updated":"2022-08-09 08:31:57.000000000","message":"Looks good","commit_id":"57ab45323cf5617ebd2decd757e708673d949a8f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31261aadaef9139c0054b7f4dc0387bec002651d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a98e112_9ba0fc55","updated":"2022-08-09 15:12:13.000000000","message":"i think im happy enough to proceed with this.\n\nwe could perhaps update the docs to call this out but im not really sure we currently have anywhere that makes sense to document this so for now im happy enough with calling this out via a release note and leaving it at that.","commit_id":"57ab45323cf5617ebd2decd757e708673d949a8f"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1a223ea7698737604738c71a0dbaae265692056a","unresolved":true,"context_lines":[{"line_number":2738,"context_line":"        self.reset \u003d False"},{"line_number":2739,"context_line":"        self.frequencies \u003d False"},{"line_number":2740,"context_line":"        self.reenlightenment \u003d False"},{"line_number":2741,"context_line":"        self.tbflush \u003d False"},{"line_number":2742,"context_line":"        self.ipi \u003d False"},{"line_number":2743,"context_line":"        self.evmcs \u003d False"},{"line_number":2744,"context_line":"        self.vendorid_spoof \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0c754cc_70f3c49e","line":2741,"updated":"2022-08-02 20:48:17.000000000","message":"type, this should be tlbflush","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f33d5881fdba7d17fddabf001e1537a1908ad432","unresolved":true,"context_lines":[{"line_number":2728,"context_line":"        super(LibvirtConfigGuestFeatureHyperV, self).__init__(\"hyperv\","},{"line_number":2729,"context_line":"                                                              **kwargs)"},{"line_number":2730,"context_line":""},{"line_number":2731,"context_line":"        self.relaxed \u003d False"},{"line_number":2732,"context_line":"        self.vapic \u003d False"},{"line_number":2733,"context_line":"        self.spinlocks \u003d False"},{"line_number":2734,"context_line":"        self.spinlock_retries \u003d self.MIN_SPINLOCK_RETRIES"},{"line_number":2735,"context_line":"        self.vpindex \u003d False"},{"line_number":2736,"context_line":"        self.runtime \u003d False"},{"line_number":2737,"context_line":"        self.synic \u003d False"},{"line_number":2738,"context_line":"        self.reset \u003d False"},{"line_number":2739,"context_line":"        self.frequencies \u003d False"},{"line_number":2740,"context_line":"        self.reenlightenment \u003d False"},{"line_number":2741,"context_line":"        self.tbflush \u003d False"},{"line_number":2742,"context_line":"        self.ipi \u003d False"},{"line_number":2743,"context_line":"        self.evmcs \u003d False"},{"line_number":2744,"context_line":"        self.vendorid_spoof \u003d False"},{"line_number":2745,"context_line":"        self.vendorid \u003d self.SPOOFED_VENDOR_ID"},{"line_number":2746,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d0b32b00_25ab90e8","line":2743,"range":{"start_line":2731,"start_character":7,"end_line":2743,"end_character":26},"updated":"2022-08-02 20:30:17.000000000","message":"im half tempted to default these to true by the way.\nsince if we ever generate this element then they will be hard coded to true","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31261aadaef9139c0054b7f4dc0387bec002651d","unresolved":false,"context_lines":[{"line_number":2728,"context_line":"        super(LibvirtConfigGuestFeatureHyperV, self).__init__(\"hyperv\","},{"line_number":2729,"context_line":"                                                              **kwargs)"},{"line_number":2730,"context_line":""},{"line_number":2731,"context_line":"        self.relaxed \u003d False"},{"line_number":2732,"context_line":"        self.vapic \u003d False"},{"line_number":2733,"context_line":"        self.spinlocks \u003d False"},{"line_number":2734,"context_line":"        self.spinlock_retries \u003d self.MIN_SPINLOCK_RETRIES"},{"line_number":2735,"context_line":"        self.vpindex \u003d False"},{"line_number":2736,"context_line":"        self.runtime \u003d False"},{"line_number":2737,"context_line":"        self.synic \u003d False"},{"line_number":2738,"context_line":"        self.reset \u003d False"},{"line_number":2739,"context_line":"        self.frequencies \u003d False"},{"line_number":2740,"context_line":"        self.reenlightenment \u003d False"},{"line_number":2741,"context_line":"        self.tbflush \u003d False"},{"line_number":2742,"context_line":"        self.ipi \u003d False"},{"line_number":2743,"context_line":"        self.evmcs \u003d False"},{"line_number":2744,"context_line":"        self.vendorid_spoof \u003d False"},{"line_number":2745,"context_line":"        self.vendorid \u003d self.SPOOFED_VENDOR_ID"},{"line_number":2746,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4f23ebc4_19a0f7e6","line":2743,"range":{"start_line":2731,"start_character":7,"end_line":2743,"end_character":26},"in_reply_to":"2823ab43_7fef9e8c","updated":"2022-08-09 15:12:13.000000000","message":"Ack","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1a223ea7698737604738c71a0dbaae265692056a","unresolved":true,"context_lines":[{"line_number":2728,"context_line":"        super(LibvirtConfigGuestFeatureHyperV, self).__init__(\"hyperv\","},{"line_number":2729,"context_line":"                                                              **kwargs)"},{"line_number":2730,"context_line":""},{"line_number":2731,"context_line":"        self.relaxed \u003d False"},{"line_number":2732,"context_line":"        self.vapic \u003d False"},{"line_number":2733,"context_line":"        self.spinlocks \u003d False"},{"line_number":2734,"context_line":"        self.spinlock_retries \u003d self.MIN_SPINLOCK_RETRIES"},{"line_number":2735,"context_line":"        self.vpindex \u003d False"},{"line_number":2736,"context_line":"        self.runtime \u003d False"},{"line_number":2737,"context_line":"        self.synic \u003d False"},{"line_number":2738,"context_line":"        self.reset \u003d False"},{"line_number":2739,"context_line":"        self.frequencies \u003d False"},{"line_number":2740,"context_line":"        self.reenlightenment \u003d False"},{"line_number":2741,"context_line":"        self.tbflush \u003d False"},{"line_number":2742,"context_line":"        self.ipi \u003d False"},{"line_number":2743,"context_line":"        self.evmcs \u003d False"},{"line_number":2744,"context_line":"        self.vendorid_spoof \u003d False"},{"line_number":2745,"context_line":"        self.vendorid \u003d self.SPOOFED_VENDOR_ID"},{"line_number":2746,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2823ab43_7fef9e8c","line":2743,"range":{"start_line":2731,"start_character":7,"end_line":2743,"end_character":26},"in_reply_to":"d0b32b00_25ab90e8","updated":"2022-08-02 20:48:17.000000000","message":"Yeah, but our patterns seems to be to default everything to False, so I\u0027d rather stay internally consistent.","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f33d5881fdba7d17fddabf001e1537a1908ad432","unresolved":true,"context_lines":[{"line_number":6072,"context_line":""},{"line_number":6073,"context_line":"        if CONF.libvirt.virt_type in (\u0027qemu\u0027, \u0027kvm\u0027) and os_type \u003d\u003d \u0027windows\u0027:"},{"line_number":6074,"context_line":"            hv \u003d vconfig.LibvirtConfigGuestFeatureHyperV()"},{"line_number":6075,"context_line":"            hv.relaxed \u003d True"},{"line_number":6076,"context_line":""},{"line_number":6077,"context_line":"            hv.spinlocks \u003d True"},{"line_number":6078,"context_line":"            # Increase spinlock retries - value recommended by"},{"line_number":6079,"context_line":"            # KVM maintainers who certify Windows guests"},{"line_number":6080,"context_line":"            # with Microsoft"},{"line_number":6081,"context_line":"            hv.spinlock_retries \u003d 8191"},{"line_number":6082,"context_line":"            hv.vapic \u003d True"},{"line_number":6083,"context_line":"            hv.vpindex \u003d True"},{"line_number":6084,"context_line":"            hv.runtime \u003d True"},{"line_number":6085,"context_line":"            hv.synic \u003d True"},{"line_number":6086,"context_line":"            hv.reset \u003d True"},{"line_number":6087,"context_line":"            hv.frequencies \u003d True"},{"line_number":6088,"context_line":"            hv.reenlightenment \u003d True"},{"line_number":6089,"context_line":"            hv.tlbflush \u003d True"},{"line_number":6090,"context_line":"            hv.ipi \u003d True"},{"line_number":6091,"context_line":"            hv.evmcs \u003d True"},{"line_number":6092,"context_line":""},{"line_number":6093,"context_line":"            # NOTE(kosamara): Spoofing the vendor_id aims to allow the nvidia"},{"line_number":6094,"context_line":"            # driver to work on windows VMs. At the moment, the nvidia driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"957009f8_6576d4ee","line":6091,"range":{"start_line":6075,"start_character":12,"end_line":6091,"end_character":27},"updated":"2022-08-02 20:30:17.000000000","message":"if we set the defaults to true we could then remove theses lines.","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31261aadaef9139c0054b7f4dc0387bec002651d","unresolved":false,"context_lines":[{"line_number":6072,"context_line":""},{"line_number":6073,"context_line":"        if CONF.libvirt.virt_type in (\u0027qemu\u0027, \u0027kvm\u0027) and os_type \u003d\u003d \u0027windows\u0027:"},{"line_number":6074,"context_line":"            hv \u003d vconfig.LibvirtConfigGuestFeatureHyperV()"},{"line_number":6075,"context_line":"            hv.relaxed \u003d True"},{"line_number":6076,"context_line":""},{"line_number":6077,"context_line":"            hv.spinlocks \u003d True"},{"line_number":6078,"context_line":"            # Increase spinlock retries - value recommended by"},{"line_number":6079,"context_line":"            # KVM maintainers who certify Windows guests"},{"line_number":6080,"context_line":"            # with Microsoft"},{"line_number":6081,"context_line":"            hv.spinlock_retries \u003d 8191"},{"line_number":6082,"context_line":"            hv.vapic \u003d True"},{"line_number":6083,"context_line":"            hv.vpindex \u003d True"},{"line_number":6084,"context_line":"            hv.runtime \u003d True"},{"line_number":6085,"context_line":"            hv.synic \u003d True"},{"line_number":6086,"context_line":"            hv.reset \u003d True"},{"line_number":6087,"context_line":"            hv.frequencies \u003d True"},{"line_number":6088,"context_line":"            hv.reenlightenment \u003d True"},{"line_number":6089,"context_line":"            hv.tlbflush \u003d True"},{"line_number":6090,"context_line":"            hv.ipi \u003d True"},{"line_number":6091,"context_line":"            hv.evmcs \u003d True"},{"line_number":6092,"context_line":""},{"line_number":6093,"context_line":"            # NOTE(kosamara): Spoofing the vendor_id aims to allow the nvidia"},{"line_number":6094,"context_line":"            # driver to work on windows VMs. At the moment, the nvidia driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2ae1ad3_6bd8a00a","line":6091,"range":{"start_line":6075,"start_character":12,"end_line":6091,"end_character":27},"in_reply_to":"957009f8_6576d4ee","updated":"2022-08-09 15:12:13.000000000","message":"Ack","commit_id":"a4f761cee8b45c7205ea0536cf51042cb5e5b945"}]}