)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6030646727a291e23cbde4c852c28c404e6d0b9f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Using the test \"test_performance_check_select_destination\""},{"line_number":16,"context_line":"modifying it to use 200 hosts, the request time went from"},{"line_number":17,"context_line":"70ms to under 10ms."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We could reduce logging further, but this minimal change makes"},{"line_number":20,"context_line":"a massive impact. The next steps would require a config value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9q9w%3D","line":17,"updated":"2014-04-02 22:26:44.000000000","message":"Can\u0027t you get the same results by turning off debug logs?","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"255aeb479392991b65a7f5ca1cab0aca96746cf1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Using the test \"test_performance_check_select_destination\""},{"line_number":16,"context_line":"modifying it to use 200 hosts, the request time went from"},{"line_number":17,"context_line":"70ms to under 10ms."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We could reduce logging further, but this minimal change makes"},{"line_number":20,"context_line":"a massive impact. The next steps would require a config value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9nqY%3D","line":17,"in_reply_to":"AAAAWH%2F9q9w%3D","updated":"2014-04-03 10:06:08.000000000","message":"it doesn\u0027t seem that way, maybe its going through the translation code.","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"}],"nova/scheduler/filters/retry_filter.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6030646727a291e23cbde4c852c28c404e6d0b9f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        passes \u003d host not in hosts"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if not passes:"},{"line_number":42,"context_line":"            LOG.debug(_(\"Host %(host)s fails.  Previously tried hosts: \""},{"line_number":43,"context_line":"                        \"%(hosts)s\") % {\u0027host\u0027: host, \u0027hosts\u0027: hosts})"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Host passes if it\u0027s not in the list of previously attempted hosts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9q7k%3D","line":42,"updated":"2014-04-02 22:26:44.000000000","message":"you can make this faster but passing in the dictionary with a comma instead of \u0027%\u0027. That way the interpolation will only happen if the message is being used (debug logging is on).","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"255aeb479392991b65a7f5ca1cab0aca96746cf1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        passes \u003d host not in hosts"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if not passes:"},{"line_number":42,"context_line":"            LOG.debug(_(\"Host %(host)s fails.  Previously tried hosts: \""},{"line_number":43,"context_line":"                        \"%(hosts)s\") % {\u0027host\u0027: host, \u0027hosts\u0027: hosts})"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Host passes if it\u0027s not in the list of previously attempted hosts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9nqI%3D","line":42,"in_reply_to":"AAAAWH%2F9q7k%3D","updated":"2014-04-03 10:06:08.000000000","message":"yes, good point.","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"}],"nova/servicegroup/drivers/db.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ba15520275fed87fc2055d786100b2317fc30d70","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        elapsed \u003d timeutils.delta_seconds(last_heartbeat, timeutils.utcnow())"},{"line_number":70,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d CONF.service_down_time"},{"line_number":71,"context_line":"        if not is_up:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027DB_Driver.is_up last_heartbeat \u003d %(lhb)s elapsed \u003d %(el)s\u0027)"},{"line_number":73,"context_line":"            LOG.debug(msg, {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":74,"context_line":"        return is_up"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9s8o%3D","line":72,"updated":"2014-04-02 17:37:07.000000000","message":"How about changing the log message to:\n\n \"Seems service is down. Last heartbeat was %(lhb)s. Elapsed time is %(el)s\"","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"255aeb479392991b65a7f5ca1cab0aca96746cf1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        elapsed \u003d timeutils.delta_seconds(last_heartbeat, timeutils.utcnow())"},{"line_number":70,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d CONF.service_down_time"},{"line_number":71,"context_line":"        if not is_up:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027DB_Driver.is_up last_heartbeat \u003d %(lhb)s elapsed \u003d %(el)s\u0027)"},{"line_number":73,"context_line":"            LOG.debug(msg, {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":74,"context_line":"        return is_up"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9npc%3D","line":72,"in_reply_to":"AAAAWH%2F9q8I%3D","updated":"2014-04-03 10:06:08.000000000","message":"Yeah, its a bit late if you spot this in the log, and yes, that can get too chatty I suspect.\n\nI can update the log message, was trying not to change the log messages here really.","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8c260216f29fe1e52fdf5f6eff3a22e158b36427","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        elapsed \u003d timeutils.delta_seconds(last_heartbeat, timeutils.utcnow())"},{"line_number":70,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d CONF.service_down_time"},{"line_number":71,"context_line":"        if not is_up:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027DB_Driver.is_up last_heartbeat \u003d %(lhb)s elapsed \u003d %(el)s\u0027)"},{"line_number":73,"context_line":"            LOG.debug(msg, {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":74,"context_line":"        return is_up"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9snE%3D","line":72,"in_reply_to":"AAAAWH%2F9s8o%3D","updated":"2014-04-02 18:14:21.000000000","message":"I think Jay\u0027s suggestion would be beneficial here…","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6030646727a291e23cbde4c852c28c404e6d0b9f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        elapsed \u003d timeutils.delta_seconds(last_heartbeat, timeutils.utcnow())"},{"line_number":70,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d CONF.service_down_time"},{"line_number":71,"context_line":"        if not is_up:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027DB_Driver.is_up last_heartbeat \u003d %(lhb)s elapsed \u003d %(el)s\u0027)"},{"line_number":73,"context_line":"            LOG.debug(msg, {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":74,"context_line":"        return is_up"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9q8I%3D","line":72,"in_reply_to":"AAAAWH%2F9snE%3D","updated":"2014-04-02 22:26:44.000000000","message":"This info is useful for debugging even if the service is up, it can show you if you have NTP issues etc.\n\nWhat about making this a INFO \"if not is_up\", else make it a debug log. Then again in a big cloud that may be a bit chatty.","commit_id":"f2baf2df0cd9e2cdbcdaf49f3a1c694515fa7453"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"6b8d6a306ae09be7bb54d8c57f5367f3ef72a85f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d CONF.service_down_time"},{"line_number":71,"context_line":"        if not is_up:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Seems service is down. Last heartbeat was %(lhb)s. \u0027"},{"line_number":73,"context_line":"                    \u0027Elapsed time is %(el)s\u0027)"},{"line_number":74,"context_line":"            LOG.debug(msg, {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":75,"context_line":"        return is_up"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9mM0%3D","line":73,"updated":"2014-04-03 13:13:43.000000000","message":"A little bit odd to print elapsed time when it is know from message timestamp and last heartbeat.","commit_id":"93f29574c416aebcd1bd7527d3007664aa073766"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"7f1edd249bd9397c0d11c09cacedca649556eadd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        is_up \u003d abs(elapsed) \u003c\u003d CONF.service_down_time"},{"line_number":71,"context_line":"        if not is_up:"},{"line_number":72,"context_line":"            msg \u003d _(\u0027Seems service is down. Last heartbeat was %(lhb)s. \u0027"},{"line_number":73,"context_line":"                    \u0027Elapsed time is %(el)s\u0027)"},{"line_number":74,"context_line":"            LOG.debug(msg, {\u0027lhb\u0027: str(last_heartbeat), \u0027el\u0027: str(elapsed)})"},{"line_number":75,"context_line":"        return is_up"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9khM%3D","line":73,"in_reply_to":"AAAAWH%2F9mM0%3D","updated":"2014-04-03 16:08:51.000000000","message":"Unless I misunderstand, sometimes it\u0027s easier to have the computer do the math for you IMO ;-)","commit_id":"93f29574c416aebcd1bd7527d3007664aa073766"}]}