)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"4617157ce1bc7d490bdf2392c57667fc5fb715b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2afb1d2c_7a645690","updated":"2022-07-15 09:42:52.000000000","message":"I backported the patch to Debian in the Yoga release, and it fixed the 2 unit test failures for me. So big +1 and thanks to Stephen for this work.\n\nI\u0027m now investigating Ironic and Sahara failures.","commit_id":"bbc3f3aeb7f002d570534ca62c3ae1f2388f2dbe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c8c774ba214c3fb33f457550ad112e920f21c3b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8c51dc4_02f0b33e","updated":"2022-07-14 14:54:24.000000000","message":"Looks good.","commit_id":"bbc3f3aeb7f002d570534ca62c3ae1f2388f2dbe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"297ec7bc4eeab88f81a08a4ebcae673ffc027be8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79ecb6eb_1e53b20f","updated":"2022-07-15 14:25:23.000000000","message":"Thanks Stephen i expect this to now pass the requiremtnes check job so +2","commit_id":"2e02f6cff04ff982e0517ded92b6ee0fcb898655"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f91b30baa76c74d8daf11d5d1af5cf1a09a8fd8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3418ca4_71b934d9","updated":"2022-07-18 17:36:07.000000000","message":"Looks OK to me. This is needed in order to bump the version of jsonschema in the openstack/requirements repo:\n\nhttps://review.opendev.org/c/openstack/requirements/+/849102","commit_id":"2709e30956b53be1dca91eec801220f0efbaed93"}],"nova/tests/unit/compute/test_provider_config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41573a79fb45379a064ee4927f3164280ef3d190","unresolved":true,"context_lines":[{"line_number":119,"context_line":"    @ddt.unpack"},{"line_number":120,"context_line":"    @ddt.file_data(\u0027provider_config_data/v1/validation_error_test_data.yaml\u0027)"},{"line_number":121,"context_line":"    def test_validation_errors(self, config, expected_messages):"},{"line_number":122,"context_line":"        # TODO(stephenfin): Drop this once we no longer support jsonschema 3.x"},{"line_number":123,"context_line":"        jsonschema_version \u003d importlib.metadata.version(\u0027jsonschema\u0027)"},{"line_number":124,"context_line":"        if version.parse(jsonschema_version) \u003c version.parse(\u00274.0.0\u0027):"},{"line_number":125,"context_line":"            if expected_messages \u003d\u003d ["},{"line_number":126,"context_line":"                \"should not be valid under {}\","},{"line_number":127,"context_line":"                \"validating \u0027not\u0027 in schema[\u0027properties\u0027][\u0027__source_file\u0027]\","},{"line_number":128,"context_line":"            ]:"},{"line_number":129,"context_line":"                expected_messages \u003d ["},{"line_number":130,"context_line":"                    \"{} is not allowed for\","},{"line_number":131,"context_line":"                    \"validating \u0027not\u0027 in schema[\u0027properties\u0027][\u0027__source_file\u0027]\",  # noqa: E501"},{"line_number":132,"context_line":"                ]"},{"line_number":133,"context_line":"        self.run_test_validation_errors(config, expected_messages)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @ddt.unpack"},{"line_number":136,"context_line":"    @ddt.file_data(\u0027provider_config_data/v1/validation_success_test_data.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"11e8ab21_1e3b6712","line":133,"range":{"start_line":122,"start_character":0,"end_line":133,"end_character":66},"updated":"2023-02-22 18:49:54.000000000","message":"actually asserting on the error message which is never a stable interface is bad idea from starting itslef. We should check error code instead but at same time we need to check some of them to assert on exact error due to variant of different schema data. \n\nat least we should keep the latest error message instead of depending on jsonscheme version which is what you are doing in https://review.opendev.org/c/openstack/nova/+/850021 . thanks","commit_id":"2709e30956b53be1dca91eec801220f0efbaed93"}],"requirements.txt":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c8c774ba214c3fb33f457550ad112e920f21c3b6","unresolved":true,"context_lines":[{"line_number":67,"context_line":"openstacksdk\u003e\u003d0.35.0 # Apache-2.0"},{"line_number":68,"context_line":"dataclasses\u003e\u003d0.7;python_version\u003d\u003d\u00273.6\u0027  # Apache 2.0 License"},{"line_number":69,"context_line":"PyYAML\u003e\u003d5.1 # MIT"},{"line_number":70,"context_line":"packaging  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"34db0006_dea4313f","line":70,"updated":"2022-07-14 14:54:24.000000000","message":"OK, this is in global-requirements","commit_id":"bbc3f3aeb7f002d570534ca62c3ae1f2388f2dbe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"73f4baded36cbf4726675d81f112e1ec7703e771","unresolved":true,"context_lines":[{"line_number":67,"context_line":"openstacksdk\u003e\u003d0.35.0 # Apache-2.0"},{"line_number":68,"context_line":"dataclasses\u003e\u003d0.7;python_version\u003d\u003d\u00273.6\u0027  # Apache 2.0 License"},{"line_number":69,"context_line":"PyYAML\u003e\u003d5.1 # MIT"},{"line_number":70,"context_line":"packaging  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"42be6356_933a5aa7","line":70,"in_reply_to":"34db0006_dea4313f","updated":"2022-07-14 16:49:14.000000000","message":"ya but without a min version our check job is still unhappy\n\nValidating requirements.txt\nERROR: Requirement \u0027{Requirement(package\u003d\u0027dataclasses\u0027, location\u003d\u0027\u0027, specifiers\u003d\u0027\u003e\u003d0.7\u0027, markers\u003d\"python_version\u003d\u003d\u00273.6\u0027\", comment\u003d\u0027# Apache 2.0 License\u0027, extras\u003dfrozenset())}\u0027 not in openstack/requirements\nERROR: Requirement for package \u0027packaging\u0027 has no lower bound\n\nso i would set it eitehr to the current verion or if you want to find the actual min version then do.","commit_id":"bbc3f3aeb7f002d570534ca62c3ae1f2388f2dbe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"297ec7bc4eeab88f81a08a4ebcae673ffc027be8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"openstacksdk\u003e\u003d0.35.0 # Apache-2.0"},{"line_number":68,"context_line":"dataclasses\u003e\u003d0.7;python_version\u003d\u003d\u00273.6\u0027  # Apache 2.0 License"},{"line_number":69,"context_line":"PyYAML\u003e\u003d5.1 # MIT"},{"line_number":70,"context_line":"packaging  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"7a077e8e_a6db510a","line":70,"in_reply_to":"42be6356_933a5aa7","updated":"2022-07-15 14:25:23.000000000","message":"Done","commit_id":"bbc3f3aeb7f002d570534ca62c3ae1f2388f2dbe"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"34477ebca24c2c224083c1edd594f0e7f2906fa5","unresolved":true,"context_lines":[{"line_number":65,"context_line":"python-dateutil\u003e\u003d2.7.0 # BSD"},{"line_number":66,"context_line":"futurist\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":67,"context_line":"openstacksdk\u003e\u003d0.35.0 # Apache-2.0"},{"line_number":68,"context_line":"dataclasses\u003e\u003d0.7;python_version\u003d\u003d\u00273.6\u0027  # Apache 2.0 License"},{"line_number":69,"context_line":"PyYAML\u003e\u003d5.1 # MIT"},{"line_number":70,"context_line":"packaging\u003e\u003d21.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1318d161_7ddace60","line":68,"updated":"2022-07-15 19:44:19.000000000","message":"There is still one error left:\n\n ERROR: Requirement \u0027{Requirement(package\u003d\u0027dataclasses\u0027, location\u003d\u0027\u0027, specifiers\u003d\u0027\u003e\u003d0.7\u0027, markers\u003d\"python_version\u003d\u003d\u00273.6\u0027\", comment\u003d\u0027# Apache 2.0 License\u0027, extras\u003dfrozenset())}\u0027 not in openstack/requirements\n \nIt\u0027s true that dataclasses is not in global-requirements [1] ... but then how was this working before? 🤔\n \n [1] https://github.com/openstack/requirements/blob/dd5375f5291e0353c7fa05e48c50116dba9c6e9e/global-requirements.txt","commit_id":"2e02f6cff04ff982e0517ded92b6ee0fcb898655"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"07af0f38a97f027fb99ce0c6594ba881df92b85d","unresolved":true,"context_lines":[{"line_number":65,"context_line":"python-dateutil\u003e\u003d2.7.0 # BSD"},{"line_number":66,"context_line":"futurist\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":67,"context_line":"openstacksdk\u003e\u003d0.35.0 # Apache-2.0"},{"line_number":68,"context_line":"dataclasses\u003e\u003d0.7;python_version\u003d\u003d\u00273.6\u0027  # Apache 2.0 License"},{"line_number":69,"context_line":"PyYAML\u003e\u003d5.1 # MIT"},{"line_number":70,"context_line":"packaging\u003e\u003d21.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"8286d50c_13e7143b","line":68,"in_reply_to":"1318d161_7ddace60","updated":"2022-07-16 14:33:52.000000000","message":"this is fixed in the next patch so i guess we just need to change the order","commit_id":"2e02f6cff04ff982e0517ded92b6ee0fcb898655"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"92c2ff937a67c5b60969b6556dbf240bc1631205","unresolved":false,"context_lines":[{"line_number":65,"context_line":"python-dateutil\u003e\u003d2.7.0 # BSD"},{"line_number":66,"context_line":"futurist\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":67,"context_line":"openstacksdk\u003e\u003d0.35.0 # Apache-2.0"},{"line_number":68,"context_line":"dataclasses\u003e\u003d0.7;python_version\u003d\u003d\u00273.6\u0027  # Apache 2.0 License"},{"line_number":69,"context_line":"PyYAML\u003e\u003d5.1 # MIT"},{"line_number":70,"context_line":"packaging\u003e\u003d21.0  # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"193ca05f_87c5560e","line":68,"in_reply_to":"8286d50c_13e7143b","updated":"2022-07-18 15:47:09.000000000","message":"fwiw, this worked because the requirements job only runs on changes to requirements files. Previously this requirement was listed in global-requirements.txt in openstack/requirements but it was removed at some point since the requirements job last run on nova (or the last time we noticed it running)","commit_id":"2e02f6cff04ff982e0517ded92b6ee0fcb898655"}]}