)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9227757ca73aabe83224abb901db582660fdc038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"00fc17d2_d731beca","updated":"2023-01-25 18:06:42.000000000","message":"Ideally this should be before we expose the feature in the previous (API) patch. Without moving this before the API patch we need to be very careful to land the API and this patch in the same release. So if it is not super hard then please move this before the API patch.","commit_id":"15964c158fa5575abea57a5e8ebed37d7fb53f37"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"19e88df81eadcb778e25bc51b36bd35466392a0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"9fa7c47d_c1114f58","updated":"2024-01-30 12:42:15.000000000","message":"Could you squash this into the previous patch as this means now that we first publish the API then we add the upgrade check","commit_id":"b453c44fdaa3c7838a3f0c894941f3e5ca43a847"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6c6df4abbf96bdd27503d98abab3670f31973836","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"05c8a7ca_5a8d7ff9","in_reply_to":"9fa7c47d_c1114f58","updated":"2024-02-28 13:49:33.000000000","message":"I keep this on hold for the moment to make the patch smaller. I will merge as soon as the API patch will be ok.","commit_id":"b453c44fdaa3c7838a3f0c894941f3e5ca43a847"}],"nova/api/openstack/compute/server_shares.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af512cadd1843608d722c46d051418118d483c81","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from nova.objects import share_mapping as sm"},{"line_number":28,"context_line":"from nova.policies import server_shares as ss_policies"},{"line_number":29,"context_line":"from nova.share import manila"},{"line_number":30,"context_line":"from nova.virt import hardware as hw"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _get_instance_mapping(context, server_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"8b4a795c_8bfd22db","line":30,"updated":"2023-01-25 18:19:35.000000000","message":"this is a bit scary. This is the first time we import virt/hardware from the nova.api package.","commit_id":"15964c158fa5575abea57a5e8ebed37d7fb53f37"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7bdb73c79fa63263c252b50666516eabd15b2a45","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from nova.objects import share_mapping as sm"},{"line_number":28,"context_line":"from nova.policies import server_shares as ss_policies"},{"line_number":29,"context_line":"from nova.share import manila"},{"line_number":30,"context_line":"from nova.virt import hardware as hw"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _get_instance_mapping(context, server_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5b93faa7_f4a6b31f","line":30,"in_reply_to":"8b4a795c_8bfd22db","updated":"2023-01-30 09:39:40.000000000","message":"It could be elsewhere. I could be wrong, or I may not have understood well, but I think Sean suggested that this could be in the hardware part.","commit_id":"15964c158fa5575abea57a5e8ebed37d7fb53f37"}],"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af512cadd1843608d722c46d051418118d483c81","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                raise exception.ForbiddenWithShare()"},{"line_number":389,"context_line":"            return func(self, context, instance, *args, **kwargs)"},{"line_number":390,"context_line":"        return wrapper"},{"line_number":391,"context_line":"    return inner"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"def instance_has_share(context, instance):"}],"source_content_type":"text/x-python","patch_set":16,"id":"a9835a92_7e8ebe69","line":391,"updated":"2023-01-25 18:19:35.000000000","message":"double wrapping is not needed here as the decorate does not have any parameter at the momemnt. But I\u0027m OK to keep this as is as I assume you will have a parameter later when you selectively enable certain operators.","commit_id":"15964c158fa5575abea57a5e8ebed37d7fb53f37"}],"nova/virt/hardware.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af512cadd1843608d722c46d051418118d483c81","unresolved":true,"context_lines":[{"line_number":2725,"context_line":"    return None"},{"line_number":2726,"context_line":""},{"line_number":2727,"context_line":""},{"line_number":2728,"context_line":"def check_shares_supported(context, instance):"},{"line_number":2729,"context_line":"    \"\"\"Check that the compute version support shares and required traits and"},{"line_number":2730,"context_line":"    instance extra specs are configured."},{"line_number":2731,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"28894b57_083f9e4a","line":2728,"updated":"2023-01-25 18:19:35.000000000","message":"I\u0027m not sure this is a good place for this util called from the nova.api package. @Sylvain how do you feel about it?","commit_id":"15964c158fa5575abea57a5e8ebed37d7fb53f37"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7bdb73c79fa63263c252b50666516eabd15b2a45","unresolved":true,"context_lines":[{"line_number":2725,"context_line":"    return None"},{"line_number":2726,"context_line":""},{"line_number":2727,"context_line":""},{"line_number":2728,"context_line":"def check_shares_supported(context, instance):"},{"line_number":2729,"context_line":"    \"\"\"Check that the compute version support shares and required traits and"},{"line_number":2730,"context_line":"    instance extra specs are configured."},{"line_number":2731,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"d32b19ee_dc959f24","line":2728,"in_reply_to":"28894b57_083f9e4a","updated":"2023-01-30 09:39:40.000000000","message":"Please see comment on #30.","commit_id":"15964c158fa5575abea57a5e8ebed37d7fb53f37"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6ada984a8c6ed6c7163f34cffd1ed78f84b57a14","unresolved":true,"context_lines":[{"line_number":2752,"context_line":"    if not ("},{"line_number":2753,"context_line":"        ("},{"line_number":2754,"context_line":"            \u0027COMPUTE_STORAGE_VIRTIO_FS\u0027 in trait_info.traits and"},{"line_number":2755,"context_line":"            \u0027COMPUTE_MEM_BACKING_FILE\u0027 in trait_info.traits"},{"line_number":2756,"context_line":"        ) or"},{"line_number":2757,"context_line":"        ("},{"line_number":2758,"context_line":"            \u0027COMPUTE_STORAGE_VIRTIO_FS\u0027 in trait_info.traits and"}],"source_content_type":"text/x-python","patch_set":22,"id":"ad5440da_7e1a07a6","line":2755,"updated":"2023-03-13 18:24:32.000000000","message":"I was able to reconfigure a nova-compute from normal ram to file backed ram while it had a VM running (on normal ram). So we might need to be worried that there can be computes out there with file backed memory configured but with VMs running on real ram. I know that this is not directly related to this feature but I think we should have a block in the nova-compute startup when nova is reconfigured to file backed memory while there are VMs on the host as it can lead to issue with this check, but also can result in resource allocation inconsistencies.","commit_id":"424cdb43cf49987fbe302c8025512d4dd92a6ee8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4f7b0ba90faa06a707fd702c3ae3183c7c5246d2","unresolved":true,"context_lines":[{"line_number":2752,"context_line":"    if not ("},{"line_number":2753,"context_line":"        ("},{"line_number":2754,"context_line":"            \u0027COMPUTE_STORAGE_VIRTIO_FS\u0027 in trait_info.traits and"},{"line_number":2755,"context_line":"            \u0027COMPUTE_MEM_BACKING_FILE\u0027 in trait_info.traits"},{"line_number":2756,"context_line":"        ) or"},{"line_number":2757,"context_line":"        ("},{"line_number":2758,"context_line":"            \u0027COMPUTE_STORAGE_VIRTIO_FS\u0027 in trait_info.traits and"}],"source_content_type":"text/x-python","patch_set":22,"id":"f5bf7437_a15d83f7","line":2755,"in_reply_to":"ad5440da_7e1a07a6","updated":"2023-03-13 18:25:17.000000000","message":"I think having a bug report is a must, but I hope you can add a follow up later doing a nova-compute startup check to avoid this reconfiguration.","commit_id":"424cdb43cf49987fbe302c8025512d4dd92a6ee8"}]}