)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29ce3a9ea1b08bd87fcc00699007dbe2a2a4c34c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"1a436905_042af899","updated":"2024-01-30 10:23:11.000000000","message":"I tried this in my devstack. \nI have a VM where I can mount the manila share attached and the guest xml has the filesystem device.\n\n```\n    \u003cfilesystem type\u003d\u0027mount\u0027 accessmode\u003d\u0027passthrough\u0027\u003e\n      \u003cdriver type\u003d\u0027virtiofs\u0027/\u003e\n      \u003cbinary path\u003d\u0027/usr/lib/qemu/virtiofsd\u0027/\u003e\n      \u003csource dir\u003d\u0027/opt/stack/data/nova/mnt/05e2b0b35fb7d5cc2282c1704928329f\u0027/\u003e\n      \u003ctarget dir\u003d\u002706580c76-c01b-4650-a162-42b8586977ae\u0027/\u003e\n      \u003calias name\u003d\u0027fs0\u0027/\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x03\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/filesystem\u003e\n```\n\nBut the metadata on the config drive does not show the device\n\n```\nroot@vm1:~# mount /dev/sr0 ./b\nmount: /root/b: WARNING: source write-protected, mounted read-only.\nroot@vm1:~# ll ./b\ntotal 10\ndr-xr-xr-x  4 root root 2048 Jan 30 10:15 ./\ndrwx------  7 root root 4096 Jan 30 10:19 ../\ndr-xr-xr-x  4 root root 2048 Jan 30 10:15 ec2/\ndr-xr-xr-x 12 root root 2048 Jan 30 10:15 openstack/\nroot@vm1:~# ll ./b/openstack/\ntotal 24\ndr-xr-xr-x 12 root root 2048 Jan 30 10:15 ./\ndr-xr-xr-x  4 root root 2048 Jan 30 10:15 ../\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2012-08-10/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2013-04-04/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2013-10-17/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2015-10-15/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2016-06-30/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2016-10-06/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2017-02-22/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2018-08-27/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 2020-10-14/\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 latest/\nroot@vm1:~# ll ./b/openstack/latest/\ntotal 7\ndr-xr-xr-x  2 root root 2048 Jan 30 10:15 ./\ndr-xr-xr-x 12 root root 2048 Jan 30 10:15 ../\n-r--r--r--  1 root root  960 Jan 30 10:15 meta_data.json\n-r--r--r--  1 root root    2 Jan 30 10:15 network_data.json\n-r--r--r--  1 root root    2 Jan 30 10:15 vendor_data.json\n-r--r--r--  1 root root   14 Jan 30 10:15 vendor_data2.json\nroot@vm1:~# cat ./b/openstack/latest/meta_data.json \n{\"uuid\": \"d546d783-bd8c-4814-b557-31cdee3bdfdd\", \"admin_pass\": \"hiHAh4xvYxdb\", \"hostname\": \"vm1.novalocal\", \"name\": \"vm1\", \"launch_index\": 0, \"availability_zone\": \"nova\", \"random_seed\": \"aYxigKnM4RDh3u1LLhjnBEfPoSQRK4mMO0VYBj+p0D2gAB8dE0plispbOZGmvomNIkmv0FLfbyXvSYQ66KYfuTlnpIeavSOwfPx4yArK/dPZhtH8wBS++ZgdqkRNYnxb3mFSrKsYQGp3gSzspvz1EqvD+v30zBVwNiAB4yvbIz6p0OHOTiVE+A1YH7Ks3CfIZuy4brlzUFB2wujArBzlozKjyJ1E7LFfOZyNjdQG79bsE9Ce/BxN6A37Jj242RJ1tiNAQZto69EUjyR32H9pF24LsN3pDb83wWdiR68bRo3CNzaY/5S6AF3Ufd5QMQCBl6mRpd09oXvOuMAo67stg/I75KLyVG43qN7v2iLNSscMxfGIpF7N4EEFibczbcLF69xp65WBxqarQjIdRBNDueVRof3i6SQVC8Lce6qRlVdU/oEREMlPmqFkORRJy2XrWeqiJOMFrFp3Rm0yQAlclt2xgeR7symKNc8iK3yD8Ua3fC+wxx/r88WdSfsbrvkUEebRC3gn06oSLj97rWfNV3n4dO52WfXGaREDadt62P9bePioHCO/sRi92RGdAImmSQNg7CyModH6T3teqkrGle7wKaWKM1bzTQQ16bCHa6E84QbRAS9fd6WPQatFLal1VFMc2qGT+R03FkVgjp8e2Q6L2fnvAX0xD8/HePmfIZU\u003d\", \"project_id\": \"c4535a6a79b64102ab30f49fe2723def\", \"devices\": [], \"dedicated_cpus\": []}root@vm1:~# \n\n```","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"37a5bd9cfa43aa967b29629beec96f4a4fb54fd8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"2e6dea03_ddd38a0f","in_reply_to":"1a436905_042af899","updated":"2024-01-30 10:24:26.000000000","message":"Does it happen because we need to\n1. boot VM -\u003e config drive generated\n2. stop the VM \n3. attach the share\n4. start the VM -\u003e metadata regenerated with the device but the config drive does not","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"772864c77e9631724062a832edc5317a75766559","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"b24d0878_d18bf88b","in_reply_to":"2e6dea03_ddd38a0f","updated":"2024-01-30 10:38:39.000000000","message":"I also checked the metadata response but I don\u0027t see it there either:\n```\nroot@vm1:~# curl 169.254.169.254/latest/meta-data\nami-id\nami-launch-index\nami-manifest-path\nblock-device-mapping/\nhostname\ninstance-action\ninstance-id\ninstance-type\nlocal-hostname\nlocal-ipv4\nplacement/\npublic-hostname\npublic-ipv4\nreservation-id\nsecurity-groups\nroot@vm1:~#\n```","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f891e950f82e99dee799e82b257b57785584e5b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"7829838f_c3dcbe97","in_reply_to":"2f61fc54_0046a932","updated":"2024-05-28 09:04:31.000000000","message":"We need to document that the config drive will not show the share information. Also it worth to file a bug on this and link it to https://review.opendev.org/c/openstack/nova-specs/+/863884 as if that spec will lead to an implementation of a generic config drive regeneration code then the manila feature could use that too to trigger the regeneration of the config drive when a share is attached.","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"49f0fadf4b9b7dc1d919388d7ba72b3130b4267b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"7c5ac45c_e4422cc0","in_reply_to":"4b29518e_2da47abc","updated":"2024-09-23 14:58:05.000000000","message":"I have added this as a known bug in the documentation of this series.\nI\u0027m going to open an upstream bug, as mentioned above.","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"86bd99db8c7e769d8b7e710306f85bf079561985","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"4b29518e_2da47abc","in_reply_to":"7829838f_c3dcbe97","updated":"2024-07-02 11:29:31.000000000","message":"Is there a bug to track to fix do the config drive regeneration after the generic spec https://review.opendev.org/c/openstack/nova-specs/+/863884 is implemented?","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a837ea91b083144e54b9cbb5e167ca4a4db703a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"e7095921_15fef21f","in_reply_to":"7c5ac45c_e4422cc0","updated":"2024-10-11 11:46:58.000000000","message":"Do you have a link to the upstream bug?","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07a865c8cbcaa3b43ffee204909e0d1564628488","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"2f61fc54_0046a932","in_reply_to":"b24d0878_d18bf88b","updated":"2024-01-30 10:40:43.000000000","message":"OK so it is not in the ec2 metadata response but it is in the openstack metadata respone:\n```\nvendor_data2.jsonroot@vm1:~# curl 169.254.169.254/openstack/latest/meta_data.json\n{\"uuid\": \"3a08b81b-668a-4f1f-a63f-efe98ddf0f39\", \"hostname\": \"vm1.novalocal\", \"name\": \"vm1\", \"launch_index\": 0, \"availability_zone\": \"nova\", \"random_seed\": \"mCmEsuESHl8pDVl3CjnzORJOvgAxhWd6ykrWL/VNBkC1HmIppqLc3cjGkeRI0+RecFH3YwsbpMyb5KUdJrYSvfhvodmL2TZk5LxQnW3s+DzAPOfKgWvJq1qzNv8gFYQLOYQcGa4y1b42Ij51ez9yjPNmo0ZAuc1tn27u3dfVsJ8gnhFQf8YkzR5qvksaVZr1PeayJ+/4zbdKsd6zAw7RlL6/aH/2UJVkqY2xXu7yWN7aVBOySSt1sJXvesuxwlYGQ5gwSJudg19r3rqIs8nWxxXqJb+MyHLRJrHs+HJ3nMeog/NF1dUXG0rwdZUKhYMwrKTkPkkmt3BYHhtZm8OOY8+Rd9vDc9NAkel2jnhi2UsVwjzOULQzoELHSmaYo8AaILtNWncXURwrR1IyN0wr5ix+LkIhSZQmmN0Ru2b+5okju2kRfG9/JjZEO0rAcfEaqPfpoVjFhuLOZWdVV7IsbEVr27niNu9GNaiItimC8P8J+XpvC/z05mvaY/pU2V2FxvoQe6ezuBKw4WP/V4zRuAhxdKyvBNOjCYK2/473i2z/m3qupasJy6iESLAiuHi6nBru4t1vz+HH9Mp9Cu0piaDwaAp8j8eX/6od25yVwvR4KZQDK9rRt1TEJP/XifSNzVIJuFdRB5p7ES8iAG3CD4mRufVVe5hipfrbJYlOWec\u003d\", \"project_id\": \"c4535a6a79b64102ab30f49fe2723def\", \"devices\": [{\"type\": \"share\", \"share_id\": \"06580c76-c01b-4650-a162-42b8586977ae\", \"tag\": \"06580c76-c01b-4650-a162-42b8586977ae\", \"bus\": \"none\", \"address\": \"none\"}], \"dedicated_cpus\": []}root@vm1:~# \n```\n\nSo the only problem is that shares metadata won\u0027t appear in the config drive.","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"e0abe5804a9e75d66c4e81efbcea338a1784b60a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"7a648878_5c7a5271","in_reply_to":"e7095921_15fef21f","updated":"2024-11-18 14:28:40.000000000","message":"Here is it: https://bugs.launchpad.net/nova/+bug/2088464","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"53bc4f8ec1b23549dafb07d7d9ab605adac2e249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"023a4530_0d91297c","updated":"2024-08-28 13:19:56.000000000","message":"This has two open issue:\n* the metadata versioning \n* a tracking bug to revisit the config drive case after the config drive regeneration bp is merged.","commit_id":"17c5f35ee2d38f0da4ba1f77ac2b662289a4927b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15d56c12f60d180abcf74d412e1129478cf6a3c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"b3739b06_76c30db9","updated":"2024-11-13 15:01:38.000000000","message":"There is no reason to hold that patch hence the +1 but I agree with the fact we should mention that configdrive won\u0027t show the shares. +2 once the series is fully +1d.","commit_id":"7203b37b4886033f28c936403d1cd6003267a455"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"040824fa207d26623f7c79a46c177f7d19801c6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"0b85d48b_395b391a","updated":"2024-11-15 10:29:35.000000000","message":"Code looks good to me. Please file a follow up bug about config drive refresh.","commit_id":"ba786c0536e0d88dc1e076615266a6ca3ae59ad4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"520e1b72aad96ad5b2dc95e0da8b3c0eb4322090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"7beeaf30_11f4ea7a","updated":"2024-11-20 15:04:54.000000000","message":"Thanks for the bug report I\u0027m upgrading my vote.","commit_id":"8f6fc37789ef954156aa28225ad794af6c4f270e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"962b50532872c4e1920a67552627263d3c51202a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"958a2650_4d9177b1","updated":"2024-11-23 09:17:18.000000000","message":"recheck POST_FAILURE","commit_id":"5bc088de0d91f0bc4c3b29ca56d9d00fb32831a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"453ef296fe4ae35943b5ab2b25bc4cff1582f470","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"6abaad39_8553fba9","updated":"2024-11-26 04:17:32.000000000","message":"recheck kernel panic /sbin/init: can\u0027t load library \u0027libtirpc.so.3\u0027","commit_id":"5bc088de0d91f0bc4c3b29ca56d9d00fb32831a6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2b265de817d8838e5a5f4f0626299762302cd26a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"37b4c994_cec23305","updated":"2024-11-25 12:42:39.000000000","message":"recheck ssh to guest timed out in a rescue test","commit_id":"5bc088de0d91f0bc4c3b29ca56d9d00fb32831a6"}],"nova/api/metadata/base.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e24c276558b8b60a6118eada0cddf5b996e80672","unresolved":true,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if self._check_os_version(VICTORIA, version):"},{"line_number":364,"context_line":"            metadata[\u0027dedicated_cpus\u0027] \u003d self._get_instance_dedicated_cpus()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.set_mimetype(MIME_TYPE_APPLICATION_JSON)"},{"line_number":367,"context_line":"        return jsonutils.dump_as_bytes(metadata)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"82de09a5_ca84bf18","line":365,"updated":"2024-07-04 14:23:57.000000000","message":"IMHO we should add a specific metadata version for Dalmatian here.\nhttps://docs.openstack.org/nova/latest/user/metadata.html#metadata-openstack-format","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d921e9f9695a794255f0d03dfd8306a8549a3593","unresolved":true,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if self._check_os_version(VICTORIA, version):"},{"line_number":364,"context_line":"            metadata[\u0027dedicated_cpus\u0027] \u003d self._get_instance_dedicated_cpus()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.set_mimetype(MIME_TYPE_APPLICATION_JSON)"},{"line_number":367,"context_line":"        return jsonutils.dump_as_bytes(metadata)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"f9964a08_9b6da5e2","line":365,"in_reply_to":"35228bf1_cc9ebf91","updated":"2024-07-31 13:10:44.000000000","message":"As we discussed, we need to provide another specific version, like 2024_1","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"eb53a7cb0f8a0b47868c766d20f58388cfd6eed7","unresolved":true,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if self._check_os_version(VICTORIA, version):"},{"line_number":364,"context_line":"            metadata[\u0027dedicated_cpus\u0027] \u003d self._get_instance_dedicated_cpus()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.set_mimetype(MIME_TYPE_APPLICATION_JSON)"},{"line_number":367,"context_line":"        return jsonutils.dump_as_bytes(metadata)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"35228bf1_cc9ebf91","line":365,"in_reply_to":"82de09a5_ca84bf18","updated":"2024-07-17 20:19:36.000000000","message":"What do you mean ? Create a doc update for metadata or a dedicated folder ?","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3eb360888d3d7009695d4131c3a5e68abf18c254","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if self._check_os_version(VICTORIA, version):"},{"line_number":364,"context_line":"            metadata[\u0027dedicated_cpus\u0027] \u003d self._get_instance_dedicated_cpus()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.set_mimetype(MIME_TYPE_APPLICATION_JSON)"},{"line_number":367,"context_line":"        return jsonutils.dump_as_bytes(metadata)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"da883f65_0a285713","line":365,"in_reply_to":"f9964a08_9b6da5e2","updated":"2024-09-09 16:12:48.000000000","message":"Done","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e24c276558b8b60a6118eada0cddf5b996e80672","unresolved":true,"context_lines":[{"line_number":625,"context_line":"                                   ALL_OPENSTACK_VERSIONS):"},{"line_number":626,"context_line":"                path \u003d \u0027openstack/%s/%s\u0027 % (version, VD2_JSON_NAME)"},{"line_number":627,"context_line":"                yield (path, self.lookup(path))"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        for (cid, content) in self.content.items():"},{"line_number":630,"context_line":"            yield (\u0027%s/%s/%s\u0027 % (\"openstack\", CONTENT_DIR, cid), content)"},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"89eea674_9612fe18","line":628,"updated":"2024-07-04 14:23:57.000000000","message":"that\u0027s why we don\u0027t see it in configdrive.","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15d56c12f60d180abcf74d412e1129478cf6a3c4","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                                   ALL_OPENSTACK_VERSIONS):"},{"line_number":626,"context_line":"                path \u003d \u0027openstack/%s/%s\u0027 % (version, VD2_JSON_NAME)"},{"line_number":627,"context_line":"                yield (path, self.lookup(path))"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        for (cid, content) in self.content.items():"},{"line_number":630,"context_line":"            yield (\u0027%s/%s/%s\u0027 % (\"openstack\", CONTENT_DIR, cid), content)"},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"945999ae_8edd92a9","line":628,"in_reply_to":"69f93bca_61b2bca6","updated":"2024-11-13 15:01:38.000000000","message":"Done","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"eb53a7cb0f8a0b47868c766d20f58388cfd6eed7","unresolved":true,"context_lines":[{"line_number":625,"context_line":"                                   ALL_OPENSTACK_VERSIONS):"},{"line_number":626,"context_line":"                path \u003d \u0027openstack/%s/%s\u0027 % (version, VD2_JSON_NAME)"},{"line_number":627,"context_line":"                yield (path, self.lookup(path))"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        for (cid, content) in self.content.items():"},{"line_number":630,"context_line":"            yield (\u0027%s/%s/%s\u0027 % (\"openstack\", CONTENT_DIR, cid), content)"},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"69f93bca_61b2bca6","line":628,"in_reply_to":"89eea674_9612fe18","updated":"2024-07-17 20:19:36.000000000","message":"I don\u0027t think so. Because it would be covered by the ALL_OPENSTACK_VERSIONS case.\nI think the problem is: Config drive is created during spawn. It is not rebuild after an hard reboot. So the data are not updated to the config drive.","commit_id":"c1be33be367a5a5394304c855452429e94a14f3a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d921e9f9695a794255f0d03dfd8306a8549a3593","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    NEWTON_TWO,"},{"line_number":82,"context_line":"    OCATA,"},{"line_number":83,"context_line":"    ROCKY,"},{"line_number":84,"context_line":"    VICTORIA,"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"VERSION \u003d \"version\""}],"source_content_type":"text/x-python","patch_set":50,"id":"d0f8f83e_bdff2578","line":84,"updated":"2024-07-31 13:10:44.000000000","message":"that\u0027s where we need another version","commit_id":"27138938dd7a3fdcc5a619b173efb754c2422366"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3eb360888d3d7009695d4131c3a5e68abf18c254","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    NEWTON_TWO,"},{"line_number":82,"context_line":"    OCATA,"},{"line_number":83,"context_line":"    ROCKY,"},{"line_number":84,"context_line":"    VICTORIA,"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"VERSION \u003d \"version\""}],"source_content_type":"text/x-python","patch_set":50,"id":"60f86d57_2710252a","line":84,"in_reply_to":"d0f8f83e_bdff2578","updated":"2024-09-09 16:12:48.000000000","message":"Done","commit_id":"27138938dd7a3fdcc5a619b173efb754c2422366"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d921e9f9695a794255f0d03dfd8306a8549a3593","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                        device_metadata[\u0027serial\u0027] \u003d device.serial"},{"line_number":427,"context_line":"                    if \u0027path\u0027 in device:"},{"line_number":428,"context_line":"                        device_metadata[\u0027path\u0027] \u003d device.path"},{"line_number":429,"context_line":"                elif isinstance(device, metadata_obj.ShareMetadata):"},{"line_number":430,"context_line":"                    device_metadata[\u0027type\u0027] \u003d \u0027share\u0027"},{"line_number":431,"context_line":"                    device_metadata[\u0027share_id\u0027] \u003d device.share_id"},{"line_number":432,"context_line":"                    device_metadata[\u0027tag\u0027] \u003d device.tag"}],"source_content_type":"text/x-python","patch_set":50,"id":"e5a22105_493b22b2","line":429,"updated":"2024-07-31 13:10:44.000000000","message":"and here, you can\u0027t return the share metadata directly if the version is older than 2024_1","commit_id":"27138938dd7a3fdcc5a619b173efb754c2422366"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3eb360888d3d7009695d4131c3a5e68abf18c254","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                        device_metadata[\u0027serial\u0027] \u003d device.serial"},{"line_number":427,"context_line":"                    if \u0027path\u0027 in device:"},{"line_number":428,"context_line":"                        device_metadata[\u0027path\u0027] \u003d device.path"},{"line_number":429,"context_line":"                elif isinstance(device, metadata_obj.ShareMetadata):"},{"line_number":430,"context_line":"                    device_metadata[\u0027type\u0027] \u003d \u0027share\u0027"},{"line_number":431,"context_line":"                    device_metadata[\u0027share_id\u0027] \u003d device.share_id"},{"line_number":432,"context_line":"                    device_metadata[\u0027tag\u0027] \u003d device.tag"}],"source_content_type":"text/x-python","patch_set":50,"id":"7725dc01_0de9f880","line":429,"in_reply_to":"e5a22105_493b22b2","updated":"2024-09-09 16:12:48.000000000","message":"Done","commit_id":"27138938dd7a3fdcc5a619b173efb754c2422366"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a837ea91b083144e54b9cbb5e167ca4a4db703a0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"OCATA \u003d \u00272017-02-22\u0027"},{"line_number":72,"context_line":"ROCKY \u003d \u00272018-08-27\u0027"},{"line_number":73,"context_line":"VICTORIA \u003d \u00272020-10-14\u0027"},{"line_number":74,"context_line":"# TODO(uggla): review this date"},{"line_number":75,"context_line":"EPOXY \u003d \u00272025-04-04\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"OPENSTACK_VERSIONS \u003d ["},{"line_number":78,"context_line":"    FOLSOM,"}],"source_content_type":"text/x-python","patch_set":56,"id":"bb9b3ffc_5d2b36ec","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":20},"updated":"2024-10-11 11:46:58.000000000","message":"This is correct according to the https://releases.openstack.org/epoxy/schedule.html so you can drop the comment.","commit_id":"2df346b6c11cab91509af06c16364b3cd8156a7a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1a6d8072d610d3b025d9141be5cd1dd3122eec82","unresolved":false,"context_lines":[{"line_number":71,"context_line":"OCATA \u003d \u00272017-02-22\u0027"},{"line_number":72,"context_line":"ROCKY \u003d \u00272018-08-27\u0027"},{"line_number":73,"context_line":"VICTORIA \u003d \u00272020-10-14\u0027"},{"line_number":74,"context_line":"# TODO(uggla): review this date"},{"line_number":75,"context_line":"EPOXY \u003d \u00272025-04-04\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"OPENSTACK_VERSIONS \u003d ["},{"line_number":78,"context_line":"    FOLSOM,"}],"source_content_type":"text/x-python","patch_set":56,"id":"c6d5cf59_8335c9e2","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":20},"in_reply_to":"b3f4f982_d8275352","updated":"2024-11-14 13:53:25.000000000","message":"Done","commit_id":"2df346b6c11cab91509af06c16364b3cd8156a7a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15d56c12f60d180abcf74d412e1129478cf6a3c4","unresolved":true,"context_lines":[{"line_number":71,"context_line":"OCATA \u003d \u00272017-02-22\u0027"},{"line_number":72,"context_line":"ROCKY \u003d \u00272018-08-27\u0027"},{"line_number":73,"context_line":"VICTORIA \u003d \u00272020-10-14\u0027"},{"line_number":74,"context_line":"# TODO(uggla): review this date"},{"line_number":75,"context_line":"EPOXY \u003d \u00272025-04-04\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"OPENSTACK_VERSIONS \u003d ["},{"line_number":78,"context_line":"    FOLSOM,"}],"source_content_type":"text/x-python","patch_set":56,"id":"b3f4f982_d8275352","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":20},"in_reply_to":"bb9b3ffc_5d2b36ec","updated":"2024-11-13 15:01:38.000000000","message":"This can be done in a FUP","commit_id":"2df346b6c11cab91509af06c16364b3cd8156a7a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1a6d8072d610d3b025d9141be5cd1dd3122eec82","unresolved":true,"context_lines":[{"line_number":71,"context_line":"OCATA \u003d \u00272017-02-22\u0027"},{"line_number":72,"context_line":"ROCKY \u003d \u00272018-08-27\u0027"},{"line_number":73,"context_line":"VICTORIA \u003d \u00272020-10-14\u0027"},{"line_number":74,"context_line":"# TODO(uggla): review this date"},{"line_number":75,"context_line":"EPOXY \u003d \u00272025-04-04\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"OPENSTACK_VERSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":57,"id":"ac0807c2_c529089c","line":74,"updated":"2024-11-14 13:53:25.000000000","message":"thanks for removing it","commit_id":"7203b37b4886033f28c936403d1cd6003267a455"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"040824fa207d26623f7c79a46c177f7d19801c6a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"OCATA \u003d \u00272017-02-22\u0027"},{"line_number":72,"context_line":"ROCKY \u003d \u00272018-08-27\u0027"},{"line_number":73,"context_line":"VICTORIA \u003d \u00272020-10-14\u0027"},{"line_number":74,"context_line":"# TODO(uggla): review this date"},{"line_number":75,"context_line":"EPOXY \u003d \u00272025-04-04\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"OPENSTACK_VERSIONS \u003d ["}],"source_content_type":"text/x-python","patch_set":57,"id":"92ae3972_8f165e19","line":74,"in_reply_to":"ac0807c2_c529089c","updated":"2024-11-15 10:29:35.000000000","message":"Acknowledged","commit_id":"7203b37b4886033f28c936403d1cd6003267a455"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15d56c12f60d180abcf74d412e1129478cf6a3c4","unresolved":true,"context_lines":[{"line_number":434,"context_line":"                ):"},{"line_number":435,"context_line":"                    device_metadata[\u0027type\u0027] \u003d \u0027share\u0027"},{"line_number":436,"context_line":"                    device_metadata[\u0027share_id\u0027] \u003d device.share_id"},{"line_number":437,"context_line":"                    device_metadata[\u0027tag\u0027] \u003d device.tag"},{"line_number":438,"context_line":"                else:"},{"line_number":439,"context_line":"                    LOG.debug(\u0027Metadata for device of unknown type %s has not \u0027"},{"line_number":440,"context_line":"                              \u0027been included in the \u0027"}],"source_content_type":"text/x-python","patch_set":57,"id":"59c9ba79_41d00007","line":437,"updated":"2024-11-13 15:01:38.000000000","message":"I tested and it works : \n\n```\n$ curl http://169.254.169.254/openstack/latest/meta_data.json \n{\"uuid\": \"8031ca33-505b-41dd-8832-7d7ff1998266\", \"public_keys\": {xxx}, \"keys\": [{xxx}], \"hostname\": \"vm1.novalocal\", \"name\": \"vm1\", \"launch_index\": 0, \"availability_zone\": \"nova\", \"random_seed\": \"xxx\", \"project_id\": \"e0574fccdca44a0caa60b1d389a45277\", \"devices\": [{\"type\": \"share\", \"share_id\": \"18b6f2c9-13c9-4341-8b9a-07277ada0f90\", \"tag\": \"share2\", \"bus\": \"none\", \"address\": \"none\"}, {\"type\": \"share\", \"share_id\": \"fd96c684-c667-4de5-ab91-9b8c4e1bfcc0\", \"tag\": \"share1\", \"bus\": \"none\", \"address\": \"none\"}], \"dedicated_cpus\": []}\n```","commit_id":"7203b37b4886033f28c936403d1cd6003267a455"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"040824fa207d26623f7c79a46c177f7d19801c6a","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                ):"},{"line_number":435,"context_line":"                    device_metadata[\u0027type\u0027] \u003d \u0027share\u0027"},{"line_number":436,"context_line":"                    device_metadata[\u0027share_id\u0027] \u003d device.share_id"},{"line_number":437,"context_line":"                    device_metadata[\u0027tag\u0027] \u003d device.tag"},{"line_number":438,"context_line":"                else:"},{"line_number":439,"context_line":"                    LOG.debug(\u0027Metadata for device of unknown type %s has not \u0027"},{"line_number":440,"context_line":"                              \u0027been included in the \u0027"}],"source_content_type":"text/x-python","patch_set":57,"id":"27f521f7_fb9072a6","line":437,"in_reply_to":"59c9ba79_41d00007","updated":"2024-11-15 10:29:35.000000000","message":"Acknowledged","commit_id":"7203b37b4886033f28c936403d1cd6003267a455"}],"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c1929e72f02f707ac7410fd832cba5ff0e9a19f3","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    }"},{"line_number":243,"context_line":"    share_meta \u003d {"},{"line_number":244,"context_line":"        \u0027type\u0027: \u0027share\u0027,"},{"line_number":245,"context_line":"        \u0027bus\u0027: \u0027none\u0027,"},{"line_number":246,"context_line":"        \u0027address\u0027: \u0027none\u0027,"},{"line_number":247,"context_line":"        \u0027share_id\u0027: \u0027ca3c176e-fd5a-438b-b595-e18a358f6909\u0027,"},{"line_number":248,"context_line":"        \u0027tag\u0027: \u0027ca3c176e-fd5a-438b-b595-e18a358f6909\u0027,"},{"line_number":249,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"46a8e865_5d1dc192","line":246,"range":{"start_line":245,"start_character":0,"end_line":246,"end_character":26},"updated":"2023-01-31 17:10:19.000000000","message":"these are strange. Where these are coming from?","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2eafe446bf8d13861109b5a4811da1d90666ad7b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    }"},{"line_number":243,"context_line":"    share_meta \u003d {"},{"line_number":244,"context_line":"        \u0027type\u0027: \u0027share\u0027,"},{"line_number":245,"context_line":"        \u0027bus\u0027: \u0027none\u0027,"},{"line_number":246,"context_line":"        \u0027address\u0027: \u0027none\u0027,"},{"line_number":247,"context_line":"        \u0027share_id\u0027: \u0027ca3c176e-fd5a-438b-b595-e18a358f6909\u0027,"},{"line_number":248,"context_line":"        \u0027tag\u0027: \u0027ca3c176e-fd5a-438b-b595-e18a358f6909\u0027,"},{"line_number":249,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"ffc25359_4a55bf5f","line":246,"range":{"start_line":245,"start_character":0,"end_line":246,"end_character":26},"in_reply_to":"46a8e865_5d1dc192","updated":"2023-03-06 10:18:29.000000000","message":"I wanted to have shares part of the device metadata because, to my mind, it seems the most coherent regarding the metadata \"tree\".\nSo the ShareMetadata object inherits from DeviceMetadata that owns \u0027bus\u0027 and \u0027address\u0027 fields.","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c1929e72f02f707ac7410fd832cba5ff0e9a19f3","unresolved":true,"context_lines":[{"line_number":2338,"context_line":"        fake_share_mapping \u003d {"},{"line_number":2339,"context_line":"            \u0027created_at\u0027: None,"},{"line_number":2340,"context_line":"            \u0027updated_at\u0027: None,"},{"line_number":2341,"context_line":"            # \u0027deleted_at\u0027: None,"},{"line_number":2342,"context_line":"            # \u0027deleted\u0027: False,"},{"line_number":2343,"context_line":"            \u0027id\u0027: 1,"},{"line_number":2344,"context_line":"            \u0027uuid\u0027: uuids.share_mapping,"},{"line_number":2345,"context_line":"            \u0027instance_uuid\u0027: uuids.instance,"}],"source_content_type":"text/x-python","patch_set":16,"id":"8814d6d5_6358f1fd","line":2342,"range":{"start_line":2341,"start_character":0,"end_line":2342,"end_character":31},"updated":"2023-01-31 17:10:19.000000000","message":"either uncomment them or remove them","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2eafe446bf8d13861109b5a4811da1d90666ad7b","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"        fake_share_mapping \u003d {"},{"line_number":2339,"context_line":"            \u0027created_at\u0027: None,"},{"line_number":2340,"context_line":"            \u0027updated_at\u0027: None,"},{"line_number":2341,"context_line":"            # \u0027deleted_at\u0027: None,"},{"line_number":2342,"context_line":"            # \u0027deleted\u0027: False,"},{"line_number":2343,"context_line":"            \u0027id\u0027: 1,"},{"line_number":2344,"context_line":"            \u0027uuid\u0027: uuids.share_mapping,"},{"line_number":2345,"context_line":"            \u0027instance_uuid\u0027: uuids.instance,"}],"source_content_type":"text/x-python","patch_set":16,"id":"f90227fc_736fca43","line":2342,"range":{"start_line":2341,"start_character":0,"end_line":2342,"end_character":31},"in_reply_to":"8814d6d5_6358f1fd","updated":"2023-03-06 10:18:29.000000000","message":"Done","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c1929e72f02f707ac7410fd832cba5ff0e9a19f3","unresolved":true,"context_lines":[{"line_number":2345,"context_line":"            \u0027instance_uuid\u0027: uuids.instance,"},{"line_number":2346,"context_line":"            \u0027share_id\u0027: \u002733714a70-38d5-40d6-88e4-a382ae1c6dfe\u0027,"},{"line_number":2347,"context_line":"            \u0027status\u0027: \u0027inactive\u0027,"},{"line_number":2348,"context_line":"            \u0027tag\u0027: \u002733714a70-38d5-40d6-88e4-a382ae1c6dfe\u0027,"},{"line_number":2349,"context_line":"            \u0027export_location\u0027: \u0027192.168.122.152:/manila/share\u0027,"},{"line_number":2350,"context_line":"            \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":2351,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":16,"id":"eed2763e_ccb2e680","line":2348,"updated":"2023-01-31 17:10:19.000000000","message":"I would use different value for share_id and tag so that the test can assert that they are not mixed by the impl","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2eafe446bf8d13861109b5a4811da1d90666ad7b","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"            \u0027instance_uuid\u0027: uuids.instance,"},{"line_number":2346,"context_line":"            \u0027share_id\u0027: \u002733714a70-38d5-40d6-88e4-a382ae1c6dfe\u0027,"},{"line_number":2347,"context_line":"            \u0027status\u0027: \u0027inactive\u0027,"},{"line_number":2348,"context_line":"            \u0027tag\u0027: \u002733714a70-38d5-40d6-88e4-a382ae1c6dfe\u0027,"},{"line_number":2349,"context_line":"            \u0027export_location\u0027: \u0027192.168.122.152:/manila/share\u0027,"},{"line_number":2350,"context_line":"            \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":2351,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":16,"id":"98bb1ab3_5123731f","line":2348,"in_reply_to":"eed2763e_ccb2e680","updated":"2023-03-06 10:18:29.000000000","message":"Done","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c1929e72f02f707ac7410fd832cba5ff0e9a19f3","unresolved":true,"context_lines":[{"line_number":16987,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.destroy\u0027)"},{"line_number":16988,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.\u0027"},{"line_number":16989,"context_line":"                \u0027_get_all_assigned_mediated_devices\u0027)"},{"line_number":16990,"context_line":"    def test_hard_reboot(self, mock_get_mdev, mock_destroy, mock_get_disk_info,"},{"line_number":16991,"context_line":"                         mock_get_guest_xml, mock_create_guest_with_network,"},{"line_number":16992,"context_line":"                         mock_get_info, mock_metadata, mock_save):"},{"line_number":16993,"context_line":"        self.context.auth_token \u003d True  # any non-None value will suffice"}],"source_content_type":"text/x-python","patch_set":16,"id":"cc5d0e84_78c0b058","line":16990,"updated":"2023-01-31 17:10:19.000000000","message":"please assert that _build_device_metadata is called.","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2eafe446bf8d13861109b5a4811da1d90666ad7b","unresolved":false,"context_lines":[{"line_number":16987,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.destroy\u0027)"},{"line_number":16988,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.\u0027"},{"line_number":16989,"context_line":"                \u0027_get_all_assigned_mediated_devices\u0027)"},{"line_number":16990,"context_line":"    def test_hard_reboot(self, mock_get_mdev, mock_destroy, mock_get_disk_info,"},{"line_number":16991,"context_line":"                         mock_get_guest_xml, mock_create_guest_with_network,"},{"line_number":16992,"context_line":"                         mock_get_info, mock_metadata, mock_save):"},{"line_number":16993,"context_line":"        self.context.auth_token \u003d True  # any non-None value will suffice"}],"source_content_type":"text/x-python","patch_set":16,"id":"de5e2bb0_f17510be","line":16990,"in_reply_to":"cc5d0e84_78c0b058","updated":"2023-03-06 10:18:29.000000000","message":"Done","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c1929e72f02f707ac7410fd832cba5ff0e9a19f3","unresolved":true,"context_lines":[{"line_number":17070,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.destroy\u0027)"},{"line_number":17071,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.\u0027"},{"line_number":17072,"context_line":"                \u0027_get_all_assigned_mediated_devices\u0027)"},{"line_number":17073,"context_line":"    def test_hard_reboot_with_share_info("},{"line_number":17074,"context_line":"        self, mock_get_mdev, mock_destroy, mock_get_disk_info,"},{"line_number":17075,"context_line":"        mock_get_guest_xml, mock_create_guest_with_network,"},{"line_number":17076,"context_line":"        mock_get_info, mock_attach, mock_metadata, mock_save"}],"source_content_type":"text/x-python","patch_set":16,"id":"cdc1591a_21ba92e5","line":17073,"updated":"2023-01-31 17:10:19.000000000","message":"please assert that _build_device_metadata is called","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2eafe446bf8d13861109b5a4811da1d90666ad7b","unresolved":false,"context_lines":[{"line_number":17070,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.destroy\u0027)"},{"line_number":17071,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver.\u0027"},{"line_number":17072,"context_line":"                \u0027_get_all_assigned_mediated_devices\u0027)"},{"line_number":17073,"context_line":"    def test_hard_reboot_with_share_info("},{"line_number":17074,"context_line":"        self, mock_get_mdev, mock_destroy, mock_get_disk_info,"},{"line_number":17075,"context_line":"        mock_get_guest_xml, mock_create_guest_with_network,"},{"line_number":17076,"context_line":"        mock_get_info, mock_attach, mock_metadata, mock_save"}],"source_content_type":"text/x-python","patch_set":16,"id":"3c58ac5e_daec7f75","line":17073,"in_reply_to":"cdc1591a_21ba92e5","updated":"2023-03-06 10:18:29.000000000","message":"Done","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c1929e72f02f707ac7410fd832cba5ff0e9a19f3","unresolved":true,"context_lines":[{"line_number":12065,"context_line":"                device.tag \u003d share.tag"},{"line_number":12066,"context_line":"                return device"},{"line_number":12067,"context_line":""},{"line_number":12068,"context_line":"        return None"},{"line_number":12069,"context_line":""},{"line_number":12070,"context_line":"    def _build_hostdev_metadata(self, dev, vifs_to_expose, vlans_by_mac):"},{"line_number":12071,"context_line":"        \"\"\"Builds a metadata object for a hostdev. This can only be a PF, so we"}],"source_content_type":"text/x-python","patch_set":16,"id":"8a7acbf2_d66869b4","line":12068,"updated":"2023-01-31 17:10:19.000000000","message":"I would log a warning in this case to help debugging why metadata is missing from the guest for certain devices.","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2eafe446bf8d13861109b5a4811da1d90666ad7b","unresolved":false,"context_lines":[{"line_number":12065,"context_line":"                device.tag \u003d share.tag"},{"line_number":12066,"context_line":"                return device"},{"line_number":12067,"context_line":""},{"line_number":12068,"context_line":"        return None"},{"line_number":12069,"context_line":""},{"line_number":12070,"context_line":"    def _build_hostdev_metadata(self, dev, vifs_to_expose, vlans_by_mac):"},{"line_number":12071,"context_line":"        \"\"\"Builds a metadata object for a hostdev. This can only be a PF, so we"}],"source_content_type":"text/x-python","patch_set":16,"id":"14eb7c93_8958c6f1","line":12068,"in_reply_to":"8a7acbf2_d66869b4","updated":"2023-03-06 10:18:29.000000000","message":"Done, but not sure about the message.","commit_id":"1c83a637ded73563b53c18e1151f4cd3e5586d97"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a4bce741d306a8994aa2f4adb5096c7c590b7594","unresolved":true,"context_lines":[{"line_number":4032,"context_line":"        # Rebuild device_metadata to get shares"},{"line_number":4033,"context_line":"        instance.device_metadata \u003d self._build_device_metadata("},{"line_number":4034,"context_line":"            context, instance)"},{"line_number":4035,"context_line":"        instance.save()"},{"line_number":4036,"context_line":""},{"line_number":4037,"context_line":"    def pause(self, instance):"},{"line_number":4038,"context_line":"        \"\"\"Pause VM instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":37,"id":"37208196_cdfb0277","line":4035,"updated":"2024-01-30 10:07:17.000000000","message":"the instance.save is unnecessary as the compute manager will save the instance anyhow.","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e24c276558b8b60a6118eada0cddf5b996e80672","unresolved":true,"context_lines":[{"line_number":4032,"context_line":"        # Rebuild device_metadata to get shares"},{"line_number":4033,"context_line":"        instance.device_metadata \u003d self._build_device_metadata("},{"line_number":4034,"context_line":"            context, instance)"},{"line_number":4035,"context_line":"        instance.save()"},{"line_number":4036,"context_line":""},{"line_number":4037,"context_line":"    def pause(self, instance):"},{"line_number":4038,"context_line":"        \"\"\"Pause VM instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":37,"id":"feb330b3_e6d63fff","line":4035,"in_reply_to":"37208196_cdfb0277","updated":"2024-07-04 14:23:57.000000000","message":"yup","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"e484470db29f8f64a071e10418d7e416d001c4de","unresolved":false,"context_lines":[{"line_number":4032,"context_line":"        # Rebuild device_metadata to get shares"},{"line_number":4033,"context_line":"        instance.device_metadata \u003d self._build_device_metadata("},{"line_number":4034,"context_line":"            context, instance)"},{"line_number":4035,"context_line":"        instance.save()"},{"line_number":4036,"context_line":""},{"line_number":4037,"context_line":"    def pause(self, instance):"},{"line_number":4038,"context_line":"        \"\"\"Pause VM instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":37,"id":"6410b980_62381e7f","line":4035,"in_reply_to":"feb330b3_e6d63fff","updated":"2024-07-17 20:19:50.000000000","message":"Done","commit_id":"058ebe27c4bcf4e2ec0219de5fddc46f88454fcc"}]}