)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"2a68f12f63f18a6c562d310378e97dbd984a2c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"94a2a5ca_763d729e","updated":"2023-03-07 16:23:15.000000000","message":"recheck","commit_id":"e412b50f31d52331f7fa4efa6a91f115142c216e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6d9cc1b10f408b293e951eda446d1a4bdc2efad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"299971f6_060ea5d0","updated":"2024-08-28 13:56:41.000000000","message":"Looks good only a nit for the code comment on the reason of the version bump","commit_id":"368b2c7211065f5529813ac29cae0f013a8d5ddc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e4ce49e674968cbcddc6c9864b5065ee73059bdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"c9b276b0_6b547499","updated":"2024-10-11 12:08:48.000000000","message":"looks good","commit_id":"9cfeba47e4c1618195489886471235efd30939b0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"44fa00aac9af1eb32cf8fd18f5a5f17119c7d63c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"c7b72904_1c478694","updated":"2024-11-19 14:06:01.000000000","message":"Great work","commit_id":"ab939de922b0882c88ce1340dfd5d507e1e6c2b0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0e25f1bd8c7c2fc67669d064383f85b0b9de2cf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"fcc1e3eb_c9939e4d","updated":"2024-11-15 10:44:44.000000000","message":"Still good.","commit_id":"ab939de922b0882c88ce1340dfd5d507e1e6c2b0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e199c610da416d7221d5ef88a9e2823f0e518d1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"e8035bfe_457c7460","updated":"2024-12-06 16:41:24.000000000","message":"recheck guest ssh timed out","commit_id":"320dca539147a607b126eeb37192603d279918df"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f0faff28114ca4a5441c885c1d19bbfd367694f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"f34bc1e7_1d9fc961","updated":"2024-12-06 12:12:35.000000000","message":"recheck parent merged","commit_id":"320dca539147a607b126eeb37192603d279918df"}],"nova/api/openstack/compute/server_shares.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b5ef22de91d06d0f7f52212b0bc300d32cca10b","unresolved":true,"context_lines":[{"line_number":155,"context_line":"                _try_create_share_mapping(share_mapping)"},{"line_number":156,"context_line":"                self.compute_api.allow_share(cctxt, instance, share_mapping)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"                utils.notify_about_share_attach_detach("},{"line_number":159,"context_line":"                    cctxt,"},{"line_number":160,"context_line":"                    instance,"},{"line_number":161,"context_line":"                    instance.host,"}],"source_content_type":"text/x-python","patch_set":50,"id":"7435345c_242091d7","line":158,"updated":"2024-06-20 12:07:51.000000000","message":"I\u0027m wondering if it would be better to send the END notification from the compute manager when the RPC is finished.","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c40da29de9ae7ff5ce659e3737ba845d13eebb07","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                _try_create_share_mapping(share_mapping)"},{"line_number":156,"context_line":"                self.compute_api.allow_share(cctxt, instance, share_mapping)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"                utils.notify_about_share_attach_detach("},{"line_number":159,"context_line":"                    cctxt,"},{"line_number":160,"context_line":"                    instance,"},{"line_number":161,"context_line":"                    instance.host,"}],"source_content_type":"text/x-python","patch_set":50,"id":"bf1a46be_96ac4fc2","line":158,"in_reply_to":"7435345c_242091d7","updated":"2024-06-26 16:12:52.000000000","message":"Done","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"}],"nova/compute/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"299613a7db8c1606990cb0f9d96f2dd23edb5981","unresolved":true,"context_lines":[{"line_number":593,"context_line":"        context\u003dcontext,"},{"line_number":594,"context_line":"        priority\u003dpriority,"},{"line_number":595,"context_line":"        publisher\u003dnotification_base.NotificationPublisher("},{"line_number":596,"context_line":"            host\u003dhost, source\u003dfields.NotificationSource.COMPUTE),"},{"line_number":597,"context_line":"        event_type\u003dnotification_base.EventType("},{"line_number":598,"context_line":"            object\u003d\u0027instance\u0027,"},{"line_number":599,"context_line":"            action\u003daction,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ea5edeaa_b5d932e1","line":596,"range":{"start_line":596,"start_character":56,"end_line":596,"end_character":63},"updated":"2023-02-08 17:22:31.000000000","message":"this is coming from the api service as far as I see","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"14c10487346f91301d5b028e8089fbce310efe85","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        context\u003dcontext,"},{"line_number":594,"context_line":"        priority\u003dpriority,"},{"line_number":595,"context_line":"        publisher\u003dnotification_base.NotificationPublisher("},{"line_number":596,"context_line":"            host\u003dhost, source\u003dfields.NotificationSource.COMPUTE),"},{"line_number":597,"context_line":"        event_type\u003dnotification_base.EventType("},{"line_number":598,"context_line":"            object\u003d\u0027instance\u0027,"},{"line_number":599,"context_line":"            action\u003daction,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5617acdd_391000c8","line":596,"range":{"start_line":596,"start_character":56,"end_line":596,"end_character":63},"in_reply_to":"ea5edeaa_b5d932e1","updated":"2023-03-06 10:18:37.000000000","message":"Done","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"}],"nova/notifications/objects/base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6d9cc1b10f408b293e951eda446d1a4bdc2efad2","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    #               enum"},{"line_number":74,"context_line":"    # Version 1.20: IMAGE_CACHE is added to the NotificationActionField enum"},{"line_number":75,"context_line":"    # Version 1.21: PROGRESS added to NotificationPhase enum"},{"line_number":76,"context_line":"    # Version 1.22: Add InstanceActionShareNotification  class"},{"line_number":77,"context_line":"    VERSION \u003d \u00271.22\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":54,"id":"4593da28_5054edc2","line":76,"updated":"2024-08-28 13:56:41.000000000","message":"nit: the reason for the bump is more like:\n\nSHARE_ATTACH SHARE_DETACH are added to the NotificationActionField enum","commit_id":"368b2c7211065f5529813ac29cae0f013a8d5ddc"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"12b2587d3ce99911a0f94ffe1853ae2208f36678","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    #               enum"},{"line_number":74,"context_line":"    # Version 1.20: IMAGE_CACHE is added to the NotificationActionField enum"},{"line_number":75,"context_line":"    # Version 1.21: PROGRESS added to NotificationPhase enum"},{"line_number":76,"context_line":"    # Version 1.22: Add InstanceActionShareNotification  class"},{"line_number":77,"context_line":"    VERSION \u003d \u00271.22\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":54,"id":"29d0b826_e1306342","line":76,"in_reply_to":"4593da28_5054edc2","updated":"2024-09-17 06:42:02.000000000","message":"Done","commit_id":"368b2c7211065f5529813ac29cae0f013a8d5ddc"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"299613a7db8c1606990cb0f9d96f2dd23edb5981","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":22,"context_line":"SHARE_MAPPING_STATUSES \u003d [\u0027active\u0027, \u0027inactive\u0027, \u0027error\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":20,"id":"f30aed8d_c76eea01","line":22,"updated":"2023-02-08 17:22:31.000000000","message":"Where it is used?","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"14c10487346f91301d5b028e8089fbce310efe85","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":22,"context_line":"SHARE_MAPPING_STATUSES \u003d [\u0027active\u0027, \u0027inactive\u0027, \u0027error\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":20,"id":"1758c2f3_68af196a","line":22,"in_reply_to":"f30aed8d_c76eea01","updated":"2023-03-06 10:18:37.000000000","message":"Done","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b5ef22de91d06d0f7f52212b0bc300d32cca10b","unresolved":true,"context_lines":[{"line_number":192,"context_line":"    # Version 1.0: Initial version"},{"line_number":193,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":194,"context_line":"    fields \u003d {"},{"line_number":195,"context_line":"        \u0027share_id\u0027: fields.UUIDField(),"},{"line_number":196,"context_line":"    }"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def __init__(self, context, instance, fault, share_id):"}],"source_content_type":"text/x-python","patch_set":50,"id":"4ea733bc_2f212499","line":195,"updated":"2024-06-20 12:07:51.000000000","message":"is it the ID of the share or the ID of the share_mapping?","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c40da29de9ae7ff5ce659e3737ba845d13eebb07","unresolved":true,"context_lines":[{"line_number":192,"context_line":"    # Version 1.0: Initial version"},{"line_number":193,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":194,"context_line":"    fields \u003d {"},{"line_number":195,"context_line":"        \u0027share_id\u0027: fields.UUIDField(),"},{"line_number":196,"context_line":"    }"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def __init__(self, context, instance, fault, share_id):"}],"source_content_type":"text/x-python","patch_set":50,"id":"554e8ed4_ef9e6ec0","line":195,"in_reply_to":"4ea733bc_2f212499","updated":"2024-06-26 16:12:52.000000000","message":"This is the id of the share from manila.","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"961ec37159e165bd54b92c6a82a8ec10b9f4129f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    # Version 1.0: Initial version"},{"line_number":193,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":194,"context_line":"    fields \u003d {"},{"line_number":195,"context_line":"        \u0027share_id\u0027: fields.UUIDField(),"},{"line_number":196,"context_line":"    }"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def __init__(self, context, instance, fault, share_id):"}],"source_content_type":"text/x-python","patch_set":50,"id":"fbc461ba_23ebdbf9","line":195,"in_reply_to":"4ea733bc_2f212499","updated":"2024-07-04 16:16:08.000000000","message":"this is the share ID and that is good.","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"299613a7db8c1606990cb0f9d96f2dd23edb5981","unresolved":true,"context_lines":[{"line_number":1701,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":1702,"context_line":"            actual\u003dself.notifier.versioned_notifications[1])"},{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"    @mock.patch(\u0027socket.gethostbyname\u0027, return_value\u003d\u0027192.168.122.152\u0027)"},{"line_number":1705,"context_line":"    def _test_share_attach(self, server, mock_dns):"},{"line_number":1706,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027os-stop\u0027: {}})"},{"line_number":1707,"context_line":"        self._wait_for_state_change(server, expected_status\u003d\u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"daecb352_d27aff35","line":1704,"updated":"2023-02-08 17:22:31.000000000","message":"hm, this seems strange... I removed it and the test still passes. Does it fail for you? With what error?","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"14c10487346f91301d5b028e8089fbce310efe85","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                \u0027uuid\u0027: server[\u0027id\u0027]},"},{"line_number":1702,"context_line":"            actual\u003dself.notifier.versioned_notifications[1])"},{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"    @mock.patch(\u0027socket.gethostbyname\u0027, return_value\u003d\u0027192.168.122.152\u0027)"},{"line_number":1705,"context_line":"    def _test_share_attach(self, server, mock_dns):"},{"line_number":1706,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027os-stop\u0027: {}})"},{"line_number":1707,"context_line":"        self._wait_for_state_change(server, expected_status\u003d\u0027SHUTOFF\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ece1e830_43fe975c","line":1704,"in_reply_to":"daecb352_d27aff35","updated":"2023-03-06 10:18:37.000000000","message":"Done","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"299613a7db8c1606990cb0f9d96f2dd23edb5981","unresolved":true,"context_lines":[{"line_number":1708,"context_line":"        self.notifier.reset()"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        # Return a constant share uuid"},{"line_number":1711,"context_line":"        with mock.patch("},{"line_number":1712,"context_line":"                \u0027oslo_utils.uuidutils.generate_uuid\u0027,"},{"line_number":1713,"context_line":"                return_value\u003d\u0027f7c1726d-7622-42b3-8b2c-4473239d60d1\u0027):"},{"line_number":1714,"context_line":"            self._attach_share_to_server("},{"line_number":1715,"context_line":"                server, \u0027e8debdc0-447a-4376-a10a-4cd9122d7986\u0027)"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"        self.assertEqual(2, len(self.notifier.versioned_notifications),"},{"line_number":1718,"context_line":"                         self.notifier.versioned_notifications)"}],"source_content_type":"text/x-python","patch_set":20,"id":"000241ae_aacdc796","line":1715,"range":{"start_line":1711,"start_character":0,"end_line":1715,"end_character":63},"updated":"2023-02-08 17:22:31.000000000","message":"this should be part of some fixture to avoid duplicating this for all tests. \n//later\nHm I removed this too and the test still passes","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"14c10487346f91301d5b028e8089fbce310efe85","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"        self.notifier.reset()"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        # Return a constant share uuid"},{"line_number":1711,"context_line":"        with mock.patch("},{"line_number":1712,"context_line":"                \u0027oslo_utils.uuidutils.generate_uuid\u0027,"},{"line_number":1713,"context_line":"                return_value\u003d\u0027f7c1726d-7622-42b3-8b2c-4473239d60d1\u0027):"},{"line_number":1714,"context_line":"            self._attach_share_to_server("},{"line_number":1715,"context_line":"                server, \u0027e8debdc0-447a-4376-a10a-4cd9122d7986\u0027)"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"        self.assertEqual(2, len(self.notifier.versioned_notifications),"},{"line_number":1718,"context_line":"                         self.notifier.versioned_notifications)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dab5dddf_b43e8071","line":1715,"range":{"start_line":1711,"start_character":0,"end_line":1715,"end_character":63},"in_reply_to":"000241ae_aacdc796","updated":"2023-03-06 10:18:37.000000000","message":"Done","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"299613a7db8c1606990cb0f9d96f2dd23edb5981","unresolved":true,"context_lines":[{"line_number":1733,"context_line":"                \u0027power_state\u0027: \u0027shutdown\u0027},"},{"line_number":1734,"context_line":"            actual\u003dself.notifier.versioned_notifications[1])"},{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        # Restart server"},{"line_number":1737,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":1738,"context_line":"        self._wait_for_state_change(server, expected_status\u003d\u0027ACTIVE\u0027)"},{"line_number":1739,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"64a969f4_c7c98cf0","line":1736,"range":{"start_line":1736,"start_character":10,"end_line":1736,"end_character":17},"updated":"2023-02-08 17:22:31.000000000","message":"nit:start","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"14c10487346f91301d5b028e8089fbce310efe85","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"                \u0027power_state\u0027: \u0027shutdown\u0027},"},{"line_number":1734,"context_line":"            actual\u003dself.notifier.versioned_notifications[1])"},{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        # Restart server"},{"line_number":1737,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":1738,"context_line":"        self._wait_for_state_change(server, expected_status\u003d\u0027ACTIVE\u0027)"},{"line_number":1739,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"4b108e3d_7e6f6add","line":1736,"range":{"start_line":1736,"start_character":10,"end_line":1736,"end_character":17},"in_reply_to":"64a969f4_c7c98cf0","updated":"2023-03-06 10:18:37.000000000","message":"Done","commit_id":"743f4caeb24b603874491b5ec026c7beb52bdf2b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b5ef22de91d06d0f7f52212b0bc300d32cca10b","unresolved":true,"context_lines":[{"line_number":1708,"context_line":"        self.notifier.reset()"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        # Return a constant share uuid"},{"line_number":1711,"context_line":"        with mock.patch("},{"line_number":1712,"context_line":"            \"oslo_utils.uuidutils.generate_uuid\","},{"line_number":1713,"context_line":"            return_value\u003d\"f7c1726d-7622-42b3-8b2c-4473239d60d1\","},{"line_number":1714,"context_line":"        ):"},{"line_number":1715,"context_line":"            self._attach_share("},{"line_number":1716,"context_line":"                server, \"e8debdc0-447a-4376-a10a-4cd9122d7986\""},{"line_number":1717,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":50,"id":"7e93735c_8bd24793","line":1714,"range":{"start_line":1711,"start_character":0,"end_line":1714,"end_character":10},"updated":"2024-06-20 12:07:51.000000000","message":"mocking in a functional test is discouraged. Please use the replacement facility instead.\n//later\nIt seems that the sample has the share_id so it does not matter what share_mapping_id is generated. So you should be able to drop the mock without replacement.","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c40da29de9ae7ff5ce659e3737ba845d13eebb07","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"        self.notifier.reset()"},{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        # Return a constant share uuid"},{"line_number":1711,"context_line":"        with mock.patch("},{"line_number":1712,"context_line":"            \"oslo_utils.uuidutils.generate_uuid\","},{"line_number":1713,"context_line":"            return_value\u003d\"f7c1726d-7622-42b3-8b2c-4473239d60d1\","},{"line_number":1714,"context_line":"        ):"},{"line_number":1715,"context_line":"            self._attach_share("},{"line_number":1716,"context_line":"                server, \"e8debdc0-447a-4376-a10a-4cd9122d7986\""},{"line_number":1717,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":50,"id":"5ab905ef_7455ccb9","line":1714,"range":{"start_line":1711,"start_character":0,"end_line":1714,"end_character":10},"in_reply_to":"7e93735c_8bd24793","updated":"2024-06-26 16:12:52.000000000","message":"Done","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b5ef22de91d06d0f7f52212b0bc300d32cca10b","unresolved":true,"context_lines":[{"line_number":375,"context_line":"    \u0027ComputeTaskNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":376,"context_line":"    \u0027ComputeTaskPayload\u0027: \u00271.0-59a9b78b6199470a83c8d07bffd13f5e\u0027,"},{"line_number":377,"context_line":"    \u0027DestinationPayload\u0027: \u00271.0-d8faf610201bf5f460892243f6632a37\u0027,"},{"line_number":378,"context_line":"    \u0027EventType\u0027: \u00271.21-fab37f98c6e7513edece32ad5420f549\u0027,"},{"line_number":379,"context_line":"    \u0027ExceptionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":380,"context_line":"    \u0027ExceptionPayload\u0027: \u00271.1-34f006107693b8c9eaf4b104157d21b4\u0027,"},{"line_number":381,"context_line":"    \u0027FlavorNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"}],"source_content_type":"text/x-python","patch_set":50,"id":"f2c6cb89_0f77a922","line":378,"updated":"2024-06-20 12:07:51.000000000","message":"this is wrong. I think you need to bump the version of the event type not just updating the hash.","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c40da29de9ae7ff5ce659e3737ba845d13eebb07","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    \u0027ComputeTaskNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":376,"context_line":"    \u0027ComputeTaskPayload\u0027: \u00271.0-59a9b78b6199470a83c8d07bffd13f5e\u0027,"},{"line_number":377,"context_line":"    \u0027DestinationPayload\u0027: \u00271.0-d8faf610201bf5f460892243f6632a37\u0027,"},{"line_number":378,"context_line":"    \u0027EventType\u0027: \u00271.21-fab37f98c6e7513edece32ad5420f549\u0027,"},{"line_number":379,"context_line":"    \u0027ExceptionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":380,"context_line":"    \u0027ExceptionPayload\u0027: \u00271.1-34f006107693b8c9eaf4b104157d21b4\u0027,"},{"line_number":381,"context_line":"    \u0027FlavorNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"}],"source_content_type":"text/x-python","patch_set":50,"id":"2ba9811f_4557d1da","line":378,"in_reply_to":"f2c6cb89_0f77a922","updated":"2024-06-26 16:12:52.000000000","message":"Done","commit_id":"214ad1faedf836bce06e7786b2581eac2e3b009e"}]}