)]}'
{"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2449f4d23ae5da454e29619e8dcd671658fbfa1c","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        \"\"\""},{"line_number":207,"context_line":"        # We are intentionally not calling super() here. Nova\u0027s base test class"},{"line_number":208,"context_line":"        # defines starting and restarting compute service with a very"},{"line_number":209,"context_line":"        # different signatures and also those calls are cannot be made aware of"},{"line_number":210,"context_line":"        # the intricacies of the libvirt fixture. So we simply hide that"},{"line_number":211,"context_line":"        # implementation."},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"56f7604d_888100f0","line":209,"range":{"start_line":209,"start_character":52,"end_line":209,"end_character":55},"updated":"2022-08-10 10:02:27.000000000","message":"nit: delete","commit_id":"d275c20bca9029b6a3e992e9d4ba74ab614cea86"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"da231e8ec03335ecacba2d24f33b18ec036956d6","unresolved":true,"context_lines":[{"line_number":1187,"context_line":"        self.flags(cpu_dedicated_set\u003d\u00270-7\u0027, group\u003d\u0027compute\u0027)"},{"line_number":1188,"context_line":"        self.flags(vcpu_pin_set\u003dNone)"},{"line_number":1189,"context_line":""},{"line_number":1190,"context_line":"        for host in list(self.computes.keys()):"},{"line_number":1191,"context_line":"            self.restart_compute_service(host)"},{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        # verify that the inventory, usages and allocation are correct after"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0ba19e3_f733e84d","line":1190,"updated":"2022-08-09 16:50:04.000000000","message":"Isn\u0027t\n\n  for host in self.computes:\n\nthe same thing?","commit_id":"d275c20bca9029b6a3e992e9d4ba74ab614cea86"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2449f4d23ae5da454e29619e8dcd671658fbfa1c","unresolved":true,"context_lines":[{"line_number":1187,"context_line":"        self.flags(cpu_dedicated_set\u003d\u00270-7\u0027, group\u003d\u0027compute\u0027)"},{"line_number":1188,"context_line":"        self.flags(vcpu_pin_set\u003dNone)"},{"line_number":1189,"context_line":""},{"line_number":1190,"context_line":"        for host in list(self.computes.keys()):"},{"line_number":1191,"context_line":"            self.restart_compute_service(host)"},{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        # verify that the inventory, usages and allocation are correct after"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfea2c3f_98c5e413","line":1190,"in_reply_to":"e0ba19e3_f733e84d","updated":"2022-08-10 10:02:27.000000000","message":"technically that would use the iterator over teh keys and we are modifying self.computes in the call to restart_compute_service \n\na sideeffect of calling restart_compute_service is we recreate the compute service and store it in self.computes with the same hostname.\nhttps://review.opendev.org/c/openstack/nova/+/850510/5/nova/tests/functional/libvirt/base.py#226\n\nso we want to iterate over a copy of the keys not the keys themselves.\n\nthe the code is correct as is.\n\nthis could be list(self.computes) i think as that would still just be the keys but im fine with is as written.","commit_id":"d275c20bca9029b6a3e992e9d4ba74ab614cea86"}]}