)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40f9327172ebc7304b160a3120d99b162f6e7904","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9eb5183_f18e840c","updated":"2022-07-28 17:53:49.000000000","message":"I run out of time so it is not complete","commit_id":"528e813eb4cbf09fbde9ed094dbe21a9aa350543"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a7c367194e6847bfbd7a1c5b8b805bdfb9a8d039","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e46a095_451e05b6","updated":"2022-08-01 15:16:13.000000000","message":"Drive by review. I did *not* attempt to grok this fully. Just a couple things I noticed in passing.","commit_id":"33a3cca7f4f1ae9318865ef2bd1749e10786984a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52072b43a5e339c2dcab9d1186438218b69eaaa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"89e5f253_10cf428c","in_reply_to":"7e46a095_451e05b6","updated":"2022-08-02 13:32:26.000000000","message":"Ack","commit_id":"33a3cca7f4f1ae9318865ef2bd1749e10786984a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3102764e171c4430173c6e6d0b0ed8a3d8a05f5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"892c27e2_79378618","updated":"2022-08-02 17:49:31.000000000","message":"I am partly proving efried +1\n\nthis does appear to resolve the py310 ci issues and for the most part nothing looks too strange  so in the absence of evidence to suggest this is incorrect and based on Stephen review too im going to approve this.\n\nwe should likely watch the ci carefully for the next few days to see if this introduces any instability but for now I think this is good to proceed.","commit_id":"f8cf050a1380ae844e0184ed45f4a04fde3b07a9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d96ce2a261ff90f702402448d73ed8655fe6b4ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1fc1711d_dca00741","updated":"2022-08-02 16:25:34.000000000","message":"Nicely done","commit_id":"f8cf050a1380ae844e0184ed45f4a04fde3b07a9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1bcc1f6c2c2145ebd987f131324dae94279de61c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ad88bc5_dac29aa0","updated":"2022-08-02 14:03:23.000000000","message":"Thanks gibi!","commit_id":"f8cf050a1380ae844e0184ed45f4a04fde3b07a9"}],"nova/test.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a7c367194e6847bfbd7a1c5b8b805bdfb9a8d039","unresolved":true,"context_lines":[{"line_number":887,"context_line":"    def fake_exists(path):"},{"line_number":888,"context_line":"        if path \u003d\u003d patched_path:"},{"line_number":889,"context_line":"            return result"},{"line_number":890,"context_line":"        elif other:"},{"line_number":891,"context_line":"            return other"},{"line_number":892,"context_line":"        else:"},{"line_number":893,"context_line":"            return real_exists(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e1626e1_6ea35a09","line":890,"updated":"2022-08-01 15:16:13.000000000","message":"Should this be\n\nelif other is not None:\n\n? As written, if I want it to return False, I\u0027ll say ``other\u003dFalse`` and it\u0027ll drop through to ``real_exists(path)``.","commit_id":"a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52072b43a5e339c2dcab9d1186438218b69eaaa9","unresolved":false,"context_lines":[{"line_number":887,"context_line":"    def fake_exists(path):"},{"line_number":888,"context_line":"        if path \u003d\u003d patched_path:"},{"line_number":889,"context_line":"            return result"},{"line_number":890,"context_line":"        elif other:"},{"line_number":891,"context_line":"            return other"},{"line_number":892,"context_line":"        else:"},{"line_number":893,"context_line":"            return real_exists(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8837f8d1_7ee20298","line":890,"in_reply_to":"0fd9e0ef_e5d9707c","updated":"2022-08-02 13:32:26.000000000","message":"good point. fixed.","commit_id":"a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2de548cbb6b63b12f17752674c2b9ae0faead559","unresolved":true,"context_lines":[{"line_number":887,"context_line":"    def fake_exists(path):"},{"line_number":888,"context_line":"        if path \u003d\u003d patched_path:"},{"line_number":889,"context_line":"            return result"},{"line_number":890,"context_line":"        elif other:"},{"line_number":891,"context_line":"            return other"},{"line_number":892,"context_line":"        else:"},{"line_number":893,"context_line":"            return real_exists(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0fd9e0ef_e5d9707c","line":890,"in_reply_to":"9e1626e1_6ea35a09","updated":"2022-08-01 18:49:29.000000000","message":"+1 to check for None","commit_id":"a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"}],"nova/tests/unit/api/openstack/compute/test_limits.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a7c367194e6847bfbd7a1c5b8b805bdfb9a8d039","unresolved":true,"context_lines":[{"line_number":435,"context_line":"        self.mock_get_project_quotas.side_effect \u003d _get_project_quotas"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        response \u003d self.controller.index(self.req)"},{"line_number":438,"context_line":"        # staring from version 2.39 there is no \u0027maxImageMeta\u0027 field"},{"line_number":439,"context_line":"        # in response after removing \u0027image-metadata\u0027 proxy API"},{"line_number":440,"context_line":"        expected_response \u003d {"},{"line_number":441,"context_line":"            \"limits\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"b50341b6_fc24a092","line":438,"updated":"2022-08-01 15:16:13.000000000","message":"latent: s/staring/starting/","commit_id":"a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52072b43a5e339c2dcab9d1186438218b69eaaa9","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        self.mock_get_project_quotas.side_effect \u003d _get_project_quotas"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        response \u003d self.controller.index(self.req)"},{"line_number":438,"context_line":"        # staring from version 2.39 there is no \u0027maxImageMeta\u0027 field"},{"line_number":439,"context_line":"        # in response after removing \u0027image-metadata\u0027 proxy API"},{"line_number":440,"context_line":"        expected_response \u003d {"},{"line_number":441,"context_line":"            \"limits\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"0af519d1_d44a8d39","line":438,"in_reply_to":"b50341b6_fc24a092","updated":"2022-08-02 13:32:26.000000000","message":"Done","commit_id":"a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"}],"nova/tests/unit/api/openstack/compute/test_server_actions.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3102764e171c4430173c6e6d0b0ed8a3d8a05f5f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        # In most of the cases we don\u0027t care about anything getting as far as"},{"line_number":71,"context_line":"        # hitting the compute RPC API so we just mock it out here."},{"line_number":72,"context_line":"        patcher_rpcapi \u003d mock.patch.object(self.compute_api, \u0027compute_rpcapi\u0027)"},{"line_number":73,"context_line":"        self.mock_rpcapi \u003d patcher_rpcapi.start()"},{"line_number":74,"context_line":"        self.addCleanup(patcher_rpcapi.stop)"},{"line_number":75,"context_line":"        # The project_id here matches what is used by default in"},{"line_number":76,"context_line":"        # fake_compute_get which need to match for policy checks."}],"source_content_type":"text/x-python","patch_set":5,"id":"7b59dcb5_9f9881f6","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":24},"updated":"2022-08-02 17:49:31.000000000","message":"ok so we assign it here for the cases where we do care and update the side effect below instead of remoking.","commit_id":"f8cf050a1380ae844e0184ed45f4a04fde3b07a9"}]}