)]}'
{"id":"openstack%2Fnova~851445","triplet_id":"openstack%2Fnova~master~I3998d0d49583806ac1c3ae64f1b1fe343cefd20d","project":"openstack/nova","branch":"master","topic":"unittest.mock","attention_set":{},"removed_from_attention_set":{"14070":{"account":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"last_update":"2022-08-02 14:03:23.000000000","reason":"\u003cGERRIT_ACCOUNT_14070\u003e replied on the change","reason_account":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}},"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2022-08-02 20:24:55.000000000","reason":"Change was submitted"},"8556":{"account":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"last_update":"2022-08-02 20:24:55.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3998d0d49583806ac1c3ae64f1b1fe343cefd20d","subject":"Remove double mocking","status":"MERGED","created":"2022-07-28 17:53:21.000000000","updated":"2022-08-02 20:24:55.000000000","submitted":"2022-08-02 20:24:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":12,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"851445-unittest.mock","meta_rev_id":"a40de842d4c45c1f557a4029194f000b90fe270a","_number":851445,"virtual_id_number":851445,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-02 20:24:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2022-08-02 17:49:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2022-08-02 14:03:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2022-08-02 16:25:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2022-08-02 17:49:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-28 18:18:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-28 19:57:26.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-07-28 20:43:06.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2022-08-01 15:16:13.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"CC"},{"updated":"2022-08-01 16:18:08.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-01 16:31:55.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2022-08-01 18:49:29.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"CC"},{"updated":"2022-08-02 14:03:23.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2022-08-02 16:25:34.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-08-02 17:49:31.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"a96aa9acdb898337b29caaceb874f9b46bb94e77","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-07-28 17:53:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40f9327172ebc7304b160a3120d99b162f6e7904","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-07-28 17:53:49.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0f19fd498d8149e8443d367ee2102842865cb36d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-28 18:18:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/774eb2e792cc47f197bc5597d1d9b7e7\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/63a37b607ee84c399b64e3ae38d87b05 : SUCCESS in 16m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8bad770dc6bc4a80a3c17771f97cc804 : FAILURE in 10m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c729dfe9746f4e40822db309591d79fa : SUCCESS in 12m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0f76f42570114b50a69e88be4f7847f6 : SUCCESS in 12m 39s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/37d7f8291c4243fc9f00b5cd93535b5c : FAILURE in 15m 15s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5b70e6928ea34ccca9ad86ec66a71d7b : SUCCESS in 10m 33s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/a09bbd487fee416ebde5d057da88aa50 : SUCCESS in 6m 41s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/dc2790ada2e0458ea1504c5d788856df : SUCCESS in 23m 14s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/919176e09f694e5cb4df397487c5b503 : SUCCESS in 23m 17s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/1e2ea80d4cc944209e0e2b615f620cf8 : FAILURE in 19m 39s (non-voting)\n\nWarning:\n  Comments left for invalid file nova/tests/unit/compute/test_shelve.py","accounts_in_message":[],"_revision_number":1},{"id":"6da513e28f2a84394c98aaeec717bc6ccb646fd4","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-28 18:26:17.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a1e9655834244159a6b9ca7cc9f50790\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/756f8e6863534d1da61920eaf97c0c04 : SUCCESS in 30m 52s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/b6cc25229b6644e4b946627015fb2ee7 : SUCCESS in 22m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e03904fb56317f628f281e44cf71b365b06f0dea","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-07-28 19:57:26.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/b8aaba0993dd49aaa58bfd85769a6f87 : POST_FAILURE in 1h 53m 46s","accounts_in_message":[],"_revision_number":1},{"id":"7bf4e357e3fa496d62d55603d9cb79d9c4e7b481","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-07-28 20:43:06.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/851445/1/iscsi : FAILURE in 2h 47m 36s","accounts_in_message":[],"_revision_number":1},{"id":"394abe4207b7202bcf6f58a31af8c9c25fb4deea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-01 14:47:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5b3e5cc4c159f26cb6d41475bcba0906bcbea7ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-01 15:03:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a7c367194e6847bfbd7a1c5b8b805bdfb9a8d039","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2022-08-01 15:16:13.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"590b3d38b0d95b94668d4fd22da72ac7802495db","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-01 15:33:00.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/ec83c9fa744f4bbbb286c2c17aa71bf6\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c94676b4f3194c02b325b9890d145c76 : SUCCESS in 18m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cd2a17139647432aab014b3500f13ae2 : FAILURE in 13m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/18c3658bdb424e3eaaaedd8029648735 : SUCCESS in 15m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fb0e33a233774f62ad442469c8243907 : SUCCESS in 16m 02s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/260b0962190b4431854d264416ba3fd6 : SUCCESS in 16m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/59a8e21eaf1449e1aa9b23052c540608 : SUCCESS in 13m 31s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/fa7e599c2c10481b8167ece085e106d4 : SUCCESS in 8m 22s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/dac0dd5408b44ff8b980a9c2dc958699 : SUCCESS in 26m 13s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/5ce3ffec34ba40e9993359329d791498 : SUCCESS in 23m 39s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/4a4060afa31c4c19a44cc3acf8055050 : SUCCESS in 19m 44s (non-voting)\n\nWarning:\n  Comments left for invalid file nova/tests/unit/compute/test_shelve.py","accounts_in_message":[],"_revision_number":3},{"id":"ba0fe828e8b68d1fd0e5ee2959e658f71d18b84d","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-01 15:38:10.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/406d63d6d3214faf8c7000961d633c7a\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/5da56cb4a5f54615ae6e64ecbb7c43d9 : SUCCESS in 24m 44s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/2ee4c520ead344bb8b22e7e2b74aefc6 : SUCCESS in 24m 39s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"236379e470bc346019d756f6443e4400af6a33fa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-01 15:47:23.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"5442fede6ad817cab0fa6cc11fddbff7af4706fd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-01 16:17:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5e6926e33ff041ddb0f6492a08867502\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/23839019b24340d18698fcf765845d2b : SUCCESS in 18m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cfb7e6afe072490988fbad41129db37d : SUCCESS in 15m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5646d6ce7b884a3f92b01388564b5598 : SUCCESS in 12m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b7320b3542a045b28b44125121631cce : SUCCESS in 17m 07s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4ff8d9fc8358480ebe87242fcb34f4a9 : SUCCESS in 13m 49s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/882aa2c495c04477b05971230aa1c4fe : SUCCESS in 10m 32s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/45e18b4b9d5e4e98a2ddae724d2aac6e : SUCCESS in 6m 27s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7976dfbd88b94aff836a71a944f4b048 : SUCCESS in 24m 19s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/9611c9cfb656426ca52f75bd7c9c65ee : SUCCESS in 23m 32s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/6284924ede7c4ff48202cb726c1f72a1 : SUCCESS in 22m 33s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"e3b4e9713f1b96b7ea2a3f5e72510bfb8d0199d8","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2022-08-01 16:18:08.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/45/851445/4/check/EMC_PowerFlex_NOVA/0994f2a/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":4},{"id":"2b4c1352f116c9919cc5a18cf5ddd193ec313773","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-01 16:18:16.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e14af4c01ad64ffe9455bf8edfaf76ce\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/4a82cc5dc13743b7a0aef376c267fb3c : SUCCESS in 19m 47s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/01217d955d6345cfb603ea9e24f926a0 : SUCCESS in 21m 14s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"d32b3ddedcb4efe9e93c28500b742b911d5218ed","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2022-08-01 16:18:43.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/45/851445/4/check/EMC_PowerFlex_NOVA/66b25dc/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":4},{"id":"dd04ba6e9fb699a7845689489d22734479a88939","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2022-08-01 16:31:55.000000000","message":"Patch Set 4:\n\nBuild SUCCESS. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":4},{"id":"2de548cbb6b63b12f17752674c2b9ae0faead559","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2022-08-01 18:49:29.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9b3def06485cb917de205a0f1e15bdfa0e51c533","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-08-01 19:01:51.000000000","message":"Patch Set 4:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/851445/4/iscsi : SUCCESS in 3h 11m 29s","accounts_in_message":[],"_revision_number":4},{"id":"787eb1fdc2704456a61f47e1d38755dfd6ae0ac3","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-08-01 19:46:25.000000000","message":"Patch Set 4:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/e0f2cc20ca994537b341ba9282611ef8 : TIMED_OUT in 3h 08m 02s","accounts_in_message":[],"_revision_number":4},{"id":"d31c66483b418105dad5dbfa1ce541a16ec1b340","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-02 13:32:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"52072b43a5e339c2dcab9d1186438218b69eaaa9","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-02 13:32:26.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"b339a404d2e047f380b5c001e82c965deb1ca9c7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 14:01:30.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7ac4df8f4672436f933389dbf42dff9b\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/45c7958fb7dd4bf1a6e57b707bc776e6 : SUCCESS in 13m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/62c08d677fe440ca92e90a6d55dccc23 : SUCCESS in 12m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9e70f30cb7194943b5fdaa176bb84565 : SUCCESS in 13m 21s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bb469336ea344ceea0323aa25cb54cb9 : SUCCESS in 13m 27s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5c220e390ccd4fdeb95d8ec35dc951e8 : SUCCESS in 13m 16s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf2fabbb093240e385d463de3c1043d3 : SUCCESS in 11m 00s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b4c9c6bd42ad4cde813c5d632b854bb5 : SUCCESS in 6m 07s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c61cc3d16e2d49b697c54b8ce4ee2634 : SUCCESS in 20m 19s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/23865949e51746feadae313d50136914 : SUCCESS in 19m 56s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/f98f7ca4b2c545fb97b7e44395c32cb1 : SUCCESS in 22m 30s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"1bcc1f6c2c2145ebd987f131324dae94279de61c","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2022-08-02 14:03:23.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"ab521e0f8262f0de66646e78e5690d9062002a72","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 14:04:00.000000000","message":"Patch Set 5:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2387724a76b34ea7844f67475d0cbe8e\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/22cb3f97e9ac4dc9b52717d8b2702d5f : SUCCESS in 29m 26s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/d2373267fe064d7f97572d6ecc150d56 : SUCCESS in 21m 36s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"62932bdfda19a79c6df79598a2159fd6c8d895d0","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2022-08-02 14:30:38.000000000","message":"Patch Set 5:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/45/851445/5/check/EMC_PowerFlex_NOVA/3feddf1/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":5},{"id":"eeb58b1814ee7bc63c6cc78627faff01b77fa0fa","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2022-08-02 15:14:43.000000000","message":"Patch Set 5:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":5},{"id":"3c6d2bc0192a87e6c3318b54c3c238dd01ee7d64","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-08-02 15:36:51.000000000","message":"Patch Set 5:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/cf49ff9fde4b464a86b120832058069e : POST_FAILURE in 1h 49m 47s","accounts_in_message":[],"_revision_number":5},{"id":"a4993fc038a4e7d6c6987e31517d4466cf087264","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-08-02 16:14:32.000000000","message":"Patch Set 5:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/851445/5/iscsi : SUCCESS in 2h 40m 36s","accounts_in_message":[],"_revision_number":5},{"id":"d96ce2a261ff90f702402448d73ed8655fe6b4ea","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-08-02 16:25:34.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"3102764e171c4430173c6e6d0b0ed8a3d8a05f5f","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-02 17:49:31.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"14246bac0792bb37b925bd8abca5778291592c7d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 17:50:12.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"e75dcdba347cbb2cd2a366ef7e7a27741c6adc29","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 20:24:54.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c125a59fbaa645f483836a93ac12e2dd\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd08af42270e43e49e8a3f7bcb02e729 : SUCCESS in 12m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e6c5c12352a54dc6855f771879426b36 : SUCCESS in 14m 20s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ccc58e192922406e9697171c53cfeaef : SUCCESS in 15m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/186a4615bbc64cc3a986d48386057fdd : SUCCESS in 11m 39s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b5787a9c54124eb7852112bb9c7615c4 : SUCCESS in 20m 51s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/9f5f9ba8e65f4c12923beddc49c34b8c : SUCCESS in 26m 39s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/2fe0f88537854d38a0166300fb756914 : SUCCESS in 7m 07s","accounts_in_message":[],"_revision_number":5},{"id":"a40de842d4c45c1f557a4029194f000b90fe270a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 20:24:55.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"f8cf050a1380ae844e0184ed45f4a04fde3b07a9","revisions":{"528e813eb4cbf09fbde9ed094dbe21a9aa350543":{"kind":"REWORK","_number":1,"created":"2022-07-28 17:53:21.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/45/851445/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/851445/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/851445/1"}}},"commit":{"parents":[{"commit":"cfbda3d845de285ec05ed20586450c037addd7d5","subject":"Use unittest.mock instead of third party mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cfbda3d845de285ec05ed20586450c037addd7d5"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/528e813eb4cbf09fbde9ed094dbe21a9aa350543"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/528e813eb4cbf09fbde9ed094dbe21a9aa350543"}]},"branch":"refs/heads/master"},"a1e4c849d5bb430d67135780ba5ff6dd60ddf84e":{"kind":"REWORK","_number":2,"created":"2022-08-01 14:47:59.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/45/851445/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/851445/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/851445/2"}}},"commit":{"parents":[{"commit":"cfbda3d845de285ec05ed20586450c037addd7d5","subject":"Use unittest.mock instead of third party mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cfbda3d845de285ec05ed20586450c037addd7d5"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-08-01 14:47:13.000000000","tz":120},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a1e4c849d5bb430d67135780ba5ff6dd60ddf84e"}]},"branch":"refs/heads/master"},"33a3cca7f4f1ae9318865ef2bd1749e10786984a":{"kind":"REWORK","_number":3,"created":"2022-08-01 15:03:08.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/45/851445/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/851445/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/851445/3"}}},"commit":{"parents":[{"commit":"d1ab27716ea13419fe50c97498d26cb45ae2e0de","subject":"Use unittest.mock instead of third party mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d1ab27716ea13419fe50c97498d26cb45ae2e0de"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-08-01 14:56:21.000000000","tz":120},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/33a3cca7f4f1ae9318865ef2bd1749e10786984a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/33a3cca7f4f1ae9318865ef2bd1749e10786984a"}]},"branch":"refs/heads/master"},"4508609e84ad5645c3d84fb809b358ff6764168b":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-08-01 15:47:23.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/45/851445/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/851445/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/851445/4"}}},"commit":{"parents":[{"commit":"89ef050b8c049b9a6f0e2c70408fc93c826c55e0","subject":"Use unittest.mock instead of third party mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89ef050b8c049b9a6f0e2c70408fc93c826c55e0"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-08-01 15:47:12.000000000","tz":120},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4508609e84ad5645c3d84fb809b358ff6764168b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4508609e84ad5645c3d84fb809b358ff6764168b"}]},"branch":"refs/heads/master"},"f8cf050a1380ae844e0184ed45f4a04fde3b07a9":{"kind":"REWORK","_number":5,"created":"2022-08-02 13:32:09.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/45/851445/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/45/851445/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/45/851445/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/45/851445/5"}}},"commit":{"parents":[{"commit":"89ef050b8c049b9a6f0e2c70408fc93c826c55e0","subject":"Use unittest.mock instead of third party mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89ef050b8c049b9a6f0e2c70408fc93c826c55e0"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-08-02 13:31:15.000000000","tz":120},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f8cf050a1380ae844e0184ed45f4a04fde3b07a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f8cf050a1380ae844e0184ed45f4a04fde3b07a9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}