)]}'
{"id":"openstack%2Fnova~851854","triplet_id":"openstack%2Fnova~master~I4a6b56c5619fdf972193c5c78aa8ce5a417e532e","project":"openstack/nova","branch":"master","attention_set":{"9642":{"account":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"last_update":"2022-08-02 15:27:54.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4a6b56c5619fdf972193c5c78aa8ce5a417e532e","subject":"Skip useless qemu-img convert when snapshotting","status":"NEW","created":"2022-08-02 12:55:25.000000000","updated":"2023-06-30 12:10:54.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c475c6b1311ed0b3c7210d591967645292afe58b","_number":851854,"virtual_id_number":851854,"owner":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-06-30 12:10:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-02 13:28:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-02 14:46:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-02 14:46:44.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-02 15:27:54.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2022-08-02 15:33:52.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2022-08-02 16:07:00.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-06-30 08:26:16.000000000","updated_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"reviewer":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"state":"CC"}],"messages":[{"id":"912c91ab67fe909140b89bd98ec45c7377da6ecb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"date":"2022-08-02 12:55:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b08adcb142652e81e14e1ba1c184ed918ee93f95","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 13:28:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4f4d28babd104d6080a26d2e63f88c48\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ed6ed731be184effafc6012cc2d27b5a : SUCCESS in 17m 43s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ba1feb420ec04e2d9ecc08cad851f188 : SUCCESS in 30m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"64e9def0c8bc351bd6dbcba6995fee45d41efe02","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 14:46:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/141a2bd5342a4003a7140101099334dd\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/999c2a7ee3764c66bc4e56ae2b33a961 : SUCCESS in 1h 26m 31s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/40a0472ee385410b9775d3209b590615 : SUCCESS in 49m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6214b634699548f8876d43a248618845 : SUCCESS in 18m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/beadec0f5205450f88dc5371c9d1d902 : SUCCESS in 13m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/347659843c12455c94c9f7e2bd2049e9 : SUCCESS in 12m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/444778c2d39b4f80a4a55f8f3b91638c : SUCCESS in 13m 15s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b64b55d4778f4bc7a598a2876e42705a : FAILURE in 13m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e90d0a0afe6848d488974f5dda71a9b9 : SUCCESS in 10m 11s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/579faf6f3ad24582a17db3a2cbf84d56 : SUCCESS in 52m 49s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/66339a775e514a039f64a3dfb6befb7b : SUCCESS in 1h 20m 06s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7d7cad8c7e52490ba503caec5ad369f3 : SUCCESS in 55m 33s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/4db06adb3e7943cbaacdba2b66b535e4 : SUCCESS in 1h 06m 03s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/dabbaa72beca4698bafc60f68ccdafbd : SUCCESS in 57m 07s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/70c205c6fe3e4f85a72606031cf0b76b : SUCCESS in 1h 39m 39s\n- nova-next https://zuul.opendev.org/t/openstack/build/0cd51e661141435aae02bee389cb4bc0 : SUCCESS in 1h 45m 35s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/b49440532cc64d74af6f13dac2901920 : SUCCESS in 45m 03s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/680426469d8040aea2ceea9bebed3568 : SUCCESS in 8m 06s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/94d6509428c84d20a350d8433baa8e72 : SUCCESS in 19m 47s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/885412082f984373b4f29292e0d6a9ad : SUCCESS in 22m 48s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/eb16dffc99e241a2ab71b8753fb40952 : FAILURE in 20m 42s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/491ff4f2e58548ec93360a73004f0c53 : SUCCESS in 1h 00m 27s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6cdc105402d346aeac81faa27f19ac13 : SUCCESS in 1h 01m 07s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/78bd33802a674ce1ba9a37cd9935076b : SUCCESS in 30m 36s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/3fdfe702cfdd47b585e0c4ed900e8349 : SUCCESS in 44m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"78b9edb947632a8e9e3de44de49dc24ee861945c","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2022-08-02 14:46:44.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/54/851854/1/check/EMC_PowerFlex_NOVA/2daa8e5/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"28c5a6f58821db0851487417b0cbd3b5ab7c5005","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-08-02 15:27:54.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/851854/1/iscsi : SUCCESS in 2h 31m 10s","accounts_in_message":[],"_revision_number":1},{"id":"4e7953aa78beaff4569ef0affc464a4059b7dba6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2022-08-02 15:33:52.000000000","message":"Patch Set 1:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1},{"id":"0fda9ca84c0fd348c9f2ecad23252d15d11325de","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-08-02 16:07:00.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/f33bb5f38ed94ddc89e62e9e6776074d : POST_FAILURE in 2h 49m 57s","accounts_in_message":[],"_revision_number":1},{"id":"3c8ee53621aa1ad957d3beda18bc5d89ab30219a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"date":"2023-06-30 08:35:38.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"532d569d2cc542b83e329e90124fe4e4a5d53464","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"date":"2023-06-30 08:50:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f1ab2fc8661364318a4c8d115e01cc2b0b6a52d8","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-30 09:29:24.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/daf12935210b4a8789406c2981a4106c\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/407ec57e058f495e90f0067a566b3e7f : FAILURE in 11m 05s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/0cc43fdd61b4482a891018eabd35e8a0 : FAILURE in 12m 10s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/52cc7887bfe54bf8bf06da55645693ee : FAILURE in 36m 13s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"c475c6b1311ed0b3c7210d591967645292afe58b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-30 12:10:54.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/0d1efc410dba41f19aacc4f70435ee84\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/f25065d58c16467c9fdd6f9bc9e10c7b : SUCCESS in 56m 26s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/5ce784cdc23948a39736c2908794582c : SUCCESS in 1h 21m 50s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/062dbe8ef4734136bee6d3e49c429836 : SUCCESS in 43m 51s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/44be8c2789d446a0987c232a5b7e064c : FAILURE in 13m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22bb83135e1f4d36ad8d911cdf52fedc : FAILURE in 8m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2cc8be19521b4698a94c5c4748eb153d : FAILURE in 13m 06s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/43fd275e1de849d4bff68dbb6649cbbc : FAILURE in 12m 33s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9e61be6a05a24453a43b84195141130b : FAILURE in 13m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1c317644285241cf9499fcda171d7842 : SUCCESS in 9m 51s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/30000a52ec0241868e951dffcd3a95e9 : SUCCESS in 45m 19s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/8f7a85cb50db45f3b7ae368066ac7499 : FAILURE in 2h 05m 03s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8897c340f94b44589e70855f3ef61eb5 : SUCCESS in 39m 31s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/561f89a82c5a4c90a16096afdb226e3c : SUCCESS in 47m 44s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/a33aa3dbad43462b8a8066001947ab56 : FAILURE in 50m 18s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/8c2c17f0fd3945d3bb1c55db94537e2c : FAILURE in 2h 08m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/3301d849a590428082444dcbebed701a : SUCCESS in 1h 39m 40s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/d0f4fff1db8a4fc790cfd173ae1e4901 : SUCCESS in 1h 02m 07s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/cd118a322d49418db1163580e0b444d2 : SUCCESS in 9m 00s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/4b8cac56ac4e4234b723ac9fc7f477f3 : SUCCESS in 21m 48s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/66868e4337474eb1a3f8850bad83c9af : SUCCESS in 27m 21s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/45f18786379a4745976ec24397417f0f : SUCCESS in 29m 19s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/07c1d95a9eef41ab8f6c3500dbe172f1 : SUCCESS in 1h 34m 33s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/9a57c3583fe94f58aae57ad457e6703a : TIMED_OUT in 3h 04m 47s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/77384fbd96464b1081f4c16c33987315 : SUCCESS in 1h 17m 50s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/d811aac12de34d0a8d273f68ef4ec3b4 : SUCCESS in 40m 03s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/b7562730cae14b239e3b8661b03b4c7a : SUCCESS in 30m 22s (non-voting)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"849f16d777646b7257e9c41af0394964e28fb9d4","revisions":{"b057072da2ec58f99df0703e432dcb8c928360e8":{"kind":"REWORK","_number":1,"created":"2022-08-02 12:55:25.000000000","uploader":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"ref":"refs/changes/54/851854/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/851854/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/851854/1"}}},"commit":{"parents":[{"commit":"89ef050b8c049b9a6f0e2c70408fc93c826c55e0","subject":"Use unittest.mock instead of third party mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89ef050b8c049b9a6f0e2c70408fc93c826c55e0"}]}],"author":{"name":"Guillaume Espanel","email":"guillaume.espanel.ext@ovhcloud.com","date":"2022-08-01 10:03:21.000000000","tz":0},"committer":{"name":"Guillaume Espanel","email":"guillaume.espanel.ext@ovhcloud.com","date":"2022-08-02 12:55:22.000000000","tz":120},"subject":"Skip useless qemu-img convert when snapshotting","message":"Skip useless qemu-img convert when snapshotting\n\nWhen a qcow2 snapshot is created from an instance running off a raw\ndisk image, the resulting .delta file is a qcow2 file that doesn\u0027t have\na backing file. In this case, and when no compression is needed, the\nqemu-img convert operation performed on the .delta file is not needed\n(in our tests, the qemu-img convert in this case reduces the size of the\nresulting image by a small fraction).\n\nWith this patch, if the image we extract a snapshot off doesn\u0027t have a\nbacking file and we don\u0027t want compression and the image input format is\nthe same as the image output format, the qemu-img convert call\nis replaced by a os.rename call to get the snapshot.\n\nChange-Id: I4a6b56c5619fdf972193c5c78aa8ce5a417e532e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b057072da2ec58f99df0703e432dcb8c928360e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b057072da2ec58f99df0703e432dcb8c928360e8"}]},"branch":"refs/heads/master"},"19e2a0b8667ca0a895f9be4d9cd506ca924f57ae":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-06-30 08:35:38.000000000","uploader":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"ref":"refs/changes/54/851854/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/851854/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/851854/2"}}},"commit":{"parents":[{"commit":"d56d1a828df512136645aa257082bc929a4e353d","subject":"Merge \"Verify a move operation for cross_az_attach\u003dFalse\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d56d1a828df512136645aa257082bc929a4e353d"}]}],"author":{"name":"Guillaume Espanel","email":"guillaume.espanel.ext@ovhcloud.com","date":"2022-08-01 10:03:21.000000000","tz":0},"committer":{"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","date":"2023-06-30 08:35:38.000000000","tz":0},"subject":"Skip useless qemu-img convert when snapshotting","message":"Skip useless qemu-img convert when snapshotting\n\nWhen a qcow2 snapshot is created from an instance running off a raw\ndisk image, the resulting .delta file is a qcow2 file that doesn\u0027t have\na backing file. In this case, and when no compression is needed, the\nqemu-img convert operation performed on the .delta file is not needed\n(in our tests, the qemu-img convert in this case reduces the size of the\nresulting image by a small fraction).\n\nWith this patch, if the image we extract a snapshot off doesn\u0027t have a\nbacking file and we don\u0027t want compression and the image input format is\nthe same as the image output format, the qemu-img convert call\nis replaced by a os.rename call to get the snapshot.\n\nChange-Id: I4a6b56c5619fdf972193c5c78aa8ce5a417e532e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/19e2a0b8667ca0a895f9be4d9cd506ca924f57ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/19e2a0b8667ca0a895f9be4d9cd506ca924f57ae"}]},"branch":"refs/heads/master","description":"Rebase"},"849f16d777646b7257e9c41af0394964e28fb9d4":{"kind":"REWORK","_number":3,"created":"2023-06-30 08:50:32.000000000","uploader":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"ref":"refs/changes/54/851854/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/851854/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/851854/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/851854/3"}}},"commit":{"parents":[{"commit":"d56d1a828df512136645aa257082bc929a4e353d","subject":"Merge \"Verify a move operation for cross_az_attach\u003dFalse\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d56d1a828df512136645aa257082bc929a4e353d"}]}],"author":{"name":"Guillaume Espanel","email":"guillaume.espanel.ext@ovhcloud.com","date":"2022-08-01 10:03:21.000000000","tz":0},"committer":{"name":"Guillaume Espanel","email":"guillaume.espanel@ovhcloud.com","date":"2023-06-30 08:49:40.000000000","tz":120},"subject":"Skip useless qemu-img convert when snapshotting","message":"Skip useless qemu-img convert when snapshotting\n\nWhen a qcow2 snapshot is created from an instance running off a raw\ndisk image, the resulting .delta file is a qcow2 file that doesn\u0027t have\na backing file. In this case, and when no compression is needed, the\nqemu-img convert operation performed on the .delta file is not needed\n(in our tests, the qemu-img convert in this case reduces the size of the\nresulting image by a small fraction).\n\nWith this patch, if the image we extract a snapshot off doesn\u0027t have a\nbacking file and we don\u0027t want compression and the image input format is\nthe same as the image output format, the qemu-img convert call\nis replaced by a shutil.move call to get the snapshot.\n\nChange-Id: I4a6b56c5619fdf972193c5c78aa8ce5a417e532e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/849f16d777646b7257e9c41af0394964e28fb9d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/849f16d777646b7257e9c41af0394964e28fb9d4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}