)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"4de81bb0284b1678fc6591657ddbc3e49adca3f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d340530c_eb4098f8","updated":"2023-02-02 13:58:13.000000000","message":"recheck","commit_id":"b5aeaf7f915afb2d3cf8141c632a6c180ed7c8cd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7eacc1339588653c007607df08ab8048375bf3b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"257c7d89_75462de3","updated":"2024-08-28 14:30:29.000000000","message":"looks OK to me.","commit_id":"474c6b5f4b8cfd679288b86675f8b43c47681398"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"85d103567931798e46549a6d55939e8c9fe94ad6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"5fc36fd3_3f2a6e58","updated":"2024-09-24 13:12:57.000000000","message":"LGTM","commit_id":"14146cdb834cc6c1442a9839fc25908cc3ea4447"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98487d5ad75d72afeb512134cb4d6193b0e94728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"2dae0aca_452139cf","updated":"2024-11-05 14:10:51.000000000","message":"looks good just a minor refactor request","commit_id":"283e8373b6548965b95772a3e6fc922e3669a52b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9b5698c47104d21142adef6389b95f9a9f8e0d63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"fc788a40_60f8745d","updated":"2024-11-15 10:53:54.000000000","message":"test nit remains. Please propose a follow up then I can upgrade my vote.","commit_id":"81cc3471162d65e8e6e80e3c01d83f0403ae56a1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"09f47cf779ed36a2c651b0272e5413fc5104738a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":60,"id":"4ddeb3cb_d2084709","updated":"2024-11-21 08:58:23.000000000","message":"FUP is in the works so I\u0027m upgrading my vote.","commit_id":"95bd61d1cdeeee2e819f42471a6571717be2d7d4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09deea4694adcecd88b8d548fb64d4ff0c462dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"41de80b0_71e86fa9","updated":"2024-11-22 16:42:31.000000000","message":"nothing to say now","commit_id":"cbe20899ddf0538e590675138b9558dd5284a33a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3faea6b94d7a105bb0196fddd28ee74413ffb7d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"05830464_15481ba7","updated":"2024-12-11 12:24:19.000000000","message":"recheck ancestor","commit_id":"a34103c53f5560f802d558ecd9ae5a46d0176980"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"92f232a6b9e08629655b556efeae097054d6dc7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"45dba560_76a7d567","updated":"2024-12-13 07:11:35.000000000","message":"recheck https://review.opendev.org/927088 is now merged","commit_id":"a34103c53f5560f802d558ecd9ae5a46d0176980"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"be746e1e0ea6d95bcffd586c8174f678529f667d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"2eda1d40_e882530d","updated":"2024-12-09 10:30:35.000000000","message":"recheck parent merged","commit_id":"a34103c53f5560f802d558ecd9ae5a46d0176980"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c495e3bf27deb711ed7e816e6154610582c33d5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"ee9055bd_9c8c91cf","updated":"2024-12-10 12:41:37.000000000","message":"recheck requeue after ancestor rechecked","commit_id":"a34103c53f5560f802d558ecd9ae5a46d0176980"}],"nova/tests/functional/libvirt/test_server_shares.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"811c15986c3daa5179a97b2b6adf503339a987cc","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        return xml"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_filesystem_tag(self, xml, tag):"},{"line_number":66,"context_line":"        # Tag is the filesystem target directory."},{"line_number":67,"context_line":"        # If POST /server/{server_id}/share was called without a specific tag"},{"line_number":68,"context_line":"        # then the tag is the share id."},{"line_number":69,"context_line":"        tags \u003d []"},{"line_number":70,"context_line":"        tree \u003d etree.fromstring(xml)"},{"line_number":71,"context_line":"        device_nodes \u003d tree.find(\u0027./devices\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"a55182ec_9738c55d","line":68,"range":{"start_line":66,"start_character":1,"end_line":68,"end_character":39},"updated":"2023-02-08 17:48:51.000000000","message":"move this comment to the call of _assert_filesystem_tag at L131 as there it explains why we are passing share_id to the assert","commit_id":"2f658e945223e19ec0ee618eb998a23214bb619b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"b8063e1dd533a46d7d78cca4940e1b3e04709ed3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return xml"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_filesystem_tag(self, xml, tag):"},{"line_number":66,"context_line":"        # Tag is the filesystem target directory."},{"line_number":67,"context_line":"        # If POST /server/{server_id}/share was called without a specific tag"},{"line_number":68,"context_line":"        # then the tag is the share id."},{"line_number":69,"context_line":"        tags \u003d []"},{"line_number":70,"context_line":"        tree \u003d etree.fromstring(xml)"},{"line_number":71,"context_line":"        device_nodes \u003d tree.find(\u0027./devices\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"539bba48_72904cf6","line":68,"range":{"start_line":66,"start_character":1,"end_line":68,"end_character":39},"in_reply_to":"a55182ec_9738c55d","updated":"2023-03-06 10:19:04.000000000","message":"Done","commit_id":"2f658e945223e19ec0ee618eb998a23214bb619b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98487d5ad75d72afeb512134cb4d6193b0e94728","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_server_share_metadata(self):"},{"line_number":110,"context_line":"        \"\"\"Verify that share metadata are available\"\"\""},{"line_number":111,"context_line":"        with mock.patch("},{"line_number":112,"context_line":"            \u0027nova.virt.libvirt.volume.nfs.LibvirtNFSVolumeDriver.\u0027"},{"line_number":113,"context_line":"            \u0027disconnect_volume\u0027"},{"line_number":114,"context_line":"        ), mock.patch("},{"line_number":115,"context_line":"            \u0027nova.virt.libvirt.volume.nfs.LibvirtNFSVolumeDriver.\u0027"},{"line_number":116,"context_line":"            \u0027connect_volume\u0027"},{"line_number":117,"context_line":"        ):"},{"line_number":118,"context_line":"            traits \u003d self._get_provider_traits("},{"line_number":119,"context_line":"                self.compute_rp_uuids[self.compute])"},{"line_number":120,"context_line":"            for trait in ("}],"source_content_type":"text/x-python","patch_set":58,"id":"76703f17_d28148de","line":117,"range":{"start_line":111,"start_character":1,"end_line":117,"end_character":10},"updated":"2024-11-05 14:10:51.000000000","message":"don\u0027t we have a fixture for this? If not then feel free to just move this as always mocked in the ServerSharesTestBase class.","commit_id":"283e8373b6548965b95772a3e6fc922e3669a52b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"513a093d52747aca61dd23ab410966a3bb7b02a0","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_server_share_metadata(self):"},{"line_number":110,"context_line":"        \"\"\"Verify that share metadata are available\"\"\""},{"line_number":111,"context_line":"        with mock.patch("},{"line_number":112,"context_line":"            \u0027nova.virt.libvirt.volume.nfs.LibvirtNFSVolumeDriver.\u0027"},{"line_number":113,"context_line":"            \u0027disconnect_volume\u0027"},{"line_number":114,"context_line":"        ), mock.patch("},{"line_number":115,"context_line":"            \u0027nova.virt.libvirt.volume.nfs.LibvirtNFSVolumeDriver.\u0027"},{"line_number":116,"context_line":"            \u0027connect_volume\u0027"},{"line_number":117,"context_line":"        ):"},{"line_number":118,"context_line":"            traits \u003d self._get_provider_traits("},{"line_number":119,"context_line":"                self.compute_rp_uuids[self.compute])"},{"line_number":120,"context_line":"            for trait in ("}],"source_content_type":"text/x-python","patch_set":58,"id":"561fef97_5af7b92e","line":117,"range":{"start_line":111,"start_character":1,"end_line":117,"end_character":10},"in_reply_to":"76703f17_d28148de","updated":"2024-11-21 08:54:53.000000000","message":"It was much easier to fix in a follow up patch.\nThis is done in change: If8b2263c86f4eb580426b1a7b3de28c85cf5af1a on top of the series.","commit_id":"283e8373b6548965b95772a3e6fc922e3669a52b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98487d5ad75d72afeb512134cb4d6193b0e94728","unresolved":true,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_server_cephfs_share_metadata(self):"},{"line_number":140,"context_line":"        \"\"\"Verify that cephfs share metadata are available\"\"\""},{"line_number":141,"context_line":"        with mock.patch("},{"line_number":142,"context_line":"            \u0027nova.virt.libvirt.volume.cephfs.LibvirtCEPHFSVolumeDriver.\u0027"},{"line_number":143,"context_line":"            \u0027disconnect_volume\u0027"},{"line_number":144,"context_line":"        ), mock.patch("},{"line_number":145,"context_line":"            \u0027nova.virt.libvirt.volume.cephfs.LibvirtCEPHFSVolumeDriver.\u0027"},{"line_number":146,"context_line":"            \u0027connect_volume\u0027"},{"line_number":147,"context_line":"        ):"},{"line_number":148,"context_line":"            # update the mock to call the cephfs fake values"},{"line_number":149,"context_line":"            self.manila_fixture.mock_get.side_effect \u003d ("},{"line_number":150,"context_line":"                self.manila_fixture.fake_get_cephfs"}],"source_content_type":"text/x-python","patch_set":58,"id":"06e985fd_b0350193","line":147,"range":{"start_line":141,"start_character":0,"end_line":147,"end_character":10},"updated":"2024-11-05 14:10:51.000000000","message":"ditto","commit_id":"283e8373b6548965b95772a3e6fc922e3669a52b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"513a093d52747aca61dd23ab410966a3bb7b02a0","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_server_cephfs_share_metadata(self):"},{"line_number":140,"context_line":"        \"\"\"Verify that cephfs share metadata are available\"\"\""},{"line_number":141,"context_line":"        with mock.patch("},{"line_number":142,"context_line":"            \u0027nova.virt.libvirt.volume.cephfs.LibvirtCEPHFSVolumeDriver.\u0027"},{"line_number":143,"context_line":"            \u0027disconnect_volume\u0027"},{"line_number":144,"context_line":"        ), mock.patch("},{"line_number":145,"context_line":"            \u0027nova.virt.libvirt.volume.cephfs.LibvirtCEPHFSVolumeDriver.\u0027"},{"line_number":146,"context_line":"            \u0027connect_volume\u0027"},{"line_number":147,"context_line":"        ):"},{"line_number":148,"context_line":"            # update the mock to call the cephfs fake values"},{"line_number":149,"context_line":"            self.manila_fixture.mock_get.side_effect \u003d ("},{"line_number":150,"context_line":"                self.manila_fixture.fake_get_cephfs"}],"source_content_type":"text/x-python","patch_set":58,"id":"58012328_28b910db","line":147,"range":{"start_line":141,"start_character":0,"end_line":147,"end_character":10},"in_reply_to":"06e985fd_b0350193","updated":"2024-11-21 08:54:53.000000000","message":"Done","commit_id":"283e8373b6548965b95772a3e6fc922e3669a52b"}]}