)]}'
{"id":"openstack%2Fnova~852135","triplet_id":"openstack%2Fnova~master~I73b5cabdd7579b072a59ae8ab09d1efef2ec4f01","project":"openstack/nova","branch":"master","topic":"fix_get_function_by_ifname","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2022-08-10 03:41:23.000000000","reason":"Change was abandoned"},"31652":{"account":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"last_update":"2022-08-05 02:35:39.000000000","reason":"\u003cGERRIT_ACCOUNT_31652\u003e replied on the change","reason_account":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"}}},"hashtags":[],"change_id":"I73b5cabdd7579b072a59ae8ab09d1efef2ec4f01","subject":"pci: fix checking for physical function","status":"ABANDONED","created":"2022-08-04 10:09:26.000000000","updated":"2022-08-10 03:41:23.000000000","total_comment_count":12,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"73c5c6ce45e31cc88d6588f4f5dc68d7809e1327","_number":852135,"virtual_id_number":852135,"owner":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-08-04 11:50:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2022-08-04 10:30:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}],"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-04 10:30:38.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2022-08-04 10:46:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-04 11:50:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-04 11:51:09.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-04 12:15:31.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2022-08-04 13:50:36.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2022-08-04 14:09:06.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"d82c4e9b799375b8f8b4c7e3d3e62750bd2b516c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"date":"2022-08-04 10:09:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a11d229058c5853a8b49e00da65477c527e0966","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-04 10:30:38.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c3aa3319d0a96af39ab641c9e84a620a05acd90a","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-04 10:31:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"18c8cae42384fd21de352750586b7e15baeeb9bb","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 10:46:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/904994146b644f6da5a818d83f717ee4\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ceab0904641243ceb72db3789feb19b6 : SUCCESS in 31m 47s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/6356e6a7c71a498ab849a1fda863686d : SUCCESS in 32m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dfbddbdad37796311f135270e4e5918bf301fd2d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 11:50:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3b510d6da6024734b0f668e931de5ac9\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/b525fbdc3d5845afa1116b016580478b : SUCCESS in 1h 20m 58s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9effac21446346969ee7c7b1856a2451 : SUCCESS in 50m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/03f199c43f444cdfaa6480ee19e292a4 : SUCCESS in 17m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2a23836e2cd049e1a5167839cde358df : SUCCESS in 14m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b15c5dc12e15452184d2d05d2a10a04c : SUCCESS in 15m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d8f5b87b6da247119eeb68d3f4da3882 : SUCCESS in 10m 58s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4712bba0f1f0467d9669a80d7f4c3833 : FAILURE in 11m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6f5ef279a6f54133981d7c24bfb5f49d : SUCCESS in 8m 53s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7fa5a49add8b497596d926fdd277ff59 : SUCCESS in 54m 35s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/eaa3d547850b4233984327c2d7763379 : SUCCESS in 1h 09m 29s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ca99be6af2d14832acdd2c6165ff09b1 : SUCCESS in 49m 54s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/f53fb339ff484f26aa28d9b7fcd8e473 : SUCCESS in 46m 32s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/7aafc45d20c04fa9ac1dd4eaa8d2f2b1 : SUCCESS in 1h 14m 13s\n- nova-next https://zuul.opendev.org/t/openstack/build/4c8514b0264e41d8a90a13320b1006dc : SUCCESS in 1h 34m 24s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/7be89ab49e8e416193a7a7bf185f56c5 : SUCCESS in 56m 00s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/6fe03b238f364f1d82ee93528ebb053b : SUCCESS in 5m 20s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8284e168f1974bbf8eaded504806c053 : SUCCESS in 20m 03s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/43b30ddceaca453495a73e4082a45e92 : SUCCESS in 20m 34s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/aab8c9be65784ad9bebd6656f4ed1d1f : FAILURE in 18m 31s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/dba738ed02b544d78b07726858e4c907 : SUCCESS in 1h 02m 51s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8dd2442b269844c08688ebb943b833c7 : SUCCESS in 46m 01s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/e5dfe0ea72484da294494b39c3833b86 : SUCCESS in 27m 39s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/edfe112a992c4c6a9cc1f1101c28d97b : SUCCESS in 43m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"05d53c59edd40ad8c084c46aa87170b51705c449","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2022-08-04 11:51:09.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA https://elab-os-logsrv.delllabs.net/35/852135/1/check/EMC_PowerFlex_NOVA/16ed08a/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"842af3c2f2cdbc56395686d2f19b30790a174753","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2022-08-04 12:15:31.000000000","message":"Patch Set 1:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1},{"id":"4a1462903a1be563944bb5fd1767fba4e79e14b3","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-08-04 13:50:36.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/852135/1/iscsi : FAILURE in 3h 15m 09s","accounts_in_message":[],"_revision_number":1},{"id":"fb50fd3ca002507dc5286ff9f85d6bdc4e45c092","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-08-04 14:09:06.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/0a5468680c5345b087c11260c87aef5b : TIMED_OUT in 3h 23m 24s","accounts_in_message":[],"_revision_number":1},{"id":"c3e3108755448e8a3ee575727c09b3f9276ae2e1","author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"date":"2022-08-05 02:35:39.000000000","message":"Patch Set 1:\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"8745b67149c4df9011ce699f8ff45bf652b838a5","author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"date":"2022-08-10 03:39:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73c5c6ce45e31cc88d6588f4f5dc68d7809e1327","tag":"autogenerated:gerrit:abandon","author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"date":"2022-08-10 03:41:23.000000000","message":"Abandoned\n\nalready fixed","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a01bd5d7ef74284f655e5c3b00651142021b07a8","revisions":{"a01bd5d7ef74284f655e5c3b00651142021b07a8":{"kind":"REWORK","_number":1,"created":"2022-08-04 10:09:26.000000000","uploader":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"ref":"refs/changes/35/852135/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/35/852135/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/35/852135/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/35/852135/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/35/852135/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/35/852135/1"}}},"commit":{"parents":[{"commit":"3b4378c1890337a096b26f1a5335620d475cb778","subject":"Merge \"Fix mocking SafeConnectedTestCase\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3b4378c1890337a096b26f1a5335620d475cb778"}]}],"author":{"name":"Nobuhiro MIKI","email":"nmiki@yahoo-corp.jp","date":"2022-08-04 09:17:19.000000000","tz":540},"committer":{"name":"Nobuhiro MIKI","email":"nmiki@yahoo-corp.jp","date":"2022-08-04 10:08:47.000000000","tz":540},"subject":"pci: fix checking for physical function","message":"pci: fix checking for physical function\n\nIf drivers for recently released Mellanox drivers (mlx5_core\nand mlx5e_rep) are used, the VF representor is incorrectly\nidentified as PF. This is because the VF representor used\nin switchdev mode [1] also has a value in sriov_totalvfs,\njust like PF.\n\nFor example, if Mellanox Out-of-Box driver (OFED 5.4+) is\nused, the values under /sys/class/net are as follows.\n\nFor PF:\n  /sys/class/net/eth1/phys_port_name:p1\n  /sys/class/net/eth1/device/sriov_totalvfs:10\n\nFor VF representor:\n  /sys/class/net/vfrep0/phys_port_name:pf1vf0\n  /sys/class/net/vfrep0/device/sriov_totalvfs:10\n\nFor VF:\n  /sys/class/net/vf0/phys_port_name: Operation not supported\n  /sys/class/net/vf0/device/sriov_totalvfs: No such file or directory\n\nFor reference, libvirt already contains a similar logic to determine\nPF based on phys_port_name [2]. The regex to match PF is also\ndiscussed and is used in this patch.\n\n\u003e All PF devices have a phys_port_name matching a particular regex\n\u003e (p[0-9]+$)|(p[0-9]+s[0-9]+$)\n\n[1] https://www.kernel.org/doc/html/latest/networking/switchdev.html\n[2] https://gitlab.com/libvirt/libvirt/-/commit/5b1c525b1f3608156884aed0dc5e925306c1e260\n\nChange-Id: I73b5cabdd7579b072a59ae8ab09d1efef2ec4f01\nSigned-off-by: Nobuhiro MIKI \u003cnmiki@yahoo-corp.jp\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a01bd5d7ef74284f655e5c3b00651142021b07a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a01bd5d7ef74284f655e5c3b00651142021b07a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}