)]}'
{".zuul.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b830d5b6ee842e6e1624fc9eda69477d227ab299","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        - nova-tox-functional-py38"},{"line_number":666,"context_line":"        - nova-tox-functional-py39"},{"line_number":667,"context_line":"        - nova-tox-functional-py310:"},{"line_number":668,"context_line":"            voting: true"},{"line_number":669,"context_line":"        - openstack-tox-py310:"},{"line_number":670,"context_line":"            voting: true"},{"line_number":671,"context_line":"        - tempest-integrated-compute:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dbbe0830_bd5f7b4c","line":668,"updated":"2022-08-09 10:04:18.000000000","message":"nit: Can\u0027t we just drop this?","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        - nova-tox-functional-py38"},{"line_number":666,"context_line":"        - nova-tox-functional-py39"},{"line_number":667,"context_line":"        - nova-tox-functional-py310:"},{"line_number":668,"context_line":"            voting: true"},{"line_number":669,"context_line":"        - openstack-tox-py310:"},{"line_number":670,"context_line":"            voting: true"},{"line_number":671,"context_line":"        - tempest-integrated-compute:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"779032ea_34dc8f71","line":668,"in_reply_to":"dbbe0830_bd5f7b4c","updated":"2022-08-09 16:51:12.000000000","message":"i think it would be non voting in the current template.\nso we should keep this until a","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b830d5b6ee842e6e1624fc9eda69477d227ab299","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        - nova-tox-functional-py39"},{"line_number":667,"context_line":"        - nova-tox-functional-py310:"},{"line_number":668,"context_line":"            voting: true"},{"line_number":669,"context_line":"        - openstack-tox-py310:"},{"line_number":670,"context_line":"            voting: true"},{"line_number":671,"context_line":"        - tempest-integrated-compute:"},{"line_number":672,"context_line":"           # NOTE(gmann): Policies changes do not need to run all the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3e96172f_1d13a145","line":669,"updated":"2022-08-09 10:04:18.000000000","message":"nit: Probably want to add a note reminding us to drop this once it\u0027s included in a job template. Maybe the bot will do this for us?","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        - nova-tox-functional-py39"},{"line_number":667,"context_line":"        - nova-tox-functional-py310:"},{"line_number":668,"context_line":"            voting: true"},{"line_number":669,"context_line":"        - openstack-tox-py310:"},{"line_number":670,"context_line":"            voting: true"},{"line_number":671,"context_line":"        - tempest-integrated-compute:"},{"line_number":672,"context_line":"           # NOTE(gmann): Policies changes do not need to run all the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"51c00f1f_ee348bad","line":669,"in_reply_to":"3e96172f_1d13a145","updated":"2022-08-09 16:51:12.000000000","message":"i think we will remember to do this when we are updating the branched the branched templates for A on line 637-638","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b830d5b6ee842e6e1624fc9eda69477d227ab299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a79ea3d_9bda9760","updated":"2022-08-09 10:04:18.000000000","message":"Nice work 👍","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b30685711b9c2e8e982f6ea0cfad6cf5978bd4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"317abfdf_92c5b672","updated":"2022-08-09 16:18:08.000000000","message":"if other have not reviewd it ill review this after teh upstream irc meeting","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2e7725984ac11cd450c09e8b95b62b280f6efe3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5b220b9_173dc526","updated":"2022-08-10 07:22:31.000000000","message":"recheck port binding failed","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d5a3da361d2bc42c0f73aa3da1e97fc3d6b2b751","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddd4ac7c_3194e622","updated":"2022-08-10 09:49:43.000000000","message":"recheck seems like a control network failure during resize:\n\nAug 10 08:11:18.851514 ubuntu-focal-rax-iad-0030682409 nova-compute[101808]: ERROR nova.compute.manager [instance: ba26a35f-fd39-4d07-aeb2-368532354496] Command: scp -r /opt/stack/data/nova/instances/ba26a35f-fd39-4d07-aeb2-368532354496_resize/disk 10.209.0.96:/opt/stack/data/nova/instances/ba26a35f-fd39-4d07-aeb2-368532354496/disk\n\nAug 10 08:11:18.851514 ubuntu-focal-rax-iad-0030682409 nova-compute[101808]: ERROR nova.compute.manager [instance: ba26a35f-fd39-4d07-aeb2-368532354496] Exit code: 1\n\nAug 10 08:11:18.851514 ubuntu-focal-rax-iad-0030682409 nova-compute[101808]: ERROR nova.compute.manager [instance: ba26a35f-fd39-4d07-aeb2-368532354496] Stdout: \u0027\u0027\n\nAug 10 08:11:18.851514 ubuntu-focal-rax-iad-0030682409 nova-compute[101808]: ERROR nova.compute.manager [instance: ba26a35f-fd39-4d07-aeb2-368532354496] Stderr: \u0027kex_exchange_identification: Connection closed by remote host\\r\\nlost connection\\n\u0027\n\nAug 10 08:11:18.851514 ubuntu-focal-rax-iad-0030682409 nova-compute[101808]: ERROR nova.compute.manager [instance: ba26a35f-fd39-4d07-aeb2-368532354496] ","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16f2e7a1_74cbb76b","updated":"2022-08-09 16:51:12.000000000","message":"we aggreed to make the python 3.10 jobs voting in the meeting and i dont see any issue bar stephns nit regarding a comment to remind us to drop the voting overrides so +2w","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"nova/tests/fixtures/libvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":2220,"context_line":""},{"line_number":2221,"context_line":"        self.useFixture("},{"line_number":2222,"context_line":"            fixtures.MockPatch(\u0027nova.virt.libvirt.utils.get_fs_info\u0027))"},{"line_number":2223,"context_line":"        self.mock_get_machine_ips \u003d self.useFixture("},{"line_number":2224,"context_line":"            fixtures.MockPatch(\u0027nova.compute.utils.get_machine_ips\u0027)).mock"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        # libvirt driver needs to call out to the filesystem to get the"}],"source_content_type":"text/x-python","patch_set":1,"id":"dea23a0d_9f1fe0cc","line":2223,"updated":"2022-08-09 16:51:12.000000000","message":"ack so these changes are just naming the fixture mocks so that we can reference them and update them later in the patch where we prviously double mocked.\n+1","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":1100,"context_line":"        # Don\u0027t poison the function if it\u0027s already mocked"},{"line_number":1101,"context_line":"        import nova.virt.libvirt.host"},{"line_number":1102,"context_line":"        if not isinstance(nova.virt.libvirt.host.Host._init_events, mock.Mock):"},{"line_number":1103,"context_line":"            self.useFixture(fixtures.MockPatch("},{"line_number":1104,"context_line":"                \u0027nova.virt.libvirt.host.Host._init_events\u0027,"},{"line_number":1105,"context_line":"                side_effect\u003devloop))"},{"line_number":1106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"aeb79936_f9607104","side":"PARENT","line":1103,"range":{"start_line":1103,"start_character":37,"end_line":1103,"end_character":46},"updated":"2022-08-09 16:51:12.000000000","message":"ok so we are convertign form \nhttps://github.com/testing-cabal/fixtures/blob/1c9e951be29f203b720251b1288b6ca54ce1b505/README.rst#mockpatch\n\nAdapts mock.patch to be used as a Fixture.\n\nto","commit_id":"adeea3d5e7d7337d2817dd5c46334c76c05995ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":1106,"context_line":"        # Don\u0027t poison the function if it\u0027s already mocked"},{"line_number":1107,"context_line":"        import nova.virt.libvirt.host"},{"line_number":1108,"context_line":"        if not isinstance(nova.virt.libvirt.host.Host._init_events, mock.Mock):"},{"line_number":1109,"context_line":"            self.useFixture(fixtures.MonkeyPatch("},{"line_number":1110,"context_line":"                \u0027nova.virt.libvirt.host.Host._init_events\u0027,"},{"line_number":1111,"context_line":"                evloop))"},{"line_number":1112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a686efc_2078e91c","line":1109,"range":{"start_line":1109,"start_character":37,"end_line":1109,"end_character":48},"updated":"2022-08-09 16:51:12.000000000","message":"https://github.com/testing-cabal/fixtures/blob/1c9e951be29f203b720251b1288b6ca54ce1b505/README.rst#monkeypatch\n\nControl the value of a named Python attribute.\n\n\u003e\u003e\u003e def fake_open(path, mode):\n...     pass\n\u003e\u003e\u003e fixture \u003d fixtures.MonkeyPatch(\u0027__builtin__.open\u0027, fake_open)\nNote that there are some complexities when patching methods - please see the API documentation for details.\n\nhttps://github.com/testing-cabal/fixtures/blob/1c9e951be29f203b720251b1288b6ca54ce1b505/fixtures/_fixtures/monkeypatch.py#L99-L127\n\n   \"\"\"Create a MonkeyPatch.\n        :param name: The fully qualified object name to override.\n        :param new_value: A value to set the name to. If set to\n            MonkeyPatch.delete the attribute will be deleted.\n        During setup the name will be deleted or assigned the requested value,\n        and this will be restored in cleanUp.\n        When patching methods, the call signature of name should be a subset\n        of the parameters which can be used to call new_value.\n        For instance.\n        \u003e\u003e\u003e class T:\n        ...     def method(self, arg1):\n        ...         pass\n        \u003e\u003e\u003e class N:\n        ...     @staticmethod\n        ...     def newmethod(arg1):\n        ...         pass\n        Patching N.newmethod on top of T.method and then calling T().method(1)\n        will not work because they do not have compatible call signatures -\n        self will be passed to newmethod because the callable (N.newmethod)\n        is placed onto T as a regular function. This allows capturing all the\n        supplied parameters while still consulting local state in your\n        new_value.\n        \"\"\"\n        \n based on how we were previously use the side_effect to execute evloop this makes sesnse that we can mokeypatch it instead.","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"nova/tests/functional/compute/test_resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":695,"context_line":"        compute service that provides that trait."},{"line_number":696,"context_line":"        \"\"\""},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"},{"line_number":699,"context_line":"        self.useFixture(nova_fixtures.GlanceFixture(self))"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        # Start nova services."},{"line_number":702,"context_line":"        self.api \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":703,"context_line":"            api_version\u003d\u0027v2.1\u0027)).admin_api"},{"line_number":704,"context_line":"        self.api.microversion \u003d \u0027latest\u0027"},{"line_number":705,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":706,"context_line":"        # start nova-compute that will not have the additional trait."},{"line_number":707,"context_line":"        self._start_compute(\"fake-host-1\")"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"45b430bd_ebe28ef0","side":"PARENT","line":705,"range":{"start_line":698,"start_character":0,"end_line":705,"end_character":39},"updated":"2022-08-09 16:51:12.000000000","message":"ok so this was just duplciated and not needed","commit_id":"adeea3d5e7d7337d2817dd5c46334c76c05995ef"}],"nova/tests/functional/libvirt/test_reshape.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        4) create another server now against the new tree"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        self.mock_file_open.side_effect \u003d ["},{"line_number":43,"context_line":"            io.BytesIO(b\u0027\u0027), io.BytesIO(b\u0027\u0027), io.BytesIO(b\u0027\u0027)]"},{"line_number":44,"context_line":"        # NOTE(gibi): We cannot simply ask the virt driver to create an old"},{"line_number":45,"context_line":"        # RP tree with vgpu on the root RP as that code path does not exist"},{"line_number":46,"context_line":"        # any more. So we have to hack a \"bit\". We will create a compute"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c918276_a78b9f43","line":43,"updated":"2022-08-09 16:51:12.000000000","message":"ack so you previosly nameed the fixture and now your just updating the sideeffect for this test case +1","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":1253,"context_line":"    def test_get_servers_detail_filters(self):"},{"line_number":1254,"context_line":"        # We get the results only from the up cells, this ignoring the down"},{"line_number":1255,"context_line":"        # cells if list_records_by_skipping_down_cells config option is True."},{"line_number":1256,"context_line":"        self.admin_api \u003d self.api_fixture.admin_api"},{"line_number":1257,"context_line":"        self.admin_api.microversion \u003d \u00272.69\u0027"},{"line_number":1258,"context_line":"        servers \u003d self.admin_api.get_servers("},{"line_number":1259,"context_line":"            search_opts\u003d{\u0027hostname\u0027: \"cell3-inst0\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"535b9592_521fda84","line":1256,"updated":"2022-08-09 16:51:12.000000000","message":"+1 just delegating to the existing fixture","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"nova/tests/unit/api/openstack/compute/test_server_group_quotas.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":210,"context_line":"        self.flags(driver\u003d\u0027nova.quota.UnifiedLimitsDriver\u0027, group\u003d\u0027quota\u0027)"},{"line_number":211,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":212,"context_line":"        self.controller \u003d sg_v21.ServerGroupController()"},{"line_number":213,"context_line":"        self.limit_fixture \u003d self.useFixture("},{"line_number":214,"context_line":"            limit_fixture.LimitFixture({\u0027server_groups\u0027: 10}, {}))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    @mock.patch(\u0027nova.limit.local.enforce_db_limit\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef30b590_17b6cf53","line":213,"updated":"2022-08-09 16:51:12.000000000","message":"+1 same pattern name","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":238,"context_line":"                                             delta\u003d1)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_group_fails_with_zero_quota(self):"},{"line_number":241,"context_line":"        self.limit_fixture.reglimits \u003d {\u0027server_groups\u0027: 0}"},{"line_number":242,"context_line":"        sgroup \u003d {\u0027name\u0027: \u0027test\u0027, \u0027policies\u0027: [\u0027anti-affinity\u0027]}"},{"line_number":243,"context_line":"        exc \u003d self.assertRaises(webob.exc.HTTPForbidden,"},{"line_number":244,"context_line":"                                self.controller.create,"}],"source_content_type":"text/x-python","patch_set":1,"id":"76a5f64a_652aada1","line":241,"updated":"2022-08-09 16:51:12.000000000","message":"and update where requried","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e774023efccba6ed002d215e83da5514038da3","unresolved":true,"context_lines":[{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        return snapshot_id"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    def _test_delete(self, delete_type, **attrs):"},{"line_number":971,"context_line":"        delete_time \u003d datetime.datetime("},{"line_number":972,"context_line":"            1955, 11, 5, 9, 30, tzinfo\u003diso8601.UTC)"},{"line_number":973,"context_line":"        timeutils.set_time_override(delete_time)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4a71f1a_062bb410","line":970,"range":{"start_line":970,"start_character":8,"end_line":970,"end_character":20},"updated":"2022-08-09 16:51:12.000000000","message":"ack this took me a minute to figure out that you factored this out.\nand renamed the orginial function to _do_delete","commit_id":"bf654e3a4a8f690ad0bec0955690bf4fadf98dba"}]}