)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1ad55c3996505de4d69f0c46791c52e88189c180","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"All contents in the original compute node should be released because"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"instance to be unshelved into the other compute node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For using nova-network environment, however,"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAW3%2F%2FgYA%3D","line":13,"updated":"2014-04-14 06:16:55.000000000","message":"the other \u003d\u003e another","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"1f72325e52b2b53c71fb44f69c8452b41686eb92","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"All contents in the original compute node should be released because"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"instance to be unshelved into the other compute node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For using nova-network environment, however,"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAW3%2F%2FfzE%3D","line":13,"in_reply_to":"AAAAW3%2F%2FgYA%3D","updated":"2014-08-26 05:31:37.000000000","message":"I fixed. Thank you for review the codes","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1ad55c3996505de4d69f0c46791c52e88189c180","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For using nova-network environment, however,"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"dummy mac address in the dhcp conf file is remained."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Therefore, this dummy dhcp mac address should be deleted during shelving instance work flow."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAW3%2F%2FgX8%3D","line":17,"updated":"2014-04-14 06:16:55.000000000","message":"is remained \u003d\u003e remains","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"1f72325e52b2b53c71fb44f69c8452b41686eb92","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For using nova-network environment, however,"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"dummy mac address in the dhcp conf file is remained."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Therefore, this dummy dhcp mac address should be deleted during shelving instance work flow."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAW3%2F%2FfzA%3D","line":17,"in_reply_to":"AAAAW3%2F%2FgX8%3D","updated":"2014-08-26 05:31:37.000000000","message":"I fixed. Thank you for review the codes","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     seungjin \u003cseungjin77.han@samsung.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-16 00:58:59 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing dummy mac address in the dhcp conf file when shelving instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a dummy contents of dhcp conf file during shelving instance."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa98f980_159d19bc","line":7,"updated":"2014-09-16 08:11:43.000000000","message":"Topic for commit message must not be greater than 50 characters","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is a dummy contents of dhcp conf file during shelving instance."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"All contents in the original compute node should be released because"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"instance to be unshelved into another compute node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For using nova-network environment, however,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa98f980_95b02944","line":12,"updated":"2014-09-16 08:11:43.000000000","message":"Here not needed blank line.","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":13,"context_line":"instance to be unshelved into another compute node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For using nova-network environment, however,"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"dummy mac address in the dhcp conf file remains."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Therefore, this dummy dhcp mac address should be deleted during shelving instance work flow."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa98f980_b5ab6dd4","line":16,"updated":"2014-09-16 08:11:43.000000000","message":"Here not needed blank line.","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"dummy mac address in the dhcp conf file remains."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Therefore, this dummy dhcp mac address should be deleted during shelving instance work flow."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ibc36033700d11489014fb23d9f82e02e9ed804b8"},{"line_number":22,"context_line":"Closes-Bug: #1290635"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa98f980_f5b17544","line":19,"updated":"2014-09-16 08:11:43.000000000","message":"Line must not be greater than 72 characters -\u003e you have 92","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"}],"nova/network/linux_net.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f96fe766dec3466984d5991eef9246105c27e953","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    for fixedip in fixed_ip_obj.FixedIPList.get_by_network(context,"},{"line_number":902,"context_line":"                                                           network_ref,"},{"line_number":903,"context_line":"                                                           host\u003dhost):"},{"line_number":904,"context_line":"        if (fixedip.virtual_interface.address not in macs) and \\"},{"line_number":905,"context_line":"           (fixedip.virtual_interface.address !\u003d vif_address):"},{"line_number":906,"context_line":"            hosts.append(_host_dhcp(fixedip))"},{"line_number":907,"context_line":"            macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Vw4%3D","line":904,"updated":"2014-04-06 14:09:44.000000000","message":"Consider:\nif (fixedip.virtual_interface.address !\u003d vif_address and fixedip.virtual_interface.address not in macs):\n\nit is better to check the !\u003d and then the search in the array","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"7452b2878145b9bf4f1cc0f399cd21bf4fb89dd5","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    for fixedip in fixed_ip_obj.FixedIPList.get_by_network(context,"},{"line_number":902,"context_line":"                                                           network_ref,"},{"line_number":903,"context_line":"                                                           host\u003dhost):"},{"line_number":904,"context_line":"        if (fixedip.virtual_interface.address not in macs) and \\"},{"line_number":905,"context_line":"           (fixedip.virtual_interface.address !\u003d vif_address):"},{"line_number":906,"context_line":"            hosts.append(_host_dhcp(fixedip))"},{"line_number":907,"context_line":"            macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Tpg%3D","line":904,"in_reply_to":"AAAAWH%2F9Vw4%3D","updated":"2014-04-07 08:19:19.000000000","message":"I fixed\nThanks for reviwing the codes","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1ad55c3996505de4d69f0c46791c52e88189c180","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    for fixedip in fixed_ip_obj.FixedIPList.get_by_network(context,"},{"line_number":902,"context_line":"                                                           network_ref,"},{"line_number":903,"context_line":"                                                           host\u003dhost):"},{"line_number":904,"context_line":"        if (fixedip.virtual_interface.address !\u003d vif_address) and \\"},{"line_number":905,"context_line":"           (fixedip.virtual_interface.address not in macs):"},{"line_number":906,"context_line":"            hosts.append(_host_dhcp(fixedip))"},{"line_number":907,"context_line":"            macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FgX0%3D","line":904,"updated":"2014-04-14 06:16:55.000000000","message":"please use:\nif (fixedip.virtual_interface.address !\u003d vif_address and\n        fixedip.virtual_interface.address not in macs):","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"1f72325e52b2b53c71fb44f69c8452b41686eb92","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    for fixedip in fixed_ip_obj.FixedIPList.get_by_network(context,"},{"line_number":902,"context_line":"                                                           network_ref,"},{"line_number":903,"context_line":"                                                           host\u003dhost):"},{"line_number":904,"context_line":"        if (fixedip.virtual_interface.address !\u003d vif_address) and \\"},{"line_number":905,"context_line":"           (fixedip.virtual_interface.address not in macs):"},{"line_number":906,"context_line":"            hosts.append(_host_dhcp(fixedip))"},{"line_number":907,"context_line":"            macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2Ffy8%3D","line":904,"in_reply_to":"AAAAW3%2F%2FgX0%3D","updated":"2014-08-26 05:31:37.000000000","message":"I fixed. Thank you for review the codes","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d54db5c54092066eb267bd0f501b0087942bd4a4","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    for fixedip in fixed_ip_obj.FixedIPList.get_by_network(context,"},{"line_number":902,"context_line":"                                                           network_ref,"},{"line_number":903,"context_line":"                                                           host\u003dhost):"},{"line_number":904,"context_line":"        if (fixedip.virtual_interface.address !\u003d vif_address and \\"},{"line_number":905,"context_line":"            fixedip.virtual_interface.address not in macs):"},{"line_number":906,"context_line":"            hosts.append(_host_dhcp(fixedip))"},{"line_number":907,"context_line":"            macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FfDU%3D","line":904,"updated":"2014-04-14 09:49:43.000000000","message":"you do not need the \\\nthe () ensure that it can wrap on the next line\nyou do need to move the bottom spaces to the right for pep8","commit_id":"a848cf75d3fcfed6a2635325e3c2588c8fb5ade7"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"63e37d0ca7ecfedc3f908cfcd5d0f9be8dba557a","unresolved":false,"context_lines":[{"line_number":901,"context_line":"    for fixedip in fixed_ip_obj.FixedIPList.get_by_network(context,"},{"line_number":902,"context_line":"                                                           network_ref,"},{"line_number":903,"context_line":"                                                           host\u003dhost):"},{"line_number":904,"context_line":"        if (fixedip.virtual_interface.address !\u003d vif_address and \\"},{"line_number":905,"context_line":"            fixedip.virtual_interface.address not in macs):"},{"line_number":906,"context_line":"            hosts.append(_host_dhcp(fixedip))"},{"line_number":907,"context_line":"            macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FYUc%3D","line":904,"in_reply_to":"AAAAW3%2F%2FfDU%3D","updated":"2014-08-26 05:31:20.000000000","message":"I fixed it\n\nThank you for review the codes","commit_id":"a848cf75d3fcfed6a2635325e3c2588c8fb5ade7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4b1afb46c73bdded34a3e9f0b9f6a35be9c02ff3","unresolved":false,"context_lines":[{"line_number":891,"context_line":"    return \u0027\\n\u0027.join(hosts)"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"def get_dhcp_hosts(context, network_ref, vif_address\u003dNone):"},{"line_number":895,"context_line":"    \"\"\"Get network\u0027s hosts config in dhcp-host format.\"\"\""},{"line_number":896,"context_line":"    hosts \u003d []"},{"line_number":897,"context_line":"    host \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_b0e4b0a8","line":894,"updated":"2014-06-19 13:11:11.000000000","message":"ok, it took me a while to grok what was going on here, mostly because of naming.\n\nCan we change vif_address to exclude_addresses, and make it an array [].\n\nThen do if fixedip.virtual_interface.address not in exclude_addresses.\n\nI think the code becomes a lot more readable after that, and then I\u0027d be +2.","commit_id":"ac8b3067401ed9073ddea24e18f309398bd41234"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"ff17669f98c0e21d60842e877c519ddf048824d5","unresolved":false,"context_lines":[{"line_number":891,"context_line":"    return \u0027\\n\u0027.join(hosts)"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"def get_dhcp_hosts(context, network_ref, vif_address\u003dNone):"},{"line_number":895,"context_line":"    \"\"\"Get network\u0027s hosts config in dhcp-host format.\"\"\""},{"line_number":896,"context_line":"    hosts \u003d []"},{"line_number":897,"context_line":"    host \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_e748fc2e","line":894,"in_reply_to":"1ae5cdf2_b0e4b0a8","updated":"2014-08-23 11:28:17.000000000","message":"I tried to make it readable.\nThanks for reviewing the code","commit_id":"ac8b3067401ed9073ddea24e18f309398bd41234"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    macs \u003d set()"},{"line_number":917,"context_line":"    for fixedip in fixedips:"},{"line_number":918,"context_line":"        if fixedip.allocated:"},{"line_number":919,"context_line":"\t    if (fixedip.virtual_interface.address not in exclude_addresses) and \\"},{"line_number":920,"context_line":"               (fixedip.virtual_interface.address not in macs):"},{"line_number":921,"context_line":"                hosts.append(_host_dhcp(fixedip))"},{"line_number":922,"context_line":"                macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_15eb5913","line":919,"range":{"start_line":919,"start_character":72,"end_line":919,"end_character":74},"updated":"2014-09-16 08:11:43.000000000","message":"Also replace the backslash on brackets.","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    macs \u003d set()"},{"line_number":917,"context_line":"    for fixedip in fixedips:"},{"line_number":918,"context_line":"        if fixedip.allocated:"},{"line_number":919,"context_line":"\t    if (fixedip.virtual_interface.address not in exclude_addresses) and \\"},{"line_number":920,"context_line":"               (fixedip.virtual_interface.address not in macs):"},{"line_number":921,"context_line":"                hosts.append(_host_dhcp(fixedip))"},{"line_number":922,"context_line":"                macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_9597498f","line":919,"range":{"start_line":919,"start_character":0,"end_line":919,"end_character":2},"updated":"2014-09-16 08:11:43.000000000","message":"Please remove redundant `tab`.","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"4ed807254c5f866896c2a6933b37894e888801c0","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    macs \u003d set()"},{"line_number":917,"context_line":"    for fixedip in fixedips:"},{"line_number":918,"context_line":"        if fixedip.allocated:"},{"line_number":919,"context_line":"\t    if (fixedip.virtual_interface.address not in exclude_addresses) and \\"},{"line_number":920,"context_line":"               (fixedip.virtual_interface.address not in macs):"},{"line_number":921,"context_line":"                hosts.append(_host_dhcp(fixedip))"},{"line_number":922,"context_line":"                macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_95e829e3","line":919,"in_reply_to":"fa98f980_15eb5913","updated":"2014-09-16 08:20:41.000000000","message":"Done","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"4ed807254c5f866896c2a6933b37894e888801c0","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    macs \u003d set()"},{"line_number":917,"context_line":"    for fixedip in fixedips:"},{"line_number":918,"context_line":"        if fixedip.allocated:"},{"line_number":919,"context_line":"\t    if (fixedip.virtual_interface.address not in exclude_addresses) and \\"},{"line_number":920,"context_line":"               (fixedip.virtual_interface.address not in macs):"},{"line_number":921,"context_line":"                hosts.append(_host_dhcp(fixedip))"},{"line_number":922,"context_line":"                macs.add(fixedip.virtual_interface.address)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_d5ee31ec","line":919,"in_reply_to":"fa98f980_9597498f","updated":"2014-09-16 08:20:41.000000000","message":"Done","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"c06038e58555a364580f4ee51a772e5e6375787d","unresolved":false,"context_lines":[{"line_number":914,"context_line":"    if not exclude_addresses:"},{"line_number":915,"context_line":"        exclude_addresses \u003d []"},{"line_number":916,"context_line":"    macs \u003d set()"},{"line_number":917,"context_line":"    for fixedip in fixedips:"},{"line_number":918,"context_line":"        if fixedip.allocated:"},{"line_number":919,"context_line":"            if (fixedip.virtual_interface.address not in exclude_addresses) \\"},{"line_number":920,"context_line":"                and (fixedip.virtual_interface.address not in macs):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_98105d51","line":917,"range":{"start_line":917,"start_character":8,"end_line":917,"end_character":15},"updated":"2014-09-16 11:21:31.000000000","message":"It must be an object. \n AttributeError: \u0027str\u0027 object has no attribute \u0027allocated\u0027","commit_id":"e11f9bb3745cfbd69372b165769e8b76a4a7db06"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"7d68a9c6abb4fae4a8f61470dc97379f1587f2fe","unresolved":false,"context_lines":[{"line_number":916,"context_line":"    macs \u003d set()"},{"line_number":917,"context_line":"    for fixedip in fixedips:"},{"line_number":918,"context_line":"        if fixedip.allocated:"},{"line_number":919,"context_line":"            if (fixedip.virtual_interface.address not in exclude_addresses) \\"},{"line_number":920,"context_line":"                and (fixedip.virtual_interface.address not in macs):"},{"line_number":921,"context_line":"                hosts.append(_host_dhcp(fixedip))"},{"line_number":922,"context_line":"                macs.add(fixedip.virtual_interface.address)"},{"line_number":923,"context_line":"    return \u0027\\n\u0027.join(hosts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_d0739f4b","line":920,"range":{"start_line":919,"start_character":15,"end_line":920,"end_character":68},"updated":"2014-09-16 09:12:11.000000000","message":"As I said in previous patch-set -\u003e\n\nif (fixedip.virtual_interface.address not in exclude_addresses\n        and fixedip.virtual_interface.address not in macs):","commit_id":"e11f9bb3745cfbd69372b165769e8b76a4a7db06"}],"nova/network/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f96fe766dec3466984d5991eef9246105c27e953","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"            if self.host \u003d\u003d host or host is None:"},{"line_number":1312,"context_line":"                # at this point i am the correct host, or host doesn\u0027t"},{"line_number":1313,"context_line":"                # matter -\u003e FlatManager"},{"line_number":1314,"context_line":"                call_func(context, network, vif.address)"},{"line_number":1315,"context_line":"            else:"},{"line_number":1316,"context_line":"                # i\u0027m not the right host, run call on correct host"},{"line_number":1317,"context_line":"                green_threads.append(eventlet.spawn("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Vwk%3D","line":1314,"updated":"2014-04-06 14:09:44.000000000","message":"please use vif_address\u003dvif.address","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"7452b2878145b9bf4f1cc0f399cd21bf4fb89dd5","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"            if self.host \u003d\u003d host or host is None:"},{"line_number":1312,"context_line":"                # at this point i am the correct host, or host doesn\u0027t"},{"line_number":1313,"context_line":"                # matter -\u003e FlatManager"},{"line_number":1314,"context_line":"                call_func(context, network, vif.address)"},{"line_number":1315,"context_line":"            else:"},{"line_number":1316,"context_line":"                # i\u0027m not the right host, run call on correct host"},{"line_number":1317,"context_line":"                green_threads.append(eventlet.spawn("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Tos%3D","line":1314,"in_reply_to":"AAAAWH%2F9Vwk%3D","updated":"2014-04-07 08:19:19.000000000","message":"I fixed\nThanks for reviwing the codes","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f96fe766dec3466984d5991eef9246105c27e953","unresolved":false,"context_lines":[{"line_number":1677,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":1678,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1679,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1680,"context_line":"            self.driver.update_dhcp(elevated, dev, network, vif_address)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1683,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Vww%3D","line":1680,"updated":"2014-04-06 14:09:44.000000000","message":"please use vif_address\u003dvif_address","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"7452b2878145b9bf4f1cc0f399cd21bf4fb89dd5","unresolved":false,"context_lines":[{"line_number":1677,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":1678,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1679,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1680,"context_line":"            self.driver.update_dhcp(elevated, dev, network, vif_address)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1683,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Too%3D","line":1680,"in_reply_to":"AAAAWH%2F9Vww%3D","updated":"2014-04-07 08:19:19.000000000","message":"I fixed\nThanks for reviwing the codes","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f96fe766dec3466984d5991eef9246105c27e953","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":1904,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1905,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1906,"context_line":"            self.driver.update_dhcp(elevated, dev, network, vif_address)"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"            # NOTE(ethuleau): For multi hosted networks, if the network is no"},{"line_number":1909,"context_line":"            # more used on this host and if VPN forwarding rule aren\u0027t handed"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Vws%3D","line":1906,"updated":"2014-04-06 14:09:44.000000000","message":"ditto","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"7452b2878145b9bf4f1cc0f399cd21bf4fb89dd5","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":1904,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1905,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1906,"context_line":"            self.driver.update_dhcp(elevated, dev, network, vif_address)"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"            # NOTE(ethuleau): For multi hosted networks, if the network is no"},{"line_number":1909,"context_line":"            # more used on this host and if VPN forwarding rule aren\u0027t handed"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Tog%3D","line":1906,"in_reply_to":"AAAAWH%2F9Vws%3D","updated":"2014-04-07 08:19:19.000000000","message":"I fixed\nThanks for reviwing the codes","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f96fe766dec3466984d5991eef9246105c27e953","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"                    fip.host \u003d None"},{"line_number":1924,"context_line":"                    fip.save()"},{"line_number":1925,"context_line":"            else:"},{"line_number":1926,"context_line":"                self.driver.update_dhcp(elevated, dev, network, vif_address)"},{"line_number":1927,"context_line":""},{"line_number":1928,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1929,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Vwo%3D","line":1926,"updated":"2014-04-06 14:09:44.000000000","message":"ditto","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"7452b2878145b9bf4f1cc0f399cd21bf4fb89dd5","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"                    fip.host \u003d None"},{"line_number":1924,"context_line":"                    fip.save()"},{"line_number":1925,"context_line":"            else:"},{"line_number":1926,"context_line":"                self.driver.update_dhcp(elevated, dev, network, vif_address)"},{"line_number":1927,"context_line":""},{"line_number":1928,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1929,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9Toc%3D","line":1926,"in_reply_to":"AAAAWH%2F9Vwo%3D","updated":"2014-04-07 08:19:19.000000000","message":"I fixed\nThanks for reviwing the codes","commit_id":"a4b9adc15a7b0eb3fa3ea059f95c9a054f82ecbe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1ad55c3996505de4d69f0c46791c52e88189c180","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1679,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1680,"context_line":"            self.driver.update_dhcp(elevated, dev, network,"},{"line_number":1681,"context_line":"                                                   vif_address\u003dvif_address)"},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1684,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FgXs%3D","line":1681,"updated":"2014-04-14 06:16:55.000000000","message":"indentation here is odd.\ncan you please have vif_address\u003dvif_address) under the elevated","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"1f72325e52b2b53c71fb44f69c8452b41686eb92","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1679,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1680,"context_line":"            self.driver.update_dhcp(elevated, dev, network,"},{"line_number":1681,"context_line":"                                                   vif_address\u003dvif_address)"},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1684,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2Ffy0%3D","line":1681,"in_reply_to":"AAAAW3%2F%2FgXs%3D","updated":"2014-08-26 05:31:37.000000000","message":"I fixed. Thank you for review the codes","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1ad55c3996505de4d69f0c46791c52e88189c180","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1906,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1907,"context_line":"            self.driver.update_dhcp(elevated, dev, network,"},{"line_number":1908,"context_line":"                                                   vif_address\u003dvif_address)"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"            # NOTE(ethuleau): For multi hosted networks, if the network is no"},{"line_number":1911,"context_line":"            # more used on this host and if VPN forwarding rule aren\u0027t handed"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FgXo%3D","line":1908,"updated":"2014-04-14 06:16:55.000000000","message":"ditto","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"1f72325e52b2b53c71fb44f69c8452b41686eb92","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"            # NOTE(dprince): dhcp DB queries require elevated context"},{"line_number":1906,"context_line":"            elevated \u003d context.elevated()"},{"line_number":1907,"context_line":"            self.driver.update_dhcp(elevated, dev, network,"},{"line_number":1908,"context_line":"                                                   vif_address\u003dvif_address)"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"            # NOTE(ethuleau): For multi hosted networks, if the network is no"},{"line_number":1911,"context_line":"            # more used on this host and if VPN forwarding rule aren\u0027t handed"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2Ffyw%3D","line":1908,"in_reply_to":"AAAAW3%2F%2FgXo%3D","updated":"2014-08-26 05:31:37.000000000","message":"I fixed. Thank you for review the codes","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1ad55c3996505de4d69f0c46791c52e88189c180","unresolved":false,"context_lines":[{"line_number":1926,"context_line":"                    fip.save()"},{"line_number":1927,"context_line":"            else:"},{"line_number":1928,"context_line":"                self.driver.update_dhcp(elevated, dev, network,"},{"line_number":1929,"context_line":"                                                       vif_address\u003dvif_address)"},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1932,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2FgXk%3D","line":1929,"updated":"2014-04-14 06:16:55.000000000","message":"ditto","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"1f72325e52b2b53c71fb44f69c8452b41686eb92","unresolved":false,"context_lines":[{"line_number":1926,"context_line":"                    fip.save()"},{"line_number":1927,"context_line":"            else:"},{"line_number":1928,"context_line":"                self.driver.update_dhcp(elevated, dev, network,"},{"line_number":1929,"context_line":"                                                       vif_address\u003dvif_address)"},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"    def _get_network_dict(self, network):"},{"line_number":1932,"context_line":"        \"\"\"Returns the dict representing necessary and meta network fields.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAW3%2F%2Ffys%3D","line":1929,"in_reply_to":"AAAAW3%2F%2FgXk%3D","updated":"2014-08-26 05:31:37.000000000","message":"I fixed. Thank you for review the codes","commit_id":"1da271acbfb4e1da7e8604862b6ba27ec09aa900"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"650f40b52ecc2f05b1337bbacd7e8e961858d5e7","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"        vifs \u003d objects.VirtualInterfaceList.get_by_instance_uuid("},{"line_number":1472,"context_line":"                context, instance.uuid)"},{"line_number":1473,"context_line":"        for vif in vifs:"},{"line_number":1474,"context_line":"            exclude_addresses.append(vif.address)"},{"line_number":1475,"context_line":"        LOG.debug(\u0027Setup networks on host\u0027, instance\u003dinstance)"},{"line_number":1476,"context_line":"        for vif in vifs:"},{"line_number":1477,"context_line":"            network \u003d objects.Network.get_by_id(context, vif.network_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aca2d91_6f737116","line":1474,"range":{"start_line":1474,"start_character":12,"end_line":1474,"end_character":29},"updated":"2015-05-07 11:43:21.000000000","message":"Can you use a list comprehension here:\nexclude_addresses \u003d [vif.address for vif in vifs]","commit_id":"7aac3f785fe7d576142532f8bb973aae1f3ff459"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"778fdd471fa619cd51f97827886d3a2c7aad882e","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"        vifs \u003d objects.VirtualInterfaceList.get_by_instance_uuid("},{"line_number":1472,"context_line":"                context, instance.uuid)"},{"line_number":1473,"context_line":"        for vif in vifs:"},{"line_number":1474,"context_line":"            exclude_addresses.append(vif.address)"},{"line_number":1475,"context_line":"        LOG.debug(\u0027Setup networks on host\u0027, instance\u003dinstance)"},{"line_number":1476,"context_line":"        for vif in vifs:"},{"line_number":1477,"context_line":"            network \u003d objects.Network.get_by_id(context, vif.network_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aca2d91_a7b3e0e8","line":1474,"range":{"start_line":1474,"start_character":12,"end_line":1474,"end_character":29},"in_reply_to":"1aca2d91_6f737116","updated":"2015-05-07 18:07:46.000000000","message":"I can, but Why is this worth a -1?","commit_id":"7aac3f785fe7d576142532f8bb973aae1f3ff459"}],"nova/tests/network/test_linux_net.py":[{"author":{"_account_id":10614,"name":"Alex Frolov","email":"afrolov@mirantis.com","username":"afrolov"},"change_message_id":"7cbcae5c452a69cb4e585d565cfb66d922b2fa26","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        )"},{"line_number":423,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[0],"},{"line_number":424,"context_line":"                                                  exclude_addresses)"},{"line_number":425,"context_line":"        self.assertEqual(actual_hosts, expected)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_get_dhcp_hosts_for_nw01_with_exclude_addresses(self):"},{"line_number":428,"context_line":"        self.flags(use_single_default_gateway\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_541e1571","line":425,"updated":"2014-09-12 08:16:01.000000000","message":"self.assertEqual has signature\n        assertEqual(expected, actual)\nso it\u0027s better to use\n        self.assertEqual(expected, actual_hosts)\n\nPlease do the same for all such cases in this file","commit_id":"6f9ffefd949a667e27998036c616e6dbcff3c01e"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"55dbb450e6b1d9b1d97dd66e22fd17b125407008","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        )"},{"line_number":423,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[0],"},{"line_number":424,"context_line":"                                                  exclude_addresses)"},{"line_number":425,"context_line":"        self.assertEqual(actual_hosts, expected)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_get_dhcp_hosts_for_nw01_with_exclude_addresses(self):"},{"line_number":428,"context_line":"        self.flags(use_single_default_gateway\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_82de54d8","line":425,"in_reply_to":"fa98f980_541e1571","updated":"2014-09-14 23:12:51.000000000","message":"I\u0027m afraid that if I should modify the assertEqual parameters which I didn\u0027t add.\nI followed the previous source codes in this file","commit_id":"6f9ffefd949a667e27998036c616e6dbcff3c01e"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        )"},{"line_number":440,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[0],"},{"line_number":441,"context_line":"                                                  exclude_addresses)"},{"line_number":442,"context_line":"        self.assertEqual(actual_hosts, expected)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_get_dhcp_hosts_for_nw01_with_exclude_addresses(self):"},{"line_number":445,"context_line":"        self.flags(use_single_default_gateway\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_95de696b","line":442,"updated":"2014-09-16 08:11:43.000000000","message":"I agree with @Alex in previous patch-set -\u003e self.assertEqual(expected, actual)","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"4ed807254c5f866896c2a6933b37894e888801c0","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        )"},{"line_number":440,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[0],"},{"line_number":441,"context_line":"                                                  exclude_addresses)"},{"line_number":442,"context_line":"        self.assertEqual(actual_hosts, expected)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_get_dhcp_hosts_for_nw01_with_exclude_addresses(self):"},{"line_number":445,"context_line":"        self.flags(use_single_default_gateway\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_350a1dd2","line":442,"in_reply_to":"fa98f980_95de696b","updated":"2014-09-16 08:20:41.000000000","message":"Done","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"f9697ded475b6d079035f8f61702f6df5d140b02","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[1],"},{"line_number":454,"context_line":"                                                  exclude_addresses)"},{"line_number":455,"context_line":"        self.assertEqual(actual_hosts, expected)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def test_get_dns_hosts_for_nw00(self):"},{"line_number":458,"context_line":"        expected \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_b5d9ad84","line":455,"updated":"2014-09-16 08:11:43.000000000","message":"ditto","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"4ed807254c5f866896c2a6933b37894e888801c0","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[1],"},{"line_number":454,"context_line":"                                                  exclude_addresses)"},{"line_number":455,"context_line":"        self.assertEqual(actual_hosts, expected)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def test_get_dns_hosts_for_nw00(self):"},{"line_number":458,"context_line":"        expected \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_550de1e6","line":455,"in_reply_to":"fa98f980_b5d9ad84","updated":"2014-09-16 08:20:41.000000000","message":"Done","commit_id":"6961362bd05ab062d8e58f5d11f1062b12d55ac0"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"81e0ce4b98d9c0e21517bd9b83f77e8733c5dd43","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                \"DE:AD:BE:EF:00:02,fake_instance01.novalocal,\""},{"line_number":451,"context_line":"                \"192.168.0.101,net:NW-2\""},{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[1],"},{"line_number":454,"context_line":"                                                  exclude_addresses)"},{"line_number":455,"context_line":"        self.assertEqual(expected, actual_host)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_956ae619","line":453,"range":{"start_line":453,"start_character":8,"end_line":453,"end_character":20},"updated":"2014-09-16 11:10:20.000000000","message":"F841 local variable \u0027actual_hosts\u0027 is assigned to but never used","commit_id":"e11f9bb3745cfbd69372b165769e8b76a4a7db06"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"81e0ce4b98d9c0e21517bd9b83f77e8733c5dd43","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        actual_hosts \u003d self.driver.get_dhcp_hosts(self.context, networks[1],"},{"line_number":454,"context_line":"                                                  exclude_addresses)"},{"line_number":455,"context_line":"        self.assertEqual(expected, actual_host)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def test_get_dns_hosts_for_nw00(self):"},{"line_number":458,"context_line":"        expected \u003d ("}],"source_content_type":"text/x-python","patch_set":15,"id":"fa98f980_3563fa42","line":455,"range":{"start_line":455,"start_character":35,"end_line":455,"end_character":46},"updated":"2014-09-16 11:10:20.000000000","message":"s/actual_host/actual_hosts","commit_id":"e11f9bb3745cfbd69372b165769e8b76a4a7db06"}],"nova/tests/unit/compute/test_shelve.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"650f40b52ecc2f05b1337bbacd7e8e961858d5e7","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        with mock.patch.object(instance, \u0027save\u0027):"},{"line_number":171,"context_line":"            with mock.patch.object(self.compute.network_api,"},{"line_number":172,"context_line":"                 \u0027setup_networks_on_host\u0027):"},{"line_number":173,"context_line":"                self.compute.shelve_offload_instance("},{"line_number":174,"context_line":"                        self.context, instance,"},{"line_number":175,"context_line":"                        clean_shutdown\u003dclean_shutdown)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aca2d91_efeb0177","line":172,"updated":"2015-05-07 11:43:21.000000000","message":"Can you please check that the method is invoked with the correct parameters","commit_id":"7aac3f785fe7d576142532f8bb973aae1f3ff459"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"650f40b52ecc2f05b1337bbacd7e8e961858d5e7","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                 mock.patch.object(instance, \u0027save\u0027) as mock_save:"},{"line_number":252,"context_line":"            mock_save.side_effect \u003d check_save"},{"line_number":253,"context_line":"            with mock.patch.object(self.compute.network_api,"},{"line_number":254,"context_line":"                 \u0027setup_networks_on_host\u0027):"},{"line_number":255,"context_line":"                self.compute.unshelve_instance("},{"line_number":256,"context_line":"                    self.context, instance, image\u003dimage,"},{"line_number":257,"context_line":"                    filter_properties\u003dfilter_properties,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aca2d91_cf03a541","line":254,"updated":"2015-05-07 11:43:21.000000000","message":"ditto","commit_id":"7aac3f785fe7d576142532f8bb973aae1f3ff459"}]}