)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6128e43e91b074dd185cdf60402c1c01a069e8c2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"is not set, then fail with proper error message, without changing"},{"line_number":18,"context_line":"instance state."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1978958"},{"line_number":21,"context_line":"Change-Id: Id4c8c5f3b32985ac7d3d7c833b82e0876f7367c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e8627426_2fc3ac72","line":20,"updated":"2022-08-11 15:14:24.000000000","message":"this need unit tests and ideally a repoduce functional test before it to show this acutlly fixes the issue","commit_id":"3d6d4a548acf40abe14436c8a4dd0b2a8a338f30"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"a3654deab6589c66363cb2dacc0bda42102f2625","unresolved":false,"context_lines":[{"line_number":17,"context_line":"is not set, then fail with proper error message, without changing"},{"line_number":18,"context_line":"instance state."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1978958"},{"line_number":21,"context_line":"Change-Id: Id4c8c5f3b32985ac7d3d7c833b82e0876f7367c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bc9a2b6d_dce0c51e","line":20,"in_reply_to":"e8627426_2fc3ac72","updated":"2022-08-26 07:00:31.000000000","message":"Done","commit_id":"3d6d4a548acf40abe14436c8a4dd0b2a8a338f30"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa4b60d4980607de10606bc1517c0a3545b9c283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a372b68_84e773f9","updated":"2022-08-11 15:14:58.000000000","message":"a release note would be nice too, if this is going to be backported it should have one.","commit_id":"3d6d4a548acf40abe14436c8a4dd0b2a8a338f30"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8b097da19af7d99d4d4e6938086df6088342c71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8bb1ecba_6f32dbfe","updated":"2022-09-19 13:04:53.000000000","message":"ill try and loop back to this later this week","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"b301af18c36460eeb95f6e6f37862133e2887339","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"87cb39c3_722d6bbd","updated":"2022-09-02 10:20:12.000000000","message":"recheck nova-next job Timeout on tests","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7a2d3e67108f50f1796d4b9315f26bcf80a4434a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d41bdf9f_9cccd800","updated":"2022-09-05 16:20:34.000000000","message":"recheck nova-next job socket.timeout: The read operation timed out","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"5603bacbf9300b9424553242827ad5a268e4fafa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5dbe2094_b9037fd2","updated":"2023-01-30 06:55:11.000000000","message":"recheck tempest.lib.exceptions.TimeoutException: Request timed out","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6128e43e91b074dd185cdf60402c1c01a069e8c2","unresolved":true,"context_lines":[{"line_number":4664,"context_line":"        volume_backed \u003d compute_utils.is_volume_backed_instance("},{"line_number":4665,"context_line":"            context, instance, bdms)"},{"line_number":4666,"context_line":""},{"line_number":4667,"context_line":"        if ((image_meta.properties.get("},{"line_number":4668,"context_line":"                \u0027hw_rescue_device\u0027) is None) or (image_meta.properties.get("},{"line_number":4669,"context_line":"            \u0027hw_rescue_bus\u0027) is None)):"},{"line_number":4670,"context_line":"            allow_bfv_rescue \u003d False"},{"line_number":4671,"context_line":""},{"line_number":4672,"context_line":"        if volume_backed and allow_bfv_rescue:"},{"line_number":4673,"context_line":"            cn \u003d objects.ComputeNode.get_by_host_and_nodename("}],"source_content_type":"text/x-python","patch_set":2,"id":"926e4fc6_49fedb8a","line":4670,"range":{"start_line":4667,"start_character":8,"end_line":4670,"end_character":36},"updated":"2022-08-11 15:14:24.000000000","message":"i would proably do it more like this\n\nallow_bfv_rescue \u0026\u003d \u0027hw_rescue_bus\u0027 in image_meta and \u0027hw_rescue_device\u0027 in image_meta\n\nthe in operator on an ovo checks if the field is set.\n\n\nwith that said i think hw_rescue_bus is ment to default to hw_disk_bus and hw_rescue_device is ment to default to disk.\n\nso im not sure if this is the approch we want to take or if we should otherwise make this work by using bettr defaults.\n\nwe we do block it however then this test can be simpler as noted above","commit_id":"3d6d4a548acf40abe14436c8a4dd0b2a8a338f30"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"a3654deab6589c66363cb2dacc0bda42102f2625","unresolved":false,"context_lines":[{"line_number":4664,"context_line":"        volume_backed \u003d compute_utils.is_volume_backed_instance("},{"line_number":4665,"context_line":"            context, instance, bdms)"},{"line_number":4666,"context_line":""},{"line_number":4667,"context_line":"        if ((image_meta.properties.get("},{"line_number":4668,"context_line":"                \u0027hw_rescue_device\u0027) is None) or (image_meta.properties.get("},{"line_number":4669,"context_line":"            \u0027hw_rescue_bus\u0027) is None)):"},{"line_number":4670,"context_line":"            allow_bfv_rescue \u003d False"},{"line_number":4671,"context_line":""},{"line_number":4672,"context_line":"        if volume_backed and allow_bfv_rescue:"},{"line_number":4673,"context_line":"            cn \u003d objects.ComputeNode.get_by_host_and_nodename("}],"source_content_type":"text/x-python","patch_set":2,"id":"6720c2e9_a15e8b91","line":4670,"range":{"start_line":4667,"start_character":8,"end_line":4670,"end_character":36},"in_reply_to":"926e4fc6_49fedb8a","updated":"2022-08-26 07:00:31.000000000","message":"Done","commit_id":"3d6d4a548acf40abe14436c8a4dd0b2a8a338f30"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9149770e65cb691fa0dceeddd2433f26b00fc55c","unresolved":false,"context_lines":[{"line_number":4711,"context_line":"        volume_backed \u003d compute_utils.is_volume_backed_instance("},{"line_number":4712,"context_line":"            context, instance, bdms)"},{"line_number":4713,"context_line":""},{"line_number":4714,"context_line":"        allow_bfv_rescue \u0026\u003d \u0027hw_rescue_bus\u0027 in image_meta.properties and \\"},{"line_number":4715,"context_line":"            \u0027hw_rescue_device\u0027 in image_meta.properties"},{"line_number":4716,"context_line":""},{"line_number":4717,"context_line":"        if volume_backed and allow_bfv_rescue:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff4d7828_8b50b15d","line":4714,"updated":"2023-01-26 09:47:45.000000000","message":"First I did not noticed the \u0027\u0026\u0027, but yeah, this is still building on the flag we got from the nova.api.","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"}],"nova/tests/functional/test_server_rescue.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1bcdd5ffee312d992b2b1aa5916f3a382cb30211","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        image \u003d {"},{"line_number":32,"context_line":"            \u0027id\u0027: uuids.stable_rescue_image,"},{"line_number":33,"context_line":"            \u0027name\u0027: \u0027fake-image-rescue-property\u0027,"},{"line_number":34,"context_line":"            \u0027created_at\u0027: datetime.datetime(2011, 1, 1, 1, 2, 3),"},{"line_number":35,"context_line":"            \u0027updated_at\u0027: datetime.datetime(2011, 1, 1, 1, 2, 3),"},{"line_number":36,"context_line":"            \u0027deleted_at\u0027: None,"},{"line_number":37,"context_line":"            \u0027deleted\u0027: False,"},{"line_number":38,"context_line":"            \u0027status\u0027: \u0027active\u0027,"},{"line_number":39,"context_line":"            \u0027is_public\u0027: False,"},{"line_number":40,"context_line":"            \u0027container_format\u0027: \u0027raw\u0027,"},{"line_number":41,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":42,"context_line":"            \u0027size\u0027: \u002725165824\u0027,"},{"line_number":43,"context_line":"            \u0027min_ram\u0027: 0,"},{"line_number":44,"context_line":"            \u0027min_disk\u0027: 0,"},{"line_number":45,"context_line":"            \u0027protected\u0027: False,"},{"line_number":46,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":47,"context_line":"            \u0027tags\u0027: [\u0027tag1\u0027, \u0027tag2\u0027],"},{"line_number":48,"context_line":"            \u0027properties\u0027: {"},{"line_number":49,"context_line":"                \u0027kernel_id\u0027: \u0027nokernel\u0027,"},{"line_number":50,"context_line":"                \u0027ramdisk_id\u0027: \u0027nokernel\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"6f8d4698_b06a16b8","line":47,"range":{"start_line":34,"start_character":12,"end_line":47,"end_character":37},"updated":"2022-09-23 05:51:32.000000000","message":"The test are passing without these properties as well.\n\nif they are good to have properties, we may have a single module, from where we can import these as CONSTANTS.\n\nwe may have it in tests/CONSTANTS.py","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"efbbf0dbee6bd4436dd31eccf594e9fea92a65cb","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        image \u003d {"},{"line_number":32,"context_line":"            \u0027id\u0027: uuids.stable_rescue_image,"},{"line_number":33,"context_line":"            \u0027name\u0027: \u0027fake-image-rescue-property\u0027,"},{"line_number":34,"context_line":"            \u0027created_at\u0027: datetime.datetime(2011, 1, 1, 1, 2, 3),"},{"line_number":35,"context_line":"            \u0027updated_at\u0027: datetime.datetime(2011, 1, 1, 1, 2, 3),"},{"line_number":36,"context_line":"            \u0027deleted_at\u0027: None,"},{"line_number":37,"context_line":"            \u0027deleted\u0027: False,"},{"line_number":38,"context_line":"            \u0027status\u0027: \u0027active\u0027,"},{"line_number":39,"context_line":"            \u0027is_public\u0027: False,"},{"line_number":40,"context_line":"            \u0027container_format\u0027: \u0027raw\u0027,"},{"line_number":41,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":42,"context_line":"            \u0027size\u0027: \u002725165824\u0027,"},{"line_number":43,"context_line":"            \u0027min_ram\u0027: 0,"},{"line_number":44,"context_line":"            \u0027min_disk\u0027: 0,"},{"line_number":45,"context_line":"            \u0027protected\u0027: False,"},{"line_number":46,"context_line":"            \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":47,"context_line":"            \u0027tags\u0027: [\u0027tag1\u0027, \u0027tag2\u0027],"},{"line_number":48,"context_line":"            \u0027properties\u0027: {"},{"line_number":49,"context_line":"                \u0027kernel_id\u0027: \u0027nokernel\u0027,"},{"line_number":50,"context_line":"                \u0027ramdisk_id\u0027: \u0027nokernel\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"4c0745dc_d2961567","line":47,"range":{"start_line":34,"start_character":12,"end_line":47,"end_character":37},"in_reply_to":"6f8d4698_b06a16b8","updated":"2023-01-24 11:26:26.000000000","message":"this isn\u0027t really worth factoring out into constants.\n\nmost of this data is not really required but having it does not hurt.\n\nwe have precreated images in the fixutres that could have also been copied and updated.\n\ni think this is fine as is although i normllay do this definently if i need to do this.","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"efbbf0dbee6bd4436dd31eccf594e9fea92a65cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8e537ed7_b8dab00c","line":169,"updated":"2023-01-24 11:26:26.000000000","message":"+1","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"efbbf0dbee6bd4436dd31eccf594e9fea92a65cb","unresolved":true,"context_lines":[{"line_number":5774,"context_line":"                destination_type\u003d\u0027volume\u0027, volume_type\u003dNone,"},{"line_number":5775,"context_line":"                snapshot_id\u003dNone, volume_id\u003duuids.volume_id,"},{"line_number":5776,"context_line":"                volume_size\u003dNone)])"},{"line_number":5777,"context_line":"        rescue_image_meta_obj \u003d image_meta_obj.ImageMeta.from_dict({"},{"line_number":5778,"context_line":"            \u0027properties\u0027: {\u0027hw_rescue_device\u0027: \u0027disk\u0027,"},{"line_number":5779,"context_line":"                           \u0027hw_rescue_bus\u0027: \u0027scsi\u0027}"},{"line_number":5780,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":10,"id":"a406a528_eef06550","line":5777,"updated":"2023-01-24 11:26:26.000000000","message":"i would personally group this where its used online 5795\nsame with the rest.\n\nthis is python not c so varibles should be created when they are need not at the top of functions.","commit_id":"6eed55bf55469f4ceaa7d4d4eb1be635e14bc73b"}]}