)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"608f468dccae34f68264dda9ae42939b5e8ccae5","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        for attr in (\u0027status\u0027, \u0027location\u0027, \u0027id\u0027):"},{"line_number":1501,"context_line":"            src_image.pop(attr, None)"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"        image_id \u003d self._register_image(context, src_image)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        if restart_instance:"},{"line_number":1506,"context_line":"            self.compute_api.start(context, instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2Fgo%3D","side":"PARENT","line":1503,"updated":"2012-06-14 17:01:58.000000000","message":"I\u0027m a little worried at how much code is disappearing here...","commit_id":"2adeb5a76d8376d3506f4c63ec73211bfa1e5cc0"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6892cc70ffa6d2920f871cc7ae5336899147e81a","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        for attr in (\u0027status\u0027, \u0027location\u0027, \u0027id\u0027):"},{"line_number":1501,"context_line":"            src_image.pop(attr, None)"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"        image_id \u003d self._register_image(context, src_image)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        if restart_instance:"},{"line_number":1506,"context_line":"            self.compute_api.start(context, instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2FUM%3D","side":"PARENT","line":1503,"in_reply_to":"AAAAIn%2F%2F%2FaA%3D","updated":"2012-06-14 20:04:48.000000000","message":"Whatever you think will prevent this from bitrotting in the future.","commit_id":"2adeb5a76d8376d3506f4c63ec73211bfa1e5cc0"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"2316dd0ce3667d5230dfa129e3e3071e58399d9f","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        for attr in (\u0027status\u0027, \u0027location\u0027, \u0027id\u0027):"},{"line_number":1501,"context_line":"            src_image.pop(attr, None)"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"        image_id \u003d self._register_image(context, src_image)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        if restart_instance:"},{"line_number":1506,"context_line":"            self.compute_api.start(context, instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2Ffg%3D","side":"PARENT","line":1503,"in_reply_to":"AAAAIn%2F%2F%2Ff8%3D","updated":"2012-06-14 17:20:08.000000000","message":"Ok, if someone can functionally test this and demonstrate that snapshots were not working and with this change they are (and produce bootable images), I\u0027m cool with this.","commit_id":"2adeb5a76d8376d3506f4c63ec73211bfa1e5cc0"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"83cf835041875c66168b9f7ca06573508598a1ee","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        for attr in (\u0027status\u0027, \u0027location\u0027, \u0027id\u0027):"},{"line_number":1501,"context_line":"            src_image.pop(attr, None)"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"        image_id \u003d self._register_image(context, src_image)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        if restart_instance:"},{"line_number":1506,"context_line":"            self.compute_api.start(context, instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2FaA%3D","side":"PARENT","line":1503,"in_reply_to":"AAAAIn%2F%2F%2Ffg%3D","updated":"2012-06-14 18:39:32.000000000","message":"Do you mean a repeatable functional test (e.g. a new Tempest testcase) or just a once-off confirmation?","commit_id":"2adeb5a76d8376d3506f4c63ec73211bfa1e5cc0"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"3723de138c3950d04f22cefbc6443a169a90464a","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"        for attr in (\u0027status\u0027, \u0027location\u0027, \u0027id\u0027):"},{"line_number":1501,"context_line":"            src_image.pop(attr, None)"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"        image_id \u003d self._register_image(context, src_image)"},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        if restart_instance:"},{"line_number":1506,"context_line":"            self.compute_api.start(context, instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2Ff8%3D","side":"PARENT","line":1503,"in_reply_to":"AAAAIn%2F%2F%2Fgo%3D","updated":"2012-06-14 17:12:46.000000000","message":"Yes, there\u0027s a fair number of lines excised, but that codepath was previously completely broken, so I don\u0027t think we\u0027re in danger of losing any functionality.","commit_id":"2adeb5a76d8376d3506f4c63ec73211bfa1e5cc0"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"608f468dccae34f68264dda9ae42939b5e8ccae5","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"                    raise exception.EC2APIError("},{"line_number":1444,"context_line":"                        _(\u0027Couldn\\\u0027t stop instance with in %d sec\u0027) % timeout)"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        new_image \u003d self.compute_api.create_image(context,"},{"line_number":1447,"context_line":"                                                  instance,"},{"line_number":1448,"context_line":"                                                  kwargs.get(\u0027name\u0027),"},{"line_number":1449,"context_line":"                                                  \u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2Fgs%3D","line":1446,"updated":"2012-06-14 17:01:58.000000000","message":"Instead of making _create_image a public method, why not just call snapshot?","commit_id":"7f1c23935dbcb86e62d40ec1a6ab792663f49d88"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"3723de138c3950d04f22cefbc6443a169a90464a","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"                    raise exception.EC2APIError("},{"line_number":1444,"context_line":"                        _(\u0027Couldn\\\u0027t stop instance with in %d sec\u0027) % timeout)"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        new_image \u003d self.compute_api.create_image(context,"},{"line_number":1447,"context_line":"                                                  instance,"},{"line_number":1448,"context_line":"                                                  kwargs.get(\u0027name\u0027),"},{"line_number":1449,"context_line":"                                                  \u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAIn%2F%2F%2FgI%3D","line":1446,"in_reply_to":"AAAAIn%2F%2F%2Fgs%3D","updated":"2012-06-14 17:12:46.000000000","message":"Good shout, done.","commit_id":"7f1c23935dbcb86e62d40ec1a6ab792663f49d88"}]}