)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"257232e9e87e21e51cd297a45d26e5fb48e6fa2e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-17 17:53:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reproduce bug 1986838"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1986838"},{"line_number":10,"context_line":"Change-Id: I374b21fafff1a2f359d3cf887a9c271449f83635"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3fe80d_e509e5fa","line":8,"updated":"2022-08-23 15:20:54.000000000","message":"This change replicates  bug 1986838\nwhere by nova pci requests form distinct pci aliases\nto overlapp and be fulfilled by a singe host device.\n\nThis is invalid and should be rejected in the scheduler.","commit_id":"15dde478b927c3c7ff53cf3dff175c0e70b09019"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a07c9626cd15d0b68310850a1ea790007ed498c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a72050b_e183d27f","updated":"2022-08-23 15:29:33.000000000","message":"ignoring the commit message the issue i see are adresssed in the follow up patch that fixes the bug so upgrading to +2","commit_id":"15dde478b927c3c7ff53cf3dff175c0e70b09019"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"257232e9e87e21e51cd297a45d26e5fb48e6fa2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fcd9fe2_39ddad0a","updated":"2022-08-23 15:20:54.000000000","message":"im conflicted because there are some things i would like to be improved but i also don\u0027t really want you to have to rebase the full series to adress this.\n\nso +1 for now while i reveiw the rest.","commit_id":"15dde478b927c3c7ff53cf3dff175c0e70b09019"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"257232e9e87e21e51cd297a45d26e5fb48e6fa2e","unresolved":true,"context_lines":[{"line_number":1511,"context_line":"        # self.assertIn(\u0027No valid host\u0027, server[\u0027fault\u0027][\u0027message\u0027])"},{"line_number":1512,"context_line":""},{"line_number":1513,"context_line":"        # This is bug 1986838"},{"line_number":1514,"context_line":"        # The boot succeeds and none of the requested devices will be allocated"},{"line_number":1515,"context_line":"        # to the instance."},{"line_number":1516,"context_line":"        server \u003d self._create_server(flavor_id\u003dflavor_id, networks\u003d\u0027none\u0027)"},{"line_number":1517,"context_line":"        self.assertPCIDeviceCounts(\u0027compute1\u0027, total\u003d1, free\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d61a0f2_bb8e50a7","line":1514,"range":{"start_line":1514,"start_character":19,"end_line":1514,"end_character":27},"updated":"2022-08-23 15:20:54.000000000","message":"does the boot and schedule succeed or just the scheduling?","commit_id":"15dde478b927c3c7ff53cf3dff175c0e70b09019"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"257232e9e87e21e51cd297a45d26e5fb48e6fa2e","unresolved":true,"context_lines":[{"line_number":1513,"context_line":"        # This is bug 1986838"},{"line_number":1514,"context_line":"        # The boot succeeds and none of the requested devices will be allocated"},{"line_number":1515,"context_line":"        # to the instance."},{"line_number":1516,"context_line":"        server \u003d self._create_server(flavor_id\u003dflavor_id, networks\u003d\u0027none\u0027)"},{"line_number":1517,"context_line":"        self.assertPCIDeviceCounts(\u0027compute1\u0027, total\u003d1, free\u003d1)"},{"line_number":1518,"context_line":"        devices \u003d objects.PciDeviceList.get_by_instance_uuid("},{"line_number":1519,"context_line":"            self.ctxt, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e16343c_5683baec","line":1516,"range":{"start_line":1516,"start_character":8,"end_line":1516,"end_character":14},"updated":"2022-08-23 15:20:54.000000000","message":"ca you assert that this is active.","commit_id":"15dde478b927c3c7ff53cf3dff175c0e70b09019"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"257232e9e87e21e51cd297a45d26e5fb48e6fa2e","unresolved":true,"context_lines":[{"line_number":1532,"context_line":"        # And yes, the compute service detects the failure but states that this"},{"line_number":1533,"context_line":"        # should not happen as the scheduler needed to choose the host"},{"line_number":1534,"context_line":"        # properly. Then it simply cleans up all the instance PCI allocations"},{"line_number":1535,"context_line":"        # and ignores the fault, so the instance boots with the requested PCI"},{"line_number":1536,"context_line":"        # devs."},{"line_number":1537,"context_line":"        self.assertIn("},{"line_number":1538,"context_line":"            \u0027ERROR [nova.pci.stats] Failed to allocate PCI devices for \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f542625_572c1d18","line":1535,"range":{"start_line":1535,"start_character":55,"end_line":1535,"end_character":59},"updated":"2022-08-23 15:20:54.000000000","message":"without.","commit_id":"15dde478b927c3c7ff53cf3dff175c0e70b09019"}]}