)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3ed4b73f36246b2cefe37796acc34af0e9415191","unresolved":true,"context_lines":[{"line_number":10,"context_line":"of passthough vnic types and removes the api blocks"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable the existing suspend and live migrate"},{"line_number":13,"context_line":"code to properly manage vdpa interfaces enableding"},{"line_number":14,"context_line":"\"hot plug\" live migrations similar to direct sr-iov."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint vdpa-suspend-detach-and-live-migrate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"373e1b35_170552e7","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":50},"updated":"2022-08-19 10:56:08.000000000","message":"enabling","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of passthough vnic types and removes the api blocks"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable the existing suspend and live migrate"},{"line_number":13,"context_line":"code to properly manage vdpa interfaces enableding"},{"line_number":14,"context_line":"\"hot plug\" live migrations similar to direct sr-iov."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint vdpa-suspend-detach-and-live-migrate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ab1816f_0776d55d","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":50},"in_reply_to":"373e1b35_170552e7","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4e23f22_15549c88","updated":"2022-08-19 11:40:16.000000000","message":"Since you need to rework this anyway...","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3ed4b73f36246b2cefe37796acc34af0e9415191","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f4bf00a_303cd708","updated":"2022-08-19 10:56:08.000000000","message":"This needs functional test coverage for live migration with vdpa","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bad7fb015acbf8092ca2cdcf9cc09eccde9f1cdb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"faafa814_b0a204d7","in_reply_to":"2f4bf00a_303cd708","updated":"2022-08-19 10:56:26.000000000","message":"I\u0027m -1 due to this","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25279bc78da278757b2632a4ceeebf77d8d8b8ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23072591_bc0cdc2e","updated":"2022-08-22 14:28:04.000000000","message":"due to the service version mistmatches","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eba4eae34b1d324d919083497e4607b5965bee49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e172447_e104c9ac","updated":"2022-08-22 17:07:13.000000000","message":"One small question inline. -1 just to catch your attention","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"831b602f53423a607a1d57ee292a9c07dbe4efc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c62f4d17_828e3c9f","updated":"2022-08-23 08:13:00.000000000","message":"my issues were resolved. If the tests are happy then I\u0027m happy.","commit_id":"7e38594955b9d75ce568bf14fc9a5606a04f1d5a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b293a660c8f3fb3d4f6c1b167e565b6b9ceeefb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3c421540_11d159b2","updated":"2022-08-23 10:20:56.000000000","message":"recheck tempest.api.volume.test_volumes_extend.VolumesExtendAttachedTest.test_extend_attached_volume","commit_id":"0aad338b1c68f319df603bca340ff33dc7fd7b54"}],"doc/source/admin/vdpa.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":true,"context_lines":[{"line_number":4,"context_line":".. versionadded:: 23.0.0 (Wallaby)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"   Introduced support for vDPA."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. important::"},{"line_number":9,"context_line":"   The functionality described below is only supported by the"},{"line_number":10,"context_line":"   libvirt/KVM virt driver."}],"source_content_type":"text/x-rst","patch_set":3,"id":"6f34ea49_4af32f8d","line":7,"updated":"2022-08-19 11:40:16.000000000","message":"nit:\n\n  .. versionchanged:: 26.0.0 (Zed)\n\n     Added support for all instance move (cold migration, live migration,\n     resize) operations operations, instance suspend/resume operations, and\n     interface attach/detach operations.","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":false,"context_lines":[{"line_number":4,"context_line":".. versionadded:: 23.0.0 (Wallaby)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"   Introduced support for vDPA."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. important::"},{"line_number":9,"context_line":"   The functionality described below is only supported by the"},{"line_number":10,"context_line":"   libvirt/KVM virt driver."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bd2eb5da_cf0a19ce","line":7,"in_reply_to":"6f34ea49_4af32f8d","updated":"2022-08-22 14:07:30.000000000","message":"Done","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eba4eae34b1d324d919083497e4607b5965bee49","unresolved":true,"context_lines":[{"line_number":8,"context_line":".. versionadded:: 26.0.0 (Zed)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"   Added support for all instance move operations,"},{"line_number":11,"context_line":"   and the interface attach/detach, and suspend/resume operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. important::"},{"line_number":14,"context_line":"   The functionality described below is only supported by the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fc86f20_9f4e5a40","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":34},"updated":"2022-08-22 17:07:13.000000000","message":"nit:\n\n  Added support for all instance move operations,\n  the interface attach/detach operations, and the suspend/resume operations.","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"899566af3fd6375f14755be958c1d7c582c00c08","unresolved":false,"context_lines":[{"line_number":8,"context_line":".. versionadded:: 26.0.0 (Zed)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"   Added support for all instance move operations,"},{"line_number":11,"context_line":"   and the interface attach/detach, and suspend/resume operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. important::"},{"line_number":14,"context_line":"   The functionality described below is only supported by the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ecfbf3aa_48769d00","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":34},"in_reply_to":"5fc86f20_9f4e5a40","updated":"2022-08-24 17:17:54.000000000","message":"Not done, but it\u0027s not critical","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eba4eae34b1d324d919083497e4607b5965bee49","unresolved":true,"context_lines":[{"line_number":81,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"At this time QEMU and the ``vhost-vdpa`` kernel module do not support transparent"},{"line_number":84,"context_line":"live migration of vm with vdpa ports. To enable live migration of VMs with"},{"line_number":85,"context_line":"vDPA interfaces the existing SR-IOV hotplug live migration procedure has been"},{"line_number":86,"context_line":"extended to include ``vnic_type\u003d\u0027vdpa\u0027`` interfaces."}],"source_content_type":"text/x-rst","patch_set":5,"id":"50a0fff1_49dc5aa2","line":84,"range":{"start_line":84,"start_character":18,"end_line":84,"end_character":20},"updated":"2022-08-22 17:07:13.000000000","message":"instances (or VMs, which would be okay here since we\u0027re talking about QEMU and the kernel)","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"899566af3fd6375f14755be958c1d7c582c00c08","unresolved":false,"context_lines":[{"line_number":81,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"At this time QEMU and the ``vhost-vdpa`` kernel module do not support transparent"},{"line_number":84,"context_line":"live migration of vm with vdpa ports. To enable live migration of VMs with"},{"line_number":85,"context_line":"vDPA interfaces the existing SR-IOV hotplug live migration procedure has been"},{"line_number":86,"context_line":"extended to include ``vnic_type\u003d\u0027vdpa\u0027`` interfaces."}],"source_content_type":"text/x-rst","patch_set":5,"id":"54680a29_3b3ee98e","line":84,"range":{"start_line":84,"start_character":18,"end_line":84,"end_character":20},"in_reply_to":"50a0fff1_49dc5aa2","updated":"2022-08-24 17:17:54.000000000","message":"Ditto","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"}],"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3ed4b73f36246b2cefe37796acc34af0e9415191","unresolved":true,"context_lines":[{"line_number":4610,"context_line":"    # the vDPA devices before calling managed save as we do with SR-IOV"},{"line_number":4611,"context_line":"    # devices"},{"line_number":4612,"context_line":"    @block_port_accelerators()"},{"line_number":4613,"context_line":"    @reject_vdpa_instances(instance_actions.SUSPEND)"},{"line_number":4614,"context_line":"    @block_accelerators()"},{"line_number":4615,"context_line":"    @reject_sev_instances(instance_actions.SUSPEND)"},{"line_number":4616,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":3,"id":"23c6f87d_d89dc844","side":"PARENT","line":4613,"updated":"2022-08-19 10:56:08.000000000","message":"so suspend does not need compute service version 62?","commit_id":"392034f8a7f3865b133a0f43a3280d3987b43362"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd6d3ecf8496ef611508bbaa2ef2929518dcf755","unresolved":true,"context_lines":[{"line_number":4610,"context_line":"    # the vDPA devices before calling managed save as we do with SR-IOV"},{"line_number":4611,"context_line":"    # devices"},{"line_number":4612,"context_line":"    @block_port_accelerators()"},{"line_number":4613,"context_line":"    @reject_vdpa_instances(instance_actions.SUSPEND)"},{"line_number":4614,"context_line":"    @block_accelerators()"},{"line_number":4615,"context_line":"    @reject_sev_instances(instance_actions.SUSPEND)"},{"line_number":4616,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a65132b_1db74e46","side":"PARENT","line":4613,"in_reply_to":"23c6f87d_d89dc844","updated":"2022-08-19 11:17:24.000000000","message":"hum good point i guess should proably have it yes\nin which case perhaps attach/detach should too.\n\nmy reasoning for not adding it was that it only involved a singel host but that is  flawed.\n\ni guess i shoudl have 2 bumps\n\n62: attach/detach\n63: suspened and live migration.\n\nill do that and adress your  other comments once stephen has had a chance to review.","commit_id":"392034f8a7f3865b133a0f43a3280d3987b43362"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":4610,"context_line":"    # the vDPA devices before calling managed save as we do with SR-IOV"},{"line_number":4611,"context_line":"    # devices"},{"line_number":4612,"context_line":"    @block_port_accelerators()"},{"line_number":4613,"context_line":"    @reject_vdpa_instances(instance_actions.SUSPEND)"},{"line_number":4614,"context_line":"    @block_accelerators()"},{"line_number":4615,"context_line":"    @reject_sev_instances(instance_actions.SUSPEND)"},{"line_number":4616,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8415d99_94b25d6a","side":"PARENT","line":4613,"in_reply_to":"3a65132b_1db74e46","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"392034f8a7f3865b133a0f43a3280d3987b43362"}],"nova/objects/service.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3ed4b73f36246b2cefe37796acc34af0e9415191","unresolved":true,"context_lines":[{"line_number":230,"context_line":"    \u0027Victoria\u0027: 52,"},{"line_number":231,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":232,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":233,"context_line":"    \u0027Zed\u0027: 62"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"434af78b_5a7f5bba","line":233,"updated":"2022-08-19 10:56:08.000000000","message":"does 62 the first zed service version? If yes then this is a nice help for the future us when in AA we need to set OLDEST_SUPPORTED_SERVICE_VERSION to Zed","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    \u0027Victoria\u0027: 52,"},{"line_number":231,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":232,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":233,"context_line":"    \u0027Zed\u0027: 62"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ca32fe7_6c7f9bca","line":233,"in_reply_to":"37771a73_88574b92","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":true,"context_lines":[{"line_number":230,"context_line":"    \u0027Victoria\u0027: 52,"},{"line_number":231,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":232,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":233,"context_line":"    \u0027Zed\u0027: 62"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"37771a73_88574b92","line":233,"in_reply_to":"434af78b_5a7f5bba","updated":"2022-08-22 14:07:30.000000000","message":"yes i belive so. remote managed port i belvie was in yoga but ill confrim","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"813819c5314b98d071db5f031f4e559e9390766f","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(danms): This is the global service version counter"},{"line_number":34,"context_line":"SERVICE_VERSION \u003d 62"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(danms): This is our SERVICE_VERSION history. The idea is that any"}],"source_content_type":"text/x-python","patch_set":4,"id":"8c346d0e_7eeb7188","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":20},"updated":"2022-08-22 14:34:08.000000000","message":"this is actully why the tests fail i forgot to bump this to 63","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(danms): This is the global service version counter"},{"line_number":34,"context_line":"SERVICE_VERSION \u003d 62"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# NOTE(danms): This is our SERVICE_VERSION history. The idea is that any"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba4df107_fb04b430","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":20},"in_reply_to":"8c346d0e_7eeb7188","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25279bc78da278757b2632a4ceeebf77d8d8b8ec","unresolved":true,"context_lines":[{"line_number":233,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":234,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":235,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":236,"context_line":"    \u0027Zed\u0027: 63"},{"line_number":237,"context_line":"}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"07780b09_3af4a8e4","line":236,"updated":"2022-08-22 14:28:04.000000000","message":"keep this on 62, as that is the first service version that we support in Zed. I know that this is not really relevant as we don\u0027t support upgrading to beta or RC1 or older Zed. But we had this pattern above so that we set it to the first service version of the given release. (Or you can drop this from the patch and let us add  Yoga here when Zed is released)","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":234,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":235,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":236,"context_line":"    \u0027Zed\u0027: 63"},{"line_number":237,"context_line":"}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfb07793_b87e45c4","line":236,"in_reply_to":"07780b09_3af4a8e4","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eba4eae34b1d324d919083497e4607b5965bee49","unresolved":true,"context_lines":[{"line_number":233,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":234,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":235,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":236,"context_line":"    \u0027Zed\u0027: 62"},{"line_number":237,"context_line":"}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4842915f_1d3f2b03","line":236,"updated":"2022-08-22 17:07:13.000000000","message":"Shouldn\u0027t this be 63 now?","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"113bd175bbaba3c88c52ce1651cc0df1346d8107","unresolved":true,"context_lines":[{"line_number":233,"context_line":"    \u0027Wallaby\u0027: 54,"},{"line_number":234,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":235,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":236,"context_line":"    \u0027Zed\u0027: 62"},{"line_number":237,"context_line":"}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a285545_950f1e5e","line":236,"in_reply_to":"4842915f_1d3f2b03","updated":"2022-08-22 17:21:36.000000000","message":"i changed it to 63 becuase i tought this shoudl match the latest one for the release but gibi seamed to think it shoudl be 62 so i reverted it so im not sure","commit_id":"872efb90ce5c8860d08808560c24a9b243930d02"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25279bc78da278757b2632a4ceeebf77d8d8b8ec","unresolved":true,"context_lines":[{"line_number":1570,"context_line":"    def test_suspend_and_resume_service_version_62(self):"},{"line_number":1571,"context_line":"        with mock.patch("},{"line_number":1572,"context_line":"                \"nova.objects.service.get_minimum_version_all_cells\","},{"line_number":1573,"context_line":"                return_value\u003d61"},{"line_number":1574,"context_line":"        ):"},{"line_number":1575,"context_line":"            self._test_common(self._suspend_server)"},{"line_number":1576,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfef62b6_c59242b4","line":1573,"range":{"start_line":1573,"start_character":29,"end_line":1573,"end_character":31},"updated":"2022-08-22 14:28:04.000000000","message":"62","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":1570,"context_line":"    def test_suspend_and_resume_service_version_62(self):"},{"line_number":1571,"context_line":"        with mock.patch("},{"line_number":1572,"context_line":"                \"nova.objects.service.get_minimum_version_all_cells\","},{"line_number":1573,"context_line":"                return_value\u003d61"},{"line_number":1574,"context_line":"        ):"},{"line_number":1575,"context_line":"            self._test_common(self._suspend_server)"},{"line_number":1576,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f9d4aff5_9cfb55e2","line":1573,"range":{"start_line":1573,"start_character":29,"end_line":1573,"end_character":31},"in_reply_to":"bfef62b6_c59242b4","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25279bc78da278757b2632a4ceeebf77d8d8b8ec","unresolved":true,"context_lines":[{"line_number":1589,"context_line":"    def test_live_migrate_service_version_62(self):"},{"line_number":1590,"context_line":"        with mock.patch("},{"line_number":1591,"context_line":"                \"nova.objects.service.get_minimum_version_all_cells\","},{"line_number":1592,"context_line":"                return_value\u003d61"},{"line_number":1593,"context_line":"        ):"},{"line_number":1594,"context_line":"            self._test_common(self._live_migrate)"},{"line_number":1595,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"99a2dc8c_3152b5c6","line":1592,"updated":"2022-08-22 14:28:04.000000000","message":"62","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"    def test_live_migrate_service_version_62(self):"},{"line_number":1590,"context_line":"        with mock.patch("},{"line_number":1591,"context_line":"                \"nova.objects.service.get_minimum_version_all_cells\","},{"line_number":1592,"context_line":"                return_value\u003d61"},{"line_number":1593,"context_line":"        ):"},{"line_number":1594,"context_line":"            self._test_common(self._live_migrate)"},{"line_number":1595,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e2080aab_946d3195","line":1592,"in_reply_to":"99a2dc8c_3152b5c6","updated":"2022-08-22 16:59:56.000000000","message":"Done","commit_id":"9c86b5d59d34550f490ebbff8674d7843c34731a"}],"nova/tests/functional/regressions/test_bug_1944619.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0ac881d54a6f876ad968d71b18721b1c9c64f441","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                # Live migrate the instance to another host"},{"line_number":72,"context_line":"                self._live_migrate(self.server,"},{"line_number":73,"context_line":"                                   migration_expected_state\u003d\u0027failed\u0027,"},{"line_number":74,"context_line":"                                   server_expected_state\u003d\u0027ACTIVE\u0027)"},{"line_number":75,"context_line":"        mlpr.assert_not_called()"},{"line_number":76,"context_line":"        mlpp.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3c78d659_738b4a79","line":74,"updated":"2022-08-23 08:43:07.000000000","message":"yepp, the migration is rolled back so the server is active again. This is a side effect of the _live_migrate helper change but it is more correct this way as it asserts the stead state not a transient.","commit_id":"0aad338b1c68f319df603bca340ff33dc7fd7b54"}],"releasenotes/notes/vdpa-suspend-detach-and-live-migrate-e591e6a03a0c834d.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2d240bb0_3470833f","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":46},"updated":"2022-08-19 11:40:16.000000000","message":"nit: drop this (we know it\u0027s nova)","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b9323048_0eed7c01","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":8},"updated":"2022-08-19 11:40:16.000000000","message":"nit: vDPA (here and elsewhere)","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1dcddf17_74ec2b54","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":46},"in_reply_to":"2d240bb0_3470833f","updated":"2022-08-22 14:07:30.000000000","message":"Done","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e1d69575_dcfd1482","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":8},"in_reply_to":"b9323048_0eed7c01","updated":"2022-08-22 14:07:30.000000000","message":"ill do it for constiantce but the loweer case v is not really correct.\nwe have had that disucssion before but i have used vDPA else where so ill use it here","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"663cb3aa_3991c349","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":27},"updated":"2022-08-19 11:40:16.000000000","message":"nit: instance","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cb921ddc_5f3a0ea3","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":27},"in_reply_to":"663cb3aa_3991c349","updated":"2022-08-22 14:07:30.000000000","message":"Done","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"789bb6eb_04c215e2","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":10},"updated":"2022-08-19 11:40:16.000000000","message":"nit: instance (here and elsewhere)","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5584b55e_acc9b43d","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":10},"in_reply_to":"789bb6eb_04c215e2","updated":"2022-08-22 14:07:30.000000000","message":"Done","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e62de1ab85b1b1749df72e6e7f93489a475dda7e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Hot-plug live migration unplugs the VDPA device on the source host"},{"line_number":11,"context_line":"    before the VM is live migrated and automatically hot-plugs the device"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"903c858e_ff16a26f","line":8,"range":{"start_line":7,"start_character":4,"end_line":8,"end_character":68},"updated":"2022-08-19 11:40:16.000000000","message":"nit: I\u0027d put all of this information in the next paragraph to avoid cluttering the main message here.\n\n  and live migration.\n  \n  Note that live migration support is achieved via hot plugging. QEMU and the\n  Linux kernel do not currently support transparent live migration of VDPA devices.\n  Hot plug live migration unplugs the VDPA device on the source host before ...\n\nWe could also just say:\n\n  There are some caveats to how live migration has been implemented. For more\n  information, refer to the\n  `documentation \u003clink to docs\u003e`__.","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"891f68823da904df374d25ef763f9a11b72cd9bc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Hot-plug live migration unplugs the VDPA device on the source host"},{"line_number":11,"context_line":"    before the VM is live migrated and automatically hot-plugs the device"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b7fc2fed_93777704","line":8,"range":{"start_line":7,"start_character":4,"end_line":8,"end_character":68},"in_reply_to":"903c858e_ff16a26f","updated":"2022-08-22 14:07:30.000000000","message":"we could but i would prefer to call it out here.","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98bbebb2cb31c79fcad2b0c225e6fc06a9529771","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    VDPA support was first introduced to nova in the 23.0.0 (Wallaby)"},{"line_number":5,"context_line":"    release with limited VM lifecycle operations. Nova now supports"},{"line_number":6,"context_line":"    all vm lifecycle operations including suspend, attach/detach"},{"line_number":7,"context_line":"    and hot-plug live migration. QEMU and the Linux kernel do not currently"},{"line_number":8,"context_line":"    support transparent live migration of VDPA devices at this time."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Hot-plug live migration unplugs the VDPA device on the source host"},{"line_number":11,"context_line":"    before the VM is live migrated and automatically hot-plugs the device"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6a014d88_b485339a","line":8,"range":{"start_line":7,"start_character":4,"end_line":8,"end_character":68},"in_reply_to":"b7fc2fed_93777704","updated":"2022-08-22 16:59:56.000000000","message":"Ack","commit_id":"01aec0c81331047c4d462b7fe076b85f82596ca1"}]}