)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4b82f1c19e4a09d31cfbcec3dd9a7a7d0b00bc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cab9e454_64dbdcf1","updated":"2022-09-01 15:55:11.000000000","message":"Nice refactoring","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86e07c42f0f257b22a7f8cdd3697fd5c8748bb72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7e1bb8c3_38c3c079","updated":"2022-08-29 20:14:02.000000000","message":"im mostly happy about this but i dont know if we will have two devices with the same pci request id","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1a2747a28447b5cdc96caf7a466e448e3dc85401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7e501cb5_9c1facc9","updated":"2022-09-02 09:30:06.000000000","message":"recheck grenade failed to ping the floating ip of a guest. this is unrelated to this patch","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"}],"nova/objects/instance.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4b82f1c19e4a09d31cfbcec3dd9a7a7d0b00bc1","unresolved":true,"context_lines":[{"line_number":1245,"context_line":"            # return early to avoid an extra lazy load on self.pci_requests"},{"line_number":1246,"context_line":"            # if there are no devices allocated to be filtered"},{"line_number":1247,"context_line":"            return []"},{"line_number":1248,"context_line":"        else:"},{"line_number":1249,"context_line":"            devs \u003d self.pci_devices.objects"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        if request_id is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"cc657243_7db827a3","line":1248,"updated":"2022-09-01 15:55:11.000000000","message":"nit: don\u0027t need the \u0027else\u0027 since there\u0027s an early return above","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c90c5b1f1ccc36adab4af4ce9920c03975836529","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"            # return early to avoid an extra lazy load on self.pci_requests"},{"line_number":1246,"context_line":"            # if there are no devices allocated to be filtered"},{"line_number":1247,"context_line":"            return []"},{"line_number":1248,"context_line":"        else:"},{"line_number":1249,"context_line":"            devs \u003d self.pci_devices.objects"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        if request_id is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"60571b3e_b5a14eb9","line":1248,"in_reply_to":"cc657243_7db827a3","updated":"2022-09-02 12:27:30.000000000","message":"Done in a FUP","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"}],"nova/pci/request.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3838ec74940f705ad6dc050ce3d9029ed568958b","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            spec\u003dspec,"},{"line_number":186,"context_line":"            alias_name\u003dname,"},{"line_number":187,"context_line":"            numa_policy\u003dpolicy,"},{"line_number":188,"context_line":"            request_id\u003duuidutils.generate_uuid(),"},{"line_number":189,"context_line":"        ))"},{"line_number":190,"context_line":"    return pci_requests"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bc55ed34_68ccdece","line":188,"updated":"2022-08-29 20:15:16.000000000","message":"i think this would always result in distict uuid for each pci request object and as a result each pci device that is allocated","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1457f585ca1b61480802cff9cd5ccf48bebe9d4a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            spec\u003dspec,"},{"line_number":186,"context_line":"            alias_name\u003dname,"},{"line_number":187,"context_line":"            numa_policy\u003dpolicy,"},{"line_number":188,"context_line":"            request_id\u003duuidutils.generate_uuid(),"},{"line_number":189,"context_line":"        ))"},{"line_number":190,"context_line":"    return pci_requests"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8773e8a0_87b9c11d","line":188,"in_reply_to":"85adc0c1_714cb380","updated":"2022-08-30 10:38:49.000000000","message":"ah and in that case each device object will map to a single request.\nya thats the case i ws missing i forgot about that\n\nyou are also changing that later in the seriese so with the new way of spliting that wont happen thanks","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a6e465c12f6ffbdf9f30552288fdec256b2c6ee2","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            spec\u003dspec,"},{"line_number":186,"context_line":"            alias_name\u003dname,"},{"line_number":187,"context_line":"            numa_policy\u003dpolicy,"},{"line_number":188,"context_line":"            request_id\u003duuidutils.generate_uuid(),"},{"line_number":189,"context_line":"        ))"},{"line_number":190,"context_line":"    return pci_requests"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"392883f6_2a7f4c63","line":188,"in_reply_to":"8773e8a0_87b9c11d","updated":"2022-08-31 08:32:16.000000000","message":"I don\u0027t split a single InstancePCIRequest objects with count\u003d2 to two InstancePCIRequest objects. I split that request to two RequestGroups objects. Also what I split is the PCI pool.","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4ca227cd5b89fab3c8c654e8eb91d38b686955fb","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            spec\u003dspec,"},{"line_number":186,"context_line":"            alias_name\u003dname,"},{"line_number":187,"context_line":"            numa_policy\u003dpolicy,"},{"line_number":188,"context_line":"            request_id\u003duuidutils.generate_uuid(),"},{"line_number":189,"context_line":"        ))"},{"line_number":190,"context_line":"    return pci_requests"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"85adc0c1_714cb380","line":188,"in_reply_to":"bc55ed34_68ccdece","updated":"2022-08-30 09:17:15.000000000","message":"Nova supports allocating muliple device per InstancePciRequest object.","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86e07c42f0f257b22a7f8cdd3697fd5c8748bb72","unresolved":true,"context_lines":[{"line_number":2150,"context_line":"        expected_devs \u003d ["},{"line_number":2151,"context_line":"            objects.PciDevice(request_id\u003duuids.req1),"},{"line_number":2152,"context_line":"            objects.PciDevice(request_id\u003duuids.req1),"},{"line_number":2153,"context_line":"        ]"},{"line_number":2154,"context_line":"        all_devs \u003d expected_devs + [objects.PciDevice(request_id\u003duuids.req2)]"},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":"        inst \u003d instance.Instance("}],"source_content_type":"text/x-python","patch_set":9,"id":"54fb45ab_1f721555","line":2153,"updated":"2022-08-29 20:14:02.000000000","message":"will this happen\ni.e. will we have two pci devices with the same uuid?","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"add976699d3d78663d629dfb41b84401592c8da2","unresolved":true,"context_lines":[{"line_number":2150,"context_line":"        expected_devs \u003d ["},{"line_number":2151,"context_line":"            objects.PciDevice(request_id\u003duuids.req1),"},{"line_number":2152,"context_line":"            objects.PciDevice(request_id\u003duuids.req1),"},{"line_number":2153,"context_line":"        ]"},{"line_number":2154,"context_line":"        all_devs \u003d expected_devs + [objects.PciDevice(request_id\u003duuids.req2)]"},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":"        inst \u003d instance.Instance("}],"source_content_type":"text/x-python","patch_set":9,"id":"76d4aa2e_547c39d3","line":2153,"in_reply_to":"54fb45ab_1f721555","updated":"2022-08-30 09:16:36.000000000","message":"Yes it will.\n\nIf the flavor asks for an alias with count 2 then nova will create an InstancePCIRequest(count\u003d2, request_id\u003duuids.req1), then the request spec logic will split that up to two groups:\n* RequestGroups(resources\u003d{RC:1}, requester_id\u003d{uuids.req1}-0)\n* RequestGroups(resources\u003d{RC:1}, requester_id\u003d{uuids.req1}-1)\nThen the scheduler makes an allocation fulfilling both groups which leads to two PciDevice being allocated. Both PciDevice will have the request_id set from the InstancePciRequest.request_id that is uuids.req1.","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1457f585ca1b61480802cff9cd5ccf48bebe9d4a","unresolved":false,"context_lines":[{"line_number":2150,"context_line":"        expected_devs \u003d ["},{"line_number":2151,"context_line":"            objects.PciDevice(request_id\u003duuids.req1),"},{"line_number":2152,"context_line":"            objects.PciDevice(request_id\u003duuids.req1),"},{"line_number":2153,"context_line":"        ]"},{"line_number":2154,"context_line":"        all_devs \u003d expected_devs + [objects.PciDevice(request_id\u003duuids.req2)]"},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":"        inst \u003d instance.Instance("}],"source_content_type":"text/x-python","patch_set":9,"id":"e058cb70_26ee7562","line":2153,"in_reply_to":"76d4aa2e_547c39d3","updated":"2022-08-30 10:38:49.000000000","message":"Ack","commit_id":"ccab6fed463337c029459469c76e92af3b96fa06"}]}