)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"521e795653cac2b7228638f20fadee79476619bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9a6ddb52_282f2674","updated":"2022-11-06 00:48:40.000000000","message":"lgtm","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a04a0b4a6a6f81bff917b2e8a926c4652639d77f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3bbaac05_1564efa8","updated":"2022-12-15 09:32:38.000000000","message":"recheck\n\nThis was a new error to me, do we have some resource constraint in the test env?\n\nThe following tests exited without returning a status\nand likely segfaulted or crashed Python:\n\n\t* tempest.api.compute.admin.test_volume.AttachSCSIVolumeTestJSON.test_attach_scsi_disk_with_config_drive[id-777e468f-17ca-4da4-b93d-b7dbf56c0494]","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b175bc11a2e0eda7072b29fa656f7db20b963bb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"491f22af_7476abce","updated":"2022-10-28 08:53:33.000000000","message":"recheck bug 1912310 (nova-next seems to be failing with this even though the bug is closed)","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b20a55ce1a9eed4603c41e276118e876469bd449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bf3734cd_3039f847","updated":"2022-11-02 10:27:09.000000000","message":"recheck grenade http timeout","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b1f3afb36ecc4fa2af8be512421049f429a0ed98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f6b84298_885c7482","updated":"2022-10-27 08:45:36.000000000","message":"recheck grenade http timeout","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8ec73c8d1406b6363d67782a7d73f91ee856b05d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5763cbc7_6e8e48c4","updated":"2022-12-14 17:26:47.000000000","message":"recheck volume timeout","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"03b47a247acb88ac880a121dd7257634029ce8b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b462fb60_06ffe355","updated":"2022-12-09 17:10:14.000000000","message":"👌","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d09d692f91280c4c7dfa2a7de33c0bd948ce0c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cb4a2157_702ed298","in_reply_to":"3bbaac05_1564efa8","updated":"2022-12-15 12:50:45.000000000","message":"i have seen that once or twice in the last month or two","commit_id":"e96601c606059c862e8066f91b49093f98ad46d2"}],"nova/pci/stats.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c613e6e3845918b9ea68bf89cb9b96024c5327c","unresolved":true,"context_lines":[{"line_number":795,"context_line":"            if len(pool_rps) \u003e\u003d 2:"},{"line_number":796,"context_line":"                # FIXME(gibi): Do we have a 1:1 pool - RP mapping even"},{"line_number":797,"context_line":"                #  if two PFs providing very similar VFs?"},{"line_number":798,"context_line":"                raise ValueError("},{"line_number":799,"context_line":"                    \"We have a pool %s connected to more than one RPs %s in \""},{"line_number":800,"context_line":"                    \"placement via devs %s\" % (pool, pool_rps, pool[\"devices\"])"},{"line_number":801,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb060b33_1d36eb31","line":798,"updated":"2022-08-23 18:00:09.000000000","message":"now I have a functional test test_vf_with_split_allocation that proves that each PF has its own pool. \\o/","commit_id":"439f51b840eaf5e93138a5e123121ce1e9fc4a63"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f76800fbb04e0795585b5dee78919c7d1cc7529e","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            if len(pool_rps) \u003e\u003d 2:"},{"line_number":796,"context_line":"                # FIXME(gibi): Do we have a 1:1 pool - RP mapping even"},{"line_number":797,"context_line":"                #  if two PFs providing very similar VFs?"},{"line_number":798,"context_line":"                raise ValueError("},{"line_number":799,"context_line":"                    \"We have a pool %s connected to more than one RPs %s in \""},{"line_number":800,"context_line":"                    \"placement via devs %s\" % (pool, pool_rps, pool[\"devices\"])"},{"line_number":801,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f81d63e_d05073eb","line":798,"in_reply_to":"816539ab_d38c013e","updated":"2022-08-28 17:30:13.000000000","message":"Done","commit_id":"439f51b840eaf5e93138a5e123121ce1e9fc4a63"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bb36ba933060e544829948cb656e41c2dbfea5a4","unresolved":true,"context_lines":[{"line_number":795,"context_line":"            if len(pool_rps) \u003e\u003d 2:"},{"line_number":796,"context_line":"                # FIXME(gibi): Do we have a 1:1 pool - RP mapping even"},{"line_number":797,"context_line":"                #  if two PFs providing very similar VFs?"},{"line_number":798,"context_line":"                raise ValueError("},{"line_number":799,"context_line":"                    \"We have a pool %s connected to more than one RPs %s in \""},{"line_number":800,"context_line":"                    \"placement via devs %s\" % (pool, pool_rps, pool[\"devices\"])"},{"line_number":801,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":2,"id":"816539ab_d38c013e","line":798,"in_reply_to":"cb060b33_1d36eb31","updated":"2022-08-26 14:14:20.000000000","message":"nah it turned out sometimes nova pools together VFs from different PFs if they are on the same numa node. So I needed to add https://review.opendev.org/c/openstack/nova/+/854440/2","commit_id":"439f51b840eaf5e93138a5e123121ce1e9fc4a63"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8744e358432fc3f3ed3ef39d977b3729b9f3d7a1","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            del pool_keys[\u0027count\u0027]"},{"line_number":98,"context_line":"            del pool_keys[\u0027devices\u0027]"},{"line_number":99,"context_line":"            # FIXME(gibi): do we need this?"},{"line_number":100,"context_line":"            pool_keys.pop(\u0027rp_uuid\u0027, None)"},{"line_number":101,"context_line":"            if (len(pool_keys.keys()) \u003d\u003d len(dev_pool.keys()) and"},{"line_number":102,"context_line":"                self._equal_properties(dev_pool, pool_keys, list(dev_pool))):"},{"line_number":103,"context_line":"                return pool"}],"source_content_type":"text/x-python","patch_set":8,"id":"7b9f1f08_63f410ba","line":100,"updated":"2022-08-29 20:56:24.000000000","message":"im not sure we need this.","commit_id":"161eb7388954d171f47b5b78af75375e9d85cc30"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49edb5f46e92d90141b796e23ff8875034fb2e4a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            del pool_keys[\u0027count\u0027]"},{"line_number":98,"context_line":"            del pool_keys[\u0027devices\u0027]"},{"line_number":99,"context_line":"            # FIXME(gibi): do we need this?"},{"line_number":100,"context_line":"            pool_keys.pop(\u0027rp_uuid\u0027, None)"},{"line_number":101,"context_line":"            if (len(pool_keys.keys()) \u003d\u003d len(dev_pool.keys()) and"},{"line_number":102,"context_line":"                self._equal_properties(dev_pool, pool_keys, list(dev_pool))):"},{"line_number":103,"context_line":"                return pool"}],"source_content_type":"text/x-python","patch_set":8,"id":"5d2877f2_ed594fc8","line":100,"in_reply_to":"7b9f1f08_63f410ba","updated":"2022-08-30 11:21:40.000000000","message":"let me test it :)\n//later\nyes we can remove it. I dropped it in a follow up","commit_id":"161eb7388954d171f47b5b78af75375e9d85cc30"}]}