)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e3674911f9295c0cbb7849cea7a5c6e8f29308ee","unresolved":true,"context_lines":[{"line_number":40,"context_line":"don\u0027t consider this as a behavior change. Therefore the test is updated"},{"line_number":41,"context_line":"not to create a situation where two different scheduling solutions are"},{"line_number":42,"context_line":"possible."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"blueprint: pci-device-tracking-in-placement"},{"line_number":45,"context_line":"Change-Id: I4b67cca3807fbda9e9b07b220a28e331def57624"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fdba691e_d1b5edad","line":43,"updated":"2022-08-29 20:50:41.000000000","message":"correct nova does not.\n\nnova has a pci weigher that could be used to prefer or avoid hosts with pci devices  based on the number avaible however we never had any optimisation of usage based on if a PF had or did not have Avaiable VFs.\n\n\nthat could have been a nice optimisation to have before tracking devices in placement but now we cant have both PFs and VFs enabled when track devices in placement so its nologer important.\n\n+1 the new algorthim is actully the more optimial one so this is generally a good improvemnt even if you dont enable pci device tracking in placment.","commit_id":"7f9dfb140d7daf67e1fa38eeedfe42ab2c452307"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5c6f9c2f8b33deb0cbb0082bfeeaf601231b8dca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"don\u0027t consider this as a behavior change. Therefore the test is updated"},{"line_number":41,"context_line":"not to create a situation where two different scheduling solutions are"},{"line_number":42,"context_line":"possible."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"blueprint: pci-device-tracking-in-placement"},{"line_number":45,"context_line":"Change-Id: I4b67cca3807fbda9e9b07b220a28e331def57624"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"57e721e5_81ea485c","line":43,"in_reply_to":"fdba691e_d1b5edad","updated":"2022-08-30 11:21:30.000000000","message":"Ack","commit_id":"7f9dfb140d7daf67e1fa38eeedfe42ab2c452307"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9529355eb833ac6c4bc2498d5b42e04b33799190","unresolved":false,"context_lines":[{"line_number":39,"context_line":"solution is equally good from nova\u0027s scheduling contract perspective I"},{"line_number":40,"context_line":"don\u0027t consider this as a behavior change. Therefore the test is updated"},{"line_number":41,"context_line":"not to create a situation where two different scheduling solutions are"},{"line_number":42,"context_line":"possible."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"blueprint: pci-device-tracking-in-placement"},{"line_number":45,"context_line":"Change-Id: I4b67cca3807fbda9e9b07b220a28e331def57624"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"312cd37e_ddbb7663","line":42,"updated":"2022-12-09 17:05:57.000000000","message":"Thanks for the context. I skipped straight to the code and wondered why you were doing what you were doing 😄","commit_id":"c2f48412b57080ca0950e47f35ba6cc926596a85"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e3674911f9295c0cbb7849cea7a5c6e8f29308ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b593f02_4a3ec14f","updated":"2022-08-29 20:50:41.000000000","message":"this looks good but again i need to review this when less tired so +1 for now","commit_id":"7f9dfb140d7daf67e1fa38eeedfe42ab2c452307"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"42b42beb084a7e22a4e33d4b1be47f2940675906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"22b58e54_7fa5f6b0","updated":"2022-11-06 00:50:00.000000000","message":"lgtm","commit_id":"c2f48412b57080ca0950e47f35ba6cc926596a85"}],"nova/pci/stats.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"516e98d2ee0fd128f4dec62c36b98d4c9ebea524","unresolved":true,"context_lines":[{"line_number":139,"context_line":"            return None"},{"line_number":140,"context_line":"        tags \u003d devspec.get_tags()"},{"line_number":141,"context_line":"        pool \u003d {k: getattr(dev, k) for k in self.pool_keys}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if tags:"},{"line_number":144,"context_line":"            pool.update("},{"line_number":145,"context_line":"                {k: v for k, v in tags.items() if k not in self.ignored_tags}"}],"source_content_type":"text/x-python","patch_set":8,"id":"6ff68803_47b499af","line":142,"updated":"2022-12-07 12:42:58.000000000","message":"nit, not related","commit_id":"c2f48412b57080ca0950e47f35ba6cc926596a85"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"516e98d2ee0fd128f4dec62c36b98d4c9ebea524","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        # are equivalent from placement perspective."},{"line_number":152,"context_line":"        address \u003d dev.parent_addr or dev.address"},{"line_number":153,"context_line":"        pool[\u0027address\u0027] \u003d address"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # NOTE(gibi): parent_ifname acts like a tag during pci claim but"},{"line_number":156,"context_line":"        # not provided as part of the whitelist spec as it is auto detected"},{"line_number":157,"context_line":"        # by the virt driver."}],"source_content_type":"text/x-python","patch_set":8,"id":"1f9cbba6_def49b20","line":154,"updated":"2022-12-07 12:42:58.000000000","message":"nit: no need to define address.\n\n        pool[\u0027address\u0027] \u003d  dev.parent_addr or dev.address","commit_id":"c2f48412b57080ca0950e47f35ba6cc926596a85"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f7f94616be56ef01cef0738a16f6c6e3bcb9e051","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        # are equivalent from placement perspective."},{"line_number":152,"context_line":"        address \u003d dev.parent_addr or dev.address"},{"line_number":153,"context_line":"        pool[\u0027address\u0027] \u003d address"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # NOTE(gibi): parent_ifname acts like a tag during pci claim but"},{"line_number":156,"context_line":"        # not provided as part of the whitelist spec as it is auto detected"},{"line_number":157,"context_line":"        # by the virt driver."}],"source_content_type":"text/x-python","patch_set":8,"id":"60e43b0c_a947b709","line":154,"in_reply_to":"1f9cbba6_def49b20","updated":"2022-12-13 13:49:35.000000000","message":"simplified in the FUP https://review.opendev.org/c/openstack/nova/+/862876","commit_id":"c2f48412b57080ca0950e47f35ba6cc926596a85"}]}