)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9956c45e76e1203c0cb5dfd07dbf2021cdcc7428","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Adds a regression test or repoducer for post live migration"},{"line_number":10,"context_line":"fail at destination, the possible casue can be fail to get"},{"line_number":11,"context_line":"instance network info or  block device info"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I48dbe0aae8a3943fdde69cda1bd663d70ea0eb19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"18e48679_0390ae6c","line":12,"updated":"2022-09-06 09:14:46.000000000","message":"Please add a reference to the relate bug via\n  \nRelated-Bug:","commit_id":"c836e9a4a5a590952a27b9a115052711b956e808"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3802aa5fc7c99a69d156d90d70d391fa18beacf4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds a regression test or repoducer for post live migration"},{"line_number":10,"context_line":"fail at destination, the possible casue can be fail to get"},{"line_number":11,"context_line":"instance network info or  block device info"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I48dbe0aae8a3943fdde69cda1bd663d70ea0eb19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e5372920_5fff72da","line":12,"in_reply_to":"18e48679_0390ae6c","updated":"2022-09-13 08:59:49.000000000","message":"Done","commit_id":"c836e9a4a5a590952a27b9a115052711b956e808"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8488f1e4574551ecb71592c310a6d66267530a49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b480ede6_1893723a","updated":"2022-08-26 11:20:00.000000000","message":"the order of the patches is also incorect.\n\nthis should be the base patch with the other patch \nhttps://review.opendev.org/c/openstack/nova/+/791135/2 \non top","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3802aa5fc7c99a69d156d90d70d391fa18beacf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3ba724ee_51e12426","updated":"2022-09-13 08:59:49.000000000","message":"Updated commit msg as per the comments","commit_id":"95a9da8f8b06a718eed6b9fa9b0198b90d17baef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c91c81cc0d0ccc46c26373a7afb59d8afd43fefb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2245cfdb_16273788","updated":"2022-10-14 13:50:44.000000000","message":"Bravo Amit for this very good functional test.","commit_id":"a20baeca1f5ebb0dfe9607335a6986e9ed0e1725"}],"nova/tests/functional/regressions/test_bug_1628606.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5becd82fc01978634ab3416448dd114834dbd12","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._get_instance_block_device_info\u0027)"},{"line_number":50,"context_line":"    def test_post_live_migration(self, mock_block_device):"},{"line_number":51,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":52,"context_line":"        server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":54,"context_line":"        "},{"line_number":55,"context_line":"        error \u003d client.OpenStackApiException(\"Get Instance Block device failed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"711fde32_4f334fcc","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":62},"updated":"2022-08-25 11:06:06.000000000","message":"this should be done by the _create_server helper.\nso you can remove it","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ab58b329eb76cf2d4b97332b8c206c125fc7116a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._get_instance_block_device_info\u0027)"},{"line_number":50,"context_line":"    def test_post_live_migration(self, mock_block_device):"},{"line_number":51,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":52,"context_line":"        server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":54,"context_line":"        "},{"line_number":55,"context_line":"        error \u003d client.OpenStackApiException(\"Get Instance Block device failed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"587200a1_23cb7555","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":62},"in_reply_to":"711fde32_4f334fcc","updated":"2022-08-26 05:33:36.000000000","message":"Done","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5becd82fc01978634ab3416448dd114834dbd12","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        error \u003d client.OpenStackApiException(\"Get Instance Block device failed\")"},{"line_number":56,"context_line":"        mock_block_device.side_effect \u003d error"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        live_migrate_req \u003d {"},{"line_number":59,"context_line":"            \u0027os-migrateLive\u0027: {\u0027host\u0027: self.dest.host, \u0027block_migration\u0027: \u0027auto\u0027}}"},{"line_number":60,"context_line":"        # try:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        #     self.api.post_server_action(server[\u0027id\u0027], live_migrate_req)"},{"line_number":63,"context_line":"        # except OpenStackApiException:"},{"line_number":64,"context_line":"        #     pass"},{"line_number":65,"context_line":"        # server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":66,"context_line":"        # self.assertEqual(\u0027host2\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8e1aa08_d13e08ed","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":67},"updated":"2022-08-25 11:06:06.000000000","message":"this shoudl be deleted this wont work when the issue is fixed.\n\nyou will still just use \n\n        \n       self._live_migrate(server, migration_expected_state\u003d\u0027error\u0027)","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ab58b329eb76cf2d4b97332b8c206c125fc7116a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        error \u003d client.OpenStackApiException(\"Get Instance Block device failed\")"},{"line_number":56,"context_line":"        mock_block_device.side_effect \u003d error"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        live_migrate_req \u003d {"},{"line_number":59,"context_line":"            \u0027os-migrateLive\u0027: {\u0027host\u0027: self.dest.host, \u0027block_migration\u0027: \u0027auto\u0027}}"},{"line_number":60,"context_line":"        # try:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        #     self.api.post_server_action(server[\u0027id\u0027], live_migrate_req)"},{"line_number":63,"context_line":"        # except OpenStackApiException:"},{"line_number":64,"context_line":"        #     pass"},{"line_number":65,"context_line":"        # server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":66,"context_line":"        # self.assertEqual(\u0027host2\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b4149ac_f91d6a7b","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":67},"in_reply_to":"c8e1aa08_d13e08ed","updated":"2022-08-26 05:33:36.000000000","message":"Done","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"40a66c4ea8d4fc6f68566b4cd210bd91022676a2","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        # self.assertEqual(\u0027host2\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"57f1f65c_ca1bf841","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":26},"updated":"2022-08-25 07:27:35.000000000","message":"Failing with traceback:\n\n\nnova.tests.functional.regressions.test_bug_1628606.PostLiveMigrationFail.test_post_live_migration\n-------------------------------------------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n\n      File \"/usr/lib/python3.8/unittest/mock.py\", line 1325, in patched\n    return func(*newargs, **newkeywargs)\n\n      File \"/opt/stack/nova/nova/tests/functional/regressions/test_bug_1628606.py\", line 69, in test_post_live_migration\n    self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)\n\n      File \"/opt/stack/nova/nova/tests/functional/integrated_helpers.py\", line 564, in _live_migrate\n    self._wait_for_migration_status(server, [migration_expected_state])\n\n      File \"/opt/stack/nova/nova/tests/functional/integrated_helpers.py\", line 290, in _wait_for_migration_status\n    self.fail(\n\n      File \"/usr/lib/python3.8/unittest/case.py\", line 753, in fail\n    raise self.failureException(msg)\n\n    AssertionError: Timed out waiting for migration with status for instance 92f1e6d4-c695-4e2c-9f98-e3f3e6ff54ed (expected \"[\u0027failed\u0027]\", got \"error\")","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ab58b329eb76cf2d4b97332b8c206c125fc7116a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # self.assertEqual(\u0027host2\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ec443609_37cc45dd","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":26},"in_reply_to":"52ffa10e_38f5913f","updated":"2022-08-26 05:33:36.000000000","message":"Done","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5becd82fc01978634ab3416448dd114834dbd12","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        # self.assertEqual(\u0027host2\u0027, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"52ffa10e_38f5913f","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":26},"in_reply_to":"57f1f65c_ca1bf841","updated":"2022-08-25 11:06:06.000000000","message":"well that pretty simple to fix\n\n server  \u003d self._live_migrate(server, migration_expected_state\u003d\u0027error\u0027)\n \n _live_migrate will now return the server i fixed that in my vdpa series.\n \n you need the updated server to asseert what host its on V","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5becd82fc01978634ab3416448dd114834dbd12","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9544080b_4df919d3","line":70,"updated":"2022-08-25 11:06:06.000000000","message":"you shoudl assert  following\n\n# FIXME(amit): this shoudl poiint to the dest but does not\n# because of bug 1628606\nself.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ab58b329eb76cf2d4b97332b8c206c125fc7116a","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        "},{"line_number":69,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027failed\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2b42fa21_991fe0ce","line":70,"in_reply_to":"9544080b_4df919d3","updated":"2022-08-26 05:33:36.000000000","message":"Done","commit_id":"39d261d0076be92f1d465ec495d620235795b569"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8488f1e4574551ecb71592c310a6d66267530a49","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        self.dest \u003d self._start_compute(host\u003d\u0027host2\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @mock.patch("},{"line_number":47,"context_line":"        \u0027nova.compute.manager.ComputeManager._get_instance_block_device_info\u0027)"},{"line_number":48,"context_line":"    def test_post_live_migration(self, mock_block_device):"},{"line_number":49,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":50,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"258bdfac_819ac215","line":47,"range":{"start_line":47,"start_character":9,"end_line":47,"end_character":77},"updated":"2022-08-26 11:20:00.000000000","message":"this is also used in check_can_live_migrate_source in pre live migrate so the test it failing their before we ever get to post live migreate\n\ntry swapping this to _post_live_migration_remove_source_vol_connections\n\nand it should simulate the behavior you wanted.","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"92566897c7587f8772d560dc19ead36ae9349c6a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.dest \u003d self._start_compute(host\u003d\u0027host2\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @mock.patch("},{"line_number":47,"context_line":"        \u0027nova.compute.manager.ComputeManager._get_instance_block_device_info\u0027)"},{"line_number":48,"context_line":"    def test_post_live_migration(self, mock_block_device):"},{"line_number":49,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":50,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"8cc75b8b_015c98c3","line":47,"range":{"start_line":47,"start_character":9,"end_line":47,"end_character":77},"in_reply_to":"258bdfac_819ac215","updated":"2022-08-29 09:39:58.000000000","message":"Done","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ab58b329eb76cf2d4b97332b8c206c125fc7116a","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            \"Get Instance Block device failed\")"},{"line_number":54,"context_line":"        mock_block_device.side_effect \u003d error"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027error\u0027)"},{"line_number":57,"context_line":"        # FIXME(amit): this shoudl point to the dest but does not"},{"line_number":58,"context_line":"        # because of bug 1628606"},{"line_number":59,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"a47fbbe5_fd083294","line":56,"updated":"2022-08-26 05:33:36.000000000","message":"error log on this:\n\nhttps://privatebin.corp.redhat.com/?f9cbaaeab2ad0c0c#2N3tTdkZ4S9J9gH3kLqUZuEMESibMqs7uc7Htj6fT2Ta","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"92566897c7587f8772d560dc19ead36ae9349c6a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \"Get Instance Block device failed\")"},{"line_number":54,"context_line":"        mock_block_device.side_effect \u003d error"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027error\u0027)"},{"line_number":57,"context_line":"        # FIXME(amit): this shoudl point to the dest but does not"},{"line_number":58,"context_line":"        # because of bug 1628606"},{"line_number":59,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"b92bcadf_3ed77bba","line":56,"in_reply_to":"05e6189a_eab94f82","updated":"2022-08-29 09:39:58.000000000","message":"Ack","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"0e920ff99f1289f9140b8b99cbfc560ab3327250","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            \"Get Instance Block device failed\")"},{"line_number":54,"context_line":"        mock_block_device.side_effect \u003d error"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027error\u0027)"},{"line_number":57,"context_line":"        # FIXME(amit): this shoudl point to the dest but does not"},{"line_number":58,"context_line":"        # because of bug 1628606"},{"line_number":59,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd614b25_7f890c67","line":56,"in_reply_to":"a47fbbe5_fd083294","updated":"2022-08-26 05:37:25.000000000","message":"Mostly this failed:\n\n  File \"/opt/stack/nova/nova/conductor/manager.py\", line 532, in _live_migrate\n    raise exception.MigrationError(reason\u003dstr(ex))\nnova.exception.MigrationError: Migration error: Get Instance Block device failed","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8488f1e4574551ecb71592c310a6d66267530a49","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            \"Get Instance Block device failed\")"},{"line_number":54,"context_line":"        mock_block_device.side_effect \u003d error"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._live_migrate(server, migration_expected_state\u003d\u0027error\u0027)"},{"line_number":57,"context_line":"        # FIXME(amit): this shoudl point to the dest but does not"},{"line_number":58,"context_line":"        # because of bug 1628606"},{"line_number":59,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"05e6189a_eab94f82","line":56,"in_reply_to":"fd614b25_7f890c67","updated":"2022-08-26 11:20:00.000000000","message":"you shoulkd not use or internal private pastbin instance for things like this\n\nuse paste.openstack.org instead.","commit_id":"1dfc93813e81c52abcc50905a24a0702bc02646b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a6aeee7fa499bd80dd910929893f773e53fd0e34","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super().setUp()"},{"line_number":28,"context_line":"        # self.useFixture(nova_fixtures.RealPolicyFixture())"},{"line_number":29,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"},{"line_number":30,"context_line":"        self.glance \u003d self.useFixture(nova_fixtures.GlanceFixture(self))"},{"line_number":31,"context_line":"        self.useFixture(func_fixtures.PlacementFixture())"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4ba387_34f2bb87","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":60},"updated":"2022-09-01 11:00:41.000000000","message":"you should remove this i dont think you need this in the follow up either","commit_id":"dbe916ede0e838089768c1a3d4f31824971f4df2"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7c25e983586b8afe03696f0fd16cd755ee690736","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super().setUp()"},{"line_number":28,"context_line":"        # self.useFixture(nova_fixtures.RealPolicyFixture())"},{"line_number":29,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"},{"line_number":30,"context_line":"        self.glance \u003d self.useFixture(nova_fixtures.GlanceFixture(self))"},{"line_number":31,"context_line":"        self.useFixture(func_fixtures.PlacementFixture())"}],"source_content_type":"text/x-python","patch_set":5,"id":"27c0cb5a_a3b0e56c","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":60},"in_reply_to":"1a4ba387_34f2bb87","updated":"2022-09-02 03:49:55.000000000","message":"Done","commit_id":"dbe916ede0e838089768c1a3d4f31824971f4df2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9956c45e76e1203c0cb5dfd07dbf2021cdcc7428","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":50,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        error \u003d client.OpenStackApiException("},{"line_number":53,"context_line":"            \"Failed to remove source vol connection post live migration\")"},{"line_number":54,"context_line":"        mock_migration.side_effect \u003d error"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"18b43fca_9e782c78","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":44},"updated":"2022-09-06 09:14:46.000000000","message":"this is not the exception that code in _post_live_migration_remove_source_vol_connections would raise.\n\nWhat error scenario you would like to simulate here exactly? \n\nThe _post_live_migration_remove_source_vol_connections calls the libvirt driver self.driver.get_volume_connector(instance) I imagine that could fail. Also _post_live_migration_remove_source_vol_connections calls cinder via self.volume_api.attachment_delete() but that is wrapped in a try/except Exception block that just log and did not re-raise any exception so that could not (reasonably) fail.","commit_id":"c836e9a4a5a590952a27b9a115052711b956e808"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8e1e3245a3aee777954d2794c434b4e45b11c52d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":50,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        error \u003d client.OpenStackApiException("},{"line_number":53,"context_line":"            \"Failed to remove source vol connection post live migration\")"},{"line_number":54,"context_line":"        mock_migration.side_effect \u003d error"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"49df32aa_8b501735","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":44},"in_reply_to":"18b43fca_9e782c78","updated":"2022-09-06 09:22:32.000000000","message":"we are trying to simulate any uncaught excpation being raised in post live migration.\n\nits not about any specific function or error that is raised just simulating any expction that gets raised before we update instance.host and save it to the db.","commit_id":"c836e9a4a5a590952a27b9a115052711b956e808"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3802aa5fc7c99a69d156d90d70d391fa18beacf4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        server \u003d self._create_server(networks\u003d[])"},{"line_number":50,"context_line":"        self.assertEqual(self.src.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        error \u003d client.OpenStackApiException("},{"line_number":53,"context_line":"            \"Failed to remove source vol connection post live migration\")"},{"line_number":54,"context_line":"        mock_migration.side_effect \u003d error"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"cdc4456a_e9b07220","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":44},"in_reply_to":"49df32aa_8b501735","updated":"2022-09-13 08:59:49.000000000","message":"Done","commit_id":"c836e9a4a5a590952a27b9a115052711b956e808"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c91c81cc0d0ccc46c26373a7afb59d8afd43fefb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fe2955d8_3e8ce3ff","line":62,"updated":"2022-10-14 13:50:44.000000000","message":"Nothing to tell, looks good to me.","commit_id":"a20baeca1f5ebb0dfe9607335a6986e9ed0e1725"}]}