)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"941c032af24568f0381f62f8a4f6667a95d3039d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"060cac75_7d3916c3","updated":"2024-07-02 11:30:55.000000000","message":"I still miss some test coverage.","commit_id":"cba50b72f52f53e6eb4505287bee33a25c054818"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"02675e14d28cf49243d2a4c0ebb1e6d8f390388c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"209a4c23_153b07f8","updated":"2024-07-04 15:01:19.000000000","message":"Slight improvement but I think we need to do the same pattern for all ops.","commit_id":"cba50b72f52f53e6eb4505287bee33a25c054818"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bc3ef305620619ae199c8492ce8af7e296681b7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"77613b99_75cf715b","updated":"2024-08-28 13:27:57.000000000","message":"I still would like to get a code comment explaining why we don\u0027t need to mount in case of soft reboot, and test coverage asserting the logic difference between soft and hard reboot.","commit_id":"5e685f8fb65888298b724abed0a0b9a95b729f2c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dfd67e9100f231fc00ce22203ee4b6c68e431c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"5c5256fc_e4b3a94e","updated":"2024-10-11 11:49:50.000000000","message":"My comments where fixed. This looks good to me now.","commit_id":"512c89954ecebf8160b2f3b1218da12033057f75"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"10c7b23f844cb9198787bf476133c032b8fc1ca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"f56c0dff_6d4e65cd","updated":"2024-11-15 10:32:30.000000000","message":"Recent change looks good to me.","commit_id":"65505be115f50052b861b4189b6f25d839842655"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6abf2ee9fe947577b2d8126e5177ddbd3a7e2475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"9462b2e9_1c7fb6e4","updated":"2024-11-18 17:57:49.000000000","message":"the problem is now fixed.","commit_id":"65505be115f50052b861b4189b6f25d839842655"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"256bdf117986f127a4e82d4de7c4b2a15de039ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"624b5e85_ba287bbc","updated":"2024-11-23 09:19:05.000000000","message":"recheck cinder volume mount failed in guest\n```\ntempest.lib.exceptions.SSHExecCommandFailed: Command \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mount /dev/vdb /mnt/1696986089/vdb\u0027, exit status: 255, stderr:\nmount: mounting /dev/vdb on /mnt/1696986089/vdb failed: Device or resource busy\n```","commit_id":"e4a443f4f568b3a242fde886b9aa63797f21471d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"883cbecac0ae982500bcc813478350799aed19ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"85780777_9482239d","updated":"2024-11-26 11:16:43.000000000","message":"recheck parent faile","commit_id":"e4a443f4f568b3a242fde886b9aa63797f21471d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"980677a5f43d24f4f843b23886713b14d8ffb956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"0ce97d67_66b5dab6","updated":"2024-11-26 04:18:39.000000000","message":"recheck parrent failed","commit_id":"e4a443f4f568b3a242fde886b9aa63797f21471d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d75d6b3899c82cceeb3037090714f56ed30c2188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"a2ca17ee_80923dd9","updated":"2024-11-28 08:52:28.000000000","message":"recheck guest kernel panic\n```\n/sbin/init: can\u0027t load library \u0027libtirpc.so.3\u0027\n[   11.638599] Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000\n```","commit_id":"3ef78478bc935b8beddc9deb36e9550a852b6b66"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"344b2c932e4651394d3a37761049e84c0d6cb8b7","unresolved":true,"context_lines":[{"line_number":4387,"context_line":"            self._handle_bad_volumes_detached("},{"line_number":4388,"context_line":"                    context, instance, bad_devices, block_device_info)"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":"        def is_share_error(share_info):"},{"line_number":4391,"context_line":"            return any("},{"line_number":4392,"context_line":"                ["},{"line_number":4393,"context_line":"                    share_mapping.status \u003d\u003d fields.ShareMappingStatus.ERROR"}],"source_content_type":"text/x-python","patch_set":34,"id":"fafbca1e_a52e4e7e","line":4390,"updated":"2024-02-28 13:24:18.000000000","message":"this can be a function on ShareMappingList","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"003d5cef36a7494dc92213ffb76e40a0579f0d4a","unresolved":false,"context_lines":[{"line_number":4387,"context_line":"            self._handle_bad_volumes_detached("},{"line_number":4388,"context_line":"                    context, instance, bad_devices, block_device_info)"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":"        def is_share_error(share_info):"},{"line_number":4391,"context_line":"            return any("},{"line_number":4392,"context_line":"                ["},{"line_number":4393,"context_line":"                    share_mapping.status \u003d\u003d fields.ShareMappingStatus.ERROR"}],"source_content_type":"text/x-python","patch_set":34,"id":"139994fd_6d10e6a3","line":4390,"in_reply_to":"b1aec885_61caa7c4","updated":"2024-09-09 16:13:01.000000000","message":"Done","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"20800b588d0983718cb48cc86ca91f8e529f74ba","unresolved":true,"context_lines":[{"line_number":4387,"context_line":"            self._handle_bad_volumes_detached("},{"line_number":4388,"context_line":"                    context, instance, bad_devices, block_device_info)"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":"        def is_share_error(share_info):"},{"line_number":4391,"context_line":"            return any("},{"line_number":4392,"context_line":"                ["},{"line_number":4393,"context_line":"                    share_mapping.status \u003d\u003d fields.ShareMappingStatus.ERROR"}],"source_content_type":"text/x-python","patch_set":34,"id":"b1aec885_61caa7c4","line":4390,"in_reply_to":"fafbca1e_a52e4e7e","updated":"2024-03-11 15:45:29.000000000","message":"Yep you are right. I\u0027ll move it depending on the below answer.","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"344b2c932e4651394d3a37761049e84c0d6cb8b7","unresolved":true,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"f787b0db_60ecdb3c","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"updated":"2024-02-28 13:24:18.000000000","message":"can we do this unconditionally, would it hurt to call mount on an already mounted share?\n\nThis is related to my comments about error handling in _get_share_info","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"018c285c8640b42cfa4a2fb7b48e54b503493c40","unresolved":true,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"664f028c_dd3a189d","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"in_reply_to":"30b7b0f5_e419ebfb","updated":"2024-05-22 13:26:46.000000000","message":"If we don\u0027t retry the mount during soft reboot then a share_mapping in ERROR state will simply be ignored (_get_share_info will only logs a warning) and the reboot will happen. I would consider that as a bug to allow rebooting a VM with share_mapping in ERROR.","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"02675e14d28cf49243d2a4c0ebb1e6d8f390388c","unresolved":true,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7bb763c8_897fb4f5","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"in_reply_to":"4c4f36a1_60da2ee1","updated":"2024-07-04 15:01:19.000000000","message":"OK, then I\u0027d prefer something like that :\n\n```\nif share_info and reboot_type \u003d\u003d \u0027HARD\u0027:\n  # unconditionally ensure that the mount is present\n  self._mount_all_shares(context, instance, share_info)\n```\n\nFirst, we would only check the reboot type *only if we need to care* and then we would call mount anyway, as it\u0027s idempotent (and I tend to think it should be the same pattern for all the operations (ie. do we have a share info ? if so, just unconditionally mount the share and pass the share info to the operation)","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"85f2cdbcaab14934a62bb662ea8226919b4e2932","unresolved":true,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"4c4f36a1_60da2ee1","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"in_reply_to":"664f028c_dd3a189d","updated":"2024-05-28 09:10:58.000000000","message":"So the API ref [1] states that soft reboot can only be done if the instance is in ACTIVE state. If the instance is in ACTIVE state it cannot have a share_mapping in ERROR so it is safe to ignore the re-mounting of the share for soft reboot. Please add a comment in the code noting this as the reason that we only do the mount in the HARD reboot case.\n\n[1] https://docs.openstack.org/api-ref/compute/#reboot-server-reboot-action","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bc3ef305620619ae199c8492ce8af7e296681b7f","unresolved":true,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"dfd7c8bc_92b1fb0d","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"in_reply_to":"7bb763c8_897fb4f5","updated":"2024-08-28 13:27:57.000000000","message":"The order is irrelevant for me as _mount_all_shares is an empty loop if share_info is empty.\n\nBut I still would like to see a comment explaining why we don\u0027t need to mount during soft reboot.","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0a4d3b39b246224f0d6e551b65817c25988cd751","unresolved":false,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"f9bf2f73_b64711e1","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"in_reply_to":"dfd7c8bc_92b1fb0d","updated":"2024-11-20 15:06:05.000000000","message":"Done","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"20800b588d0983718cb48cc86ca91f8e529f74ba","unresolved":true,"context_lines":[{"line_number":4410,"context_line":"                expected_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":4411,"context_line":"            instance.save(expected_task_state\u003dexpected_state)"},{"line_number":4412,"context_line":""},{"line_number":4413,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and is_share_error(share_info):"},{"line_number":4414,"context_line":"                # Attempt to mount the shares again."},{"line_number":4415,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"            self.driver.reboot(context, instance,"},{"line_number":4418,"context_line":"                               network_info,"}],"source_content_type":"text/x-python","patch_set":34,"id":"30b7b0f5_e419ebfb","line":4415,"range":{"start_line":4413,"start_character":1,"end_line":4415,"end_character":62},"in_reply_to":"f787b0db_60ecdb3c","updated":"2024-03-11 15:45:29.000000000","message":"This is possible, because the driver handles \"multiple\" mounts.\n\nMy intent here was:\n1- keep rebooting as fast as possible, so there is no need to do something that is already ok.\n2- I still think it is something that needs to be done only on HARD reboot.\n\nIn short, I am not opposed to doing the mount on all shares, but I would keep this for HARD reboot only.","commit_id":"b08fe272f959ed409f602e69aa908b962ab0a17f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9b52be9a25a7f7d5fbd6456703d077b14a41132c","unresolved":true,"context_lines":[{"line_number":4431,"context_line":"            # is in ACTIVE state it cannot have a share_mapping in ERROR"},{"line_number":4432,"context_line":"            # so it is safe to ignore the re-mounting of the share for"},{"line_number":4433,"context_line":"            # soft reboot."},{"line_number":4434,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and share_info.contains_error():"},{"line_number":4435,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"            self.driver.reboot(context, instance,"}],"source_content_type":"text/x-python","patch_set":51,"id":"0d06f5fc_ffb41c4f","line":4434,"updated":"2024-11-13 14:53:37.000000000","message":"that\u0027s not working on my environment, the share isn\u0027t mounted.","commit_id":"2317e78983cd38ccd501bd10b2136c5d357ecd8a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"558debe02a881c62fcafde688d1eaa6a2e08be16","unresolved":false,"context_lines":[{"line_number":4431,"context_line":"            # is in ACTIVE state it cannot have a share_mapping in ERROR"},{"line_number":4432,"context_line":"            # so it is safe to ignore the re-mounting of the share for"},{"line_number":4433,"context_line":"            # soft reboot."},{"line_number":4434,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and share_info.contains_error():"},{"line_number":4435,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"            self.driver.reboot(context, instance,"}],"source_content_type":"text/x-python","patch_set":51,"id":"9a75abeb_4141ac9f","line":4434,"in_reply_to":"0d06f5fc_ffb41c4f","updated":"2024-11-18 14:31:57.000000000","message":"should be fixed with latest in patched 52. Confirmed by Gibi.","commit_id":"2317e78983cd38ccd501bd10b2136c5d357ecd8a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6abf2ee9fe947577b2d8126e5177ddbd3a7e2475","unresolved":false,"context_lines":[{"line_number":4431,"context_line":"            # is in ACTIVE state it cannot have a share_mapping in ERROR"},{"line_number":4432,"context_line":"            # so it is safe to ignore the re-mounting of the share for"},{"line_number":4433,"context_line":"            # soft reboot."},{"line_number":4434,"context_line":"            if reboot_type \u003d\u003d \"HARD\" and share_info.contains_error():"},{"line_number":4435,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"            self.driver.reboot(context, instance,"}],"source_content_type":"text/x-python","patch_set":51,"id":"735f0029_f372cead","line":4434,"in_reply_to":"9a75abeb_4141ac9f","updated":"2024-11-18 17:57:49.000000000","message":"Yup, tested it, this is now fixed : \n```\nNov 14 09:47:54 sbauza-manila2 nova-compute[3110]: INFO nova.virt.libvirt.driver [-] [instance: 4b57bbae-ae14-47b5-a529-901753d594dd] Instance rebooted successfully.\n```","commit_id":"2317e78983cd38ccd501bd10b2136c5d357ecd8a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"10c7b23f844cb9198787bf476133c032b8fc1ca2","unresolved":false,"context_lines":[{"line_number":4432,"context_line":"            # is in ACTIVE state it cannot have a share_mapping in ERROR"},{"line_number":4433,"context_line":"            # so it is safe to ignore the re-mounting of the share for"},{"line_number":4434,"context_line":"            # soft reboot."},{"line_number":4435,"context_line":"            if reboot_type \u003d\u003d \"HARD\":"},{"line_number":4436,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4437,"context_line":""},{"line_number":4438,"context_line":"            self.driver.reboot(context, instance,"}],"source_content_type":"text/x-python","patch_set":52,"id":"c7581079_784413a0","line":4435,"updated":"2024-11-15 10:32:30.000000000","message":"Looks OK. Hard reboot is allowed to redo things even if they are not strictly needed. E.g. we always regenerate the whole XML during hard reboot even if the content is the same. So remounting during hard reboot unconditionally is totally fine.","commit_id":"65505be115f50052b861b4189b6f25d839842655"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6abf2ee9fe947577b2d8126e5177ddbd3a7e2475","unresolved":false,"context_lines":[{"line_number":4432,"context_line":"            # is in ACTIVE state it cannot have a share_mapping in ERROR"},{"line_number":4433,"context_line":"            # so it is safe to ignore the re-mounting of the share for"},{"line_number":4434,"context_line":"            # soft reboot."},{"line_number":4435,"context_line":"            if reboot_type \u003d\u003d \"HARD\":"},{"line_number":4436,"context_line":"                self._mount_all_shares(context, instance, share_info)"},{"line_number":4437,"context_line":""},{"line_number":4438,"context_line":"            self.driver.reboot(context, instance,"}],"source_content_type":"text/x-python","patch_set":52,"id":"d0677222_6242561e","line":4435,"in_reply_to":"c7581079_784413a0","updated":"2024-11-18 17:57:49.000000000","message":"indeed, see my comment on PS51","commit_id":"65505be115f50052b861b4189b6f25d839842655"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8996a672193cb5199804a455f06fd1643e869835","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"948347ca_0ffd7be8","updated":"2024-06-18 11:56:34.000000000","message":"please assert that driver.mount_share is called for HARD but not for SOFT reboot.","commit_id":"e6acb1be60829393cee94cbd4610a571e56e032b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"003d5cef36a7494dc92213ffb76e40a0579f0d4a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"0b8e3dc7_6feab5e2","in_reply_to":"215eb55a_2ab84b81","updated":"2024-09-09 16:13:01.000000000","message":"UT and comment added.","commit_id":"e6acb1be60829393cee94cbd4610a571e56e032b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bc3ef305620619ae199c8492ce8af7e296681b7f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"215eb55a_2ab84b81","in_reply_to":"948347ca_0ffd7be8","updated":"2024-08-28 13:27:57.000000000","message":"as far as I see we still missing test coverage to ensure mount happens during hard reboot but not during soft reboot.","commit_id":"e6acb1be60829393cee94cbd4610a571e56e032b"}]}